Re: [OE-core] [PATCH] eglibc_2.16.bb: replace patch with updated version that supportds e6500
On Tue, Sep 18, 2012 at 5:35 PM, Matthew McClintock wrote: > On Tue, Sep 18, 2012 at 5:33 PM, Khem Raj wrote: >> On Tue, Sep 18, 2012 at 3:32 PM, McClintock Matthew-B29882 >> wrote: >>> >>> Internal patch name. I can change it if needed. But, then I have to >>> track patch names differences between internal and external. >> >> Not that I am opposed to it but its hard to review as I said. >> cant internal be changed ? > > Ha ha ha... Please hold off on this patch - I believe I've found some more issues (besides the sign-off and upstream-status on the patch) -M > > ;) > > -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] eglibc_2.16.bb: replace patch with updated version that supportds e6500
On Tue, Sep 18, 2012 at 5:33 PM, Khem Raj wrote: > On Tue, Sep 18, 2012 at 3:32 PM, McClintock Matthew-B29882 > wrote: >> >> Internal patch name. I can change it if needed. But, then I have to >> track patch names differences between internal and external. > > Not that I am opposed to it but its hard to review as I said. > cant internal be changed ? Ha ha ha... ;) -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] eglibc_2.16.bb: replace patch with updated version that supportds e6500
On Tue, Sep 18, 2012 at 3:32 PM, McClintock Matthew-B29882 wrote: > > Internal patch name. I can change it if needed. But, then I have to > track patch names differences between internal and external. Not that I am opposed to it but its hard to review as I said. cant internal be changed ? ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] eglibc_2.16.bb: replace patch with updated version that supportds e6500
On Tue, Sep 18, 2012 at 5:30 PM, Khem Raj wrote: > On Tue, Sep 18, 2012 at 3:23 PM, McClintock Matthew-B29882 > wrote: >> >> It's just renaming the patch, so it's replacing ppc-sqrt.patch with >> glibc.fix_sqrt2.patch - and these are not authored by me... which I >> realize I forgot to add upstream-status as well. >> > > OK now I see. The shadowing is there. I dont like renaming the patch. > Is there any reason > why its renamed to glibc.fix_sqrt2.patch ? its easy to spot changes if > it was not renamed Internal patch name. I can change it if needed. But, then I have to track patch names differences between internal and external. -M ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] eglibc_2.16.bb: replace patch with updated version that supportds e6500
On Tue, Sep 18, 2012 at 3:23 PM, McClintock Matthew-B29882 wrote: > > It's just renaming the patch, so it's replacing ppc-sqrt.patch with > glibc.fix_sqrt2.patch - and these are not authored by me... which I > realize I forgot to add upstream-status as well. > OK now I see. The shadowing is there. I dont like renaming the patch. Is there any reason why its renamed to glibc.fix_sqrt2.patch ? its easy to spot changes if it was not renamed > Back to the patches themselves, ppc-sqrt seemed to be a subset of > glibc.fix_sqrt2.patch or am I wrong? As far as shadowing I'm not sure, > I'd rather not spend time testing that, these patches are used/tested > internally. Thats fine ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
