Re: [OE-core] [PATCH] fixup! fix: reproducible builds for initramfs and UKI img
On Wed, 2023-06-07 at 11:00 +0200, Alexander Kanavin wrote: > It's better to resend the whole patchset as v2. I did squash this one into the original patch. For future reference, I did also tweak the shortlog to mention "image_types:" as the prefix so the area of code changing was clearer and matches the format we usually use. It is nice to see work on reproducibility! Cheers, Richard -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#182465): https://lists.openembedded.org/g/openembedded-core/message/182465 Mute This Topic: https://lists.openembedded.org/mt/99359051/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH] fixup! fix: reproducible builds for initramfs and UKI img
It's better to resend the whole patchset as v2.
Alex
On Tue, 6 Jun 2023 at 10:01, Frieder Paape wrote:
>
> The failure happens because `touch` doesn't create a file if called with the
> no-dereference option `-h`.
> Removing `-h` from affected touch command.
>
> Signed-off-by: Frieder Paape
> ---
> meta/classes-recipe/image_types.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes-recipe/image_types.bbclass
> b/meta/classes-recipe/image_types.bbclass
> index f73b4d965e..023eb87537 100644
> --- a/meta/classes-recipe/image_types.bbclass
> +++ b/meta/classes-recipe/image_types.bbclass
> @@ -150,7 +150,7 @@ IMAGE_CMD:cpio () {
> ln -sf /sbin/init ${WORKDIR}/cpio_append/init
> touch -h -r ${IMAGE_ROOTFS}/sbin/init
> ${WORKDIR}/cpio_append/init
> else
> -touch -h -r ${IMAGE_ROOTFS}
> ${WORKDIR}/cpio_append/init
> +touch -r ${IMAGE_ROOTFS}
> ${WORKDIR}/cpio_append/init
> fi
> (cd ${WORKDIR}/cpio_append && echo ./init | cpio --reproducible
> -oA -H newc -F ${IMGDEPLOYDIR}/${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.cpio)
> fi
> --
> 2.39.2 (Apple Git-143)
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#182463):
https://lists.openembedded.org/g/openembedded-core/message/182463
Mute This Topic: https://lists.openembedded.org/mt/99359051/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH] fixup! fix: reproducible builds for initramfs and UKI img
The failure happens because `touch` doesn't create a file if called with the
no-dereference option `-h`.
Removing `-h` from affected touch command.
Signed-off-by: Frieder Paape
---
meta/classes-recipe/image_types.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes-recipe/image_types.bbclass
b/meta/classes-recipe/image_types.bbclass
index f73b4d965e..023eb87537 100644
--- a/meta/classes-recipe/image_types.bbclass
+++ b/meta/classes-recipe/image_types.bbclass
@@ -150,7 +150,7 @@ IMAGE_CMD:cpio () {
ln -sf /sbin/init ${WORKDIR}/cpio_append/init
touch -h -r ${IMAGE_ROOTFS}/sbin/init ${WORKDIR}/cpio_append/init
else
- touch -h -r ${IMAGE_ROOTFS}
${WORKDIR}/cpio_append/init
+ touch -r ${IMAGE_ROOTFS}
${WORKDIR}/cpio_append/init
fi
(cd ${WORKDIR}/cpio_append && echo ./init | cpio --reproducible -oA -H newc -F
${IMGDEPLOYDIR}/${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.cpio)
fi
--
2.39.2 (Apple Git-143)
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#182416):
https://lists.openembedded.org/g/openembedded-core/message/182416
Mute This Topic: https://lists.openembedded.org/mt/99359051/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
