Re: [OE-core] [PATCH] gptfdisk: add 0.8.10+git version

2014-11-09 Thread Burton, Ross 
On 8 November 2014 18:55, Koen Kooi k...@dominion.thruhere.net wrote:

 I can if you'd like that, the utils were few and small, so I put them all
 in ${PN}, let me know if you still want them seperate.


Personally I don't see a reason to split the tools up, but following
tradition and shipping them in $sbindir is sensible.

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] gptfdisk: add 0.8.10+git version

2014-11-08 Thread Koen Kooi 

 Op 7 nov. 2014, om 19:10 heeft Joshua Hernstrom joshua.hernst...@ni.com het 
 volgende geschreven:
 
 Hi Koen,
 
 Besides from being useful as fdisk replacement this gives us 'sgdisk'
 which can be used to set the GUID for partitions, e.g.
 
  sgdisk -t 1:C12A7328-F81F-11D2-BA4B-00A0C93EC93B /dev/mmcblk0p1
 
 To mark it as ESP in scripts like mkefidisk.sh.
 
 Signed-off-by: Koen Kooi koen@...
 ---
 meta/recipes-devtools/fdisk/gptfdisk_git.bb | 22 ++
 1 file changed, 22 insertions(+)
 create mode 100644 meta/recipes-devtools/fdisk/gptfdisk_git.bb
 
 diff --git a/meta/recipes-devtools/fdisk/gptfdisk_git.bb
 b/meta/recipes-devtools/fdisk/gptfdisk_git.bb new file mode 100644
 index 000..62c32c3
 --- /dev/null
 +++ b/meta/recipes-devtools/fdisk/gptfdisk_git.bb
 at  at  -0,0 +1,22  at  at 
 ...
 +S = ${WORKDIR}/git
 +
 +do_install() {
 +install -d ${D}${bindir}
 +install -m 0755 cgdisk ${D}${bindir}
 +install -m 0755 gdisk ${D}${bindir}
 +install -m 0755 sgdisk ${D}${bindir}
 +install -m 0755 fixparts ${D}${bindir}
 
 Have you considered splitting this package into separate sub-packages? The 
 util-linux recipe does something similar for the fdisk family of utilities.

I can if you'd like that, the utils were few and small, so I put them all in 
${PN}, let me know if you still want them seperate.

regards,

Koen

 I had a not-yet-submitted recipe along the same line as yours - the relevant 
 snippets follow for reference:
 
 snip
 PACKAGES =+ ${PN}-gdisk ${PN}-cgdisk ${PN}-sgdisk ${PN}-fixparts
 FILES_${PN}-gdisk = ${sbindir}/gdisk
 FILES_${PN}-cgdisk = ${sbindir}/cgdisk
 FILES_${PN}-sgdisk = ${sbindir}/sgdisk
 FILES_${PN}-fixparts = ${sbindir}/fixparts
 
 do_install() {
   install -m 0755 -d ${D}${sbindir}
   sbinprogs=gdisk cgdisk sgdisk fixparts
   for f in ${sbinprogs}; do
   install -m 0755 ${S}/${f} ${D}${sbindir}
   done
 }
 /snip
 
 Cheers,
 Josh
 --
 Joshua Hernstrom
 National Instruments
 -- 
 ___
 Openembedded-core mailing list
 Openembedded-core@lists.openembedded.org
 http://lists.openembedded.org/mailman/listinfo/openembedded-core
 

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] gptfdisk: add 0.8.10+git version

2014-11-07 Thread Paul Eggleton 
On Thursday 06 November 2014 14:28:49 Koen Kooi wrote:
 Op 6 nov. 2014, om 12:27 heeft Paul Eggleton paul.eggle...@linux.intel.com 
het volgende geschreven:
  Hi Koen,
  
  On Thursday 06 November 2014 08:37:56 Koen Kooi wrote:
  Besides from being useful as fdisk replacement this gives us 'sgdisk'
  which can be used to set the GUID for partitions, e.g.
  
 sgdisk -t 1:C12A7328-F81F-11D2-BA4B-00A0C93EC93B /dev/mmcblk0p1
  
  To mark it as ESP in scripts like mkefidisk.sh.
  
  Signed-off-by: Koen Kooi k...@dominion.thruhere.net
  ---
  meta/recipes-devtools/fdisk/gptfdisk_git.bb | 22 ++
  1 file changed, 22 insertions(+)
  create mode 100644 meta/recipes-devtools/fdisk/gptfdisk_git.bb
  
  diff --git a/meta/recipes-devtools/fdisk/gptfdisk_git.bb
  b/meta/recipes-devtools/fdisk/gptfdisk_git.bb new file mode 100644
  index 000..62c32c3
  --- /dev/null
  +++ b/meta/recipes-devtools/fdisk/gptfdisk_git.bb
  @@ -0,0 +1,22 @@
  ...
  +S = ${WORKDIR}/git
  +
  +do_install() {
  +install -d ${D}${bindir}
  +install -m 0755 cgdisk ${D}${bindir}
  +install -m 0755 gdisk ${D}${bindir}
  +install -m 0755 sgdisk ${D}${bindir}
  +install -m 0755 fixparts ${D}${bindir}
  
  Technically shouldn't these be in ${sbindir} ?
 
 Personally I think sbindir is a misguided idea, PATH is a very easy to get
 around security measure. Having said that, I have no objection to
 installing these things in $sbindir if it's requiered to get this into
 OE-core.

I wouldn't have thought it to be required, I was just wondering if this was 
something we wanted to stick to.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] gptfdisk: add 0.8.10+git version

2014-11-07 Thread Joshua Hernstrom 
Hi Koen,

 Besides from being useful as fdisk replacement this gives us 'sgdisk'
 which can be used to set the GUID for partitions, e.g.
 
   sgdisk -t 1:C12A7328-F81F-11D2-BA4B-00A0C93EC93B /dev/mmcblk0p1
 
 To mark it as ESP in scripts like mkefidisk.sh.
 
 Signed-off-by: Koen Kooi koen@...
 ---
  meta/recipes-devtools/fdisk/gptfdisk_git.bb | 22 ++
  1 file changed, 22 insertions(+)
  create mode 100644 meta/recipes-devtools/fdisk/gptfdisk_git.bb
 
 diff --git a/meta/recipes-devtools/fdisk/gptfdisk_git.bb
 b/meta/recipes-devtools/fdisk/gptfdisk_git.bb new file mode 100644
 index 000..62c32c3
 --- /dev/null
 +++ b/meta/recipes-devtools/fdisk/gptfdisk_git.bb
  at  at  -0,0 +1,22  at  at 
...
 +S = ${WORKDIR}/git
 +
 +do_install() {
 +install -d ${D}${bindir}
 +install -m 0755 cgdisk ${D}${bindir}
 +install -m 0755 gdisk ${D}${bindir}
 +install -m 0755 sgdisk ${D}${bindir}
 +install -m 0755 fixparts ${D}${bindir}

Have you considered splitting this package into separate sub-packages? The 
util-linux recipe does something similar for the fdisk family of utilities. I 
had a not-yet-submitted recipe along the same line as yours - the relevant 
snippets follow for reference:

snip
PACKAGES =+ ${PN}-gdisk ${PN}-cgdisk ${PN}-sgdisk ${PN}-fixparts
FILES_${PN}-gdisk = ${sbindir}/gdisk
FILES_${PN}-cgdisk = ${sbindir}/cgdisk
FILES_${PN}-sgdisk = ${sbindir}/sgdisk
FILES_${PN}-fixparts = ${sbindir}/fixparts

do_install() {
install -m 0755 -d ${D}${sbindir}
sbinprogs=gdisk cgdisk sgdisk fixparts
for f in ${sbinprogs}; do
install -m 0755 ${S}/${f} ${D}${sbindir}
done
}
/snip

Cheers,
Josh
--
Joshua Hernstrom
National Instruments
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] gptfdisk: add 0.8.10+git version

2014-11-06 Thread Paul Eggleton 
Hi Koen,

On Thursday 06 November 2014 08:37:56 Koen Kooi wrote:
 Besides from being useful as fdisk replacement this gives us 'sgdisk'
 which can be used to set the GUID for partitions, e.g.
 
   sgdisk -t 1:C12A7328-F81F-11D2-BA4B-00A0C93EC93B /dev/mmcblk0p1
 
 To mark it as ESP in scripts like mkefidisk.sh.
 
 Signed-off-by: Koen Kooi k...@dominion.thruhere.net
 ---
  meta/recipes-devtools/fdisk/gptfdisk_git.bb | 22 ++
  1 file changed, 22 insertions(+)
  create mode 100644 meta/recipes-devtools/fdisk/gptfdisk_git.bb
 
 diff --git a/meta/recipes-devtools/fdisk/gptfdisk_git.bb
 b/meta/recipes-devtools/fdisk/gptfdisk_git.bb new file mode 100644
 index 000..62c32c3
 --- /dev/null
 +++ b/meta/recipes-devtools/fdisk/gptfdisk_git.bb
 @@ -0,0 +1,22 @@
...
 +S = ${WORKDIR}/git
 +
 +do_install() {
 +install -d ${D}${bindir}
 +install -m 0755 cgdisk ${D}${bindir}
 +install -m 0755 gdisk ${D}${bindir}
 +install -m 0755 sgdisk ${D}${bindir}
 +install -m 0755 fixparts ${D}${bindir}

Technically shouldn't these be in ${sbindir} ?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] gptfdisk: add 0.8.10+git version

2014-11-06 Thread Koen Kooi 

Op 6 nov. 2014, om 12:27 heeft Paul Eggleton paul.eggle...@linux.intel.com 
het volgende geschreven:

 Hi Koen,
 
 On Thursday 06 November 2014 08:37:56 Koen Kooi wrote:
 Besides from being useful as fdisk replacement this gives us 'sgdisk'
 which can be used to set the GUID for partitions, e.g.
 
  sgdisk -t 1:C12A7328-F81F-11D2-BA4B-00A0C93EC93B /dev/mmcblk0p1
 
 To mark it as ESP in scripts like mkefidisk.sh.
 
 Signed-off-by: Koen Kooi k...@dominion.thruhere.net
 ---
 meta/recipes-devtools/fdisk/gptfdisk_git.bb | 22 ++
 1 file changed, 22 insertions(+)
 create mode 100644 meta/recipes-devtools/fdisk/gptfdisk_git.bb
 
 diff --git a/meta/recipes-devtools/fdisk/gptfdisk_git.bb
 b/meta/recipes-devtools/fdisk/gptfdisk_git.bb new file mode 100644
 index 000..62c32c3
 --- /dev/null
 +++ b/meta/recipes-devtools/fdisk/gptfdisk_git.bb
 @@ -0,0 +1,22 @@
 ...
 +S = ${WORKDIR}/git
 +
 +do_install() {
 +install -d ${D}${bindir}
 +install -m 0755 cgdisk ${D}${bindir}
 +install -m 0755 gdisk ${D}${bindir}
 +install -m 0755 sgdisk ${D}${bindir}
 +install -m 0755 fixparts ${D}${bindir}
 
 Technically shouldn't these be in ${sbindir} ?

Personally I think sbindir is a misguided idea, PATH is a very easy to get 
around security measure. Having said that, I have no objection to installing 
these things in $sbindir if it's requiered to get this into OE-core.

regards,

Koen
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] gptfdisk: add 0.8.10+git version

2014-11-05 Thread Koen Kooi 
Besides from being useful as fdisk replacement this gives us 'sgdisk'
which can be used to set the GUID for partitions, e.g.

sgdisk -t 1:C12A7328-F81F-11D2-BA4B-00A0C93EC93B /dev/mmcblk0p1

To mark it as ESP in scripts like mkefidisk.sh.

Signed-off-by: Koen Kooi k...@dominion.thruhere.net
---
 meta/recipes-devtools/fdisk/gptfdisk_git.bb | 22 ++
 1 file changed, 22 insertions(+)
 create mode 100644 meta/recipes-devtools/fdisk/gptfdisk_git.bb

diff --git a/meta/recipes-devtools/fdisk/gptfdisk_git.bb 
b/meta/recipes-devtools/fdisk/gptfdisk_git.bb
new file mode 100644
index 000..62c32c3
--- /dev/null
+++ b/meta/recipes-devtools/fdisk/gptfdisk_git.bb
@@ -0,0 +1,22 @@
+DESCRIPTION = GPT fdisk is a disk partitioning tool loosely modeled on Linux 
fdisk, but used for modifying GUID Partition Table (GPT) disks. The related 
FixParts utility fixes some common problems on Master Boot Record (MBR) disks.
+
+LICENSE = GPLv2
+LIC_FILES_CHKSUM = file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552
+
+DEPENDS = util-linux popt ncurses
+
+PV = 0.8.10+git${SRCPV}
+SRCREV = a920398fa393f9d6301b32b191bc01e086ab8bc8
+SRC_URI = git://git.code.sf.net/p/gptfdisk/code
+
+S = ${WORKDIR}/git
+
+do_install() {
+install -d ${D}${bindir}
+install -m 0755 cgdisk ${D}${bindir}
+install -m 0755 gdisk ${D}${bindir}
+install -m 0755 sgdisk ${D}${bindir}
+install -m 0755 fixparts ${D}${bindir}
+}
+
+BBCLASSEXTEND = native nativesdk
-- 
1.9.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core