Re: [OE-core] [PATCH] libevent: don't treat test stats line as pass/fail in ptest
On Mon, 2019-09-09 at 11:16 -0400, Trevor Gamblin wrote: > From: Trevor Gamblin > > The libevent "regress" test outputs its own pass/fail results, > e.g. "2/300 TESTS FAILED. (31 skipped)", which will be > miscounted as an extra test fail in the ptest log. Fixed this > to ignore the libevent results line when counting actual > pass/fail results. > > Also removed the for loop in run-ptest and targeted only the > libevent "regress" test, as the other tests being run were > related to performance and did not provide a relevant pass/fail > output. Can you put a comment into the runner script about why we're not running these other tests please? This is so that someone looking at the script in the future can immediately see we're not running them intentionally. Thanks, Richard -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] libevent: don't treat test stats line as pass/fail in ptest
On 9/9/19 11:16 AM, Trevor Gamblin wrote: From: Trevor Gamblin The libevent "regress" test outputs its own pass/fail results, e.g. "2/300 TESTS FAILED. (31 skipped)", which will be miscounted as an extra test fail in the ptest log. Fixed this to ignore the libevent results line when counting actual pass/fail results. Also removed the for loop in run-ptest and targeted only the libevent "regress" test, as the other tests being run were related to performance and did not provide a relevant pass/fail output. Signed-off-by: Trevor Gamblin --- meta/recipes-support/libevent/libevent/run-ptest | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/meta/recipes-support/libevent/libevent/run-ptest b/meta/recipes-support/libevent/libevent/run-ptest index 080806dea9..259fe56fe5 100644 --- a/meta/recipes-support/libevent/libevent/run-ptest +++ b/meta/recipes-support/libevent/libevent/run-ptest @@ -10,10 +10,7 @@ LOG="${LIBEVENTLIB}/ptest/libevent_ptest_$(date +%Y%m%d-%H%M%S).log" cd ${LIBEVENTLIB}/ptest -for test in ./test/* -do -$test 2>&1| sed -e '/OK/ s/^/PASS: / ; /FAILED/ s/^/FAIL: / ; /SKIPPED/ s/^/SKIP: / ; /DISABLED/ s/^/SKIP: /' | cut -f1,2 -d ':' | tee -a ${LOG} -done +./test/regress 2>&1| sed -e '/TESTS/d' -e '/tests/d' -e '/OK/ s/^/PASS: / ; /FAILED/ s/^/FAIL: / ; /SKIPPED/ s/^/SKIP: / ; /DISABLED/ s/^/SKIP: /' | cut -f1,2 -d ':' | tee -a ${LOG} passed=`grep PASS ${LOG}|wc -l` failed=`grep FAIL ${LOG}|wc -l` Forgot to mention in commit message - this is a follow-up to fb17b46e2 after seeing the autobuilder test results with that commit. -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] libevent: don't treat test stats line as pass/fail in ptest
From: Trevor Gamblin The libevent "regress" test outputs its own pass/fail results, e.g. "2/300 TESTS FAILED. (31 skipped)", which will be miscounted as an extra test fail in the ptest log. Fixed this to ignore the libevent results line when counting actual pass/fail results. Also removed the for loop in run-ptest and targeted only the libevent "regress" test, as the other tests being run were related to performance and did not provide a relevant pass/fail output. Signed-off-by: Trevor Gamblin --- meta/recipes-support/libevent/libevent/run-ptest | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/meta/recipes-support/libevent/libevent/run-ptest b/meta/recipes-support/libevent/libevent/run-ptest index 080806dea9..259fe56fe5 100644 --- a/meta/recipes-support/libevent/libevent/run-ptest +++ b/meta/recipes-support/libevent/libevent/run-ptest @@ -10,10 +10,7 @@ LOG="${LIBEVENTLIB}/ptest/libevent_ptest_$(date +%Y%m%d-%H%M%S).log" cd ${LIBEVENTLIB}/ptest -for test in ./test/* -do -$test 2>&1| sed -e '/OK/ s/^/PASS: / ; /FAILED/ s/^/FAIL: / ; /SKIPPED/ s/^/SKIP: / ; /DISABLED/ s/^/SKIP: /' | cut -f1,2 -d ':' | tee -a ${LOG} -done +./test/regress 2>&1| sed -e '/TESTS/d' -e '/tests/d' -e '/OK/ s/^/PASS: / ; /FAILED/ s/^/FAIL: / ; /SKIPPED/ s/^/SKIP: / ; /DISABLED/ s/^/SKIP: /' | cut -f1,2 -d ':' | tee -a ${LOG} passed=`grep PASS ${LOG}|wc -l` failed=`grep FAIL ${LOG}|wc -l` -- 2.21.0 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core