Re: [OE-core] [PATCH] strace: skip so_peerpidfd test
On 2023-10-06 4:06 p.m., Randy MacLeod via lists.openembedded.org wrote:
From: Randy MacLeod
The so_peerpidfd test is failing due to a difference of square brackets
in part of the log file. Skip the failing test until the difference is
understood and fixed.
Signed-off-by: Randy MacLeod
---
.../skip-test-so_peerpidfd.gen.test.patch | 25 +++
meta/recipes-devtools/strace/strace_6.5.bb| 2 ++
2 files changed, 27 insertions(+)
create mode 100644
meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
diff --git
a/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
b/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
new file mode 100644
index 00..76f93ab613
--- /dev/null
+++ b/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
@@ -0,0 +1,25 @@
+From 002d9f2512245536dfc8d62db429d97e2216ec3a Mon Sep 17 00:00:00 2001
+From: Randy MacLeod
+Date: Fri, 6 Oct 2023 12:08:23 -0700
+Subject: [PATCH] skip tests/so_peerpidfd.gen.test
+
+Upstream-Status: Pending
+
+Signed-off-by: Randy MacLeod
+---
+ tests/so_peerpidfd.gen.test | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/tests/so_peerpidfd.gen.test b/tests/so_peerpidfd.gen.test
+index 64ad3a2..f89da9f 100755
+--- a/tests/so_peerpidfd.gen.test
b/tests/so_peerpidfd.gen.test
+@@ -1,4 +1,5 @@
+ #!/bin/sh -efu
+ # Generated by ./tests/gen_tests.sh from ./tests/gen_tests.in (so_peerpidfd
--trace=getsockopt -y); do not edit.
+ . "${srcdir=.}/init.sh"
++skip_ "Test fails due to apparently trivial log format differences"
+ run_strace_match_diff --trace=getsockopt -y
+--
+2.39.0
+
diff --git a/meta/recipes-devtools/strace/strace_6.5.bb
b/meta/recipes-devtools/strace/strace_6.5.bb
index 8f90c35925..81baae474f 100644
--- a/meta/recipes-devtools/strace/strace_6.5.bb
+++ b/meta/recipes-devtools/strace/strace_6.5.bb
@@ -14,6 +14,7 @@ SRC_URI ="https://strace.io/files/${PV}/strace-${PV}.tar.xz \
file://skip-load.patch \
file://0001-configure-Use-autoconf-macro-to-detect-largefile-sup.patch
\ file://0002-tests-Replace-off64_t-with-off_t.patch \ +
file://skip-test-so_peerpidfd.gen.test.patch \ "
SRC_URI[sha256sum] =
"dfb051702389e1979a151892b5901afc9e93bbc1c70d84c906ade3224ca91980"
@@ -47,6 +48,7 @@ do_install_ptest() {
install -m 755 ${S}/build-aux/test-driver ${D}${PTEST_PATH}/build-aux/
install -m 644 ${B}/src/config.h ${D}${PTEST_PATH}/src/
sed -i -e '/^src/s/strace.*[0-9]/ptest/'
${D}/${PTEST_PATH}/${TESTDIR}/Makefile
+sed -i '4 i skip_ "Skip due to trivial output format difference."'
${D}${PTEST_PATH}/tests/so_peerpidfd.gen.test
Oops, that line is no longer needed. V2 with it removed coming up.
../Randy
}
RDEPENDS:${PN}-ptest += "make coreutils grep gawk sed"
--
# Randy MacLeod
# Wind River Linux
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188785):
https://lists.openembedded.org/g/openembedded-core/message/188785
Mute This Topic: https://lists.openembedded.org/mt/101805563/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] strace: skip so_peerpidfd test
From: Randy MacLeod
The so_peerpidfd test is failing due to a difference of square brackets
in part of the log file. Skip the failing test until the difference is
understood and fixed.
Signed-off-by: Randy MacLeod
---
.../skip-test-so_peerpidfd.gen.test.patch | 25 +++
meta/recipes-devtools/strace/strace_6.5.bb| 2 ++
2 files changed, 27 insertions(+)
create mode 100644
meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
diff --git
a/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
b/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
new file mode 100644
index 00..76f93ab613
--- /dev/null
+++ b/meta/recipes-devtools/strace/strace/skip-test-so_peerpidfd.gen.test.patch
@@ -0,0 +1,25 @@
+From 002d9f2512245536dfc8d62db429d97e2216ec3a Mon Sep 17 00:00:00 2001
+From: Randy MacLeod
+Date: Fri, 6 Oct 2023 12:08:23 -0700
+Subject: [PATCH] skip tests/so_peerpidfd.gen.test
+
+Upstream-Status: Pending
+
+Signed-off-by: Randy MacLeod
+---
+ tests/so_peerpidfd.gen.test | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/tests/so_peerpidfd.gen.test b/tests/so_peerpidfd.gen.test
+index 64ad3a2..f89da9f 100755
+--- a/tests/so_peerpidfd.gen.test
b/tests/so_peerpidfd.gen.test
+@@ -1,4 +1,5 @@
+ #!/bin/sh -efu
+ # Generated by ./tests/gen_tests.sh from ./tests/gen_tests.in (so_peerpidfd
--trace=getsockopt -y); do not edit.
+ . "${srcdir=.}/init.sh"
++skip_ "Test fails due to apparently trivial log format differences"
+ run_strace_match_diff --trace=getsockopt -y
+--
+2.39.0
+
diff --git a/meta/recipes-devtools/strace/strace_6.5.bb
b/meta/recipes-devtools/strace/strace_6.5.bb
index 8f90c35925..81baae474f 100644
--- a/meta/recipes-devtools/strace/strace_6.5.bb
+++ b/meta/recipes-devtools/strace/strace_6.5.bb
@@ -14,6 +14,7 @@ SRC_URI = "https://strace.io/files/${PV}/strace-${PV}.tar.xz \
file://skip-load.patch \
file://0001-configure-Use-autoconf-macro-to-detect-largefile-sup.patch \
file://0002-tests-Replace-off64_t-with-off_t.patch \
+ file://skip-test-so_peerpidfd.gen.test.patch \
"
SRC_URI[sha256sum] =
"dfb051702389e1979a151892b5901afc9e93bbc1c70d84c906ade3224ca91980"
@@ -47,6 +48,7 @@ do_install_ptest() {
install -m 755 ${S}/build-aux/test-driver ${D}${PTEST_PATH}/build-aux/
install -m 644 ${B}/src/config.h ${D}${PTEST_PATH}/src/
sed -i -e '/^src/s/strace.*[0-9]/ptest/'
${D}/${PTEST_PATH}/${TESTDIR}/Makefile
+sed -i '4 i skip_ "Skip due to trivial output format difference."'
${D}${PTEST_PATH}/tests/so_peerpidfd.gen.test
}
RDEPENDS:${PN}-ptest += "make coreutils grep gawk sed"
--
2.39.0
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#188783):
https://lists.openembedded.org/g/openembedded-core/message/188783
Mute This Topic: https://lists.openembedded.org/mt/101805563/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
