Re: [OE-core] [PATCH 0/2] Bug fixes for makedevs.c
On 28/10/2019 19:11, Andre McCurdy wrote: On Mon, Oct 28, 2019 at 10:15 AM Frazer Leslie Clews wrote: fixes a few bugs in some print statements and an overflow bug with usr_buf Frazer Leslie Clews (2): fix format strings in makedevs.c in print statements fix invalidScanfFormatWidth to prevent overflowing usr_buf Perhaps fixing these issues would be a good opportunity to align with the Buildroot (ie upstream?) version instead of diverging even more. https://git.buildroot.net/buildroot/tree/package/makedevs/makedevs.c Yes, this. If we can just fetch makedevs from buildroot that's one less piece of code we have to look after. Ross -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/2] Bug fixes for makedevs.c
On Mon, Oct 28, 2019 at 10:15 AM Frazer Leslie Clews wrote: > > fixes a few bugs in some print statements and an overflow bug with usr_buf > > Frazer Leslie Clews (2): > fix format strings in makedevs.c in print statements > fix invalidScanfFormatWidth to prevent overflowing usr_buf Perhaps fixing these issues would be a good opportunity to align with the Buildroot (ie upstream?) version instead of diverging even more. https://git.buildroot.net/buildroot/tree/package/makedevs/makedevs.c > meta/recipes-devtools/makedevs/makedevs/makedevs.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > -- > 2.20.1 > > -- > ___ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH 0/2] Bug fixes for makedevs.c
fixes a few bugs in some print statements and an overflow bug with usr_buf Frazer Leslie Clews (2): fix format strings in makedevs.c in print statements fix invalidScanfFormatWidth to prevent overflowing usr_buf meta/recipes-devtools/makedevs/makedevs/makedevs.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.20.1 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH 0/2] Bug fixes
This patchset contains two bug fixes for: - Yocto #2467 - Yocto #1465 Laurentiu Palcu (2): sanity.bbclass: warn the user if BBPATH contains wrong entries connman: make useradd parameters consistent with rootless X meta/classes/sanity.bbclass | 11 +++ meta/recipes-connectivity/connman/connman.inc |4 ++-- 2 files changed, 13 insertions(+), 2 deletions(-) -- 1.7.9.5 ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/2] Bug fixes
On Wed, 2012-01-04 at 08:51 +0800, Zhai, Edwin wrote: On 01/04/2012 07:56 AM, Saul Wold wrote: On 12/29/2011 12:09 AM, edwin.z...@intel.com wrote: From: Zhai Edwinedwin.z...@intel.com All, Patch of gnome-keyring to fix gsettings-data-convert seg fault, modified according to Saul's comments. Another patch of matchbox-wm to remove the dependence between window manager and X session. The following changes since commit 6a1b5c28f22bb07a0b7102eb88441d05768ec52e: self-hosted-image: Add builder user and mini X (2011-12-29 10:42:07 +0800) are available in the git repository at: git://git.pokylinux.org/poky-contrib gzhai/build-appliance2 http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=gzhai/build-appliance2 Zhai Edwin (2): gnome-keyring: fix gsettings_data_convert seg fault Merged this one to OE-Core matchbox-wm: Remove x-session-manager handling We need a little more explaintion about why you are removing the U-A code from the matchbox-wm? matchbox-wm should not handles x-session, or else it conflict with mini-x-session. i.e. mini-x-session set x-session to mini-X, then matchbox-wm overrides it as matchbox-session. Without matchbox-session installed, mini-X fail start. I have tested this patch and found no regression... What I don't understand is that this is using update-alternatives so surely you can just install an alternative that overrides this? Looking at the code, shouldn't we move this alternative to the matchbox-session recipe? Cheers, Richard ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/2] Bug fixes
On Wed, Jan 04, 2012 at 11:22:28AM +, Richard Purdie wrote: On Wed, 2012-01-04 at 08:51 +0800, Zhai, Edwin wrote: On 01/04/2012 07:56 AM, Saul Wold wrote: On 12/29/2011 12:09 AM, edwin.z...@intel.com wrote: From: Zhai Edwinedwin.z...@intel.com All, Patch of gnome-keyring to fix gsettings-data-convert seg fault, modified according to Saul's comments. Another patch of matchbox-wm to remove the dependence between window manager and X session. The following changes since commit 6a1b5c28f22bb07a0b7102eb88441d05768ec52e: self-hosted-image: Add builder user and mini X (2011-12-29 10:42:07 +0800) are available in the git repository at: git://git.pokylinux.org/poky-contrib gzhai/build-appliance2 http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=gzhai/build-appliance2 Zhai Edwin (2): gnome-keyring: fix gsettings_data_convert seg fault Merged this one to OE-Core matchbox-wm: Remove x-session-manager handling We need a little more explaintion about why you are removing the U-A code from the matchbox-wm? matchbox-wm should not handles x-session, or else it conflict with mini-x-session. i.e. mini-x-session set x-session to mini-X, then matchbox-wm overrides it as matchbox-session. Without matchbox-session installed, mini-X fail start. I have tested this patch and found no regression... What I don't understand is that this is using update-alternatives so surely you can just install an alternative that overrides this? Looking at the code, shouldn't we move this alternative to the matchbox-session recipe? There are indential code in matchbox-session already. This patch is just removing duplicated code. I'll send out new patch to promote mini-x's alternative priority over matchbox-session. Thanks, Edwin Cheers, Richard ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core -- best rgds, edwin ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/2] Bug fixes
On 12/29/2011 12:09 AM, edwin.z...@intel.com wrote: From: Zhai Edwinedwin.z...@intel.com All, Patch of gnome-keyring to fix gsettings-data-convert seg fault, modified according to Saul's comments. Another patch of matchbox-wm to remove the dependence between window manager and X session. The following changes since commit 6a1b5c28f22bb07a0b7102eb88441d05768ec52e: self-hosted-image: Add builder user and mini X (2011-12-29 10:42:07 +0800) are available in the git repository at: git://git.pokylinux.org/poky-contrib gzhai/build-appliance2 http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=gzhai/build-appliance2 Zhai Edwin (2): gnome-keyring: fix gsettings_data_convert seg fault Merged this one to OE-Core matchbox-wm: Remove x-session-manager handling We need a little more explaintion about why you are removing the U-A code from the matchbox-wm? Thanks Sau! meta/recipes-gnome/gnome/gnome-keyring_2.32.1.bb | 12 ++-- .../matchbox-wm/matchbox-wm_1.2.bb |9 ++--- .../matchbox-wm/matchbox-wm_git.bb |9 ++--- 3 files changed, 14 insertions(+), 16 deletions(-) ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 0/2] Bug fixes
On 01/04/2012 07:56 AM, Saul Wold wrote: On 12/29/2011 12:09 AM, edwin.z...@intel.com wrote: From: Zhai Edwinedwin.z...@intel.com All, Patch of gnome-keyring to fix gsettings-data-convert seg fault, modified according to Saul's comments. Another patch of matchbox-wm to remove the dependence between window manager and X session. The following changes since commit 6a1b5c28f22bb07a0b7102eb88441d05768ec52e: self-hosted-image: Add builder user and mini X (2011-12-29 10:42:07 +0800) are available in the git repository at: git://git.pokylinux.org/poky-contrib gzhai/build-appliance2 http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=gzhai/build-appliance2 Zhai Edwin (2): gnome-keyring: fix gsettings_data_convert seg fault Merged this one to OE-Core matchbox-wm: Remove x-session-manager handling We need a little more explaintion about why you are removing the U-A code from the matchbox-wm? matchbox-wm should not handles x-session, or else it conflict with mini-x-session. i.e. mini-x-session set x-session to mini-X, then matchbox-wm overrides it as matchbox-session. Without matchbox-session installed, mini-X fail start. I have tested this patch and found no regression... Thanks Sau! meta/recipes-gnome/gnome/gnome-keyring_2.32.1.bb | 12 ++-- .../matchbox-wm/matchbox-wm_1.2.bb | 9 ++--- .../matchbox-wm/matchbox-wm_git.bb | 9 ++--- 3 files changed, 14 insertions(+), 16 deletions(-) ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
