Re: [OE-core] [PATCH 08/11] build-appliance-image: use a real /tmp

2023-02-22 Thread Trevor Woerner 
On Wed 2023-02-22 @ 02:46:30 PM, Richard Purdie wrote:
> On Tue, 2023-02-21 at 21:25 -0500, Trevor Woerner wrote:
> > On Tue 2023-02-21 @ 03:44:42 PM, Trevor Woerner via lists.openembedded.org 
> > wrote:
> > > Make /tmp a real directory in the root filesystem and not a link to an
> > > in-memory tmpfs. Otherwise bitbake will run out of inodes on /tmp very 
> > > quickly
> > > and stop any build.
> > > 
> > > Signed-off-by: Trevor Woerner 
> > > ---
> > >  meta/recipes-core/images/build-appliance-image_15.0.0.bb | 6 ++
> > >  1 file changed, 6 insertions(+)
> > > 
> > > diff --git a/meta/recipes-core/images/build-appliance-image_15.0.0.bb 
> > > b/meta/recipes-core/images/build-appliance-image_15.0.0.bb
> > > index 3a84de0a2b43..1f7b96a9fcf4 100644
> > > --- a/meta/recipes-core/images/build-appliance-image_15.0.0.bb
> > > +++ b/meta/recipes-core/images/build-appliance-image_15.0.0.bb
> > > @@ -113,6 +113,12 @@ fakeroot do_tweak_image () {
> > >   # add a /lib64 symlink
> > >   # this is needed for building rust-native on a 64-bit build appliance
> > >   ln -rs ${IMAGE_ROOTFS}/lib ${IMAGE_ROOTFS}/lib64
> > > +
> > > + # make /tmp a real directory and not a link to an in-memory tmpfs
> > > + # otherwise /tmp will run out of inodes very quickly when bitbaking
> > > + sed -i -e 's#l root root 1777 /tmp /var/tmp#d root root 1777 /tmp 
> > > none#' ${IMAGE_ROOTFS}/etc/default/volatiles/00_core
> > > + mkdir -p ${IMAGE_ROOTFS}/tmp
> > > + chmod 1777 ${IMAGE_ROOTFS}/tmp
> > >  }
> > 
> > Richard, this feels rather "hacky" to me. I can't help wonder if it would be
> > better to implement a VOLATILE_TMP_DIR mechanism (along the same lines as
> > VOLATILE_LOG_DIR)?
> > 
> > https://docs.yoctoproject.org/dev/ref-manual/variables.html?highlight=volatile_log_dir#term-VOLATILE_LOG_DIR
> > https://git.openembedded.org/openembedded-core/tree/meta/recipes-core/initscripts/initscripts_1.0.bb#n107
> 
> When I saw this, I was wondering about that too...
> 
> I think I'll hold off this patch whilst we think about that a bit but
> my memory on this area is taking a bit of paging back in.

Sounds good. In that case I'll wait for the others to hit master then re-work
this patch to integrate a VOLATILE_TMP_DIR mechanism?

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#177585): 
https://lists.openembedded.org/g/openembedded-core/message/177585
Mute This Topic: https://lists.openembedded.org/mt/97151865/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH 08/11] build-appliance-image: use a real /tmp

2023-02-22 Thread Richard Purdie 
On Tue, 2023-02-21 at 21:25 -0500, Trevor Woerner wrote:
> On Tue 2023-02-21 @ 03:44:42 PM, Trevor Woerner via lists.openembedded.org 
> wrote:
> > Make /tmp a real directory in the root filesystem and not a link to an
> > in-memory tmpfs. Otherwise bitbake will run out of inodes on /tmp very 
> > quickly
> > and stop any build.
> > 
> > Signed-off-by: Trevor Woerner 
> > ---
> >  meta/recipes-core/images/build-appliance-image_15.0.0.bb | 6 ++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/meta/recipes-core/images/build-appliance-image_15.0.0.bb 
> > b/meta/recipes-core/images/build-appliance-image_15.0.0.bb
> > index 3a84de0a2b43..1f7b96a9fcf4 100644
> > --- a/meta/recipes-core/images/build-appliance-image_15.0.0.bb
> > +++ b/meta/recipes-core/images/build-appliance-image_15.0.0.bb
> > @@ -113,6 +113,12 @@ fakeroot do_tweak_image () {
> > # add a /lib64 symlink
> > # this is needed for building rust-native on a 64-bit build appliance
> > ln -rs ${IMAGE_ROOTFS}/lib ${IMAGE_ROOTFS}/lib64
> > +
> > +   # make /tmp a real directory and not a link to an in-memory tmpfs
> > +   # otherwise /tmp will run out of inodes very quickly when bitbaking
> > +   sed -i -e 's#l root root 1777 /tmp /var/tmp#d root root 1777 /tmp 
> > none#' ${IMAGE_ROOTFS}/etc/default/volatiles/00_core
> > +   mkdir -p ${IMAGE_ROOTFS}/tmp
> > +   chmod 1777 ${IMAGE_ROOTFS}/tmp
> >  }
> 
> Richard, this feels rather "hacky" to me. I can't help wonder if it would be
> better to implement a VOLATILE_TMP_DIR mechanism (along the same lines as
> VOLATILE_LOG_DIR)?
> 
> https://docs.yoctoproject.org/dev/ref-manual/variables.html?highlight=volatile_log_dir#term-VOLATILE_LOG_DIR
> https://git.openembedded.org/openembedded-core/tree/meta/recipes-core/initscripts/initscripts_1.0.bb#n107

When I saw this, I was wondering about that too...

I think I'll hold off this patch whilst we think about that a bit but
my memory on this area is taking a bit of paging back in.

Cheers,

Richard

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#177571): 
https://lists.openembedded.org/g/openembedded-core/message/177571
Mute This Topic: https://lists.openembedded.org/mt/97151865/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH 08/11] build-appliance-image: use a real /tmp

2023-02-21 Thread Trevor Woerner 
On Tue 2023-02-21 @ 03:44:42 PM, Trevor Woerner via lists.openembedded.org 
wrote:
> Make /tmp a real directory in the root filesystem and not a link to an
> in-memory tmpfs. Otherwise bitbake will run out of inodes on /tmp very quickly
> and stop any build.
> 
> Signed-off-by: Trevor Woerner 
> ---
>  meta/recipes-core/images/build-appliance-image_15.0.0.bb | 6 ++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/meta/recipes-core/images/build-appliance-image_15.0.0.bb 
> b/meta/recipes-core/images/build-appliance-image_15.0.0.bb
> index 3a84de0a2b43..1f7b96a9fcf4 100644
> --- a/meta/recipes-core/images/build-appliance-image_15.0.0.bb
> +++ b/meta/recipes-core/images/build-appliance-image_15.0.0.bb
> @@ -113,6 +113,12 @@ fakeroot do_tweak_image () {
>   # add a /lib64 symlink
>   # this is needed for building rust-native on a 64-bit build appliance
>   ln -rs ${IMAGE_ROOTFS}/lib ${IMAGE_ROOTFS}/lib64
> +
> + # make /tmp a real directory and not a link to an in-memory tmpfs
> + # otherwise /tmp will run out of inodes very quickly when bitbaking
> + sed -i -e 's#l root root 1777 /tmp /var/tmp#d root root 1777 /tmp 
> none#' ${IMAGE_ROOTFS}/etc/default/volatiles/00_core
> + mkdir -p ${IMAGE_ROOTFS}/tmp
> + chmod 1777 ${IMAGE_ROOTFS}/tmp
>  }

Richard, this feels rather "hacky" to me. I can't help wonder if it would be
better to implement a VOLATILE_TMP_DIR mechanism (along the same lines as
VOLATILE_LOG_DIR)?

https://docs.yoctoproject.org/dev/ref-manual/variables.html?highlight=volatile_log_dir#term-VOLATILE_LOG_DIR
https://git.openembedded.org/openembedded-core/tree/meta/recipes-core/initscripts/initscripts_1.0.bb#n107

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#177556): 
https://lists.openembedded.org/g/openembedded-core/message/177556
Mute This Topic: https://lists.openembedded.org/mt/97151865/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH 08/11] build-appliance-image: use a real /tmp

2023-02-21 Thread Trevor Woerner 
Make /tmp a real directory in the root filesystem and not a link to an
in-memory tmpfs. Otherwise bitbake will run out of inodes on /tmp very quickly
and stop any build.

Signed-off-by: Trevor Woerner 
---
 meta/recipes-core/images/build-appliance-image_15.0.0.bb | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/meta/recipes-core/images/build-appliance-image_15.0.0.bb 
b/meta/recipes-core/images/build-appliance-image_15.0.0.bb
index 3a84de0a2b43..1f7b96a9fcf4 100644
--- a/meta/recipes-core/images/build-appliance-image_15.0.0.bb
+++ b/meta/recipes-core/images/build-appliance-image_15.0.0.bb
@@ -113,6 +113,12 @@ fakeroot do_tweak_image () {
# add a /lib64 symlink
# this is needed for building rust-native on a 64-bit build appliance
ln -rs ${IMAGE_ROOTFS}/lib ${IMAGE_ROOTFS}/lib64
+
+   # make /tmp a real directory and not a link to an in-memory tmpfs
+   # otherwise /tmp will run out of inodes very quickly when bitbaking
+   sed -i -e 's#l root root 1777 /tmp /var/tmp#d root root 1777 /tmp 
none#' ${IMAGE_ROOTFS}/etc/default/volatiles/00_core
+   mkdir -p ${IMAGE_ROOTFS}/tmp
+   chmod 1777 ${IMAGE_ROOTFS}/tmp
 }
 
 IMAGE_PREPROCESS_COMMAND += "do_populate_poky_src; do_tweak_image; "
-- 
2.36.0.rc2.17.g4027e30c53


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#177546): 
https://lists.openembedded.org/g/openembedded-core/message/177546
Mute This Topic: https://lists.openembedded.org/mt/97118451/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-