Re: [OE-core] [PATCH 1/1] pbzip2: fix for rebuild

2016-04-11 Thread Robert Yang 



On 04/11/2016 10:48 PM, Burton, Ross wrote:


On 11 April 2016 at 15:46, Burton, Ross > wrote:

Wouldn't "oe_runmake clean" be simpler?


Or not disabling do_configure in the recipe, as base.bbclass's do_configure
includes an invocation to make clean.


Thanks, Andre McCurdy has sent the patch, thanks.

// Robert



Ross

--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/1] pbzip2: fix for rebuild

2016-04-11 Thread Andre McCurdy 
On Mon, Apr 11, 2016 at 4:43 PM, Andre McCurdy  wrote:
> On Mon, Apr 11, 2016 at 7:48 AM, Burton, Ross  wrote:
>>
>> On 11 April 2016 at 15:46, Burton, Ross  wrote:
>>>
>>> Wouldn't "oe_runmake clean" be simpler?
>>
>> Or not disabling do_configure in the recipe, as base.bbclass's do_configure
>> includes an invocation to make clean.
>
> Since the bzip2 source files were changed, updating bzip2's PR (r5 ->
> r6) to force a full rebuild of pbzip2 might be a more robust solution?

To answer my own question, updating bzip2's PR doesn't help. It's the
pbzip2 recipe which needs fixing.

> More curious though is that after cleansstate, pbzip2-native doesn't
> build for me at all - the LIC_FILES_CHKSUM is wrong following the
> update from pbzip2 1.1.12 -> 1.1.13
>
>   
> http://git.openembedded.org/openembedded-core/commit/?id=80712b7c0959c197ccb21efd5e7a963d1d2e83ae
>
> ???
>
>> Ross
>>
>> --
>> ___
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/1] pbzip2: fix for rebuild

2016-04-11 Thread Andre McCurdy 
On Mon, Apr 11, 2016 at 7:48 AM, Burton, Ross  wrote:
>
> On 11 April 2016 at 15:46, Burton, Ross  wrote:
>>
>> Wouldn't "oe_runmake clean" be simpler?
>
> Or not disabling do_configure in the recipe, as base.bbclass's do_configure
> includes an invocation to make clean.

Since the bzip2 source files were changed, updating bzip2's PR (r5 ->
r6) to force a full rebuild of pbzip2 might be a more robust solution?

More curious though is that after cleansstate, pbzip2-native doesn't
build for me at all - the LIC_FILES_CHKSUM is wrong following the
update from pbzip2 1.1.12 -> 1.1.13

  
http://git.openembedded.org/openembedded-core/commit/?id=80712b7c0959c197ccb21efd5e7a963d1d2e83ae

???


> Ross
>
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/1] pbzip2: fix for rebuild

2016-04-11 Thread Burton, Ross 
On 8 April 2016 at 04:13, Robert Yang  wrote:

> +do_compile_prepend() {
> +# Update timestamp to fix rebuild
> +src_files="pbzip2.cpp BZ2StreamScanner.cpp ErrorContext.cpp"
> +for f in $src_files; do
> +if [ -f $f ]; then
> +touch $f
> +else
> +bbwarn "Regular file $f not found"
> +fi
> +done
>

Wouldn't "oe_runmake clean" be simpler?

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/1] pbzip2: fix for rebuild

2016-04-11 Thread Burton, Ross 
On 11 April 2016 at 15:46, Burton, Ross  wrote:

> Wouldn't "oe_runmake clean" be simpler?
>

Or not disabling do_configure in the recipe, as base.bbclass's do_configure
includes an invocation to make clean.

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 1/1] pbzip2: fix for rebuild

2016-04-07 Thread Robert Yang 
Fixed when rebuild pbzip2:
make: Nothing to be done for `all'

This may cause unexpected errors, for example, when depends libs
changed:
| pbzip2: error while loading shared libraries: libbz2.so.0: cannot open shared 
object file: No such file or directory

Signed-off-by: Robert Yang 
---
 meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb | 12 
 1 file changed, 12 insertions(+)

diff --git a/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb 
b/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb
index b3c5975..67fb2ef 100644
--- a/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb
+++ b/meta/recipes-extended/pbzip2/pbzip2_1.1.13.bb
@@ -22,6 +22,18 @@ do_configure[noexec] = "1"
 
 EXTRA_OEMAKE = "CXX='${CXX} ${CXXFLAGS}' LDFLAGS='${LDFLAGS}'"
 
+do_compile_prepend() {
+# Update timestamp to fix rebuild
+src_files="pbzip2.cpp BZ2StreamScanner.cpp ErrorContext.cpp"
+for f in $src_files; do
+if [ -f $f ]; then
+touch $f
+else
+bbwarn "Regular file $f not found"
+fi
+done
+}
+
 do_install() {
 install -d ${D}${bindir}
 install -m 0755 pbzip2 ${D}${bindir}/
-- 
2.7.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core