Re: [OE-core] [PATCH 17/23] qemu: add a gettext-native dependency
On Tue, 15 Jan 2019 at 16:06, Alexander Kanavin wrote: > > > > gettext is a heavy enough dependency I'm tempted to suggest we do: > > > > do_install[depends] += "gettext-native:do_populate_sysroot" > > > > given how slow qemu is to compile... > > I'm going to look a bit deeper to find out why this isn't a problem in > master, but is a problem in my patchset. This was just a quick fix to > get things to build, as I was eager to get to the point where opengl > works :) qemu already unconditionally depends on glib-2.0 which has a hard dependency on gettext-native, so this wouldn't slow down the builds. However, qemu itself depends on gettext utilities only when gtk+ is enabled: https://github.com/qemu/qemu/blob/master/Makefile#L743 so I'll move the dependency into gtk+ PACKAGECONFIG. Alex Alex -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 17/23] qemu: add a gettext-native dependency
On Tue, 15 Jan 2019 at 15:21, Richard Purdie wrote: > > xgettext/msgmerge is used during do_install(). > > > > Signed-off-by: Alexander Kanavin > > --- > > meta/recipes-devtools/qemu/qemu.inc | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes- > > devtools/qemu/qemu.inc > > index db9c2245df9..6937bbc87b4 100644 > > --- a/meta/recipes-devtools/qemu/qemu.inc > > +++ b/meta/recipes-devtools/qemu/qemu.inc > > @@ -1,7 +1,7 @@ > > SUMMARY = "Fast open source processor emulator" > > HOMEPAGE = "http://qemu.org"; > > LICENSE = "GPLv2 & LGPLv2.1" > > -DEPENDS = "glib-2.0 zlib pixman" > > +DEPENDS = "glib-2.0 zlib pixman gettext-native" > > RDEPENDS_${PN}_class-target += "bash" > > gettext is a heavy enough dependency I'm tempted to suggest we do: > > do_install[depends] += "gettext-native:do_populate_sysroot" > > given how slow qemu is to compile... I'm going to look a bit deeper to find out why this isn't a problem in master, but is a problem in my patchset. This was just a quick fix to get things to build, as I was eager to get to the point where opengl works :) Alex -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 17/23] qemu: add a gettext-native dependency
On Mon, 2019-01-14 at 16:03 +0100, Alexander Kanavin wrote: > xgettext/msgmerge is used during do_install(). > > Signed-off-by: Alexander Kanavin > --- > meta/recipes-devtools/qemu/qemu.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes- > devtools/qemu/qemu.inc > index db9c2245df9..6937bbc87b4 100644 > --- a/meta/recipes-devtools/qemu/qemu.inc > +++ b/meta/recipes-devtools/qemu/qemu.inc > @@ -1,7 +1,7 @@ > SUMMARY = "Fast open source processor emulator" > HOMEPAGE = "http://qemu.org"; > LICENSE = "GPLv2 & LGPLv2.1" > -DEPENDS = "glib-2.0 zlib pixman" > +DEPENDS = "glib-2.0 zlib pixman gettext-native" > RDEPENDS_${PN}_class-target += "bash" gettext is a heavy enough dependency I'm tempted to suggest we do: do_install[depends] += "gettext-native:do_populate_sysroot" given how slow qemu is to compile... Cheers, Richard -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH 17/23] qemu: add a gettext-native dependency
xgettext/msgmerge is used during do_install(). Signed-off-by: Alexander Kanavin --- meta/recipes-devtools/qemu/qemu.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-devtools/qemu/qemu.inc index db9c2245df9..6937bbc87b4 100644 --- a/meta/recipes-devtools/qemu/qemu.inc +++ b/meta/recipes-devtools/qemu/qemu.inc @@ -1,7 +1,7 @@ SUMMARY = "Fast open source processor emulator" HOMEPAGE = "http://qemu.org"; LICENSE = "GPLv2 & LGPLv2.1" -DEPENDS = "glib-2.0 zlib pixman" +DEPENDS = "glib-2.0 zlib pixman gettext-native" RDEPENDS_${PN}_class-target += "bash" require qemu-targets.inc -- 2.17.1 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core