Re: [OE-core] [PATCH 2/6] lttng-modules: fix build issue against kernel 4.4

[Bruce Ashfield]

On Mon, Dec 21, 2015 at 6:39 AM, Alexander Kanavin <
alexander.kana...@linux.intel.com> wrote:

> On 12/21/2015 01:27 PM, Otavio Salvador wrote:
>
> Commit logs are suppose to have the information useful to understand
>> the reason of the change. Latest hides all behind it and does not
>> communicate anything. I don't think expect people to read the code to
>> know you bumped (and to which) revision is right.
>>
>
> Having the exact upstream commit id - a bunch of random numbers and
> letters - in the commit message does not make the commit message any more
> useful, readable, or searchable. You can't even click on that id to open a
> gitweb webpage with the upstream patch (having that kind of link *would* be
> useful though).
>
> The change to the recipe is short, and no one should be overwhelmed by
> looking at it if they need the commit id.
>


We are of like minds on those points. It is more important to say why a
change
was required, which is all that I look for in anything that I maintain.

That, and I'm always concerned that if someone contributes a patch that
fixes
a real problem, or is part of a larger feature, and all they get are
nit-pick comments
about more minor elements, it is a barrier to entry. Hence, why I'll also
just
fix commit messages on the way into my queues if they need a tweak.

But I digress. I'll see if this passes autobuilder sanity, and if there's a
chance,
I'll add a date to the log (but of course the commit also carries that
info).

Cheers,

Bruce


>
> Alex
>
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 2/6] lttng-modules: fix build issue against kernel 4.4

[Alexander Kanavin]

On 12/21/2015 01:27 PM, Otavio Salvador wrote:


Commit logs are suppose to have the information useful to understand
the reason of the change. Latest hides all behind it and does not
communicate anything. I don't think expect people to read the code to
know you bumped (and to which) revision is right.


Having the exact upstream commit id - a bunch of random numbers and 
letters - in the commit message does not make the commit message any 
more useful, readable, or searchable. You can't even click on that id to 
open a gitweb webpage with the upstream patch (having that kind of link 
*would* be useful though).


The change to the recipe is short, and no one should be overwhelmed by 
looking at it if they need the commit id.


Alex
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 2/6] lttng-modules: fix build issue against kernel 4.4

[Otavio Salvador]

Hello Bruce,

On Sat, Dec 19, 2015 at 3:44 PM, Bruce Ashfield
 wrote:
> On Sat, Dec 19, 2015 at 5:05 AM, Otavio Salvador
>  wrote:
>>
>> On Fri, Dec 18, 2015 at 6:44 PM, Bruce Ashfield
>>  wrote:
>> > f4b27072
>>
>>
>> Use this revision on commit log; latest is not accurate as it moves during
>> time.
>>
>
> We'll disagree on that. The patch has the commit hash, repeating it in the
> commit message is not necessary. It's like patches saying "this patch", or
> explaining what is obvious from the patch. Both are not necessary.
>
> If Ross wants to change the commit during merge, I won't complain, but
> I'm happy with it, as is.

Commit logs are suppose to have the information useful to understand
the reason of the change. Latest hides all behind it and does not
communicate anything. I don't think expect people to read the code to
know you bumped (and to which) revision is right.

I am not the OE-Core maintainer but for any layer I am, I require this
to be recorded.

>From me, this is a NACK!

-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 2/6] lttng-modules: fix build issue against kernel 4.4

[Bruce Ashfield]

On Sat, Dec 19, 2015 at 12:44 PM, Bruce Ashfield 
wrote:

>
>
> On Sat, Dec 19, 2015 at 5:05 AM, Otavio Salvador <
> otavio.salva...@ossystems.com.br> wrote:
>
>> On Fri, Dec 18, 2015 at 6:44 PM, Bruce Ashfield
>>  wrote:
>> > f4b27072
>>
>>
>> Use this revision on commit log; latest is not accurate as it moves
>> during time.
>>
>>
> We'll disagree on that. The patch has the commit hash, repeating it in the
> commit message is not necessary. It's like patches saying "this patch", or
> explaining what is obvious from the patch. Both are not necessary.
>
> If Ross wants to change the commit during merge, I won't complain, but
> I'm happy with it, as is.
>

That and I'm now far away from my development machines until mid next week,
so
I can't easily rebase to change the log until then .. and this would be
better under
test, since without it, I can't bump to 4.4-rcX.

(and yes, I can at least use a date versus "latest" in any future updates).

Cheers,

Bruce


>
> Bruce
>
>
>> --
>> Otavio Salvador O.S. Systems
>> http://www.ossystems.com.brhttp://code.ossystems.com.br
>> Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
>> --
>> ___
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>
>
>
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness await thee
> at its end"
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 2/6] lttng-modules: fix build issue against kernel 4.4

[Bruce Ashfield]

On Sat, Dec 19, 2015 at 5:05 AM, Otavio Salvador <
otavio.salva...@ossystems.com.br> wrote:

> On Fri, Dec 18, 2015 at 6:44 PM, Bruce Ashfield
>  wrote:
> > f4b27072
>
>
> Use this revision on commit log; latest is not accurate as it moves during
> time.
>
>
We'll disagree on that. The patch has the commit hash, repeating it in the
commit message is not necessary. It's like patches saying "this patch", or
explaining what is obvious from the patch. Both are not necessary.

If Ross wants to change the commit during merge, I won't complain, but
I'm happy with it, as is.

Bruce


> --
> Otavio Salvador O.S. Systems
> http://www.ossystems.com.brhttp://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 2/6] lttng-modules: fix build issue against kernel 4.4

[Otavio Salvador]

On Fri, Dec 18, 2015 at 6:44 PM, Bruce Ashfield
 wrote:
> f4b27072


Use this revision on commit log; latest is not accurate as it moves during time.

-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 2/6] lttng-modules: fix build issue against kernel 4.4

[Bruce Ashfield]

Updating to the latest 2.7 stable commit which incorporates changes
for building against the 4.4-rc kernel series.

Signed-off-by: Bruce Ashfield 
---
 meta/recipes-kernel/lttng/lttng-modules_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/lttng/lttng-modules_git.bb 
b/meta/recipes-kernel/lttng/lttng-modules_git.bb
index 46cc1f012909..33aa12551e2e 100644
--- a/meta/recipes-kernel/lttng/lttng-modules_git.bb
+++ b/meta/recipes-kernel/lttng/lttng-modules_git.bb
@@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = 
"file://LICENSE;md5=362844633a08753bd96ab322a6c7f9f6 \
 
 inherit module
 
-SRCREV = "4247236df9113aca059d79c78d85779c1ff4edb0"
+SRCREV = "f4b27072a77b43af2fea72d6700bd64eb59a39f1"
 PV = "2.7.0+git${SRCPV}"
 
 COMPATIBLE_HOST = '(x86_64|i.86|powerpc|aarch64|mips|arm).*-linux'
-- 
2.1.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core