On Tue, Feb 27, 2024 at 12:09 PM Enrico Jörns wrote:
>
> The task 'do_kernel_version_sanity_check' was defined in kernel.bbclass
> but used in kernel-yocto.bbclass only.
>
> Since the task does not depend on any kernel-yocto-specific task
> (anymore), move it to the kernel.bbclass so the check can run for all
> kernels.
>
> If it turns out that this causes too many noise for people that are not
> interested in a consistency between ${PV} and the kernel version, an
> option could be to let KERNEL_VERSION_SANITY_SKIP weakly default to "1"
> in kernel.bbclass or alternatively move the entire code to
> kernel-yocto.bbclass.
The check is actually quite annoying / noisy when working on updating a
kernel.
So we may get complaints :)
Again, I don't have a strong opinion, since the functionality is unchanged
for linux-yocto
Bruce
>
> Signed-off-by: Enrico Jörns
> ---
> meta/classes-recipe/kernel-yocto.bbclass | 1 -
> meta/classes-recipe/kernel.bbclass | 2 ++
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes-recipe/kernel-yocto.bbclass
> b/meta/classes-recipe/kernel-yocto.bbclass
> index 854e4681d5..b7d74b7ab8 100644
> --- a/meta/classes-recipe/kernel-yocto.bbclass
> +++ b/meta/classes-recipe/kernel-yocto.bbclass
> @@ -729,6 +729,5 @@ python () {
> }
>
> # extra tasks
> -addtask kernel_version_sanity_check after do_patch before do_compile
> addtask validate_branches before do_patch after do_kernel_checkout
> addtask kernel_configcheck after do_configure before do_compile
> diff --git a/meta/classes-recipe/kernel.bbclass
> b/meta/classes-recipe/kernel.bbclass
> index 837064cef7..3c805fd96f 100644
> --- a/meta/classes-recipe/kernel.bbclass
> +++ b/meta/classes-recipe/kernel.bbclass
> @@ -514,6 +514,8 @@ do_kernel_version_sanity_check() {
> exit 0
> }
>
> +addtask kernel_version_sanity_check after do_patch before do_compile
> +
> addtask shared_workdir after do_compile before do_compile_kernelmodules
> addtask shared_workdir_setscene
>
> --
> 2.39.2
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#196284):
https://lists.openembedded.org/g/openembedded-core/message/196284
Mute This Topic: https://lists.openembedded.org/mt/104606848/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
