Re: [OE-core] [PATCH 7/8] busybox: disable fstrim in defconfig
On Wed, Jul 29, 2015 at 11:22 AM, Burton, Ross ross.bur...@intel.com wrote: On 29 July 2015 at 00:21, Andre McCurdy armccu...@gmail.com wrote: The fstrim applet (to discard unused blocks on a mounted filesystem) doesn't seem like core functionality, so disable by default. With SSDs being more common, is this really true? What's the size impact of this? I agree with Ross here and I think it should stay enabled. -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 7/8] busybox: disable fstrim in defconfig
On Wed, Jul 29, 2015 at 9:28 AM, Otavio Salvador otavio.salva...@ossystems.com.br wrote: On Wed, Jul 29, 2015 at 11:22 AM, Burton, Ross ross.bur...@intel.com wrote: On 29 July 2015 at 00:21, Andre McCurdy armccu...@gmail.com wrote: The fstrim applet (to discard unused blocks on a mounted filesystem) doesn't seem like core functionality, so disable by default. With SSDs being more common, is this really true? What's the size impact of this? I agree with Ross here and I think it should stay enabled. I was thinking most people with an SSD would mount -o discard and let the filesystem take care of issuing trim commands. Trimming manually from a shell script seems like more of a niche requirement. The fstrim applet adds less than 200 bytes to the busybox binary though (x86). I'll send an updated patch series which leaves it enabled. -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 7/8] busybox: disable fstrim in defconfig
On 29 July 2015 at 00:21, Andre McCurdy armccu...@gmail.com wrote: The fstrim applet (to discard unused blocks on a mounted filesystem) doesn't seem like core functionality, so disable by default. With SSDs being more common, is this really true? What's the size impact of this? Ross -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH 7/8] busybox: disable fstrim in defconfig
The fstrim applet (to discard unused blocks on a mounted filesystem) doesn't seem like core functionality, so disable by default. Signed-off-by: Andre McCurdy armccu...@gmail.com --- meta/recipes-core/busybox/busybox/defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-core/busybox/busybox/defconfig b/meta/recipes-core/busybox/busybox/defconfig index 74d12ee..ad0c7e1 100644 --- a/meta/recipes-core/busybox/busybox/defconfig +++ b/meta/recipes-core/busybox/busybox/defconfig @@ -546,7 +546,7 @@ CONFIG_DEFAULT_DEPMOD_FILE=modules.dep # # CONFIG_BLOCKDEV is not set # CONFIG_FATATTR is not set -CONFIG_FSTRIM=y +# CONFIG_FSTRIM is not set # CONFIG_MDEV is not set # CONFIG_FEATURE_MDEV_CONF is not set # CONFIG_FEATURE_MDEV_RENAME is not set -- 1.9.1 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
