Re: [OE-core] [PATCH V2] bash: 4.3.30 -> 4.4
ping -Original Message- From: Zheng, Ruoqin/郑 若钦 Sent: Monday, January 23, 2017 10:39 AM To: openembedded-core@lists.openembedded.org Cc: Zheng, Ruoqin/郑 若钦 <zhengrq.f...@cn.fujitsu.com> Subject: [OE-core] [PATCH V2] bash: 4.3.30 -> 4.4 1) Upgrade bash from 4.3.30 to 4.4 2) Delete 1 patche below, since they are integrated upstream. fix-run-intl.patch 3) Modify 2 patches below to make it compatible with new version fix-run-coproc-run-heredoc-run-execscript-run-test-f.patch test-output.patch 4) Add 1 patche below to solve pkgconfig sanity error 0001-patch-to-obtain-pkgconfig-sanity.patch Signed-off-by: Zheng Ruoqin <zhengrq.f...@cn.fujitsu.com> --- .../0001-patch-to-obtain-pkgconfig-sanity.patch| 28 + ...roc-run-heredoc-run-execscript-run-test-f.patch | 137 ++--- meta/recipes-extended/bash/bash/fix-run-intl.patch | 110 - meta/recipes-extended/bash/bash/test-output.patch | 20 ++- meta/recipes-extended/bash/bash_4.3.30.bb | 71 --- meta/recipes-extended/bash/bash_4.4.bb | 38 ++ 6 files changed, 92 insertions(+), 312 deletions(-) create mode 100644 meta/recipes-extended/bash/bash/0001-patch-to-obtain-pkgconfig-sanity.patch delete mode 100644 meta/recipes-extended/bash/bash/fix-run-intl.patch delete mode 100644 meta/recipes-extended/bash/bash_4.3.30.bb create mode 100644 meta/recipes-extended/bash/bash_4.4.bb diff --git a/meta/recipes-extended/bash/bash/0001-patch-to-obtain-pkgconfig-sanity.patch b/meta/recipes-extended/bash/bash/0001-patch-to-obtain-pkgconfig-sanity.patch new file mode 100644 index 000..9b5e4ec --- /dev/null +++ b/meta/recipes-extended/bash/bash/0001-patch-to-obtain-pkgconfig-san +++ ity.patch @@ -0,0 +1,28 @@ +Subject: [PATCH] patch to obtain pkgconfig sanity + +Drop the paths from the pkgconfig file bash.pc.in which will cause pkgconfig sanity error below: +ERROR: QA Issue: bash.pc failed sanity test (tmpdir) in path /yocto/work001/fnst/zrq/community/poky/build/tmp/work/i586-poky-linux/bash /4.4-r0/sysroot-destdir/usr/lib/pkgconfig [pkgconfig] + +Upstream-Status: Pending + +Signed-off-by: Zheng Ruoqin <zhengrq.f...@cn.fujitsu.com> +--- + support/bash.pc.in | 2 -- + 1 file changed, 2 deletions(-) + +diff --git a/support/bash.pc.in b/support/bash.pc.in index +6009659..871fa9f 100644 +--- a/support/bash.pc.in b/support/bash.pc.in +@@ -12,8 +12,6 @@ LOCAL_CFLAGS = @LOCAL_CFLAGS@ LOCAL_DEFS = +@LOCAL_DEFS@ CCFLAGS = ${LOCAL_DEFS} ${LOCAL_CFLAGS} + +-CC = @CC@ +-SHOBJ_CC = @SHOBJ_CC@ + SHOBJ_CFLAGS = @SHOBJ_CFLAGS@ + SHOBJ_LD = @SHOBJ_LD@ + SHOBJ_LDFLAGS = @SHOBJ_LDFLAGS@ +-- +2.7.4 + diff --git a/meta/recipes-extended/bash/bash/fix-run-coproc-run-heredoc-run-execscript-run-test-f.patch b/meta/recipes-extended/bash/bash/fix-run-coproc-run-heredoc-run-execscript-run-test-f.patch index 7f099ae..d6beaff 100644 --- a/meta/recipes-extended/bash/bash/fix-run-coproc-run-heredoc-run-execscript-run-test-f.patch +++ b/meta/recipes-extended/bash/bash/fix-run-coproc-run-heredoc-run-exe +++ cscript-run-test-f.patch @@ -20,150 +20,35 @@ the test suite should not be run as root Upstream-Status: Pending Signed-off-by: Hongxu Jia <hongxu@windriver.com> +Signed-off-by: Zheng Ruoqin <zhengrq.f...@cn.fujitsu.com> --- - tests/coproc.right | 5 + - tests/coproc.tests | 30 +- - tests/heredoc.right | 5 ++--- - tests/heredoc3.sub | 3 ++- - tests/run-execscript | 3 ++- - tests/run-test | 3 ++- - 6 files changed, 34 insertions(+), 15 deletions(-) + tests/run-execscript | 3 ++- + tests/run-test | 3 ++- + 2 files changed, 4 insertions(+), 2 deletions(-) -diff --git a/tests/coproc.right b/tests/coproc.right -index 6d9deaa..94b001c 100644 a/tests/coproc.right -+++ b/tests/coproc.right -@@ -1,11 +1,8 @@ --84575 - 63 60 - a b c --84577 - 63 60 - flop --./coproc.tests: line 22: 84577 Terminated coproc REFLECT { cat -; } --84579 -+coproc.tests: REFLECT: status 143 - 63 60 - FOO - 63 60 -diff --git a/tests/coproc.tests b/tests/coproc.tests -index 8be3563..d347eb7 100644 a/tests/coproc.tests -+++ b/tests/coproc.tests -@@ -1,6 +1,13 @@ -+: ${TMPDIR:=/tmp} -+TMPOUT=${TMPDIR}/coproc-wait-$BASHPID -+ - coproc { echo a b c; sleep 2; } - --echo $COPROC_PID -+case $COPROC_PID in -+[0-9]*) ;; -+*)echo COPROC_PID not integer ;; -+esac -+ - echo ${COPROC[@]} - - read LINE <&${COPROC[0]} -@@ -10,7 +17,11 @@ wait $COPROC_PID - - coproc REFLECT { cat - ; } - --echo $REFLECT_PID -+case $REFLECT_PID in -+[0-9]*) ;; -+*)echo REFLECT_PID not integer ;; -+esac -+ - echo ${REFLECT[@]} - - echo flop >&${REFLECT[1]} -@@ -18,12 +29,21 @@ read LINE <&${REFLECT[0]} - - echo $LINE - --kill $REFLECT_PID --wait $REFLECT_PID -+{ sleep 1; kill $REFLECT_PID; } & -+wait $REFLECT_PID >$TMPOUT 2>&1 || echo "coproc.tests: REFLECT:
[OE-core] [PATCH V2] bash: 4.3.30 -> 4.4
1) Upgrade bash from 4.3.30 to 4.4 2) Delete 1 patche below, since they are integrated upstream. fix-run-intl.patch 3) Modify 2 patches below to make it compatible with new version fix-run-coproc-run-heredoc-run-execscript-run-test-f.patch test-output.patch 4) Add 1 patche below to solve pkgconfig sanity error 0001-patch-to-obtain-pkgconfig-sanity.patch Signed-off-by: Zheng Ruoqin--- .../0001-patch-to-obtain-pkgconfig-sanity.patch| 28 + ...roc-run-heredoc-run-execscript-run-test-f.patch | 137 ++--- meta/recipes-extended/bash/bash/fix-run-intl.patch | 110 - meta/recipes-extended/bash/bash/test-output.patch | 20 ++- meta/recipes-extended/bash/bash_4.3.30.bb | 71 --- meta/recipes-extended/bash/bash_4.4.bb | 38 ++ 6 files changed, 92 insertions(+), 312 deletions(-) create mode 100644 meta/recipes-extended/bash/bash/0001-patch-to-obtain-pkgconfig-sanity.patch delete mode 100644 meta/recipes-extended/bash/bash/fix-run-intl.patch delete mode 100644 meta/recipes-extended/bash/bash_4.3.30.bb create mode 100644 meta/recipes-extended/bash/bash_4.4.bb diff --git a/meta/recipes-extended/bash/bash/0001-patch-to-obtain-pkgconfig-sanity.patch b/meta/recipes-extended/bash/bash/0001-patch-to-obtain-pkgconfig-sanity.patch new file mode 100644 index 000..9b5e4ec --- /dev/null +++ b/meta/recipes-extended/bash/bash/0001-patch-to-obtain-pkgconfig-sanity.patch @@ -0,0 +1,28 @@ +Subject: [PATCH] patch to obtain pkgconfig sanity + +Drop the paths from the pkgconfig file bash.pc.in which will cause pkgconfig sanity error below: +ERROR: QA Issue: bash.pc failed sanity test (tmpdir) in path /yocto/work001/fnst/zrq/community/poky/build/tmp/work/i586-poky-linux/bash /4.4-r0/sysroot-destdir/usr/lib/pkgconfig [pkgconfig] + +Upstream-Status: Pending + +Signed-off-by: Zheng Ruoqin +--- + support/bash.pc.in | 2 -- + 1 file changed, 2 deletions(-) + +diff --git a/support/bash.pc.in b/support/bash.pc.in +index 6009659..871fa9f 100644 +--- a/support/bash.pc.in b/support/bash.pc.in +@@ -12,8 +12,6 @@ LOCAL_CFLAGS = @LOCAL_CFLAGS@ + LOCAL_DEFS = @LOCAL_DEFS@ + CCFLAGS = ${LOCAL_DEFS} ${LOCAL_CFLAGS} + +-CC = @CC@ +-SHOBJ_CC = @SHOBJ_CC@ + SHOBJ_CFLAGS = @SHOBJ_CFLAGS@ + SHOBJ_LD = @SHOBJ_LD@ + SHOBJ_LDFLAGS = @SHOBJ_LDFLAGS@ +-- +2.7.4 + diff --git a/meta/recipes-extended/bash/bash/fix-run-coproc-run-heredoc-run-execscript-run-test-f.patch b/meta/recipes-extended/bash/bash/fix-run-coproc-run-heredoc-run-execscript-run-test-f.patch index 7f099ae..d6beaff 100644 --- a/meta/recipes-extended/bash/bash/fix-run-coproc-run-heredoc-run-execscript-run-test-f.patch +++ b/meta/recipes-extended/bash/bash/fix-run-coproc-run-heredoc-run-execscript-run-test-f.patch @@ -20,150 +20,35 @@ the test suite should not be run as root Upstream-Status: Pending Signed-off-by: Hongxu Jia +Signed-off-by: Zheng Ruoqin --- - tests/coproc.right | 5 + - tests/coproc.tests | 30 +- - tests/heredoc.right | 5 ++--- - tests/heredoc3.sub | 3 ++- - tests/run-execscript | 3 ++- - tests/run-test | 3 ++- - 6 files changed, 34 insertions(+), 15 deletions(-) + tests/run-execscript | 3 ++- + tests/run-test | 3 ++- + 2 files changed, 4 insertions(+), 2 deletions(-) -diff --git a/tests/coproc.right b/tests/coproc.right -index 6d9deaa..94b001c 100644 a/tests/coproc.right -+++ b/tests/coproc.right -@@ -1,11 +1,8 @@ --84575 - 63 60 - a b c --84577 - 63 60 - flop --./coproc.tests: line 22: 84577 Terminated coproc REFLECT { cat -; } --84579 -+coproc.tests: REFLECT: status 143 - 63 60 - FOO - 63 60 -diff --git a/tests/coproc.tests b/tests/coproc.tests -index 8be3563..d347eb7 100644 a/tests/coproc.tests -+++ b/tests/coproc.tests -@@ -1,6 +1,13 @@ -+: ${TMPDIR:=/tmp} -+TMPOUT=${TMPDIR}/coproc-wait-$BASHPID -+ - coproc { echo a b c; sleep 2; } - --echo $COPROC_PID -+case $COPROC_PID in -+[0-9]*) ;; -+*)echo COPROC_PID not integer ;; -+esac -+ - echo ${COPROC[@]} - - read LINE <&${COPROC[0]} -@@ -10,7 +17,11 @@ wait $COPROC_PID - - coproc REFLECT { cat - ; } - --echo $REFLECT_PID -+case $REFLECT_PID in -+[0-9]*) ;; -+*)echo REFLECT_PID not integer ;; -+esac -+ - echo ${REFLECT[@]} - - echo flop >&${REFLECT[1]} -@@ -18,12 +29,21 @@ read LINE <&${REFLECT[0]} - - echo $LINE - --kill $REFLECT_PID --wait $REFLECT_PID -+{ sleep 1; kill $REFLECT_PID; } & -+wait $REFLECT_PID >$TMPOUT 2>&1 || echo "coproc.tests: REFLECT: status $?" -+grep 'Terminated.*coproc.*REFLECT' < $TMPOUT >/dev/null 2>&1 || { -+ echo "coproc.tests: wait for REFLECT failed" >&2 -+} -+rm -f $TMPOUT -+exec 2>&1 - - coproc xcase -n -u - --echo $COPROC_PID -+case $COPROC_PID in -+[0-9]*) ;; -+*)echo COPROC_PID not integer ;; -+esac -+ - echo ${COPROC[@]} - - echo foo