Re: [OE-core] [PATCH v2] bluez5: Point hciattach bcm43xx firmware search path to /lib/firmware

2022-11-01 Thread Ross Burton 
On 1 Nov 2022, at 21:02, Marek Vasut via lists.openembedded.org 
 wrote:
>>> +CFLAGS:append = " -DFIRMWARE_DIR=\\"${nonarch_base_libdir}/firmware\\""
>> why do we use append and not += here ?
> 
> Isn't the override syntax preferred now ?

Different behaviour for different purposes.  += would be idiomatic here.

Ross
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#172390): 
https://lists.openembedded.org/g/openembedded-core/message/172390
Mute This Topic: https://lists.openembedded.org/mt/94707064/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH v2] bluez5: Point hciattach bcm43xx firmware search path to /lib/firmware

2022-11-01 Thread Marek Vasut 

On 11/1/22 21:41, Khem Raj wrote:

On 11/1/22 4:54 AM, Marek Vasut wrote:

Currently the hciattach bcm43xx firmware loader looks up the firmware
blob in /etc/firmware . Change this to /lib/firmware instead, so that
the path is consistent with Linux kernel which also looks up firmware
for the WiFi part in /lib/firmware .

Signed-off-by: Marek Vasut 
---
Cc: Alexander Kanavin 
Cc: Alexandre Belloni 
Cc: Richard Purdie 
---
V2: Replace hard-coded /lib with ${nonarch_base_libdir}
---
  meta/recipes-connectivity/bluez5/bluez5.inc | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc 
b/meta/recipes-connectivity/bluez5/bluez5.inc

index f07e318897..a2aa7b86c4 100644
--- a/meta/recipes-connectivity/bluez5/bluez5.inc
+++ b/meta/recipes-connectivity/bluez5/bluez5.inc
@@ -68,6 +68,8 @@ EXTRA_OECONF = "\
    --without-zsh-completion-dir \
  "
+CFLAGS:append = " -DFIRMWARE_DIR=\\"${nonarch_base_libdir}/firmware\\""


why do we use append and not += here ?


Isn't the override syntax preferred now ?

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#172389): 
https://lists.openembedded.org/g/openembedded-core/message/172389
Mute This Topic: https://lists.openembedded.org/mt/94707064/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH v2] bluez5: Point hciattach bcm43xx firmware search path to /lib/firmware

2022-11-01 Thread Khem Raj 

On 11/1/22 4:54 AM, Marek Vasut wrote:

Currently the hciattach bcm43xx firmware loader looks up the firmware
blob in /etc/firmware . Change this to /lib/firmware instead, so that
the path is consistent with Linux kernel which also looks up firmware
for the WiFi part in /lib/firmware .

Signed-off-by: Marek Vasut 
---
Cc: Alexander Kanavin 
Cc: Alexandre Belloni 
Cc: Richard Purdie 
---
V2: Replace hard-coded /lib with ${nonarch_base_libdir}
---
  meta/recipes-connectivity/bluez5/bluez5.inc | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc 
b/meta/recipes-connectivity/bluez5/bluez5.inc
index f07e318897..a2aa7b86c4 100644
--- a/meta/recipes-connectivity/bluez5/bluez5.inc
+++ b/meta/recipes-connectivity/bluez5/bluez5.inc
@@ -68,6 +68,8 @@ EXTRA_OECONF = "\
--without-zsh-completion-dir \
  "
  
+CFLAGS:append = " -DFIRMWARE_DIR=\\"${nonarch_base_libdir}/firmware\\""


why do we use append and not += here ?


+
  # bluez5 builds a large number of useful utilities but does not
  # install them.  Specify which ones we want put into ${PN}-noinst-tools.
  NOINST_TOOLS_READLINE ??= ""







OpenPGP_0xBB053355919D3314.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#172387): 
https://lists.openembedded.org/g/openembedded-core/message/172387
Mute This Topic: https://lists.openembedded.org/mt/94707064/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[OE-core] [PATCH v2] bluez5: Point hciattach bcm43xx firmware search path to /lib/firmware

2022-11-01 Thread Marek Vasut 
Currently the hciattach bcm43xx firmware loader looks up the firmware
blob in /etc/firmware . Change this to /lib/firmware instead, so that
the path is consistent with Linux kernel which also looks up firmware
for the WiFi part in /lib/firmware .

Signed-off-by: Marek Vasut 
---
Cc: Alexander Kanavin 
Cc: Alexandre Belloni 
Cc: Richard Purdie 
---
V2: Replace hard-coded /lib with ${nonarch_base_libdir}
---
 meta/recipes-connectivity/bluez5/bluez5.inc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc 
b/meta/recipes-connectivity/bluez5/bluez5.inc
index f07e318897..a2aa7b86c4 100644
--- a/meta/recipes-connectivity/bluez5/bluez5.inc
+++ b/meta/recipes-connectivity/bluez5/bluez5.inc
@@ -68,6 +68,8 @@ EXTRA_OECONF = "\
   --without-zsh-completion-dir \
 "
 
+CFLAGS:append = " -DFIRMWARE_DIR=\\"${nonarch_base_libdir}/firmware\\""
+
 # bluez5 builds a large number of useful utilities but does not
 # install them.  Specify which ones we want put into ${PN}-noinst-tools.
 NOINST_TOOLS_READLINE ??= ""
-- 
2.35.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#172359): 
https://lists.openembedded.org/g/openembedded-core/message/172359
Mute This Topic: https://lists.openembedded.org/mt/94707064/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-