Re: [OE-core] [PATCH v2 5/6] busybox.inc: improve reproducibility

2017-05-01 Thread Andre McCurdy
On Mon, May 1, 2017 at 1:59 PM, Juro Bystricky  wrote:
> For reproducible builds do not generate build timestamp as part of
> the version string.

Maybe just do that by default?

> Signed-off-by: Juro Bystricky 
> ---
>  meta/recipes-core/busybox/busybox.inc | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/meta/recipes-core/busybox/busybox.inc 
> b/meta/recipes-core/busybox/busybox.inc
> index 375632d..3e991f9 100644
> --- a/meta/recipes-core/busybox/busybox.inc
> +++ b/meta/recipes-core/busybox/busybox.inc
> @@ -138,6 +138,9 @@ do_configure () {
>
>  do_compile() {
> unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
> +   if [ "$BUILD_REPRODUCIBLE_BINARIES" = "1" ]; then
> +   export KCONFIG_NOTIMESTAMP=1
> +   fi
> if [ "${BUSYBOX_SPLIT_SUID}" = "1" -a x`grep 
> "CONFIG_FEATURE_INDIVIDUAL=y" .config` = x ]; then
> # split the .config into two parts, and make two busybox binaries
> if [ -e .config.orig ]; then
> --
> 2.7.4
>
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH v2 5/6] busybox.inc: improve reproducibility

2017-05-01 Thread Juro Bystricky
For reproducible builds do not generate build timestamp as part of
the version string.

Signed-off-by: Juro Bystricky 
---
 meta/recipes-core/busybox/busybox.inc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-core/busybox/busybox.inc 
b/meta/recipes-core/busybox/busybox.inc
index 375632d..3e991f9 100644
--- a/meta/recipes-core/busybox/busybox.inc
+++ b/meta/recipes-core/busybox/busybox.inc
@@ -138,6 +138,9 @@ do_configure () {
 
 do_compile() {
unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
+   if [ "$BUILD_REPRODUCIBLE_BINARIES" = "1" ]; then
+   export KCONFIG_NOTIMESTAMP=1
+   fi
if [ "${BUSYBOX_SPLIT_SUID}" = "1" -a x`grep 
"CONFIG_FEATURE_INDIVIDUAL=y" .config` = x ]; then
# split the .config into two parts, and make two busybox binaries
if [ -e .config.orig ]; then
-- 
2.7.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core