Re: [OE-core] [PATCH v2 6/6] midori: Depend on Adwaita, not gnome-icon-theme

2015-06-15 Thread Jussi Kukkonen 
On 12 June 2015 at 18:25, Alexander Kanavin
alexander.kana...@linux.intel.com wrote:
 On 06/12/2015 04:11 PM, Jussi Kukkonen wrote:

 -RRECOMMENDS_${PN} += glib-networking ca-certificates gnome-icon-theme
 +RRECOMMENDS_${PN} += glib-networking ca-certificates adwaita-icon-theme

 This should probably be moved to gtk+ recipes or gnome class; if most(all?)
 gtk+ applications need those icons, then they shouldn't have to list them in
 their own recipes.

Thanks for the reminder, I was going to bring this up:

GTK+ does not have fallback icons included and uses symbolic icons in
many places (and the hicolor icon set does not include symbolic
icons). This means that without symbolic icons installed many GTK+
applications will look bad with placeholder icons even in stock
widgets.

So gtk+3 should probably RRECOMMEND something that provides a symbolic
theme -- currently the only option is Adwaita. If the size increase
(of an image that contains GTK) is seen as prohibitive I could
separate the symbolic icons and the normal icons: that way gtk+3 could
recommend just the symbolic theme which would 'only' be 11MB
additional size.

Now that I think about it, I guess dividing the icons into those
separate packages makes sense anyway. I'm going to do that in V3 of
this patch set but would appreciate advice on what to do with the
dependency/recommendation question.

Jussi
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH v2 6/6] midori: Depend on Adwaita, not gnome-icon-theme

2015-06-12 Thread Jussi Kukkonen 
Adwaita is the current GNOME icon theme and provides the
symbolic icons gnome-icon-theme does not.

Signed-off-by: Jussi Kukkonen jussi.kukko...@intel.com
---
 meta/recipes-sato/midori/midori_0.5.8.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-sato/midori/midori_0.5.8.bb 
b/meta/recipes-sato/midori/midori_0.5.8.bb
index aa1b395..1c027fe4 100644
--- a/meta/recipes-sato/midori/midori_0.5.8.bb
+++ b/meta/recipes-sato/midori/midori_0.5.8.bb
@@ -26,6 +26,6 @@ EXTRA_OECMAKE =  \
 
 TARGET_CC_ARCH += ${LDFLAGS}
 
-RRECOMMENDS_${PN} += glib-networking ca-certificates gnome-icon-theme
+RRECOMMENDS_${PN} += glib-networking ca-certificates adwaita-icon-theme
 
 FILES_${PN} += ${datadir}/appdata
-- 
2.1.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH v2 6/6] midori: Depend on Adwaita, not gnome-icon-theme

2015-06-12 Thread Alexander Kanavin 

On 06/12/2015 04:11 PM, Jussi Kukkonen wrote:


-RRECOMMENDS_${PN} += glib-networking ca-certificates gnome-icon-theme
+RRECOMMENDS_${PN} += glib-networking ca-certificates adwaita-icon-theme


This should probably be moved to gtk+ recipes or gnome class; if 
most(all?) gtk+ applications need those icons, then they shouldn't have 
to list them in their own recipes.


Alex

--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core