Re: [OE-core] [PATCHv2 1/1] insane.bbclass: Add missing dependencies
On 15/02/17 22:02, Richard Purdie wrote: > On Fri, 2017-02-10 at 14:19 -0600, mariano.lo...@linux.intel.com wrote: >> From: Mariano Lopez>> >> package_qa task requires some tools installed in sysroot; with >> the introduction of recipe specific sysroot this task won't >> have such tools installed if it's forced to run. >> >> Signed-off-by: Mariano Lopez >> --- >> meta/classes/insane.bbclass | 5 - >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/meta/classes/insane.bbclass >> b/meta/classes/insane.bbclass >> index 3cf86c1..0167b14 100644 >> --- a/meta/classes/insane.bbclass >> +++ b/meta/classes/insane.bbclass >> @@ -1223,9 +1223,12 @@ python do_package_qa () { >> bb.note("DONE with PACKAGE QA") >> } >> >> +# binutils is used for most checks, so need to set as dependency >> +# POPULATESYSROOTDEPS is defined in staging class. >> +do_package_qa[depends] += "${POPULATESYSROOTDEPS}" >> do_package_qa[vardepsexclude] = "BB_TASKDEPDATA" >> do_package_qa[rdeptask] = "do_packagedata" >> -addtask do_package_qa after do_packagedata do_package before >> do_build >> +addtask do_package_qa after do_prepare_recipe_sysroot do_packagedata >> do_package before do_build > This is close but I don't think you need this last addtask change, I > think it should work just fine with the added [depends]? Indeed, it works just with [depends]. Just sent v3 of this patch. Mariano > > Cheers, > > Richard -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCHv2 1/1] insane.bbclass: Add missing dependencies
On Fri, 2017-02-10 at 14:19 -0600, mariano.lo...@linux.intel.com wrote: > From: Mariano Lopez> > package_qa task requires some tools installed in sysroot; with > the introduction of recipe specific sysroot this task won't > have such tools installed if it's forced to run. > > Signed-off-by: Mariano Lopez > --- > meta/classes/insane.bbclass | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/insane.bbclass > b/meta/classes/insane.bbclass > index 3cf86c1..0167b14 100644 > --- a/meta/classes/insane.bbclass > +++ b/meta/classes/insane.bbclass > @@ -1223,9 +1223,12 @@ python do_package_qa () { > bb.note("DONE with PACKAGE QA") > } > > +# binutils is used for most checks, so need to set as dependency > +# POPULATESYSROOTDEPS is defined in staging class. > +do_package_qa[depends] += "${POPULATESYSROOTDEPS}" > do_package_qa[vardepsexclude] = "BB_TASKDEPDATA" > do_package_qa[rdeptask] = "do_packagedata" > -addtask do_package_qa after do_packagedata do_package before > do_build > +addtask do_package_qa after do_prepare_recipe_sysroot do_packagedata > do_package before do_build This is close but I don't think you need this last addtask change, I think it should work just fine with the added [depends]? Cheers, Richard -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCHv2 1/1] insane.bbclass: Add missing dependencies
From: Mariano Lopezpackage_qa task requires some tools installed in sysroot; with the introduction of recipe specific sysroot this task won't have such tools installed if it's forced to run. Signed-off-by: Mariano Lopez --- meta/classes/insane.bbclass | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 3cf86c1..0167b14 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass @@ -1223,9 +1223,12 @@ python do_package_qa () { bb.note("DONE with PACKAGE QA") } +# binutils is used for most checks, so need to set as dependency +# POPULATESYSROOTDEPS is defined in staging class. +do_package_qa[depends] += "${POPULATESYSROOTDEPS}" do_package_qa[vardepsexclude] = "BB_TASKDEPDATA" do_package_qa[rdeptask] = "do_packagedata" -addtask do_package_qa after do_packagedata do_package before do_build +addtask do_package_qa after do_prepare_recipe_sysroot do_packagedata do_package before do_build SSTATETASKS += "do_package_qa" do_package_qa[sstate-inputdirs] = "" -- 2.10.2 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core