Re: [OE-core] [RESEND PATCH 2/2] oeqa/selftest/devtool: remove spaces on empty line
Le mer. 25 oct. 2023 à 17:01, Luca Ceresoli a écrit : > > Hello Julien, > > On Tue, 24 Oct 2023 16:17:54 +0200 > "Julien Stephan" wrote: > > > Signed-off-by: Julien Stephan > > --- > > meta/lib/oeqa/selftest/cases/devtool.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/lib/oeqa/selftest/cases/devtool.py > > b/meta/lib/oeqa/selftest/cases/devtool.py > > index c36b1efa78b..b5c488be8e8 100644 > > --- a/meta/lib/oeqa/selftest/cases/devtool.py > > +++ b/meta/lib/oeqa/selftest/cases/devtool.py > > @@ -575,7 +575,7 @@ class DevtoolAddTests(DevtoolBase): > > checkvars['S'] = '${WORKDIR}/MarkupSafe-%s' % testver > > checkvars['SRC_URI'] = url > > self._test_recipe_contents(recipefile, checkvars, []) > > - > > + > > This patch does not apply due to the '-' line above having no spaces > after '-'. Perhaps your mailer mangled the content removing training > whitespace (which, ironically, is what the patch itself aims at doing!). > > Using 'git send-email' is usually the best way to send patches without > this sort of issues. > Hi Luca My editor mangled it.. I just resent it again. Thank you Cheers Julien > Luca > > -- > Luca Ceresoli, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#189691): https://lists.openembedded.org/g/openembedded-core/message/189691 Mute This Topic: https://lists.openembedded.org/mt/102158568/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core][RESEND][PATCH 2/2] oeqa/selftest/devtool: remove spaces on empty line
Signed-off-by: Julien Stephan --- meta/lib/oeqa/selftest/cases/devtool.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/lib/oeqa/selftest/cases/devtool.py b/meta/lib/oeqa/selftest/cases/devtool.py index c36b1efa78b..b5c488be8e8 100644 --- a/meta/lib/oeqa/selftest/cases/devtool.py +++ b/meta/lib/oeqa/selftest/cases/devtool.py @@ -575,7 +575,7 @@ class DevtoolAddTests(DevtoolBase): checkvars['S'] = '${WORKDIR}/MarkupSafe-%s' % testver checkvars['SRC_URI'] = url self._test_recipe_contents(recipefile, checkvars, []) - + def test_devtool_add_fetch_git(self): tempdir = tempfile.mkdtemp(prefix='devtoolqa') self.track_for_cleanup(tempdir) -- 2.42.0 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#189690): https://lists.openembedded.org/g/openembedded-core/message/189690 Mute This Topic: https://lists.openembedded.org/mt/102181567/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [RESEND PATCH 2/2] oeqa/selftest/devtool: remove spaces on empty line
Hello Julien, On Tue, 24 Oct 2023 16:17:54 +0200 "Julien Stephan" wrote: > Signed-off-by: Julien Stephan > --- > meta/lib/oeqa/selftest/cases/devtool.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/lib/oeqa/selftest/cases/devtool.py > b/meta/lib/oeqa/selftest/cases/devtool.py > index c36b1efa78b..b5c488be8e8 100644 > --- a/meta/lib/oeqa/selftest/cases/devtool.py > +++ b/meta/lib/oeqa/selftest/cases/devtool.py > @@ -575,7 +575,7 @@ class DevtoolAddTests(DevtoolBase): > checkvars['S'] = '${WORKDIR}/MarkupSafe-%s' % testver > checkvars['SRC_URI'] = url > self._test_recipe_contents(recipefile, checkvars, []) > - > + This patch does not apply due to the '-' line above having no spaces after '-'. Perhaps your mailer mangled the content removing training whitespace (which, ironically, is what the patch itself aims at doing!). Using 'git send-email' is usually the best way to send patches without this sort of issues. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#189681): https://lists.openembedded.org/g/openembedded-core/message/189681 Mute This Topic: https://lists.openembedded.org/mt/102158568/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [RESEND PATCH 2/2] oeqa/selftest/devtool: remove spaces on empty line
Signed-off-by: Julien Stephan --- meta/lib/oeqa/selftest/cases/devtool.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/lib/oeqa/selftest/cases/devtool.py b/meta/lib/oeqa/selftest/cases/devtool.py index c36b1efa78b..b5c488be8e8 100644 --- a/meta/lib/oeqa/selftest/cases/devtool.py +++ b/meta/lib/oeqa/selftest/cases/devtool.py @@ -575,7 +575,7 @@ class DevtoolAddTests(DevtoolBase): checkvars['S'] = '${WORKDIR}/MarkupSafe-%s' % testver checkvars['SRC_URI'] = url self._test_recipe_contents(recipefile, checkvars, []) - + def test_devtool_add_fetch_git(self): tempdir = tempfile.mkdtemp(prefix='devtoolqa') self.track_for_cleanup(tempdir) -- 2.41.0 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#189647): https://lists.openembedded.org/g/openembedded-core/message/189647 Mute This Topic: https://lists.openembedded.org/mt/102158568/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-