Re: [OE-core] Patchtest results for [PATCH v2 7/9] oeqa/selftest/recipetool: Move create_go test to a proper class
On 2024-01-16 05:05, Vyacheslav Yurkov wrote: I also have the same opinion. What else am I supposed to write in the body if it were merely a refactoring (function moved, renamed, etc), and it's already described in the hearer? It shouldn't be considered a strict requirement, as it's going to be difficult for Patchtest to correctly identify which pages do and don't need more explanation. If you want to completely avoid that feedback, then the solution for now is to re-state the shortlog as a one-line commit description. Slava On 16.01.2024 10:32, Alexander Kanavin wrote: Because making it strict would only result in useless noise in the commit logs. It's entirely valid to have changes that can fully be described with a commit header. I see it as a notice to consider if the commit message should be added, at the discretion of both submitter and committer. Alex On Tue, 16 Jan 2024 at 10:28, Alexandre Belloni wrote: On 16/01/2024 10:08:50+0100, Alexander Kanavin wrote: No. Why not? -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#193870): https://lists.openembedded.org/g/openembedded-core/message/193870 Mute This Topic: https://lists.openembedded.org/mt/103758512/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] Patchtest results for [PATCH v2 7/9] oeqa/selftest/recipetool: Move create_go test to a proper class
I also have the same opinion. What else am I supposed to write in the body if it were merely a refactoring (function moved, renamed, etc), and it's already described in the hearer? Slava On 16.01.2024 10:32, Alexander Kanavin wrote: Because making it strict would only result in useless noise in the commit logs. It's entirely valid to have changes that can fully be described with a commit header. I see it as a notice to consider if the commit message should be added, at the discretion of both submitter and committer. Alex On Tue, 16 Jan 2024 at 10:28, Alexandre Belloni wrote: On 16/01/2024 10:08:50+0100, Alexander Kanavin wrote: No. Why not? -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#193848): https://lists.openembedded.org/g/openembedded-core/message/193848 Mute This Topic: https://lists.openembedded.org/mt/103758512/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] Patchtest results for [PATCH v2 7/9] oeqa/selftest/recipetool: Move create_go test to a proper class
Because making it strict would only result in useless noise in the commit logs. It's entirely valid to have changes that can fully be described with a commit header. I see it as a notice to consider if the commit message should be added, at the discretion of both submitter and committer. Alex On Tue, 16 Jan 2024 at 10:28, Alexandre Belloni wrote: > > On 16/01/2024 10:08:50+0100, Alexander Kanavin wrote: > > No. > > Why not? > > > > > Alex > > > > On Tue, 16 Jan 2024 at 09:53, Vyacheslav Yurkov wrote: > > > > > > Is that a strict requirement now even for trivial patches? > > > > > > Slava > > > > > > On 16.01.2024 09:45, patcht...@automation.yoctoproject.org wrote: > > > > Thank you for your submission. Patchtest identified one > > > > or more issues with the patch. Please see the log below for > > > > more information: > > > > > > > > --- > > > > Testing patch > > > > /home/patchtest/share/mboxes/v2-7-9-oeqa-selftest-recipetool-Move-create_go-test-to-a-proper-class.patch > > > > > > > > FAIL: test commit message presence: Please include a commit message on > > > > your patch explaining the change > > > > (test_mbox.TestMbox.test_commit_message_presence) > > > > > > > > PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint) > > > > PASS: test Signed-off-by presence > > > > (test_mbox.TestMbox.test_signed_off_by_presence) > > > > PASS: test author valid (test_mbox.TestMbox.test_author_valid) > > > > PASS: test max line length > > > > (test_metadata.TestMetadata.test_max_line_length) > > > > PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) > > > > PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) > > > > PASS: test pylint (test_python_pylint.PyLint.test_pylint) > > > > PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format) > > > > PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length) > > > > > > > > SKIP: pretest src uri left files: No modified recipes, skipping pretest > > > > (test_metadata.TestMetadata.pretest_src_uri_left_files) > > > > SKIP: test CVE check ignore: No modified recipes, skipping test > > > > (test_metadata.TestMetadata.test_cve_check_ignore) > > > > SKIP: test CVE tag format: No new CVE patches introduced > > > > (test_patch.TestPatch.test_cve_tag_format) > > > > SKIP: test Signed-off-by presence: No new CVE patches introduced > > > > (test_patch.TestPatch.test_signed_off_by_presence) > > > > SKIP: test Upstream-Status presence: No new CVE patches introduced > > > > (test_patch.TestPatch.test_upstream_status_presence_format) > > > > SKIP: test bugzilla entry format: No bug ID found > > > > (test_mbox.TestMbox.test_bugzilla_entry_format) > > > > SKIP: test lic files chksum modified not mentioned: No modified > > > > recipes, skipping test > > > > (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned) > > > > SKIP: test lic files chksum presence: No added recipes, skipping test > > > > (test_metadata.TestMetadata.test_lic_files_chksum_presence) > > > > SKIP: test license presence: No added recipes, skipping test > > > > (test_metadata.TestMetadata.test_license_presence) > > > > SKIP: test series merge on head: Merge test is disabled for now > > > > (test_mbox.TestMbox.test_series_merge_on_head) > > > > SKIP: test src uri left files: No modified recipes, skipping pretest > > > > (test_metadata.TestMetadata.test_src_uri_left_files) > > > > SKIP: test summary presence: No added recipes, skipping test > > > > (test_metadata.TestMetadata.test_summary_presence) > > > > SKIP: test target mailing list: Series merged, no reason to check other > > > > mailing lists (test_mbox.TestMbox.test_target_mailing_list) > > > > > > > > --- > > > > > > > > Please address the issues identified and > > > > submit a new revision of the patch, or alternatively, reply to this > > > > email with an explanation of why the patch should be accepted. If you > > > > believe these results are due to an error in patchtest, please submit a > > > > bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category > > > > under 'Yocto Project Subprojects'). For more information on specific > > > > failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank > > > > you! > > > > > > > > > > > > > > > > > > > > > > > > > -- > Alexandre Belloni, co-owner and COO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#193847): https://lists.openembedded.org/g/openembedded-core/message/193847 Mute This Topic: https://lists.openembedded.org/mt/103758512/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] Patchtest results for [PATCH v2 7/9] oeqa/selftest/recipetool: Move create_go test to a proper class
On 16/01/2024 10:08:50+0100, Alexander Kanavin wrote: > No. Why not? > > Alex > > On Tue, 16 Jan 2024 at 09:53, Vyacheslav Yurkov wrote: > > > > Is that a strict requirement now even for trivial patches? > > > > Slava > > > > On 16.01.2024 09:45, patcht...@automation.yoctoproject.org wrote: > > > Thank you for your submission. Patchtest identified one > > > or more issues with the patch. Please see the log below for > > > more information: > > > > > > --- > > > Testing patch > > > /home/patchtest/share/mboxes/v2-7-9-oeqa-selftest-recipetool-Move-create_go-test-to-a-proper-class.patch > > > > > > FAIL: test commit message presence: Please include a commit message on > > > your patch explaining the change > > > (test_mbox.TestMbox.test_commit_message_presence) > > > > > > PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint) > > > PASS: test Signed-off-by presence > > > (test_mbox.TestMbox.test_signed_off_by_presence) > > > PASS: test author valid (test_mbox.TestMbox.test_author_valid) > > > PASS: test max line length > > > (test_metadata.TestMetadata.test_max_line_length) > > > PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) > > > PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) > > > PASS: test pylint (test_python_pylint.PyLint.test_pylint) > > > PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format) > > > PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length) > > > > > > SKIP: pretest src uri left files: No modified recipes, skipping pretest > > > (test_metadata.TestMetadata.pretest_src_uri_left_files) > > > SKIP: test CVE check ignore: No modified recipes, skipping test > > > (test_metadata.TestMetadata.test_cve_check_ignore) > > > SKIP: test CVE tag format: No new CVE patches introduced > > > (test_patch.TestPatch.test_cve_tag_format) > > > SKIP: test Signed-off-by presence: No new CVE patches introduced > > > (test_patch.TestPatch.test_signed_off_by_presence) > > > SKIP: test Upstream-Status presence: No new CVE patches introduced > > > (test_patch.TestPatch.test_upstream_status_presence_format) > > > SKIP: test bugzilla entry format: No bug ID found > > > (test_mbox.TestMbox.test_bugzilla_entry_format) > > > SKIP: test lic files chksum modified not mentioned: No modified recipes, > > > skipping test > > > (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned) > > > SKIP: test lic files chksum presence: No added recipes, skipping test > > > (test_metadata.TestMetadata.test_lic_files_chksum_presence) > > > SKIP: test license presence: No added recipes, skipping test > > > (test_metadata.TestMetadata.test_license_presence) > > > SKIP: test series merge on head: Merge test is disabled for now > > > (test_mbox.TestMbox.test_series_merge_on_head) > > > SKIP: test src uri left files: No modified recipes, skipping pretest > > > (test_metadata.TestMetadata.test_src_uri_left_files) > > > SKIP: test summary presence: No added recipes, skipping test > > > (test_metadata.TestMetadata.test_summary_presence) > > > SKIP: test target mailing list: Series merged, no reason to check other > > > mailing lists (test_mbox.TestMbox.test_target_mailing_list) > > > > > > --- > > > > > > Please address the issues identified and > > > submit a new revision of the patch, or alternatively, reply to this > > > email with an explanation of why the patch should be accepted. If you > > > believe these results are due to an error in patchtest, please submit a > > > bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category > > > under 'Yocto Project Subprojects'). For more information on specific > > > failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank > > > you! > > > > > > > > > > > > > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#193846): https://lists.openembedded.org/g/openembedded-core/message/193846 Mute This Topic: https://lists.openembedded.org/mt/103758512/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] Patchtest results for [PATCH v2 7/9] oeqa/selftest/recipetool: Move create_go test to a proper class
No. Alex On Tue, 16 Jan 2024 at 09:53, Vyacheslav Yurkov wrote: > > Is that a strict requirement now even for trivial patches? > > Slava > > On 16.01.2024 09:45, patcht...@automation.yoctoproject.org wrote: > > Thank you for your submission. Patchtest identified one > > or more issues with the patch. Please see the log below for > > more information: > > > > --- > > Testing patch > > /home/patchtest/share/mboxes/v2-7-9-oeqa-selftest-recipetool-Move-create_go-test-to-a-proper-class.patch > > > > FAIL: test commit message presence: Please include a commit message on your > > patch explaining the change > > (test_mbox.TestMbox.test_commit_message_presence) > > > > PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint) > > PASS: test Signed-off-by presence > > (test_mbox.TestMbox.test_signed_off_by_presence) > > PASS: test author valid (test_mbox.TestMbox.test_author_valid) > > PASS: test max line length (test_metadata.TestMetadata.test_max_line_length) > > PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) > > PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) > > PASS: test pylint (test_python_pylint.PyLint.test_pylint) > > PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format) > > PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length) > > > > SKIP: pretest src uri left files: No modified recipes, skipping pretest > > (test_metadata.TestMetadata.pretest_src_uri_left_files) > > SKIP: test CVE check ignore: No modified recipes, skipping test > > (test_metadata.TestMetadata.test_cve_check_ignore) > > SKIP: test CVE tag format: No new CVE patches introduced > > (test_patch.TestPatch.test_cve_tag_format) > > SKIP: test Signed-off-by presence: No new CVE patches introduced > > (test_patch.TestPatch.test_signed_off_by_presence) > > SKIP: test Upstream-Status presence: No new CVE patches introduced > > (test_patch.TestPatch.test_upstream_status_presence_format) > > SKIP: test bugzilla entry format: No bug ID found > > (test_mbox.TestMbox.test_bugzilla_entry_format) > > SKIP: test lic files chksum modified not mentioned: No modified recipes, > > skipping test > > (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned) > > SKIP: test lic files chksum presence: No added recipes, skipping test > > (test_metadata.TestMetadata.test_lic_files_chksum_presence) > > SKIP: test license presence: No added recipes, skipping test > > (test_metadata.TestMetadata.test_license_presence) > > SKIP: test series merge on head: Merge test is disabled for now > > (test_mbox.TestMbox.test_series_merge_on_head) > > SKIP: test src uri left files: No modified recipes, skipping pretest > > (test_metadata.TestMetadata.test_src_uri_left_files) > > SKIP: test summary presence: No added recipes, skipping test > > (test_metadata.TestMetadata.test_summary_presence) > > SKIP: test target mailing list: Series merged, no reason to check other > > mailing lists (test_mbox.TestMbox.test_target_mailing_list) > > > > --- > > > > Please address the issues identified and > > submit a new revision of the patch, or alternatively, reply to this > > email with an explanation of why the patch should be accepted. If you > > believe these results are due to an error in patchtest, please submit a > > bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category > > under 'Yocto Project Subprojects'). For more information on specific > > failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank > > you! > > > > > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#193845): https://lists.openembedded.org/g/openembedded-core/message/193845 Mute This Topic: https://lists.openembedded.org/mt/103758512/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] Patchtest results for [PATCH v2 7/9] oeqa/selftest/recipetool: Move create_go test to a proper class
Is that a strict requirement now even for trivial patches? Slava On 16.01.2024 09:45, patcht...@automation.yoctoproject.org wrote: Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/v2-7-9-oeqa-selftest-recipetool-Move-create_go-test-to-a-proper-class.patch FAIL: test commit message presence: Please include a commit message on your patch explaining the change (test_mbox.TestMbox.test_commit_message_presence) PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint) PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence) PASS: test author valid (test_mbox.TestMbox.test_author_valid) PASS: test max line length (test_metadata.TestMetadata.test_max_line_length) PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) PASS: test pylint (test_python_pylint.PyLint.test_pylint) PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format) PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length) SKIP: pretest src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_src_uri_left_files) SKIP: test CVE check ignore: No modified recipes, skipping test (test_metadata.TestMetadata.test_cve_check_ignore) SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format) SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence) SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format) SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format) SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned) SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence) SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence) SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head) SKIP: test src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.test_src_uri_left_files) SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence) SKIP: test target mailing list: Series merged, no reason to check other mailing lists (test_mbox.TestMbox.test_target_mailing_list) --- Please address the issues identified and submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you! -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#193841): https://lists.openembedded.org/g/openembedded-core/message/193841 Mute This Topic: https://lists.openembedded.org/mt/103758512/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] Patchtest results for [PATCH v2 7/9] oeqa/selftest/recipetool: Move create_go test to a proper class
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/v2-7-9-oeqa-selftest-recipetool-Move-create_go-test-to-a-proper-class.patch FAIL: test commit message presence: Please include a commit message on your patch explaining the change (test_mbox.TestMbox.test_commit_message_presence) PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint) PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence) PASS: test author valid (test_mbox.TestMbox.test_author_valid) PASS: test max line length (test_metadata.TestMetadata.test_max_line_length) PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) PASS: test pylint (test_python_pylint.PyLint.test_pylint) PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format) PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length) SKIP: pretest src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_src_uri_left_files) SKIP: test CVE check ignore: No modified recipes, skipping test (test_metadata.TestMetadata.test_cve_check_ignore) SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format) SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence) SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format) SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format) SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned) SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence) SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence) SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head) SKIP: test src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.test_src_uri_left_files) SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence) SKIP: test target mailing list: Series merged, no reason to check other mailing lists (test_mbox.TestMbox.test_target_mailing_list) --- Please address the issues identified and submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you! -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#193837): https://lists.openembedded.org/g/openembedded-core/message/193837 Mute This Topic: https://lists.openembedded.org/mt/103758512/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
