Re: [OE-core] Recent xserver-kdrive failure and util-macros update
On 2012年01月04日 15:28, Saul Wold wrote: We seem to have a relatively new failure in xserver-kdrive, which appeared in the last set of change. I tried to run though a bisect but was not able to find the problem. The problem seems to be related to configure.ac setting of XSERVER_CFLAGS='$(CWARNFLAGS)' and then using -Werror=address, which is what causes the failure. This seems to be related to the util-macros update to 1.16, which adds more warnings to errors. Since we are still using the older xserver-kdrive, there are warnings that are now errors with the update. We could patch the current xserver-kdrive, revert the 1.16 update to util-macros or update xserver-kdrive (which is in the works, but I think had some issues). This also seems to affect the libxp package on x86-64. Thoughts, I know we don't like to revert, but we may have to in this case as we don't have the kdrive update yet and would need to further investigate the libxp failure. Hi Saul, Do you have any suggestion my previous patches to update xserver-kdrive ? http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=xiaofeng/update ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] Recent xserver-kdrive failure and util-macros update
Xiaofeng Yan wrote on 2012-01-04: On 2012年01月04日 15:28, Saul Wold wrote: We seem to have a relatively new failure in xserver-kdrive, which appeared in the last set of change. I tried to run though a bisect but was not able to find the problem. The problem seems to be related to configure.ac setting of XSERVER_CFLAGS='$(CWARNFLAGS)' and then using -Werror=address, which is what causes the failure. Hi Saul, Can we patch this to make it not fail? I'll try to look into this... This seems to be related to the util-macros update to 1.16, which adds more warnings to errors. Since we are still using the older xserver-kdrive, there are warnings that are now errors with the update. We could patch the current xserver-kdrive, revert the 1.16 update to util-macros or update xserver-kdrive (which is in the works, but I think had some issues). This also seems to affect the libxp package on x86-64. I don't see any libxp failure(I build libxp with MACHINE=qemux86 on an X86-64 host). By saying on x86-64, did you mean qemux86-64? Thoughts, I know we don't like to revert, but we may have to in this case as we don't have the kdrive update yet and would need to further investigate the libxp failure. Hi Saul, Do you have any suggestion my previous patches to update xserver-kdrive ? http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=xiaofeng/update I can build Xiaofeng's xserver-kdrive 1.11.2 fine with util-macro_1.16. Can we use the new xserver-kdriver and remove the old one? Thanks, -- Dexuan ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] Recent xserver-kdrive failure and util-macros update
On (03/01/12 23:28), Saul Wold wrote: We seem to have a relatively new failure in xserver-kdrive, which appeared in the last set of change. I tried to run though a bisect but was not able to find the problem. The problem seems to be related to configure.ac setting of XSERVER_CFLAGS='$(CWARNFLAGS)' and then using -Werror=address, which is what causes the failure. This seems to be related to the util-macros update to 1.16, which adds more warnings to errors. Since we are still using the older xserver-kdrive, there are warnings that are now errors with the update. Fix xserver-kdrive ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] Recent xserver-kdrive failure and util-macros update
On 2012-01-04 10:39, Khem Raj wrote:
On (03/01/12 23:28), Saul Wold wrote:
We seem to have a relatively new failure in xserver-kdrive, which
appeared in the last set of change. I tried to run though a bisect
but was not able to find the problem.
The problem seems to be related to configure.ac setting of
XSERVER_CFLAGS='$(CWARNFLAGS)' and then using -Werror=address, which
is what causes the failure.
This seems to be related to the util-macros update to 1.16, which
adds more warnings to errors. Since we are still using the older
xserver-kdrive, there are warnings that are now errors with the
update.
Fix xserver-kdrive
In this case, I don't see why this is an error. All of the errors
(that I've found so far) stem from lines like this:
REGION_INIT(pGC-pScreen, rgnDst, box, 1);
where the macro REGION_INIT is defined as:
#define REGION_INIT(_pScreen, _pReg, _rect, _size) \
{ \
if ((_rect) != NULL)\
{ \
(_pReg)-extents = *(_rect); \
(_pReg)-data = (RegDataPtr)NULL; \
} \
else \
{ \
(_pReg)-extents = miEmptyBox; \
if (((_size) 1) ((_pReg)-data = \
(RegDataPtr)xalloc(REGION_SZOF(_size \
{ \
(_pReg)-data-size = (_size); \
(_pReg)-data-numRects = 0; \
} \
else \
(_pReg)-data = miEmptyData; \
} \
}
This doesn't look like an error to me, but rather an opportunity
(to remove never used code).
--
Gary Thomas | Consulting for the
MLB Associates |Embedded world
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] Recent xserver-kdrive failure and util-macros update
On 01/04/2012 11:45 AM, Gary Thomas wrote:
On 2012-01-04 10:39, Khem Raj wrote:
On (03/01/12 23:28), Saul Wold wrote:
We seem to have a relatively new failure in xserver-kdrive, which
appeared in the last set of change. I tried to run though a bisect
but was not able to find the problem.
The problem seems to be related to configure.ac setting of
XSERVER_CFLAGS='$(CWARNFLAGS)' and then using -Werror=address, which
is what causes the failure.
This seems to be related to the util-macros update to 1.16, which
adds more warnings to errors. Since we are still using the older
xserver-kdrive, there are warnings that are now errors with the
update.
Fix xserver-kdrive
In this case, I don't see why this is an error. All of the errors
(that I've found so far) stem from lines like this:
REGION_INIT(pGC-pScreen, rgnDst, box, 1);
Not all, the newer code has this snippet as a static inline and does not
have the failure because it a function.
There's at least one place that it's called with a real pointer in a
function.
Sau!
where the macro REGION_INIT is defined as:
#define REGION_INIT(_pScreen, _pReg, _rect, _size) \
{ \
if ((_rect) != NULL) \
{ \
(_pReg)-extents = *(_rect); \
(_pReg)-data = (RegDataPtr)NULL; \
} \
else \
{ \
(_pReg)-extents = miEmptyBox; \
if (((_size) 1) ((_pReg)-data = \
(RegDataPtr)xalloc(REGION_SZOF(_size \
{ \
(_pReg)-data-size = (_size); \
(_pReg)-data-numRects = 0; \
} \
else \
(_pReg)-data = miEmptyData; \
} \
}
This doesn't look like an error to me, but rather an opportunity
(to remove never used code).
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] Recent xserver-kdrive failure and util-macros update
On 2012-01-04 13:08, Saul Wold wrote:
On 01/04/2012 11:45 AM, Gary Thomas wrote:
On 2012-01-04 10:39, Khem Raj wrote:
On (03/01/12 23:28), Saul Wold wrote:
We seem to have a relatively new failure in xserver-kdrive, which
appeared in the last set of change. I tried to run though a bisect
but was not able to find the problem.
The problem seems to be related to configure.ac setting of
XSERVER_CFLAGS='$(CWARNFLAGS)' and then using -Werror=address, which
is what causes the failure.
This seems to be related to the util-macros update to 1.16, which
adds more warnings to errors. Since we are still using the older
xserver-kdrive, there are warnings that are now errors with the
update.
Fix xserver-kdrive
In this case, I don't see why this is an error. All of the errors
(that I've found so far) stem from lines like this:
REGION_INIT(pGC-pScreen, rgnDst, box, 1);
Not all, the newer code has this snippet as a static inline and does not have
the failure because it a function.
There's at least one place that it's called with a real pointer in a function.
True, not all of the calls to REGION_INIT are problematic, but all of the errors
are uses of that macro with static pointers. The attached patch fixes these
errors.
where the macro REGION_INIT is defined as:
#define REGION_INIT(_pScreen, _pReg, _rect, _size) \
{ \
if ((_rect) != NULL) \
{ \
(_pReg)-extents = *(_rect); \
(_pReg)-data = (RegDataPtr)NULL; \
} \
else \
{ \
(_pReg)-extents = miEmptyBox; \
if (((_size) 1) ((_pReg)-data = \
(RegDataPtr)xalloc(REGION_SZOF(_size \
{ \
(_pReg)-data-size = (_size); \
(_pReg)-data-numRects = 0; \
} \
else \
(_pReg)-data = miEmptyData; \
} \
}
This doesn't look like an error to me, but rather an opportunity
(to remove never used code).
--
Gary Thomas | Consulting for the
MLB Associates |Embedded world
From 8cd004c7bdce0a843fc98a0c9431ee18e391c9b1 Mon Sep 17 00:00:00 2001
From: Gary Thomas g...@mlbassoc.com
Date: Wed, 4 Jan 2012 13:35:26 -0700
Subject: [PATCH] xserver-kdrive: work around issues with -Werror=address
Signed-off-by: Gary Thomas g...@mlbassoc.com
---
.../error-address-work-around.patch| 362
.../xorg-xserver/xserver-kdrive_1.7.99.2.bb|3 +-
2 files changed, 364 insertions(+), 1 deletions(-)
create mode 100644 meta/recipes-graphics/xorg-xserver/xserver-kdrive-1.7.99.2/error-address-work-around.patch
diff --git a/meta/recipes-graphics/xorg-xserver/xserver-kdrive-1.7.99.2/error-address-work-around.patch b/meta/recipes-graphics/xorg-xserver/xserver-kdrive-1.7.99.2/error-address-work-around.patch
new file mode 100644
index 000..3052372
--- /dev/null
+++ b/meta/recipes-graphics/xorg-xserver/xserver-kdrive-1.7.99.2/error-address-work-around.patch
@@ -0,0 +1,362 @@
+diff -ur --exclude='*.lo' --exclude='config*' --exclude='Make*' --exclude='ac*' xorg-server-1.7.99.2.ORIG/dix/window.c xorg-server-1.7.99.2/dix/window.c
+--- xorg-server-1.7.99.2.ORIG/dix/window.c 2012-01-04 13:12:40.417640130 -0700
xorg-server-1.7.99.2/dix/window.c 2012-01-04 12:13:20.678605493 -0700
+@@ -559,10 +559,10 @@
+ box.y1 = 0;
+ box.x2 = pScreen-width;
+ box.y2 = pScreen-height;
+-REGION_INIT(pScreen, pWin-clipList, box, 1);
+-REGION_INIT(pScreen, pWin-winSize, box, 1);
+-REGION_INIT(pScreen, pWin-borderSize, box, 1);
+-REGION_INIT(pScreen, pWin-borderClip, box, 1);
++REGION_INIT2(pScreen, pWin-clipList, box, 1);
++REGION_INIT2(pScreen, pWin-winSize, box, 1);
++REGION_INIT2(pScreen, pWin-borderSize, box, 1);
++REGION_INIT2(pScreen, pWin-borderClip, box, 1);
+
+ pWin-drawable.class = InputOutput;
+ pWin-optional-visual = pScreen-rootVisual;
+diff -ur --exclude='*.lo' --exclude='config*' --exclude='Make*' --exclude='ac*' xorg-server-1.7.99.2.ORIG/exa/exa_accel.c xorg-server-1.7.99.2/exa/exa_accel.c
+--- xorg-server-1.7.99.2.ORIG/exa/exa_accel.c 2009-12-11 11:20:48.0 -0700
xorg-server-1.7.99.2/exa/exa_accel.c 2012-01-04 12:58:11.218616328 -0700
+@@ -1275,7 +1275,7 @@
+ Box.x2 = Box.x1 + w;
+ Box.y2 = Box.y1 + h;
+
+- REGION_INIT(pScreen, Reg, Box, 1);
++ REGION_INIT2(pScreen, Reg, Box, 1);
+
+ pixmaps[0].as_dst = FALSE;
+ pixmaps[0].as_src = TRUE;
+diff -ur --exclude='*.lo' --exclude='config*' --exclude='Make*' --exclude='ac*' xorg-server-1.7.99.2.ORIG/exa/exa.c xorg-server-1.7.99.2/exa/exa.c
+--- xorg-server-1.7.99.2.ORIG/exa/exa.c 2009-12-11 11:20:48.0 -0700
xorg-server-1.7.99.2/exa/exa.c 2012-01-04 12:56:30.592593427 -0700
+@@ -161,7 +161,7 @@
+ if (box.x1 = box.x2 || box.y1 = box.y2)
+ return;
+
+-REGION_INIT(pScreen, region, box, 1);
++REGION_INIT2(pScreen, region, box, 1);
+ DamageRegionAppend(pPix-drawable, region);
+ DamageRegionProcessPending(pPix-drawable);
+ REGION_UNINIT(pScreen, region);
[OE-core] Recent xserver-kdrive failure and util-macros update
We seem to have a relatively new failure in xserver-kdrive, which appeared in the last set of change. I tried to run though a bisect but was not able to find the problem. The problem seems to be related to configure.ac setting of XSERVER_CFLAGS='$(CWARNFLAGS)' and then using -Werror=address, which is what causes the failure. This seems to be related to the util-macros update to 1.16, which adds more warnings to errors. Since we are still using the older xserver-kdrive, there are warnings that are now errors with the update. We could patch the current xserver-kdrive, revert the 1.16 update to util-macros or update xserver-kdrive (which is in the works, but I think had some issues). This also seems to affect the libxp package on x86-64. Thoughts, I know we don't like to revert, but we may have to in this case as we don't have the kdrive update yet and would need to further investigate the libxp failure. -- Sau! Saul Wold Yocto Component Wrangler @ Intel Yocto Project / Poky Build System ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
