Re: [OE-core] [Openembedded-architecture] Cached size of off_t

[Martin Jansa]

On Tue, Jan 12, 2016 at 03:23:33PM -0800, Khem Raj wrote:
> Hi
> 
> We cache size of off_t in site files and the value is 4 in most cases
> 
> 
> meta/site/arm-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=4}
> meta/site/ix86-common:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=4}
> meta/site/nios2-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=4}
> meta/site/powerpc32-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=4}
> meta/site/x32-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=8}
> meta/site/x86_64-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=8}
> 
> 
> However this value is wrong when largefile support is enabled (which is 
> default) on
> most OE based distros. It also lands us in nasty bugs which are complicated 
> to uncover
> eg. the curl issue
> 
> http://git.openembedded.org/openembedded-core/commit/?id=3c58712465494e441c4036a7cf21d2e6d343efab
> 
> and just in OE-Core more e.g. grub2,libsndfile1,pax are showing same symptoms.

It's even more complicated in curl case, which bumps SONAME version when
off_t is changed.

So with dizzy we had libcurl5, but after the commit above we get
libcurl4 which looks strange considering the curl version in oe-core is newer 
now.

You can force the bump with --enable-soname-bump, but that doesn't make
it ABI compatible, because SIZEOF_OFF_T was really changed inside curl
build.

Regards,

> I think this value should be left for configure to compute and
> autotools.bbclass should pass --{enable|disable}-largefile based upon
> DISTRO_FEATURES enabling largefile support
> 
> Do we see any downsides or point I might have missed
> 
> Thank you
> -Khem
> 



> ___
> Openembedded-architecture mailing list
> openembedded-architect...@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-architecture


-- 
Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com


signature.asc
Description: Digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [Openembedded-architecture] Cached size of off_t

[Burton, Ross]

On 13 January 2016 at 00:09, Paul Eggleton 
wrote:

> > I think this value should be left for configure to compute and
> > autotools.bbclass should pass --{enable|disable}-largefile based upon
> > DISTRO_FEATURES enabling largefile support
> >
> > Do we see any downsides or point I might have missed
>
> IIRC I think the issue was older configure scripts without the capability
> to
> compute this properly (where we're not auto-reconf'ing them).
>

The fact that it changes based on configure options says that it really
shouldn't be a cached value.

It's very unlikely that there's configure scripts out there still that
don't use the "modern" autoconf type size detection and if there are
they're trivially patched to use the new macros.

Remove it, as this is going to cause very strange problems as large files
get enabled more globally.  In particular I'm now worrying about DBus which
just recently got a patch to enable large file support.

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [Openembedded-architecture] Cached size of off_t

[Khem Raj]

On Tue, Jan 12, 2016 at 4:09 PM, Paul Eggleton
 wrote:
> On Tue, 12 Jan 2016 15:23:33 Khem Raj wrote:
>> Hi
>>
>> We cache size of off_t in site files and the value is 4 in most cases
>>
>>
>> meta/site/arm-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=4}
>> meta/site/ix86-common:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=4}
>> meta/site/nios2-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=4}
>> meta/site/powerpc32-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=4}
>> meta/site/x32-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=8}
>> meta/site/x86_64-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=8}
>>
>>
>> However this value is wrong when largefile support is enabled (which is
>> default) on most OE based distros. It also lands us in nasty bugs which are
>> complicated to uncover eg. the curl issue
>>
>> http://git.openembedded.org/openembedded-core/commit/?id=3c58712465494e441c4
>> 036a7cf21d2e6d343efab
>>
>> and just in OE-Core more e.g. grub2,libsndfile1,pax are showing same
>> symptoms.
>>
>> I think this value should be left for configure to compute and
>> autotools.bbclass should pass --{enable|disable}-largefile based upon
>> DISTRO_FEATURES enabling largefile support
>>
>> Do we see any downsides or point I might have missed
>
> IIRC I think the issue was older configure scripts without the capability to
> compute this properly (where we're not auto-reconf'ing them).

Thanks Paul.
I think in that case it is better to move that into the concerned
recipe and let defaults be reversed


>
> Ross, any thoughts?
>
> Cheers,
> Paul
>
> --
>
> Paul Eggleton
> Intel Open Source Technology Centre
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [Openembedded-architecture] Cached size of off_t

[Paul Eggleton]

On Tue, 12 Jan 2016 15:23:33 Khem Raj wrote:
> Hi
> 
> We cache size of off_t in site files and the value is 4 in most cases
> 
> 
> meta/site/arm-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=4}
> meta/site/ix86-common:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=4}
> meta/site/nios2-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=4}
> meta/site/powerpc32-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=4}
> meta/site/x32-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=8}
> meta/site/x86_64-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=8}
> 
> 
> However this value is wrong when largefile support is enabled (which is
> default) on most OE based distros. It also lands us in nasty bugs which are
> complicated to uncover eg. the curl issue
> 
> http://git.openembedded.org/openembedded-core/commit/?id=3c58712465494e441c4
> 036a7cf21d2e6d343efab
> 
> and just in OE-Core more e.g. grub2,libsndfile1,pax are showing same
> symptoms.
> 
> I think this value should be left for configure to compute and
> autotools.bbclass should pass --{enable|disable}-largefile based upon
> DISTRO_FEATURES enabling largefile support
> 
> Do we see any downsides or point I might have missed

IIRC I think the issue was older configure scripts without the capability to 
compute this properly (where we're not auto-reconf'ing them).

Ross, any thoughts?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [Openembedded-architecture] Cached size of off_t

[Andre McCurdy]

On Tue, Jan 12, 2016 at 4:19 PM, Khem Raj  wrote:
> On Tue, Jan 12, 2016 at 4:09 PM, Paul Eggleton
>  wrote:
>> On Tue, 12 Jan 2016 15:23:33 Khem Raj wrote:
>>> Hi
>>>
>>> We cache size of off_t in site files and the value is 4 in most cases
>>>
>>>
>>> meta/site/arm-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=4}
>>> meta/site/ix86-common:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=4}
>>> meta/site/nios2-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=4}
>>> meta/site/powerpc32-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=4}
>>> meta/site/x32-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=8}
>>> meta/site/x86_64-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=8}
>>>
>>>
>>> However this value is wrong when largefile support is enabled (which is
>>> default) on most OE based distros. It also lands us in nasty bugs which are
>>> complicated to uncover eg. the curl issue
>>>
>>> http://git.openembedded.org/openembedded-core/commit/?id=3c58712465494e441c4
>>> 036a7cf21d2e6d343efab
>>>
>>> and just in OE-Core more e.g. grub2,libsndfile1,pax are showing same
>>> symptoms.
>>>
>>> I think this value should be left for configure to compute and
>>> autotools.bbclass should pass --{enable|disable}-largefile based upon
>>> DISTRO_FEATURES enabling largefile support
>>>
>>> Do we see any downsides or point I might have missed
>>
>> IIRC I think the issue was older configure scripts without the capability to
>> compute this properly (where we're not auto-reconf'ing them).
>
> Thanks Paul.
> I think in that case it is better to move that into the concerned
> recipe and let defaults be reversed

How do these older configure scripts work today for MIPS and SH4 which
don't seem to define ac_cv_sizeof_off_t in their site files?

>>
>> Ross, any thoughts?
>>
>> Cheers,
>> Paul
>>
>> --
>>
>> Paul Eggleton
>> Intel Open Source Technology Centre
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core