Re: [OE-core] [PATCH] libnotify: Make gtk+3 dependency optional

2021-05-13 Thread Mike Crowe via lists.openembedded.org 
On Thursday 13 May 2021 at 17:06:23 +0100, Richard Purdie wrote:
> On Thu, 2021-05-13 at 16:43 +0200, Alexander Kanavin wrote:
> > On Thu, 13 May 2021 at 16:36, Mike Crowe via lists.openembedded.org <
> > yocto=mac.mcrowe@lists.openembedded.org> wrote:
> > > +PACKAGECONFIG[gtk+] = "--enable-tests,--disable-tests,,gtk+3"
> > > 
> > 
> > 
> > Was the --enable-tests scenario tested? Specifying gtk+3 after two ,,s 
> > seems weird.
> 
> It means to add a runtime (RDEPENDS) rather than DEPENDS. There are 
> options for positions 5 and 6 too if I remember rightly.

Yes, but it should have been a build dependency. :( Alexander was correct
to draw attention to it. It turns out that the whole line is wrong because
I failed to spot that master is now using Meson too. :(

A better patch will be arriving shortly.

Thanks.

Mike.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#151712): 
https://lists.openembedded.org/g/openembedded-core/message/151712
Mute This Topic: https://lists.openembedded.org/mt/82800551/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH] libnotify: Make gtk+3 dependency optional

2021-05-13 Thread Richard Purdie 
On Thu, 2021-05-13 at 16:43 +0200, Alexander Kanavin wrote:
> On Thu, 13 May 2021 at 16:36, Mike Crowe via lists.openembedded.org <
> yocto=mac.mcrowe@lists.openembedded.org> wrote:
> > +PACKAGECONFIG[gtk+] = "--enable-tests,--disable-tests,,gtk+3"
> > 
> 
> 
> Was the --enable-tests scenario tested? Specifying gtk+3 after two ,,s seems 
> weird.

It means to add a runtime (RDEPENDS) rather than DEPENDS. There are 
options for positions 5 and 6 too if I remember rightly.

Cheers,

Richard


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#151711): 
https://lists.openembedded.org/g/openembedded-core/message/151711
Mute This Topic: https://lists.openembedded.org/mt/82800551/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH] libnotify: Make gtk+3 dependency optional

2021-05-13 Thread Khem Raj 



On 5/13/21 7:43 AM, Alexander Kanavin wrote:
On Thu, 13 May 2021 at 16:36, Mike Crowe via lists.openembedded.org 
 
> wrote:


+PACKAGECONFIG[gtk+] = "--enable-tests,--disable-tests,,gtk+3"


Was the --enable-tests scenario tested? Specifying gtk+3 after two ,,s 
seems weird.


it is valid if tests need gtk+3 at runtime, but not during build time, 
in that case you only create rdep as above.




Alex





-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#151709): 
https://lists.openembedded.org/g/openembedded-core/message/151709
Mute This Topic: https://lists.openembedded.org/mt/82800551/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH] libnotify: Make gtk+3 dependency optional

2021-05-13 Thread Mike Crowe via lists.openembedded.org 
On Thursday 13 May 2021 at 16:43:15 +0200, Alexander Kanavin wrote:
> On Thu, 13 May 2021 at 16:36, Mike Crowe via lists.openembedded.org  mac.mcrowe@lists.openembedded.org> wrote:
> 
> > +PACKAGECONFIG[gtk+] = "--enable-tests,--disable-tests,,gtk+3"
> >
> 
> Was the --enable-tests scenario tested? Specifying gtk+3 after two ,,s
> seems weird.

You're right. That does look odd. This is actually an old patch I hoovered
up after upgrading and didn't retest it. I'll do some more testing...

Mike.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#151708): 
https://lists.openembedded.org/g/openembedded-core/message/151708
Mute This Topic: https://lists.openembedded.org/mt/82800551/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [OE-core] [PATCH] libnotify: Make gtk+3 dependency optional

2021-05-13 Thread Alexander Kanavin 
On Thu, 13 May 2021 at 16:36, Mike Crowe via lists.openembedded.org  wrote:

> +PACKAGECONFIG[gtk+] = "--enable-tests,--disable-tests,,gtk+3"
>

Was the --enable-tests scenario tested? Specifying gtk+3 after two ,,s
seems weird.

Alex

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#151707): 
https://lists.openembedded.org/g/openembedded-core/message/151707
Mute This Topic: https://lists.openembedded.org/mt/82800551/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-