Re: [OE-core] [PATCH] mesa: link mesautil with pthreads

2018-01-22 Thread Otavio Salvador
On Mon, Jan 22, 2018 at 2:56 PM, Randy MacLeod
 wrote:
> Cherry-pick fix from mesa upstream:
>23ce168048 link mesautil with pthreads
>
> link mesautil with pthreads to avoid:
>
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function 
> `u_thread_setname':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66: 
> undefined reference to `pthread_setname_np'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function 
> `thrd_join':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:336:
>  undefined reference to `pthread_join'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function 
> `u_thread_create':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:48: 
> undefined reference to `pthread_sigmask'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function 
> `thrd_create':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:296:
>  undefined reference to `pthread_create'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function 
> `u_thread_create':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50: 
> undefined reference to `pthread_sigmask'
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50: 
> undefined reference to `pthread_sigmask'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function 
> `call_once':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:96:
>  undefined reference to `pthread_once'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function 
> `u_thread_get_time_nano':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:84: 
> undefined reference to `pthread_getcpuclockid'
> collect2: error: ld returned 1 exit status
>
> Upstream-Status: backport

This goes in the patch file.

> Signed-off-by: Randy MacLeod 
> ---
>  .../files/0001-link-mesautil-with-pthreads.patch   | 51 
> ++
>  meta/recipes-graphics/mesa/mesa_17.3.3.bb  |  1 +
>  2 files changed, 52 insertions(+)
>  create mode 100644 
> meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
>
> diff --git 
> a/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch 
> b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
> new file mode 100644
> index 00..193c54661b
> --- /dev/null
> +++ b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
> @@ -0,0 +1,51 @@
> +From 23ce168048698eeea3df6bb8c9de5be3ca4784cd Mon Sep 17 00:00:00 2001
> +From: Igor Gnatenko 
> +Date: Mon, 1 Jan 2018 22:49:00 +0100
> +Subject: [PATCH] link mesautil with pthreads
> +
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function 
> `u_thread_setname':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66: 
> undefined reference to `pthread_setname_np'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function 
> `thrd_join':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:336:
>  undefined reference to `pthread_join'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function 
> `u_thread_create':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:48: 
> undefined reference to `pthread_sigmask'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function 
> `thrd_create':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:296:
>  undefined reference to `pthread_create'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function 
> `u_thread_create':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50: 
> undefined reference to `pthread_sigmask'
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50: 
> undefined reference to `pthread_sigmask'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function 
> `call_once':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:96:
>  undefined reference to `pthread_once'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function 
> `u_thread_get_time_nano':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:84: 
> undefined reference to `pthread_getcpuclockid'
> +collect2: error: ld returned 1 exit status
> +
> +Reviewed-by: Adam Jackson 
> +Signed-off-by: Igor Gnatenko 
> +---
> + src/util/Makefile.am | 2 ++
> + 1 file changed, 2 insertions(+)
> +
> +diff --git a/src/util/Makefile.am b/src/util/Makefile.am
> +index a5241ad27b..633907b9fd 100644
> +--- a/src/util/Makefile.am
>  b/src/util/Makefile.am
> +@@ -31,6 +31,7 @@ noinst_LTLIBRARIES = \
> +   libxmlconfig.la
> +
> + AM_CPPFLAGS = \
> ++  $(PTHREAD_CFLAGS) \
> +   -I$(top_srcdir)/include
> +
> + libmesautil_la_CPP

Re: [OE-core] [PATCH] mesa: link mesautil with pthreads

2018-01-22 Thread Randy MacLeod

On 2018-01-22 12:16 PM, Burton, Ross wrote:
Upstream-Status tag needs to be in the patch you add, not the commit 
message.


Ross


Picky, picky! :)

Done.


Next patch, I'll see if local patchtest check works now.
Last time I tried using it, it was busted.

../Randy



On 22 January 2018 at 16:56, Randy MacLeod > wrote:


Cherry-pick fix from mesa upstream:
    23ce168048 link mesautil with pthreads

link mesautil with pthreads to avoid:

../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
function `u_thread_setname':
/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66:
undefined reference to `pthread_setname_np'
../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
function `thrd_join':

/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:336:
undefined reference to `pthread_join'
../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
function `u_thread_create':
/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:48:
undefined reference to `pthread_sigmask'
../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
function `thrd_create':

/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:296:
undefined reference to `pthread_create'
../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
function `u_thread_create':
/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
undefined reference to `pthread_sigmask'
/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
undefined reference to `pthread_sigmask'
../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
function `call_once':

/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:96:
undefined reference to `pthread_once'
../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
function `u_thread_get_time_nano':
/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:84:
undefined reference to `pthread_getcpuclockid'
collect2: error: ld returned 1 exit status

Upstream-Status: backport

Signed-off-by: Randy MacLeod mailto:randy.macl...@windriver.com>>
---
  .../files/0001-link-mesautil-with-pthreads.patch   | 51
++
  meta/recipes-graphics/mesa/mesa_17.3.3.bb  
         |  1 +

  2 files changed, 52 insertions(+)
  create mode 100644
meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch

diff --git
a/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
new file mode 100644
index 00..193c54661b
--- /dev/null
+++
b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
@@ -0,0 +1,51 @@
+From 23ce168048698eeea3df6bb8c9de5be3ca4784cd Mon Sep 17 00:00:00 2001
+From: Igor Gnatenko mailto:ignate...@redhat.com>>
+Date: Mon, 1 Jan 2018 22:49:00 +0100
+Subject: [PATCH] link mesautil with pthreads
+
+../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
function `u_thread_setname':
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66:
undefined reference to `pthread_setname_np'
+../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
function `thrd_join':

+/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:336:
undefined reference to `pthread_join'
+../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
function `u_thread_create':
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:48:
undefined reference to `pthread_sigmask'
+../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
function `thrd_create':

+/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:296:
undefined reference to `pthread_create'
+../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
function `u_thread_create':
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
undefined reference to `pthread_sigmask'
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
undefined reference to `pthread_sigmask'
+../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
function `call_once':

+/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:96:
undefined reference to `pthread_once'
+../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
function `u_thread_get_time_nano':
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:84:
undefined reference to `pthread_getcpuclockid'
+collect2:

Re: [OE-core] [PATCH] mesa: link mesautil with pthreads

2018-01-22 Thread Burton, Ross
Upstream-Status tag needs to be in the patch you add, not the commit
message.

Ross

On 22 January 2018 at 16:56, Randy MacLeod 
wrote:

> Cherry-pick fix from mesa upstream:
>23ce168048 link mesautil with pthreads
>
> link mesautil with pthreads to avoid:
>
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function
> `u_thread_setname':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66:
> undefined reference to `pthread_setname_np'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function
> `thrd_join':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:336:
> undefined reference to `pthread_join'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function
> `u_thread_create':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:48:
> undefined reference to `pthread_sigmask'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function
> `thrd_create':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:296:
> undefined reference to `pthread_create'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function
> `u_thread_create':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
> undefined reference to `pthread_sigmask'
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
> undefined reference to `pthread_sigmask'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function
> `call_once':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:96:
> undefined reference to `pthread_once'
> ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function
> `u_thread_get_time_nano':
> /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:84:
> undefined reference to `pthread_getcpuclockid'
> collect2: error: ld returned 1 exit status
>
> Upstream-Status: backport
>
> Signed-off-by: Randy MacLeod 
> ---
>  .../files/0001-link-mesautil-with-pthreads.patch   | 51
> ++
>  meta/recipes-graphics/mesa/mesa_17.3.3.bb  |  1 +
>  2 files changed, 52 insertions(+)
>  create mode 100644 meta/recipes-graphics/mesa/
> files/0001-link-mesautil-with-pthreads.patch
>
> diff --git 
> a/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
> b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
> new file mode 100644
> index 00..193c54661b
> --- /dev/null
> +++ b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-
> pthreads.patch
> @@ -0,0 +1,51 @@
> +From 23ce168048698eeea3df6bb8c9de5be3ca4784cd Mon Sep 17 00:00:00 2001
> +From: Igor Gnatenko 
> +Date: Mon, 1 Jan 2018 22:49:00 +0100
> +Subject: [PATCH] link mesautil with pthreads
> +
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_setname':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66:
> undefined reference to `pthread_setname_np'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `thrd_join':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:336:
> undefined reference to `pthread_join'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_create':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:48:
> undefined reference to `pthread_sigmask'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `thrd_create':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:296:
> undefined reference to `pthread_create'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_create':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
> undefined reference to `pthread_sigmask'
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
> undefined reference to `pthread_sigmask'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `call_once':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:96:
> undefined reference to `pthread_once'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_get_time_nano':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:84:
> undefined reference to `pthread_getcpuclockid'
> +collect2: error: ld returned 1 exit status
> +
> +Reviewed-by: Adam Jackson 
> +Signed-off-by: Igor Gnatenko 
> +---
> + src/util/Makefile.am | 2 ++
> + 1 file changed, 2 insertions(+)
> +
> +diff --git a/src/util/Makefile.am b/src/util/Makefile.am
> +index a5241ad27b..633907b9fd 100644
> +--- a/src/util/Makefile.am
>  b/src/util/Makefile.am
> +@@ -31,6 +31,7 @@ noinst_LTLIBRARIES = \
> +   libxmlconfig.la
> +
> + AM_CPPFLAGS = \
> ++  $(PTHREAD_CFLAGS) \
> +   -I$(top_srcdir)/include
> 

Re: [OE-core] [PATCH] mesa: link mesautil with pthreads

2018-01-22 Thread Randy MacLeod

On 2018-01-22 06:05 AM, Burton, Ross wrote:

Yes 17.3.3 is in master now, so can you rebase Randy?


Sure.
../Randy



Ross

On 21 January 2018 at 21:34, Otavio Salvador 
> wrote:


On Sun, Jan 21, 2018 at 4:18 AM, Randy MacLeod
mailto:randy.macl...@windriver.com>>
wrote:
> Cherry-pick fix from mesa upstream:
>    23ce168048 link mesautil with pthreads
>
> Signed-off-by: Randy MacLeod mailto:randy.macl...@windriver.com>>

Missing Upstream-Status. Also, base it on 17.3.3 recipe so we avoid
another patch revision.

 > ---
 >  .../files/0001-link-mesautil-with-pthreads.patch   | 51
++
 >  meta/recipes-graphics/mesa/mesa_17.3.2.bb
          |  1 +
 >  2 files changed, 52 insertions(+)
 >  create mode 100644
meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
 >
 > diff --git
a/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
 > new file mode 100644
 > index 00..193c54661b
 > --- /dev/null
 > +++
b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
 > @@ -0,0 +1,51 @@
 > +From 23ce168048698eeea3df6bb8c9de5be3ca4784cd Mon Sep 17
00:00:00 2001
 > +From: Igor Gnatenko mailto:ignate...@redhat.com>>
 > +Date: Mon, 1 Jan 2018 22:49:00 +0100
 > +Subject: [PATCH] link mesautil with pthreads
 > +
 > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
function `u_thread_setname':
 >
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66:
undefined reference to `pthread_setname_np'
 > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
function `thrd_join':
 >

+/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:336:
undefined reference to `pthread_join'
 > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
function `u_thread_create':
 >
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:48:
undefined reference to `pthread_sigmask'
 > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
function `thrd_create':
 >

+/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:296:
undefined reference to `pthread_create'
 > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
function `u_thread_create':
 >
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
undefined reference to `pthread_sigmask'
 >
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
undefined reference to `pthread_sigmask'
 > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
function `call_once':
 >

+/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:96:
undefined reference to `pthread_once'
 > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
function `u_thread_get_time_nano':
 >
+/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:84:
undefined reference to `pthread_getcpuclockid'
 > +collect2: error: ld returned 1 exit status
 > +
 > +Reviewed-by: Adam Jackson mailto:a...@redhat.com>>
 > +Signed-off-by: Igor Gnatenko mailto:ignate...@redhat.com>>
 > +---
 > + src/util/Makefile.am | 2 ++
 > + 1 file changed, 2 insertions(+)
 > +
 > +diff --git a/src/util/Makefile.am b/src/util/Makefile.am
 > +index a5241ad27b..633907b9fd 100644
 > +--- a/src/util/Makefile.am
 >  b/src/util/Makefile.am
 > +@@ -31,6 +31,7 @@ noinst_LTLIBRARIES = \
 > + libxmlconfig.la 
 > +
 > + AM_CPPFLAGS = \
 > ++      $(PTHREAD_CFLAGS) \
 > +       -I$(top_srcdir)/include
 > +
 > + libmesautil_la_CPPFLAGS = \
 > +@@ -50,6 +51,7 @@ libmesautil_la_SOURCES = \
 > +       $(MESA_UTIL_GENERATED_FILES)
 > +
 > + libmesautil_la_LIBADD = \
 > ++      $(PTHREAD_LIBS) \
 > +       $(CLOCK_LIB) \
 > +       $(ZLIB_LIBS) \
 > +       $(LIBATOMIC_LIBS)
 > +--
 > +2.14.3
 > +
 > diff --git a/meta/recipes-graphics/mesa/mesa_17.3.2.bb
 b/meta/recipes-graphics/mesa/mesa_17.3.2.bb

 > index 9e9b23322a..8cdcf6c84f 100644
 > --- a/meta/recipes-graphics/mesa/mesa_17.3.2.bb

 > +++ b/meta/recipes-graphics/mesa/mesa_17.3.2.bb

 > @@ -9,6 +9,7 @@ SRC_URI =
"https://mesa.freedesktop.org/archive/mesa-${PV}.tar.xz
 \
 >             file://llvm-config-version.patch \
 >             file://0001-winsy

Re: [OE-core] [PATCH] mesa: link mesautil with pthreads

2018-01-22 Thread Burton, Ross
Yes 17.3.3 is in master now, so can you rebase Randy?

Ross

On 21 January 2018 at 21:34, Otavio Salvador <
otavio.salva...@ossystems.com.br> wrote:

> On Sun, Jan 21, 2018 at 4:18 AM, Randy MacLeod
>  wrote:
> > Cherry-pick fix from mesa upstream:
> >23ce168048 link mesautil with pthreads
> >
> > Signed-off-by: Randy MacLeod 
>
> Missing Upstream-Status. Also, base it on 17.3.3 recipe so we avoid
> another patch revision.
>
> > ---
> >  .../files/0001-link-mesautil-with-pthreads.patch   | 51
> ++
> >  meta/recipes-graphics/mesa/mesa_17.3.2.bb  |  1 +
> >  2 files changed, 52 insertions(+)
> >  create mode 100644 meta/recipes-graphics/mesa/
> files/0001-link-mesautil-with-pthreads.patch
> >
> > diff --git 
> > a/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
> b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
> > new file mode 100644
> > index 00..193c54661b
> > --- /dev/null
> > +++ b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-
> pthreads.patch
> > @@ -0,0 +1,51 @@
> > +From 23ce168048698eeea3df6bb8c9de5be3ca4784cd Mon Sep 17 00:00:00 2001
> > +From: Igor Gnatenko 
> > +Date: Mon, 1 Jan 2018 22:49:00 +0100
> > +Subject: [PATCH] link mesautil with pthreads
> > +
> > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_setname':
> > +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66:
> undefined reference to `pthread_setname_np'
> > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `thrd_join':
> > +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:336:
> undefined reference to `pthread_join'
> > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_create':
> > +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:48:
> undefined reference to `pthread_sigmask'
> > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `thrd_create':
> > +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:296:
> undefined reference to `pthread_create'
> > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_create':
> > +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
> undefined reference to `pthread_sigmask'
> > +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50:
> undefined reference to `pthread_sigmask'
> > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `call_once':
> > +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:96:
> undefined reference to `pthread_once'
> > +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In
> function `u_thread_get_time_nano':
> > +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:84:
> undefined reference to `pthread_getcpuclockid'
> > +collect2: error: ld returned 1 exit status
> > +
> > +Reviewed-by: Adam Jackson 
> > +Signed-off-by: Igor Gnatenko 
> > +---
> > + src/util/Makefile.am | 2 ++
> > + 1 file changed, 2 insertions(+)
> > +
> > +diff --git a/src/util/Makefile.am b/src/util/Makefile.am
> > +index a5241ad27b..633907b9fd 100644
> > +--- a/src/util/Makefile.am
> >  b/src/util/Makefile.am
> > +@@ -31,6 +31,7 @@ noinst_LTLIBRARIES = \
> > +   libxmlconfig.la
> > +
> > + AM_CPPFLAGS = \
> > ++  $(PTHREAD_CFLAGS) \
> > +   -I$(top_srcdir)/include
> > +
> > + libmesautil_la_CPPFLAGS = \
> > +@@ -50,6 +51,7 @@ libmesautil_la_SOURCES = \
> > +   $(MESA_UTIL_GENERATED_FILES)
> > +
> > + libmesautil_la_LIBADD = \
> > ++  $(PTHREAD_LIBS) \
> > +   $(CLOCK_LIB) \
> > +   $(ZLIB_LIBS) \
> > +   $(LIBATOMIC_LIBS)
> > +--
> > +2.14.3
> > +
> > diff --git a/meta/recipes-graphics/mesa/mesa_17.3.2.bb
> b/meta/recipes-graphics/mesa/mesa_17.3.2.bb
> > index 9e9b23322a..8cdcf6c84f 100644
> > --- a/meta/recipes-graphics/mesa/mesa_17.3.2.bb
> > +++ b/meta/recipes-graphics/mesa/mesa_17.3.2.bb
> > @@ -9,6 +9,7 @@ SRC_URI = "https://mesa.freedesktop.org/
> archive/mesa-${PV}.tar.xz \
> > file://llvm-config-version.patch \
> > file://0001-winsys-svga-drm-Include-sys-types.h.patch \
> > 
> > file://0001-Makefile.vulkan.am-explictly-add-lib-expat-to-intel-.patch
> \
> > +   file://0001-link-mesautil-with-pthreads.patch \
> > "
> >
> >  SRC_URI[md5sum] = "5c59b779925f504ffd0f13c7dcd29ac6"
> > --
> > 2.11.0
> >
> > --
> > ___
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
>
> --
> Otavio Salvador O.S. Systems
> http://www.ossystems.com.brhttp://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
> --
> ___

Re: [OE-core] [PATCH] mesa: link mesautil with pthreads

2018-01-21 Thread Otavio Salvador
On Sun, Jan 21, 2018 at 4:18 AM, Randy MacLeod
 wrote:
> Cherry-pick fix from mesa upstream:
>23ce168048 link mesautil with pthreads
>
> Signed-off-by: Randy MacLeod 

Missing Upstream-Status. Also, base it on 17.3.3 recipe so we avoid
another patch revision.

> ---
>  .../files/0001-link-mesautil-with-pthreads.patch   | 51 
> ++
>  meta/recipes-graphics/mesa/mesa_17.3.2.bb  |  1 +
>  2 files changed, 52 insertions(+)
>  create mode 100644 
> meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
>
> diff --git 
> a/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch 
> b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
> new file mode 100644
> index 00..193c54661b
> --- /dev/null
> +++ b/meta/recipes-graphics/mesa/files/0001-link-mesautil-with-pthreads.patch
> @@ -0,0 +1,51 @@
> +From 23ce168048698eeea3df6bb8c9de5be3ca4784cd Mon Sep 17 00:00:00 2001
> +From: Igor Gnatenko 
> +Date: Mon, 1 Jan 2018 22:49:00 +0100
> +Subject: [PATCH] link mesautil with pthreads
> +
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function 
> `u_thread_setname':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66: 
> undefined reference to `pthread_setname_np'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function 
> `thrd_join':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:336:
>  undefined reference to `pthread_join'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function 
> `u_thread_create':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:48: 
> undefined reference to `pthread_sigmask'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function 
> `thrd_create':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:296:
>  undefined reference to `pthread_create'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function 
> `u_thread_create':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50: 
> undefined reference to `pthread_sigmask'
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:50: 
> undefined reference to `pthread_sigmask'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function 
> `call_once':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../include/c11/threads_posix.h:96:
>  undefined reference to `pthread_once'
> +../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function 
> `u_thread_get_time_nano':
> +/builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:84: 
> undefined reference to `pthread_getcpuclockid'
> +collect2: error: ld returned 1 exit status
> +
> +Reviewed-by: Adam Jackson 
> +Signed-off-by: Igor Gnatenko 
> +---
> + src/util/Makefile.am | 2 ++
> + 1 file changed, 2 insertions(+)
> +
> +diff --git a/src/util/Makefile.am b/src/util/Makefile.am
> +index a5241ad27b..633907b9fd 100644
> +--- a/src/util/Makefile.am
>  b/src/util/Makefile.am
> +@@ -31,6 +31,7 @@ noinst_LTLIBRARIES = \
> +   libxmlconfig.la
> +
> + AM_CPPFLAGS = \
> ++  $(PTHREAD_CFLAGS) \
> +   -I$(top_srcdir)/include
> +
> + libmesautil_la_CPPFLAGS = \
> +@@ -50,6 +51,7 @@ libmesautil_la_SOURCES = \
> +   $(MESA_UTIL_GENERATED_FILES)
> +
> + libmesautil_la_LIBADD = \
> ++  $(PTHREAD_LIBS) \
> +   $(CLOCK_LIB) \
> +   $(ZLIB_LIBS) \
> +   $(LIBATOMIC_LIBS)
> +--
> +2.14.3
> +
> diff --git a/meta/recipes-graphics/mesa/mesa_17.3.2.bb 
> b/meta/recipes-graphics/mesa/mesa_17.3.2.bb
> index 9e9b23322a..8cdcf6c84f 100644
> --- a/meta/recipes-graphics/mesa/mesa_17.3.2.bb
> +++ b/meta/recipes-graphics/mesa/mesa_17.3.2.bb
> @@ -9,6 +9,7 @@ SRC_URI = 
> "https://mesa.freedesktop.org/archive/mesa-${PV}.tar.xz \
> file://llvm-config-version.patch \
> file://0001-winsys-svga-drm-Include-sys-types.h.patch \
> 
> file://0001-Makefile.vulkan.am-explictly-add-lib-expat-to-intel-.patch \
> +   file://0001-link-mesautil-with-pthreads.patch \
> "
>
>  SRC_URI[md5sum] = "5c59b779925f504ffd0f13c7dcd29ac6"
> --
> 2.11.0
>
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core