Re: [OE-core] [PATCH] ncurses_6.0: Improve reproducibility

[Khem Raj]

On Sat, Apr 1, 2017 at 2:14 AM, Burton, Ross  wrote:
>
> On 1 April 2017 at 01:42, Khem Raj  wrote:
>>
>> Not this case obviously but I was reminded that this should be default
>> option from tool gain if not specified
>
>
> Yes, and it already is.

right. Andre confirmed that yesterday so settled.
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] ncurses_6.0: Improve reproducibility

[Burton, Ross]

On 1 April 2017 at 01:42, Khem Raj  wrote:

> Not this case obviously but I was reminded that this should be default
> option from tool gain if not specified
>
>>
Yes, and it already is.

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] ncurses_6.0: Improve reproducibility

[Khem Raj]

On Fri, Mar 31, 2017 at 3:50 PM Richard Purdie <
richard.pur...@linuxfoundation.org> wrote:

> On Fri, 2017-03-31 at 22:27 +, Khem Raj wrote:
> >
> > On Fri, Mar 31, 2017 at 2:29 PM Juro Bystricky  > com> wrote:
> > > Build static libraries without the binutils "ar" -U option.
> > > This option deliberately breaks deterministic mode.
> > While this patch is ok it would be better if we configured binutils
> > with enable-deterministic-archives option please file a ticket for
> > it
>
> ncurses is specifically asking binutils to make a non-deterministic
> archive here so I'm not sure that would help in this specific case
> Cheers,


Not this case obviously but I was reminded that this should be default
option from tool gain if not specified

>
>
> Richard
>
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] ncurses_6.0: Improve reproducibility

[Andre McCurdy]

On Fri, Mar 31, 2017 at 3:27 PM, Khem Raj  wrote:
>
> On Fri, Mar 31, 2017 at 2:29 PM Juro Bystricky 
> wrote:
>>
>> Build static libraries without the binutils "ar" -U option.
>> This option deliberately breaks deterministic mode.
>
> While this patch is ok it would be better if we configured binutils with
> enable-deterministic-archives option please file a ticket for it

We already do that:

  
http://git.openembedded.org/openembedded-core/commit/?id=df0d525c02780b5a0bd7a177a249c55f41797476

>>
>> The option seems to be a relic from 2015, intended as a workaround
>> for some unspecified build problems.
>>
>> [YOCTO#11247]
>>
>> Signed-off-by: Juro Bystricky 
>> ---
>>  .../ncurses/files/configure-reproducible.patch   | 20
>> 
>>  meta/recipes-core/ncurses/ncurses_6.0+20161126.bb|  1 +
>>  2 files changed, 21 insertions(+)
>>  create mode 100644
>> meta/recipes-core/ncurses/files/configure-reproducible.patch
>>
>> diff --git a/meta/recipes-core/ncurses/files/configure-reproducible.patch
>> b/meta/recipes-core/ncurses/files/configure-reproducible.patch
>> new file mode 100644
>> index 000..54a8bdc
>> --- /dev/null
>> +++ b/meta/recipes-core/ncurses/files/configure-reproducible.patch
>> @@ -0,0 +1,20 @@
>> +"configure" enforces -U for ar flags, breaking deterministic builds.
>> +The flag was added to fix some vaguely specified "recent POSIX binutil
>> +build problems" in 2015.
>> +
>> +Upstream-Status: Pending
>> +Signed-off-by: Juro Bystricky 
>> +
>> +diff --git a/configure b/configure
>> +index 7f31208..aa80911 100755
>> +--- a/configure
>>  b/configure
>> +@@ -4428,7 +4428,7 @@ if test "${cf_cv_ar_flags+set}" = set; then
>> + else
>> +
>> +   cf_cv_ar_flags=unknown
>> +-  for cf_ar_flags in -curvU -curv curv -crv crv -cqv cqv -rv rv
>> ++  for cf_ar_flags in -curv curv -crv crv -cqv cqv -rv rv
>> +   do
>> +
>> +   # check if $ARFLAGS already contains this choice
>> diff --git a/meta/recipes-core/ncurses/ncurses_6.0+20161126.bb
>> b/meta/recipes-core/ncurses/ncurses_6.0+20161126.bb
>> index e95741f..ace3108 100644
>> --- a/meta/recipes-core/ncurses/ncurses_6.0+20161126.bb
>> +++ b/meta/recipes-core/ncurses/ncurses_6.0+20161126.bb
>> @@ -3,6 +3,7 @@ require ncurses.inc
>>  SRC_URI += "file://tic-hang.patch \
>>  file://fix-cflags-mangle.patch \
>>  file://config.cache \
>> +file://configure-reproducible.patch \
>>  "
>>  # commit id corresponds to the revision in package version
>>  SRCREV = "3db0bd19cb50e3d9b4f2cf15b7a102fe11302068"
>> --
>> 2.7.4
>>
>> --
>> ___
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] ncurses_6.0: Improve reproducibility

[Richard Purdie]

On Fri, 2017-03-31 at 22:27 +, Khem Raj wrote:
> 
> On Fri, Mar 31, 2017 at 2:29 PM Juro Bystricky  com> wrote:
> > Build static libraries without the binutils "ar" -U option.
> > This option deliberately breaks deterministic mode.
> While this patch is ok it would be better if we configured binutils
> with enable-deterministic-archives option please file a ticket for
> it 

ncurses is specifically asking binutils to make a non-deterministic
archive here so I'm not sure that would help in this specific case.

Cheers,

Richard
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] ncurses_6.0: Improve reproducibility

[Khem Raj]

On Fri, Mar 31, 2017 at 2:29 PM Juro Bystricky 
wrote:

> Build static libraries without the binutils "ar" -U option.
> This option deliberately breaks deterministic mode.


While this patch is ok it would be better if we configured binutils with
enable-deterministic-archives option please file a ticket for it

>
> The option seems to be a relic from 2015, intended as a workaround
> for some unspecified build problems.
>
> [YOCTO#11247]
>
> Signed-off-by: Juro Bystricky 
> ---
>  .../ncurses/files/configure-reproducible.patch   | 20
> 
>  meta/recipes-core/ncurses/ncurses_6.0+20161126.bb|  1 +
>  2 files changed, 21 insertions(+)
>  create mode 100644
> meta/recipes-core/ncurses/files/configure-reproducible.patch
>
> diff --git a/meta/recipes-core/ncurses/files/configure-reproducible.patch
> b/meta/recipes-core/ncurses/files/configure-reproducible.patch
> new file mode 100644
> index 000..54a8bdc
> --- /dev/null
> +++ b/meta/recipes-core/ncurses/files/configure-reproducible.patch
> @@ -0,0 +1,20 @@
> +"configure" enforces -U for ar flags, breaking deterministic builds.
> +The flag was added to fix some vaguely specified "recent POSIX binutil
> +build problems" in 2015.
> +
> +Upstream-Status: Pending
> +Signed-off-by: Juro Bystricky 
> +
> +diff --git a/configure b/configure
> +index 7f31208..aa80911 100755
> +--- a/configure
>  b/configure
> +@@ -4428,7 +4428,7 @@ if test "${cf_cv_ar_flags+set}" = set; then
> + else
> +
> +   cf_cv_ar_flags=unknown
> +-  for cf_ar_flags in -curvU -curv curv -crv crv -cqv cqv -rv rv
> ++  for cf_ar_flags in -curv curv -crv crv -cqv cqv -rv rv
> +   do
> +
> +   # check if $ARFLAGS already contains this choice
> diff --git a/meta/recipes-core/ncurses/ncurses_6.0+20161126.bb
> b/meta/recipes-core/ncurses/ncurses_6.0+20161126.bb
> index e95741f..ace3108 100644
> --- a/meta/recipes-core/ncurses/ncurses_6.0+20161126.bb
> +++ b/meta/recipes-core/ncurses/ncurses_6.0+20161126.bb
> @@ -3,6 +3,7 @@ require ncurses.inc
>  SRC_URI += "file://tic-hang.patch \
>  file://fix-cflags-mangle.patch \
>  file://config.cache \
> +file://configure-reproducible.patch \
>  "
>  # commit id corresponds to the revision in package version
>  SRCREV = "3db0bd19cb50e3d9b4f2cf15b7a102fe11302068"
> --
> 2.7.4
>
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core