Re: [OE-core] [PATCH] no-static-libs: disable static libraries in libjpeg-turbo

2018-08-31 Thread Burton, Ross
Yes, the way the controls need to be in here has bothered me for a while.

Ross

On 31 August 2018 at 17:17, Khem Raj  wrote:
> On Thu, Aug 30, 2018 at 3:13 PM Ross Burton  wrote:
>>
>> Previously this was done with the generic autotools support, but CMake 
>> doesn't
>> have a standard option so set it explicitly.
>>
>
> Not particularly relevant to this patch but another approach could be
> to turn no-staticlibs into a distro feature and move these controls to
> respective recipes.
> may be for next release ..
>
>> Signed-off-by: Ross Burton 
>> ---
>>  meta/conf/distro/include/no-static-libs.inc | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/conf/distro/include/no-static-libs.inc 
>> b/meta/conf/distro/include/no-static-libs.inc
>> index 7fd578b3ce7..cdc53916d07 100644
>> --- a/meta/conf/distro/include/no-static-libs.inc
>> +++ b/meta/conf/distro/include/no-static-libs.inc
>> @@ -36,6 +36,7 @@ DISABLE_STATIC_pn-libusb1-native = ""
>>  EXTRA_OECONF_append = "${DISABLE_STATIC}"
>>
>>  EXTRA_OECMAKE_append_pn-libical = " -DSHARED_ONLY=True"
>> +EXTRA_OECMAKE_append_pn-libjpeg-turbo = " -DENABLE_STATIC=False"
>>
>>  EXCONFIG_ARGS_append_pn-ncurses = " --without-normal"
>>  EXCONFIG_ARGS_append_pn-ncurses-native = " --without-normal"
>> --
>> 2.11.0
>>
>> --
>> ___
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH] no-static-libs: disable static libraries in libjpeg-turbo

2018-08-31 Thread Khem Raj
On Thu, Aug 30, 2018 at 3:13 PM Ross Burton  wrote:
>
> Previously this was done with the generic autotools support, but CMake doesn't
> have a standard option so set it explicitly.
>

Not particularly relevant to this patch but another approach could be
to turn no-staticlibs into a distro feature and move these controls to
respective recipes.
may be for next release ..

> Signed-off-by: Ross Burton 
> ---
>  meta/conf/distro/include/no-static-libs.inc | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/conf/distro/include/no-static-libs.inc 
> b/meta/conf/distro/include/no-static-libs.inc
> index 7fd578b3ce7..cdc53916d07 100644
> --- a/meta/conf/distro/include/no-static-libs.inc
> +++ b/meta/conf/distro/include/no-static-libs.inc
> @@ -36,6 +36,7 @@ DISABLE_STATIC_pn-libusb1-native = ""
>  EXTRA_OECONF_append = "${DISABLE_STATIC}"
>
>  EXTRA_OECMAKE_append_pn-libical = " -DSHARED_ONLY=True"
> +EXTRA_OECMAKE_append_pn-libjpeg-turbo = " -DENABLE_STATIC=False"
>
>  EXCONFIG_ARGS_append_pn-ncurses = " --without-normal"
>  EXCONFIG_ARGS_append_pn-ncurses-native = " --without-normal"
> --
> 2.11.0
>
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core