Re: [OE-core] [PATCH] webkitgtk, gcr, libsecret: force ARM mode

2015-10-12 Thread Martin Jansa 
On Sat, Oct 10, 2015 at 11:45:43PM +0200, Carlos Alberto Lopez Perez wrote:
> On 10/10/15 17:32, Martin Jansa wrote:
> > Did you enable thumb in that build? It's not enabled by default.
> > 
> > ARM_INSTRUCTION_SET is for recipes to use arm when distro selects thumb by
> > default.
> 
> I assumed it was enabled by default if it was listed on the list printed
> on TUNE_FEATURES when starting bitbake. Seems not.
> 
> I manually enabled it on the recipe of webkitgtk+ by setting
> 'ARM_INSTRUCTION_SET = "thumb"' and I was able to reproduce the build
> failure.
> 
> However, later I tried doing the same for a standard armv7a machine and
> it built fine.
> 
> qemuarm is arvm6 with thumb1, and any armv7 or newer machine will prefer
> thumb2 instead. The compiler would automatically use thumb2 when
> enabling -mthumb on a armv7 or newer march.
> 
> So, it built fine with -march=armv7-a -mthumb
> 
> Given that most people building webkitgtk+ will use armv7 or newer, I
> don't think disabling the possibility of building webkitgtk+ with thumb
> (thumb2) unconditionally is a good idea.
> 
> I also tested to build gcr and libsecret. Both build also fine with
> -mthumb on armv7.
> 
> 
> So, could we set ARM_INSTRUCTION_SET=arm only for armv6 or older
> machines in this 3 recipes?

Yes, that would be better, I'm still waiting for answer about other
layers, see:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=7717#c6

In the meantime I'm using this to keep my world builds going.

-- 
Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com


signature.asc
Description: Digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] webkitgtk, gcr, libsecret: force ARM mode

2015-10-12 Thread Alexander Kanavin 

On 10/11/2015 12:45 AM, Carlos Alberto Lopez Perez wrote:


So, could we set ARM_INSTRUCTION_SET=arm only for armv6 or older
machines in this 3 recipes?


Indeed. Webkit has other issues on armv6 or older (JIT fails to build if 
you try to), so I believe the upstream developers test the builds only 
on v7 onwards nowadays, and don't actually support anything older.



Alex

--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] webkitgtk, gcr, libsecret: force ARM mode

2015-10-12 Thread Burton, Ross 
On 11 October 2015 at 10:51, Phil Blundell  wrote:

> > * gcr, libsecret are new since switch to gcc 5.2
>
> The problem with libsecret seems to be caused by its valgrind support
> code (which contains asm statements that only work in ARM state).  I
> wonder if you can just turn WITH_VALGRIND off rather than forcing
> ARM-state for the whole library.


That code is provided by valgrind itself so either fixing valgrind to write
valid code or forcibly disabling the code in valgrind.h if thumb is enabled
seems sensible and more likely to catch more problems in a single patch.

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] webkitgtk, gcr, libsecret: force ARM mode

2015-10-12 Thread Carlos Alberto Lopez Perez 
On 12/10/15 13:17, Alexander Kanavin wrote:
> On 10/11/2015 12:45 AM, Carlos Alberto Lopez Perez wrote:
> 
>> So, could we set ARM_INSTRUCTION_SET=arm only for armv6 or older
>> machines in this 3 recipes?
> 
> Indeed. Webkit has other issues on armv6 or older (JIT fails to build if
> you try to), so I believe the upstream developers test the builds only
> on v7 onwards nowadays, and don't actually support anything older.
> 
> 
> Alex
> 

Yes, that's true.

The buildbots we have continuously testing [1] only do it on i686,
AMD64, ARMv7+ (traditional/arm and thumb2) and ARM64 (Aarch64)
architectures.

Regards
---
[1] https://build.webkit.org/builders



signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] webkitgtk, gcr, libsecret: force ARM mode

2015-10-11 Thread Phil Blundell 
On Fri, 2015-10-09 at 17:11 +0200, Martin Jansa wrote:
> * gcr, libsecret are new since switch to gcc 5.2

The problem with libsecret seems to be caused by its valgrind support
code (which contains asm statements that only work in ARM state).  I
wonder if you can just turn WITH_VALGRIND off rather than forcing
ARM-state for the whole library.

p.


-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] webkitgtk, gcr, libsecret: force ARM mode

2015-10-10 Thread Khem Raj 
On Sat, Oct 10, 2015 at 5:13 AM, Carlos Alberto Lopez Perez
 wrote:
> On 09/10/15 17:11, Martin Jansa wrote:
>> * gcr, libsecret are new since switch to gcc 5.2
>> * webkitgtk is old but it was removed while migrating from
>>   webkit-gtk to webkitgtl (like REQUIRED_DISTRO_FEATURES were) :/
>>
>> Signed-off-by: Martin Jansa 
>> ---
>
>> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb 
>> b/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb
>> index f14c868..e29666a 100644
>> --- a/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb
>> +++ b/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb
>> @@ -70,3 +70,5 @@ FILES_${PN} += 
>> "${libdir}/webkit2gtk-4.0/injected-bundle/libwebkit2gtkinjectedbu
>>  FILES_${PN}-dbg += 
>> "${libdir}/webkit2gtk-4.0/injected-bundle/.debug/libwebkit2gtkinjectedbundle.so"
>>  FILES_${PN}-dbg += "${libdir}/webkitgtk/webkit2gtk-4.0/.debug/*"
>>
>> +# http://errors.yoctoproject.org/Errors/Details/20370/
>> +ARM_INSTRUCTION_SET = "arm"
>>
>
> I tried to build webkitgtk using current master of poky for machine
> qemuarm and it built fine:

That is fine, however keep in mind that poky is one of many
distributions using OE build framework.
there are many other which have different distribution policies and
all of them use OE-Core and bitbake layers
as must. So when you make changes to OE-Core or bitbake the scope is a
bit wider. Testing it on Poky alone
might not be sufficient. In this case the distro is choosing Thumb ISA
as default for ARM architecture, you need
to have that policy set to reproduce this error.

>
> Build Configuration:
> BB_VERSION= "1.28.0"
> BUILD_SYS = "x86_64-linux"
> NATIVELSBSTRING   = "Debian-8.1"
> TARGET_SYS= "arm-poky-linux-gnueabi"
> MACHINE   = "qemuarm"
> DISTRO= "poky"
> DISTRO_VERSION= "2.0"
> TUNE_FEATURES = "arm armv5 thumb dsp"
> TARGET_FPU= "soft"
> meta
> meta-yocto
> meta-yocto-bsp= "master:ceeb52a2544045fe8432e36307a321f6e934de49"
>
>
>
>
> Can you tell me how to reproduce this failure?
> Also, what the ARM_INSTRUCTION_SET = "arm" line does?
> Thanks.
>
>
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] webkitgtk, gcr, libsecret: force ARM mode

2015-10-10 Thread Martin Jansa 
Did you enable thumb in that build? It's not enabled by default.

ARM_INSTRUCTION_SET is for recipes to use arm when distro selects thumb by
default.

On Sat, Oct 10, 2015, 14:13 Carlos Alberto Lopez Perez 
wrote:

> On 09/10/15 17:11, Martin Jansa wrote:
> > * gcr, libsecret are new since switch to gcc 5.2
> > * webkitgtk is old but it was removed while migrating from
> >   webkit-gtk to webkitgtl (like REQUIRED_DISTRO_FEATURES were) :/
> >
> > Signed-off-by: Martin Jansa 
> > ---
>
> > diff --git a/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb
> b/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb
> > index f14c868..e29666a 100644
> > --- a/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb
> > +++ b/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb
> > @@ -70,3 +70,5 @@ FILES_${PN} +=
> "${libdir}/webkit2gtk-4.0/injected-bundle/libwebkit2gtkinjectedbu
> >  FILES_${PN}-dbg +=
> "${libdir}/webkit2gtk-4.0/injected-bundle/.debug/libwebkit2gtkinjectedbundle.so"
> >  FILES_${PN}-dbg += "${libdir}/webkitgtk/webkit2gtk-4.0/.debug/*"
> >
> > +# http://errors.yoctoproject.org/Errors/Details/20370/
> > +ARM_INSTRUCTION_SET = "arm"
> >
>
> I tried to build webkitgtk using current master of poky for machine
> qemuarm and it built fine:
>
> Build Configuration:
> BB_VERSION= "1.28.0"
> BUILD_SYS = "x86_64-linux"
> NATIVELSBSTRING   = "Debian-8.1"
> TARGET_SYS= "arm-poky-linux-gnueabi"
> MACHINE   = "qemuarm"
> DISTRO= "poky"
> DISTRO_VERSION= "2.0"
> TUNE_FEATURES = "arm armv5 thumb dsp"
> TARGET_FPU= "soft"
> meta
> meta-yocto
> meta-yocto-bsp= "master:ceeb52a2544045fe8432e36307a321f6e934de49"
>
>
>
>
> Can you tell me how to reproduce this failure?
> Also, what the ARM_INSTRUCTION_SET = "arm" line does?
> Thanks.
>
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] webkitgtk, gcr, libsecret: force ARM mode

2015-10-10 Thread Carlos Alberto Lopez Perez 
On 10/10/15 17:32, Martin Jansa wrote:
> Did you enable thumb in that build? It's not enabled by default.
> 
> ARM_INSTRUCTION_SET is for recipes to use arm when distro selects thumb by
> default.

I assumed it was enabled by default if it was listed on the list printed
on TUNE_FEATURES when starting bitbake. Seems not.

I manually enabled it on the recipe of webkitgtk+ by setting
'ARM_INSTRUCTION_SET = "thumb"' and I was able to reproduce the build
failure.

However, later I tried doing the same for a standard armv7a machine and
it built fine.

qemuarm is arvm6 with thumb1, and any armv7 or newer machine will prefer
thumb2 instead. The compiler would automatically use thumb2 when
enabling -mthumb on a armv7 or newer march.

So, it built fine with -march=armv7-a -mthumb

Given that most people building webkitgtk+ will use armv7 or newer, I
don't think disabling the possibility of building webkitgtk+ with thumb
(thumb2) unconditionally is a good idea.

I also tested to build gcr and libsecret. Both build also fine with
-mthumb on armv7.


So, could we set ARM_INSTRUCTION_SET=arm only for armv6 or older
machines in this 3 recipes?



signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] webkitgtk, gcr, libsecret: force ARM mode

2015-10-10 Thread Khem Raj 
On Sat, Oct 10, 2015 at 2:45 PM, Carlos Alberto Lopez Perez
 wrote:
> On 10/10/15 17:32, Martin Jansa wrote:
>> Did you enable thumb in that build? It's not enabled by default.
>>
>> ARM_INSTRUCTION_SET is for recipes to use arm when distro selects thumb by
>> default.
>
> I assumed it was enabled by default if it was listed on the list printed
> on TUNE_FEATURES when starting bitbake. Seems not.
>
> I manually enabled it on the recipe of webkitgtk+ by setting
> 'ARM_INSTRUCTION_SET = "thumb"' and I was able to reproduce the build
> failure.
>
> However, later I tried doing the same for a standard armv7a machine and
> it built fine.
>
> qemuarm is arvm6 with thumb1, and any armv7 or newer machine will prefer
> thumb2 instead. The compiler would automatically use thumb2 when
> enabling -mthumb on a armv7 or newer march.
>
> So, it built fine with -march=armv7-a -mthumb

that will use thumb2 ISA and its not same as thumb1 that Martin is seeing.

>
> Given that most people building webkitgtk+ will use armv7 or newer, I
> don't think disabling the possibility of building webkitgtk+ with thumb
> (thumb2) unconditionally is a good idea.
>
> I also tested to build gcr and libsecret. Both build also fine with
> -mthumb on armv7.
>
>
> So, could we set ARM_INSTRUCTION_SET=arm only for armv6 or older
> machines in this 3 recipes?

I think that should be fine. Although we don't have a single check for this
one needs to check for armv5 and armv4 and its family of sub-arches

>
>
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] webkitgtk, gcr, libsecret: force ARM mode

2015-10-10 Thread Carlos Alberto Lopez Perez 
On 09/10/15 17:11, Martin Jansa wrote:
> * gcr, libsecret are new since switch to gcc 5.2
> * webkitgtk is old but it was removed while migrating from
>   webkit-gtk to webkitgtl (like REQUIRED_DISTRO_FEATURES were) :/
> 
> Signed-off-by: Martin Jansa 
> ---

> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb 
> b/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb
> index f14c868..e29666a 100644
> --- a/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb
> +++ b/meta/recipes-sato/webkit/webkitgtk_2.8.5.bb
> @@ -70,3 +70,5 @@ FILES_${PN} += 
> "${libdir}/webkit2gtk-4.0/injected-bundle/libwebkit2gtkinjectedbu
>  FILES_${PN}-dbg += 
> "${libdir}/webkit2gtk-4.0/injected-bundle/.debug/libwebkit2gtkinjectedbundle.so"
>  FILES_${PN}-dbg += "${libdir}/webkitgtk/webkit2gtk-4.0/.debug/*"
>  
> +# http://errors.yoctoproject.org/Errors/Details/20370/
> +ARM_INSTRUCTION_SET = "arm"
> 

I tried to build webkitgtk using current master of poky for machine
qemuarm and it built fine:

Build Configuration:
BB_VERSION= "1.28.0"
BUILD_SYS = "x86_64-linux"
NATIVELSBSTRING   = "Debian-8.1"
TARGET_SYS= "arm-poky-linux-gnueabi"
MACHINE   = "qemuarm"
DISTRO= "poky"
DISTRO_VERSION= "2.0"
TUNE_FEATURES = "arm armv5 thumb dsp"
TARGET_FPU= "soft"
meta
meta-yocto
meta-yocto-bsp= "master:ceeb52a2544045fe8432e36307a321f6e934de49"




Can you tell me how to reproduce this failure?
Also, what the ARM_INSTRUCTION_SET = "arm" line does?
Thanks.



signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core