Re: [OE-core] [PATCH 02/12] qemu: enable virglrenderer and glx options for native/nativesdk builds
On Mon, 2019-02-25 at 09:29 -0600, Joshua Watt wrote: > On Mon, 2019-02-25 at 13:52 +0100, Alexander Kanavin wrote: > > On Mon, 25 Feb 2019 at 12:02, Richard Purdie > > wrote: > > > On Fri, 2019-02-22 at 15:33 +0100, Alexander Kanavin wrote: > > > > Except for ming32/darwin, which do not support them. > > > > > > > > Signed-off-by: Alexander Kanavin > > > > --- > > > > meta/recipes-devtools/qemu/qemu.inc | 10 +- > > > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > > > > > diff --git a/meta/recipes-devtools/qemu/qemu.inc > > > > b/meta/recipes- > > > > devtools/qemu/qemu.inc > > > > index c127434b020..95e9e0ede77 100644 > > > > --- a/meta/recipes-devtools/qemu/qemu.inc > > > > +++ b/meta/recipes-devtools/qemu/qemu.inc > > > > @@ -74,15 +74,15 @@ PACKAGECONFIG ??= " \ > > > > fdt sdl kvm \ > > > > ${@bb.utils.filter('DISTRO_FEATURES', 'alsa xen', d)} \ > > > > " > > > > -PACKAGECONFIG_class-native ??= "fdt alsa kvm" > > > > -PACKAGECONFIG_class-nativesdk ??= "fdt sdl kvm" > > > > +PACKAGECONFIG_class-native ??= "fdt alsa kvm virglrenderer > > > > glx" > > > > +PACKAGECONFIG_class-nativesdk ??= "fdt sdl kvm virglrenderer > > > > glx" > > > > > > > > # Handle distros such as CentOS 5 32-bit that do not have kvm > > > > support > > > > PACKAGECONFIG_class-native_remove = "${@'kvm' if not > > > > os.path.exists('/usr/include/linux/kvm.h') else ''}" > > > > > > > > -# Disable kvm on targets that do not support it > > > > -PACKAGECONFIG_remove_darwin = "kvm" > > > > -PACKAGECONFIG_remove_mingw32 = "kvm" > > > > +# Disable kvm/virgl/mesa on targets that do not support it > > > > +PACKAGECONFIG_remove_darwin = "kvm virglrenderer glx gtk+" > > > > +PACKAGECONFIG_remove_mingw32 = "kvm virglrenderer glx gtk+" > > > > > > Sorry, I just spotted this. Please don't use _remove in OE-Core. > > > Can we > > > rearrange this so we don't need to use remove? > > > > > > I appreciate there are other users that have crept in but I'd > > > like > > > to > > > see them gone too... > > > > I'm actually unsure how to override the > > PACKAGECONFIG_append_pn-qemu-native = " gtk+" > > set in local.conf without using _remove. > > I don't think I quite follow why this is an issue, mingw is not a > supported build host AFAIK, so the "-native" means it shouldn't be a > problem (e.g. "native" should never mean "mingw")? Not sure about > darwin though. I wasn't quite seeing this either at first. native isn't the problem, its the nativesdk variant... Cheers, Richard -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 02/12] qemu: enable virglrenderer and glx options for native/nativesdk builds
On Mon, 2019-02-25 at 13:52 +0100, Alexander Kanavin wrote: > On Mon, 25 Feb 2019 at 12:02, Richard Purdie > wrote: > > On Fri, 2019-02-22 at 15:33 +0100, Alexander Kanavin wrote: > > > Except for ming32/darwin, which do not support them. > > > > > > Signed-off-by: Alexander Kanavin > > > --- > > > meta/recipes-devtools/qemu/qemu.inc | 10 +- > > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > > > diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes- > > > devtools/qemu/qemu.inc > > > index c127434b020..95e9e0ede77 100644 > > > --- a/meta/recipes-devtools/qemu/qemu.inc > > > +++ b/meta/recipes-devtools/qemu/qemu.inc > > > @@ -74,15 +74,15 @@ PACKAGECONFIG ??= " \ > > > fdt sdl kvm \ > > > ${@bb.utils.filter('DISTRO_FEATURES', 'alsa xen', d)} \ > > > " > > > -PACKAGECONFIG_class-native ??= "fdt alsa kvm" > > > -PACKAGECONFIG_class-nativesdk ??= "fdt sdl kvm" > > > +PACKAGECONFIG_class-native ??= "fdt alsa kvm virglrenderer glx" > > > +PACKAGECONFIG_class-nativesdk ??= "fdt sdl kvm virglrenderer > > > glx" > > > > > > # Handle distros such as CentOS 5 32-bit that do not have kvm > > > support > > > PACKAGECONFIG_class-native_remove = "${@'kvm' if not > > > os.path.exists('/usr/include/linux/kvm.h') else ''}" > > > > > > -# Disable kvm on targets that do not support it > > > -PACKAGECONFIG_remove_darwin = "kvm" > > > -PACKAGECONFIG_remove_mingw32 = "kvm" > > > +# Disable kvm/virgl/mesa on targets that do not support it > > > +PACKAGECONFIG_remove_darwin = "kvm virglrenderer glx gtk+" > > > +PACKAGECONFIG_remove_mingw32 = "kvm virglrenderer glx gtk+" > > > > Sorry, I just spotted this. Please don't use _remove in OE-Core. > > Can we > > rearrange this so we don't need to use remove? > > > > I appreciate there are other users that have crept in but I'd like > > to > > see them gone too... > > I'm actually unsure how to override the > PACKAGECONFIG_append_pn-qemu-native = " gtk+" > set in local.conf without using _remove. I don't think I quite follow why this is an issue, mingw is not a supported build host AFAIK, so the "-native" means it shouldn't be a problem (e.g. "native" should never mean "mingw")? Not sure about darwin though. > > (we do not support gtk+ on mingw, and I guess darwin too). > > We can rearrange this, enable/not enable gtk+ directly in the recipe, > and drop the qemu related lines from local.conf altogether, if you're > okay with that. > > Alex -- Joshua Watt -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 02/12] qemu: enable virglrenderer and glx options for native/nativesdk builds
On Mon, Feb 25, 2019 at 4:52 AM Alexander Kanavin wrote: > > On Mon, 25 Feb 2019 at 12:02, Richard Purdie > wrote: > > > > On Fri, 2019-02-22 at 15:33 +0100, Alexander Kanavin wrote: > > > Except for ming32/darwin, which do not support them. > > > > > > Signed-off-by: Alexander Kanavin > > > --- > > > meta/recipes-devtools/qemu/qemu.inc | 10 +- > > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > > > diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes- > > > devtools/qemu/qemu.inc > > > index c127434b020..95e9e0ede77 100644 > > > --- a/meta/recipes-devtools/qemu/qemu.inc > > > +++ b/meta/recipes-devtools/qemu/qemu.inc > > > @@ -74,15 +74,15 @@ PACKAGECONFIG ??= " \ > > > fdt sdl kvm \ > > > ${@bb.utils.filter('DISTRO_FEATURES', 'alsa xen', d)} \ > > > " > > > -PACKAGECONFIG_class-native ??= "fdt alsa kvm" > > > -PACKAGECONFIG_class-nativesdk ??= "fdt sdl kvm" > > > +PACKAGECONFIG_class-native ??= "fdt alsa kvm virglrenderer glx" > > > +PACKAGECONFIG_class-nativesdk ??= "fdt sdl kvm virglrenderer glx" > > > > > > # Handle distros such as CentOS 5 32-bit that do not have kvm > > > support > > > PACKAGECONFIG_class-native_remove = "${@'kvm' if not > > > os.path.exists('/usr/include/linux/kvm.h') else ''}" > > > > > > -# Disable kvm on targets that do not support it > > > -PACKAGECONFIG_remove_darwin = "kvm" > > > -PACKAGECONFIG_remove_mingw32 = "kvm" > > > +# Disable kvm/virgl/mesa on targets that do not support it > > > +PACKAGECONFIG_remove_darwin = "kvm virglrenderer glx gtk+" > > > +PACKAGECONFIG_remove_mingw32 = "kvm virglrenderer glx gtk+" > > > > Sorry, I just spotted this. Please don't use _remove in OE-Core. Can we > > rearrange this so we don't need to use remove? > > > > I appreciate there are other users that have crept in but I'd like to > > see them gone too... > > I'm actually unsure how to override the > PACKAGECONFIG_append_pn-qemu-native = " gtk+" > set in local.conf without using _remove. > > (we do not support gtk+ on mingw, and I guess darwin too). > iirc there are overrides for mingw which could be used in local.conf to narrow this packageconfig setting > We can rearrange this, enable/not enable gtk+ directly in the recipe, > and drop the qemu related lines from local.conf altogether, if you're > okay with that. > > Alex > -- > ___ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 02/12] qemu: enable virglrenderer and glx options for native/nativesdk builds
On Mon, 25 Feb 2019 at 12:02, Richard Purdie wrote: > > On Fri, 2019-02-22 at 15:33 +0100, Alexander Kanavin wrote: > > Except for ming32/darwin, which do not support them. > > > > Signed-off-by: Alexander Kanavin > > --- > > meta/recipes-devtools/qemu/qemu.inc | 10 +- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes- > > devtools/qemu/qemu.inc > > index c127434b020..95e9e0ede77 100644 > > --- a/meta/recipes-devtools/qemu/qemu.inc > > +++ b/meta/recipes-devtools/qemu/qemu.inc > > @@ -74,15 +74,15 @@ PACKAGECONFIG ??= " \ > > fdt sdl kvm \ > > ${@bb.utils.filter('DISTRO_FEATURES', 'alsa xen', d)} \ > > " > > -PACKAGECONFIG_class-native ??= "fdt alsa kvm" > > -PACKAGECONFIG_class-nativesdk ??= "fdt sdl kvm" > > +PACKAGECONFIG_class-native ??= "fdt alsa kvm virglrenderer glx" > > +PACKAGECONFIG_class-nativesdk ??= "fdt sdl kvm virglrenderer glx" > > > > # Handle distros such as CentOS 5 32-bit that do not have kvm > > support > > PACKAGECONFIG_class-native_remove = "${@'kvm' if not > > os.path.exists('/usr/include/linux/kvm.h') else ''}" > > > > -# Disable kvm on targets that do not support it > > -PACKAGECONFIG_remove_darwin = "kvm" > > -PACKAGECONFIG_remove_mingw32 = "kvm" > > +# Disable kvm/virgl/mesa on targets that do not support it > > +PACKAGECONFIG_remove_darwin = "kvm virglrenderer glx gtk+" > > +PACKAGECONFIG_remove_mingw32 = "kvm virglrenderer glx gtk+" > > Sorry, I just spotted this. Please don't use _remove in OE-Core. Can we > rearrange this so we don't need to use remove? > > I appreciate there are other users that have crept in but I'd like to > see them gone too... I'm actually unsure how to override the PACKAGECONFIG_append_pn-qemu-native = " gtk+" set in local.conf without using _remove. (we do not support gtk+ on mingw, and I guess darwin too). We can rearrange this, enable/not enable gtk+ directly in the recipe, and drop the qemu related lines from local.conf altogether, if you're okay with that. Alex -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 02/12] qemu: enable virglrenderer and glx options for native/nativesdk builds
On Fri, 2019-02-22 at 15:33 +0100, Alexander Kanavin wrote: > Except for ming32/darwin, which do not support them. > > Signed-off-by: Alexander Kanavin > --- > meta/recipes-devtools/qemu/qemu.inc | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes- > devtools/qemu/qemu.inc > index c127434b020..95e9e0ede77 100644 > --- a/meta/recipes-devtools/qemu/qemu.inc > +++ b/meta/recipes-devtools/qemu/qemu.inc > @@ -74,15 +74,15 @@ PACKAGECONFIG ??= " \ > fdt sdl kvm \ > ${@bb.utils.filter('DISTRO_FEATURES', 'alsa xen', d)} \ > " > -PACKAGECONFIG_class-native ??= "fdt alsa kvm" > -PACKAGECONFIG_class-nativesdk ??= "fdt sdl kvm" > +PACKAGECONFIG_class-native ??= "fdt alsa kvm virglrenderer glx" > +PACKAGECONFIG_class-nativesdk ??= "fdt sdl kvm virglrenderer glx" > > # Handle distros such as CentOS 5 32-bit that do not have kvm > support > PACKAGECONFIG_class-native_remove = "${@'kvm' if not > os.path.exists('/usr/include/linux/kvm.h') else ''}" > > -# Disable kvm on targets that do not support it > -PACKAGECONFIG_remove_darwin = "kvm" > -PACKAGECONFIG_remove_mingw32 = "kvm" > +# Disable kvm/virgl/mesa on targets that do not support it > +PACKAGECONFIG_remove_darwin = "kvm virglrenderer glx gtk+" > +PACKAGECONFIG_remove_mingw32 = "kvm virglrenderer glx gtk+" Sorry, I just spotted this. Please don't use _remove in OE-Core. Can we rearrange this so we don't need to use remove? I appreciate there are other users that have crept in but I'd like to see them gone too... Cheers, Richard -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 02/12] qemu: enable virglrenderer and glx options for native/nativesdk builds
On Sat, 9 Feb 2019 at 10:32, Martin Jansa wrote: > Does enabling virglrenderer and glx do anything useful without any UI? > If not then I guess it should be enabled directly here or all 3 enabled > only in the poky's local.conf. Yes, absolutely. You can instruct qemu to render to an off-screen buffer, and access that with vnc, even across the network (and maybe spice will work too, I didn't try :). I explained this in the cover letter... Alex -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 02/12] qemu: enable virglrenderer and glx options for native/nativesdk builds
On Sat, Feb 09, 2019 at 12:32:13AM +0100, Alexander Kanavin wrote: > On Sat, 9 Feb 2019 at 00:12, Martin Jansa wrote: > > > " > > > -PACKAGECONFIG_class-native ??= "fdt alsa kvm" > > > -PACKAGECONFIG_class-nativesdk ??= "fdt sdl kvm" > > > +PACKAGECONFIG_class-native ??= "fdt alsa kvm virglrenderer glx" > > > +PACKAGECONFIG_class-nativesdk ??= "fdt sdl kvm virglrenderer glx" > > > > Didn't you want to enable gtk+ here as well? > > Nope; it's enabled in a separate patch in meta-poky/local.conf > template, in the same way as sdl is enabled there currently. > > On the other hand... maybe we can just simplify it all, and enable gtk > directly in the recipe. Does enabling virglrenderer and glx do anything useful without any UI? If not then I guess it should be enabled directly here or all 3 enabled only in the poky's local.conf. I haven't tried egl-headless+spice on this patchset yet, maybe that's the combination I'm looking for. Regards, -- Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com signature.asc Description: Digital signature -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 02/12] qemu: enable virglrenderer and glx options for native/nativesdk builds
On Sat, 9 Feb 2019 at 00:12, Martin Jansa wrote: > > " > > -PACKAGECONFIG_class-native ??= "fdt alsa kvm" > > -PACKAGECONFIG_class-nativesdk ??= "fdt sdl kvm" > > +PACKAGECONFIG_class-native ??= "fdt alsa kvm virglrenderer glx" > > +PACKAGECONFIG_class-nativesdk ??= "fdt sdl kvm virglrenderer glx" > > Didn't you want to enable gtk+ here as well? Nope; it's enabled in a separate patch in meta-poky/local.conf template, in the same way as sdl is enabled there currently. On the other hand... maybe we can just simplify it all, and enable gtk directly in the recipe. Alex -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 02/12] qemu: enable virglrenderer and glx options for native/nativesdk builds
On Fri, Feb 08, 2019 at 03:45:43PM +0100, Alexander Kanavin wrote: > Except for ming32/darwin, which do not support them. > > Signed-off-by: Alexander Kanavin > --- > meta/recipes-devtools/qemu/qemu.inc | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/meta/recipes-devtools/qemu/qemu.inc > b/meta/recipes-devtools/qemu/qemu.inc > index c127434b020..95e9e0ede77 100644 > --- a/meta/recipes-devtools/qemu/qemu.inc > +++ b/meta/recipes-devtools/qemu/qemu.inc > @@ -74,15 +74,15 @@ PACKAGECONFIG ??= " \ > fdt sdl kvm \ > ${@bb.utils.filter('DISTRO_FEATURES', 'alsa xen', d)} \ > " > -PACKAGECONFIG_class-native ??= "fdt alsa kvm" > -PACKAGECONFIG_class-nativesdk ??= "fdt sdl kvm" > +PACKAGECONFIG_class-native ??= "fdt alsa kvm virglrenderer glx" > +PACKAGECONFIG_class-nativesdk ??= "fdt sdl kvm virglrenderer glx" Didn't you want to enable gtk+ here as well? > # Handle distros such as CentOS 5 32-bit that do not have kvm support > PACKAGECONFIG_class-native_remove = "${@'kvm' if not > os.path.exists('/usr/include/linux/kvm.h') else ''}" > > -# Disable kvm on targets that do not support it > -PACKAGECONFIG_remove_darwin = "kvm" > -PACKAGECONFIG_remove_mingw32 = "kvm" > +# Disable kvm/virgl/mesa on targets that do not support it > +PACKAGECONFIG_remove_darwin = "kvm virglrenderer glx gtk+" > +PACKAGECONFIG_remove_mingw32 = "kvm virglrenderer glx gtk+" > > PACKAGECONFIG[sdl] = "--enable-sdl --with-sdlabi=2.0,--disable-sdl,libsdl2" > PACKAGECONFIG[virtfs] = "--enable-virtfs > --enable-attr,--disable-virtfs,libcap attr," > -- > 2.17.1 > > -- > ___ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core -- Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com signature.asc Description: Digital signature -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core