Re: [OE-core] [PATCH 1/2] conf/bitbake.conf: include ed in hosttools

2017-05-19 Thread Burton, Ross 
On 19 May 2017 at 13:54, Jose Lamego  wrote:

> This patch is a requisite for the bc recipe update from 1.06 to 1.07.1,
> which fails due to ed command not found during building.
>

I just replied to the bc patch, the new version is broken in several
interesting ways.

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/2] conf/bitbake.conf: include ed in hosttools

2017-05-19 Thread Richard Purdie 
On Fri, 2017-05-19 at 12:56 +0100, Burton, Ross wrote:
> 
> On 19 May 2017 at 10:02, Anders Darander 
> wrote:
> > As fas as I can (in a recent kernel), whoami is only used in
> > scripts/mkcompile_h. And there, it's only used if
> > $KBUILD_BUILD_USER is
> > empty. I'd rather see that we set $KBUILD_BUILD_USER to something
> > deterministic in our kernel.bbclass.
> > 
> Definitely this.

Agreed, I've mentioned this would be preferred already. I'm just living
in hope someone sends a patch!

-- 
RP
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/2] conf/bitbake.conf: include ed in hosttools

2017-05-19 Thread Jose Lamego 


On 05/19/2017 04:02 AM, Anders Darander wrote:
> * Khem Raj  [170519 01:17]:
> 
>> On Thu, May 18, 2017 at 4:12 PM, Richard Purdie
>>  wrote:
>>> On Thu, 2017-05-18 at 17:28 -0500, Jose Lamego wrote:
 Some recipes build fail due to missing ed command.
> 
 This change includes ed to the hosttools required to
 run builds with oe-core.
> 
 Signed-off-by: Jose Lamego 
 Signed-off-by: Leonardo Sandoval 
> 
>>> We really don't want to add ed here. Which recipes are failing and why
>>> do we need ed to build them?

This patch is a requisite for the bc recipe update from 1.06 to 1.07.1,
which fails due to ed command not found during building.

> 
>> we also need whoami which kernel uses to identify the build user id
> 
> 
> No, we don't want to add whoami...
> 
> As fas as I can (in a recent kernel), whoami is only used in
> scripts/mkcompile_h. And there, it's only used if $KBUILD_BUILD_USER is
> empty. I'd rather see that we set $KBUILD_BUILD_USER to something
> deterministic in our kernel.bbclass.
> 
> Cheers,
> Anders
> 

-- 
Jose Lamego | OTC Embedded Platforms & Tools | GDC



signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/2] conf/bitbake.conf: include ed in hosttools

2017-05-19 Thread Burton, Ross 
On 19 May 2017 at 10:02, Anders Darander  wrote:

> As fas as I can (in a recent kernel), whoami is only used in
> scripts/mkcompile_h. And there, it's only used if $KBUILD_BUILD_USER is
> empty. I'd rather see that we set $KBUILD_BUILD_USER to something
> deterministic in our kernel.bbclass.
>

Definitely this.

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/2] conf/bitbake.conf: include ed in hosttools

2017-05-19 Thread Anders Darander 
* Khem Raj  [170519 01:17]:

> On Thu, May 18, 2017 at 4:12 PM, Richard Purdie
>  wrote:
> > On Thu, 2017-05-18 at 17:28 -0500, Jose Lamego wrote:
> >> Some recipes build fail due to missing ed command.

> >> This change includes ed to the hosttools required to
> >> run builds with oe-core.

> >> Signed-off-by: Jose Lamego 
> >> Signed-off-by: Leonardo Sandoval  >> tel.com>

> > We really don't want to add ed here. Which recipes are failing and why
> > do we need ed to build them?

> we also need whoami which kernel uses to identify the build user id


No, we don't want to add whoami...

As fas as I can (in a recent kernel), whoami is only used in
scripts/mkcompile_h. And there, it's only used if $KBUILD_BUILD_USER is
empty. I'd rather see that we set $KBUILD_BUILD_USER to something
deterministic in our kernel.bbclass.

Cheers,
Anders

-- 
Anders Darander, Senior System Architect
ChargeStorm AB / eStorm AB
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/2] conf/bitbake.conf: include ed in hosttools

2017-05-18 Thread Khem Raj 
On Thu, May 18, 2017 at 4:12 PM, Richard Purdie
 wrote:
> On Thu, 2017-05-18 at 17:28 -0500, Jose Lamego wrote:
>> Some recipes build fail due to missing ed command.
>>
>> This change includes ed to the hosttools required to
>> run builds with oe-core.
>>
>> Signed-off-by: Jose Lamego 
>> Signed-off-by: Leonardo Sandoval > tel.com>
>
> We really don't want to add ed here. Which recipes are failing and why
> do we need ed to build them?

we also need whoami which kernel uses to identify the build user id

>
> Cheers,
>
> Richard
>
>
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/2] conf/bitbake.conf: include ed in hosttools

2017-05-18 Thread Richard Purdie 
On Thu, 2017-05-18 at 17:28 -0500, Jose Lamego wrote:
> Some recipes build fail due to missing ed command.
> 
> This change includes ed to the hosttools required to
> run builds with oe-core.
> 
> Signed-off-by: Jose Lamego 
> Signed-off-by: Leonardo Sandoval  tel.com>

We really don't want to add ed here. Which recipes are failing and why
do we need ed to build them? 

Cheers,

Richard


-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core