Re: [OE-core] [PATCH 2/2] mdadm: Disable ptest
None of the recipes in oe-core set PTEST_ENABLED, they only read it to determine build settings. If recipes in other layers do that, it's a mistake. Alex On Mon, 22 Jan 2024 at 11:28, Pavel Zhukov wrote: > > Yes, Yoann has mentioned this already. > Seems like recipes use both PTEST_ENABLED and PTESTS_PROBLEMS for this > purposes and I've not found any documentation. I'll update the patch to use > PTESTS_PROBLEMS instead > > -- > Pavel > > On Mon, Jan 22, 2024, at 11:21, Alexander Kanavin wrote: > > On Mon, 22 Jan 2024 at 09:55, Pavel Zhukov wrote: > > mdadm tests are flaky and cause a lot of failures on autobuilder. > > Disable them for now. Keeping ptest code in the recipe to fix/enable > > in the future > > SRC_URI = > > "git://git.kernel.org/pub/scm/utils/mdadm/mdadm.git;protocol=https;branch=master > > \ > > - file://run-ptest \ > > +# Disable ptests for now as they're flaky > > +# but keeping ptest code in case we want to enable them in the future > > +PTEST_ENABLED="0" > > +SRC_URI:append = "${@bb.utils.contains('PTEST_ENABLED', '1', ' > > file://run-ptest', '', d)}" > > The correct way to do this is to modify > conf/distro/include/ptest-packagelists.inc. There's a specific > exclusion list made for that purpose in there at the end. > > Alex > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#194138): https://lists.openembedded.org/g/openembedded-core/message/194138 Mute This Topic: https://lists.openembedded.org/mt/103882792/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 2/2] mdadm: Disable ptest
Yes, Yoann has mentioned this already. Seems like recipes use both PTEST_ENABLED and PTESTS_PROBLEMS for this purposes and I've not found any documentation. I'll update the patch to use PTESTS_PROBLEMS instead -- Pavel On Mon, Jan 22, 2024, at 11:21, Alexander Kanavin wrote: > On Mon, 22 Jan 2024 at 09:55, Pavel Zhukov wrote: > > mdadm tests are flaky and cause a lot of failures on autobuilder. > > Disable them for now. Keeping ptest code in the recipe to fix/enable > > in the future > > SRC_URI = > > "git://git.kernel.org/pub/scm/utils/mdadm/mdadm.git;protocol=https;branch=master > > \ > > - file://run-ptest \ > > +# Disable ptests for now as they're flaky > > +# but keeping ptest code in case we want to enable them in the future > > +PTEST_ENABLED="0" > > +SRC_URI:append = "${@bb.utils.contains('PTEST_ENABLED', '1', ' > > file://run-ptest', '', d)}" > > The correct way to do this is to modify > conf/distro/include/ptest-packagelists.inc. There's a specific > exclusion list made for that purpose in there at the end. > > Alex > > > > > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#194137): https://lists.openembedded.org/g/openembedded-core/message/194137 Mute This Topic: https://lists.openembedded.org/mt/103882792/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 2/2] mdadm: Disable ptest
Le lun. 22 janv. 2024 à 11:21, Alexander Kanavin a écrit : > On Mon, 22 Jan 2024 at 09:55, Pavel Zhukov wrote: > > mdadm tests are flaky and cause a lot of failures on autobuilder. > > Disable them for now. Keeping ptest code in the recipe to fix/enable > > in the future > > SRC_URI = "git:// > git.kernel.org/pub/scm/utils/mdadm/mdadm.git;protocol=https;branch=master > \ > > - file://run-ptest \ > > +# Disable ptests for now as they're flaky > > +# but keeping ptest code in case we want to enable them in the future > > +PTEST_ENABLED="0" > > +SRC_URI:append = "${@bb.utils.contains('PTEST_ENABLED', '1', ' > file://run-ptest', '', d)}" > > The correct way to do this is to modify > conf/distro/include/ptest-packagelists.inc. There's a specific > exclusion list made for that purpose in there at the end. > (Oops I've previously answered to Pavel in private, sorry :( ) I guess you are talking about PTESTS_PROBLEMS => https://git.openembedded.org/openembedded-core/tree/meta/conf/distro/include/ptest-packagelists.inc#n142 Regards, Alex > > > > -- Yoann Congal Smile ECS - Tech expert -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#194136): https://lists.openembedded.org/g/openembedded-core/message/194136 Mute This Topic: https://lists.openembedded.org/mt/103882792/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 2/2] mdadm: Disable ptest
On Mon, 22 Jan 2024 at 09:55, Pavel Zhukov wrote: > mdadm tests are flaky and cause a lot of failures on autobuilder. > Disable them for now. Keeping ptest code in the recipe to fix/enable > in the future > SRC_URI = > "git://git.kernel.org/pub/scm/utils/mdadm/mdadm.git;protocol=https;branch=master > \ > - file://run-ptest \ > +# Disable ptests for now as they're flaky > +# but keeping ptest code in case we want to enable them in the future > +PTEST_ENABLED="0" > +SRC_URI:append = "${@bb.utils.contains('PTEST_ENABLED', '1', ' > file://run-ptest', '', d)}" The correct way to do this is to modify conf/distro/include/ptest-packagelists.inc. There's a specific exclusion list made for that purpose in there at the end. Alex -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#194135): https://lists.openembedded.org/g/openembedded-core/message/194135 Mute This Topic: https://lists.openembedded.org/mt/103882792/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-