Re: [OE-core] [PATCH 2/3] gnupg: Make the version consistent
Thanks Richard and Ross's comments! I will try to send the patch to the upstream. Thanks, On 1/20/24 01:41, Ross Burton wrote: CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe. On 19 Jan 2024, at 11:33, Yu, Mingli via lists.openembedded.org wrote: file://0004-autogen.sh-fix-find-version-for-beta-checking.patch \ file://0001-Woverride-init-is-not-needed-with-gcc-9.patch \ file://fix-ldap.patch \ + file://0001-autogen.sh-Remove-the-unknown-suffix.patch \ 0004-autogen.sh-fix-find-version-for-beta-checking.patch already does something similar, so the patches should be merged instead of having a series of incremental fixes. Also, as RP said, engaging with upstream here would be good. Ross -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#194113): https://lists.openembedded.org/g/openembedded-core/message/194113 Mute This Topic: https://lists.openembedded.org/mt/103827979/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 2/3] gnupg: Make the version consistent
> On 19 Jan 2024, at 11:33, Yu, Mingli via lists.openembedded.org > wrote: >file://0004-autogen.sh-fix-find-version-for-beta-checking.patch \ >file://0001-Woverride-init-is-not-needed-with-gcc-9.patch \ >file://fix-ldap.patch \ > + file://0001-autogen.sh-Remove-the-unknown-suffix.patch \ 0004-autogen.sh-fix-find-version-for-beta-checking.patch already does something similar, so the patches should be merged instead of having a series of incremental fixes. Also, as RP said, engaging with upstream here would be good. Ross -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#194060): https://lists.openembedded.org/g/openembedded-core/message/194060 Mute This Topic: https://lists.openembedded.org/mt/103827979/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 2/3] gnupg: Make the version consistent
On Fri, 2024-01-19 at 19:33 +0800, Yu, Mingli wrote: > From: Mingli Yu > > The commit [b67e4e523 Improve the beta number generation.] [1] > extends the version to make it work well for no release version, > but it introduces the version inconsistency. > > Considering we mainly use a release version in oe, so remove the > added suffix to keep consistent. > > Before the patch: > # rpm -qa | grep gnupg > gnupg-gpg-2.4.3-r0.core2_64 > gnupg-2.4.3-r0.core2_64 > # gpgv --version > gpgv (GnuPG) 2.4.3-unknown > [snip] > > After the patch: > # rpm -qa | grep gnupg > gnupg-gpg-2.4.3-r0.core2_64 > gnupg-2.4.3-r0.core2_64 > # gpgv --version > gpgv (GnuPG) 2.4.3 > [snip] > > [1] > https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=blobdiff;f=autogen.sh;h=2b0a5dc51a7386ef90ff6c8358d26b9cc65c0c72;hp=471193c2af6a298fdde466950061dd890feb230e;hb=b67e4e523e6d19d384e23c5bb03010caebd150e7;hpb=518d835380a2ae01d6a9cc19de92684baade96a4 > > Signed-off-by: Mingli Yu > --- > ...autogen.sh-Remove-the-unknown-suffix.patch | 43 +++ > meta/recipes-support/gnupg/gnupg_2.4.3.bb | 1 + > 2 files changed, 44 insertions(+) > create mode 100644 > meta/recipes-support/gnupg/gnupg/0001-autogen.sh-Remove-the-unknown-suffix.patch We're not carrying a patch to do this, particularly one marked as not suitable for upstream. Please work with upstream to fix the version shown when you build a release tarball. Same for the other patch, 3/3. Cheers, Richard -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#194033): https://lists.openembedded.org/g/openembedded-core/message/194033 Mute This Topic: https://lists.openembedded.org/mt/103827979/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
