subject:"Re\: \[OE\-core\] \[PATCH 3\/4 v3\] valgrind\: don't restrict to armv7a"

Re: [OE-core] [PATCH 3/4 v3] valgrind: don't restrict to armv7a

2015-12-17 Thread Khem Raj


> On Dec 17, 2015, at 9:56 PM, Andre McCurdy  wrote:
> 
> On Thu, Dec 17, 2015 at 9:17 PM, Khem Raj  wrote:
>> 
>>> On Dec 17, 2015, at 8:42 PM, Andre McCurdy  wrote:
>>> 
>>> Valgrind has been tested on armv5te/qemuarm, so it seems
>>> that valgrind's configure check for armv7 is over cautious.
>>> 
>>> Signed-off-by: Andre McCurdy 
>>> ---
>>> meta/recipes-devtools/valgrind/valgrind_3.11.0.bb | 8 +---
>>> 1 file changed, 5 insertions(+), 3 deletions(-)
>>> 
>>> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb 
>>> b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
>>> index 3dc3cc1..bb3f6e1 100644
>>> --- a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
>>> +++ b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
>>> @@ -26,14 +26,16 @@ SRC_URI = 
>>> "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
>>> SRC_URI[md5sum] = "4ea62074da73ae82e0162d6550d3f129"
>>> SRC_URI[sha256sum] = 
>>> "6c396271a8c1ddd5a6fb9abe714ea1e8a86fce85b30ab26b4266aeb4c2413b42"
>>> 
>>> -COMPATIBLE_HOST = '(i.86|x86_64|mips|powerpc|powerpc64).*-linux'
>>> -COMPATIBLE_HOST_armv7a = 'arm.*-linux'
>>> +COMPATIBLE_HOST = '(i.86|x86_64|arm|mips|powerpc|powerpc64).*-linux'
>>> 
>>> inherit autotools ptest
>>> 
>>> EXTRA_OECONF = "--enable-tls --without-mpicc"
>>> -EXTRA_OECONF_armv7a = "--enable-tls -host=armv7-none-linux-gnueabi 
>>> --without-mpicc"
>>> EXTRA_OECONF += 
>>> "${@['--enable-only32bit','--enable-only64bit'][d.getVar('SITEINFO_BITS', 
>>> True) != '32']}"
>>> +
>>> +# valgrind checks host_cpu "armv7*)", so we need to over-ride the 
>>> autotools.bbclass default --host option
>>> +EXTRA_OECONF_append_arm = " --host=armv7${HOST_VENDOR}-${HOST_OS}”
>> 
>> this could be problematic for arm < v7
> 
> The configure script will give an error if ${host_cpu} doesn't begin
> with "armv7", so we either have to provide this kind of fake --host
> option or patch the configure script.

How is it working right now ?

> 
> Do you think patching the configure script would be better ?

that could be better since we will get failure.

> 
>> 
>>> EXTRA_OEMAKE = "-w"
>>> 
>>> do_install_append () {
>>> --
>>> 1.9.1
>>> 
>>> --
>>> ___
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>> 



signature.asc
Description: Message signed with OpenPGP using GPGMail
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 3/4 v3] valgrind: don't restrict to armv7a

2015-12-17 Thread Andre McCurdy

On Thu, Dec 17, 2015 at 10:00 PM, Khem Raj  wrote:
>
>> On Dec 17, 2015, at 9:56 PM, Andre McCurdy  wrote:
>>
>> On Thu, Dec 17, 2015 at 9:17 PM, Khem Raj  wrote:
>>>
 On Dec 17, 2015, at 8:42 PM, Andre McCurdy  wrote:

 Valgrind has been tested on armv5te/qemuarm, so it seems
 that valgrind's configure check for armv7 is over cautious.

 Signed-off-by: Andre McCurdy 
 ---
 meta/recipes-devtools/valgrind/valgrind_3.11.0.bb | 8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

 diff --git a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb 
 b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
 index 3dc3cc1..bb3f6e1 100644
 --- a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
 +++ b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
 @@ -26,14 +26,16 @@ SRC_URI = 
 "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
 SRC_URI[md5sum] = "4ea62074da73ae82e0162d6550d3f129"
 SRC_URI[sha256sum] = 
 "6c396271a8c1ddd5a6fb9abe714ea1e8a86fce85b30ab26b4266aeb4c2413b42"

 -COMPATIBLE_HOST = '(i.86|x86_64|mips|powerpc|powerpc64).*-linux'
 -COMPATIBLE_HOST_armv7a = 'arm.*-linux'
 +COMPATIBLE_HOST = '(i.86|x86_64|arm|mips|powerpc|powerpc64).*-linux'

 inherit autotools ptest

 EXTRA_OECONF = "--enable-tls --without-mpicc"
 -EXTRA_OECONF_armv7a = "--enable-tls -host=armv7-none-linux-gnueabi 
 --without-mpicc"
 EXTRA_OECONF += 
 "${@['--enable-only32bit','--enable-only64bit'][d.getVar('SITEINFO_BITS', 
 True) != '32']}"
 +
 +# valgrind checks host_cpu "armv7*)", so we need to over-ride the 
 autotools.bbclass default --host option
 +EXTRA_OECONF_append_arm = " --host=armv7${HOST_VENDOR}-${HOST_OS}”
>>>
>>> this could be problematic for arm < v7
>>
>> The configure script will give an error if ${host_cpu} doesn't begin
>> with "armv7", so we either have to provide this kind of fake --host
>> option or patch the configure script.
>
> How is it working right now ?

Up to now the recipe has been forcing "--host=armv7-..." via
EXTRA_OECONF. That hasn't changed.

The thing that's changed is that previously you couldn't build for any
ARM target other than armv7a, now you can.

>>
>> Do you think patching the configure script would be better ?
>
> that could be better since we will get failure.
>
>>
>>>
 EXTRA_OEMAKE = "-w"

 do_install_append () {
 --
 1.9.1

 --
 ___
 Openembedded-core mailing list
 Openembedded-core@lists.openembedded.org
 http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>
>
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 3/4 v3] valgrind: don't restrict to armv7a

2015-12-17 Thread Andre McCurdy

On Thu, Dec 17, 2015 at 9:17 PM, Khem Raj  wrote:
>
>> On Dec 17, 2015, at 8:42 PM, Andre McCurdy  wrote:
>>
>> Valgrind has been tested on armv5te/qemuarm, so it seems
>> that valgrind's configure check for armv7 is over cautious.
>>
>> Signed-off-by: Andre McCurdy 
>> ---
>> meta/recipes-devtools/valgrind/valgrind_3.11.0.bb | 8 +---
>> 1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb 
>> b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
>> index 3dc3cc1..bb3f6e1 100644
>> --- a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
>> +++ b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
>> @@ -26,14 +26,16 @@ SRC_URI = 
>> "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
>> SRC_URI[md5sum] = "4ea62074da73ae82e0162d6550d3f129"
>> SRC_URI[sha256sum] = 
>> "6c396271a8c1ddd5a6fb9abe714ea1e8a86fce85b30ab26b4266aeb4c2413b42"
>>
>> -COMPATIBLE_HOST = '(i.86|x86_64|mips|powerpc|powerpc64).*-linux'
>> -COMPATIBLE_HOST_armv7a = 'arm.*-linux'
>> +COMPATIBLE_HOST = '(i.86|x86_64|arm|mips|powerpc|powerpc64).*-linux'
>>
>> inherit autotools ptest
>>
>> EXTRA_OECONF = "--enable-tls --without-mpicc"
>> -EXTRA_OECONF_armv7a = "--enable-tls -host=armv7-none-linux-gnueabi 
>> --without-mpicc"
>> EXTRA_OECONF += 
>> "${@['--enable-only32bit','--enable-only64bit'][d.getVar('SITEINFO_BITS', 
>> True) != '32']}"
>> +
>> +# valgrind checks host_cpu "armv7*)", so we need to over-ride the 
>> autotools.bbclass default --host option
>> +EXTRA_OECONF_append_arm = " --host=armv7${HOST_VENDOR}-${HOST_OS}”
>
> this could be problematic for arm < v7

The configure script will give an error if ${host_cpu} doesn't begin
with "armv7", so we either have to provide this kind of fake --host
option or patch the configure script.

Do you think patching the configure script would be better ?

>
>> EXTRA_OEMAKE = "-w"
>>
>> do_install_append () {
>> --
>> 1.9.1
>>
>> --
>> ___
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 3/4 v3] valgrind: don't restrict to armv7a

2015-12-17 Thread Khem Raj


> On Dec 17, 2015, at 8:42 PM, Andre McCurdy  wrote:
> 
> Valgrind has been tested on armv5te/qemuarm, so it seems
> that valgrind's configure check for armv7 is over cautious.
> 
> Signed-off-by: Andre McCurdy 
> ---
> meta/recipes-devtools/valgrind/valgrind_3.11.0.bb | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb 
> b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
> index 3dc3cc1..bb3f6e1 100644
> --- a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
> +++ b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
> @@ -26,14 +26,16 @@ SRC_URI = 
> "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
> SRC_URI[md5sum] = "4ea62074da73ae82e0162d6550d3f129"
> SRC_URI[sha256sum] = 
> "6c396271a8c1ddd5a6fb9abe714ea1e8a86fce85b30ab26b4266aeb4c2413b42"
> 
> -COMPATIBLE_HOST = '(i.86|x86_64|mips|powerpc|powerpc64).*-linux'
> -COMPATIBLE_HOST_armv7a = 'arm.*-linux'
> +COMPATIBLE_HOST = '(i.86|x86_64|arm|mips|powerpc|powerpc64).*-linux'
> 
> inherit autotools ptest
> 
> EXTRA_OECONF = "--enable-tls --without-mpicc"
> -EXTRA_OECONF_armv7a = "--enable-tls -host=armv7-none-linux-gnueabi 
> --without-mpicc"
> EXTRA_OECONF += 
> "${@['--enable-only32bit','--enable-only64bit'][d.getVar('SITEINFO_BITS', 
> True) != '32']}"
> +
> +# valgrind checks host_cpu "armv7*)", so we need to over-ride the 
> autotools.bbclass default --host option
> +EXTRA_OECONF_append_arm = " --host=armv7${HOST_VENDOR}-${HOST_OS}”

this could be problematic for arm < v7

> +

> EXTRA_OEMAKE = "-w"
> 
> do_install_append () {
> --
> 1.9.1
> 
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



signature.asc
Description: Message signed with OpenPGP using GPGMail
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 3/4 v3] valgrind: don't restrict to armv7a

Re: [OE-core] [PATCH 3/4 v3] valgrind: don't restrict to armv7a

Re: [OE-core] [PATCH 3/4 v3] valgrind: don't restrict to armv7a

Re: [OE-core] [PATCH 3/4 v3] valgrind: don't restrict to armv7a

4 matches

Site Navigation

Mail list logo

Footer information