Re: [OE-core] [PATCH v2 1/4] polkit 0.104: convert pam code to PACKAGECONFIG and adhere to OE recipe styleguide
Op 5 mrt. 2012, om 22:14 heeft Richard Purdie het volgende geschreven:
> On Mon, 2012-03-05 at 08:38 +0100, Koen Kooi wrote:
>> Signed-off-by: Koen Kooi
>> ---
>> meta/recipes-extended/polkit/polkit_0.104.bb | 25 +++--
>> 1 files changed, 15 insertions(+), 10 deletions(-)
>>
>> diff --git a/meta/recipes-extended/polkit/polkit_0.104.bb
>> b/meta/recipes-extended/polkit/polkit_0.104.bb
>> index 2737a4a..5dc82c5 100644
>> --- a/meta/recipes-extended/polkit/polkit_0.104.bb
>> +++ b/meta/recipes-extended/polkit/polkit_0.104.bb
>> @@ -6,28 +6,33 @@ LIC_FILES_CHKSUM =
>> "file://COPYING;md5=155db86cdbafa7532b41f390409283eb \
>>
>> file://src/polkit/polkit.h;beginline=1;endline=20;md5=0a8630b0133176d0504c87a0ded39db4
>> \
>>
>> file://docs/polkit/html/license.html;md5=d85a36709a446c10f4ee123f9dda0e38"
>>
>> +DEPENDS = "expat dbus-glib eggdbus intltool-native"
>> +
>> +PACKAGECONFIG = "${@base_contains('DISTRO_FEATURES', 'pam', 'pam', '', d)}"
>> +PACKAGECONFIG[pam] = "--with-authfw=pam,--with-authfw=none,libpam,libpam"
>> +
>
> After this merged I found a few issues on the autobuilder. There were
> two problems. If DISTRO_FEATURES didn't contain pam and was empty, the
> PACKAGECONFIG code would not trigger at all (and not add the
> authfw=none). Secondly, I think we need "shadow", not "none" as
> otherwise the builds fail due to an invalid configuration.
I've thought about that, but if we choose 'shadow', we need to add (R)DEPENDS
for it to work properly. So 'none' seems like the best option.
Anyway, how can I take over maintainership of polkit, I'm getting tired of
every commit breaking it subtly and taking another week of my time finding out
that $random error is actually caused by polkit deep down. It's like dbus,
breakage does not always point to the culprit.
Takes this one for example:
http://cgit.openembedded.org/openembedded-core/commit/meta/recipes-extended/polkit?id=6bc6406b019ebc104a4abfb15c2d2e1263968664
PAM is hardcoded to be enabled, but you'll only get a working config if you put
it in DISTRO_FEATURES.
regards,
Koen
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH v2 1/4] polkit 0.104: convert pam code to PACKAGECONFIG and adhere to OE recipe styleguide
Op 5 mrt. 2012, om 22:16 heeft Koen Kooi het volgende geschreven:
>
> Op 5 mrt. 2012, om 22:14 heeft Richard Purdie het volgende geschreven:
>
>> On Mon, 2012-03-05 at 08:38 +0100, Koen Kooi wrote:
>>> Signed-off-by: Koen Kooi
>>> ---
>>> meta/recipes-extended/polkit/polkit_0.104.bb | 25
>>> +++--
>>> 1 files changed, 15 insertions(+), 10 deletions(-)
>>>
>>> diff --git a/meta/recipes-extended/polkit/polkit_0.104.bb
>>> b/meta/recipes-extended/polkit/polkit_0.104.bb
>>> index 2737a4a..5dc82c5 100644
>>> --- a/meta/recipes-extended/polkit/polkit_0.104.bb
>>> +++ b/meta/recipes-extended/polkit/polkit_0.104.bb
>>> @@ -6,28 +6,33 @@ LIC_FILES_CHKSUM =
>>> "file://COPYING;md5=155db86cdbafa7532b41f390409283eb \
>>>
>>> file://src/polkit/polkit.h;beginline=1;endline=20;md5=0a8630b0133176d0504c87a0ded39db4
>>> \
>>>
>>> file://docs/polkit/html/license.html;md5=d85a36709a446c10f4ee123f9dda0e38"
>>>
>>> +DEPENDS = "expat dbus-glib eggdbus intltool-native"
>>> +
>>> +PACKAGECONFIG = "${@base_contains('DISTRO_FEATURES', 'pam', 'pam', '', d)}"
>>> +PACKAGECONFIG[pam] = "--with-authfw=pam,--with-authfw=none,libpam,libpam"
>>> +
>>
>> After this merged I found a few issues on the autobuilder. There were
>> two problems. If DISTRO_FEATURES didn't contain pam and was empty, the
>> PACKAGECONFIG code would not trigger at all (and not add the
>> authfw=none).
>
> Beth mailed me the log and I asked her is PACKAGECONFIG is broken, and it
> seems it is since the --disable-foo isn't triggering. Or have I misunderstood
> how PACKAGECONFIG is supposed to work?
http://cgit.openembedded.org/openembedded-core/commit/?id=d7b8c247227f3cc82f92292407f548927e9fde78
:)
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH v2 1/4] polkit 0.104: convert pam code to PACKAGECONFIG and adhere to OE recipe styleguide
Op 5 mrt. 2012, om 22:14 heeft Richard Purdie het volgende geschreven:
> On Mon, 2012-03-05 at 08:38 +0100, Koen Kooi wrote:
>> Signed-off-by: Koen Kooi
>> ---
>> meta/recipes-extended/polkit/polkit_0.104.bb | 25 +++--
>> 1 files changed, 15 insertions(+), 10 deletions(-)
>>
>> diff --git a/meta/recipes-extended/polkit/polkit_0.104.bb
>> b/meta/recipes-extended/polkit/polkit_0.104.bb
>> index 2737a4a..5dc82c5 100644
>> --- a/meta/recipes-extended/polkit/polkit_0.104.bb
>> +++ b/meta/recipes-extended/polkit/polkit_0.104.bb
>> @@ -6,28 +6,33 @@ LIC_FILES_CHKSUM =
>> "file://COPYING;md5=155db86cdbafa7532b41f390409283eb \
>>
>> file://src/polkit/polkit.h;beginline=1;endline=20;md5=0a8630b0133176d0504c87a0ded39db4
>> \
>>
>> file://docs/polkit/html/license.html;md5=d85a36709a446c10f4ee123f9dda0e38"
>>
>> +DEPENDS = "expat dbus-glib eggdbus intltool-native"
>> +
>> +PACKAGECONFIG = "${@base_contains('DISTRO_FEATURES', 'pam', 'pam', '', d)}"
>> +PACKAGECONFIG[pam] = "--with-authfw=pam,--with-authfw=none,libpam,libpam"
>> +
>
> After this merged I found a few issues on the autobuilder. There were
> two problems. If DISTRO_FEATURES didn't contain pam and was empty, the
> PACKAGECONFIG code would not trigger at all (and not add the
> authfw=none).
Beth mailed me the log and I asked her is PACKAGECONFIG is broken, and it seems
it is since the --disable-foo isn't triggering. Or have I misunderstood how
PACKAGECONFIG is supposed to work?
regards,
Koen
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH v2 1/4] polkit 0.104: convert pam code to PACKAGECONFIG and adhere to OE recipe styleguide
On Mon, 2012-03-05 at 08:38 +0100, Koen Kooi wrote:
> Signed-off-by: Koen Kooi
> ---
> meta/recipes-extended/polkit/polkit_0.104.bb | 25 +++--
> 1 files changed, 15 insertions(+), 10 deletions(-)
>
> diff --git a/meta/recipes-extended/polkit/polkit_0.104.bb
> b/meta/recipes-extended/polkit/polkit_0.104.bb
> index 2737a4a..5dc82c5 100644
> --- a/meta/recipes-extended/polkit/polkit_0.104.bb
> +++ b/meta/recipes-extended/polkit/polkit_0.104.bb
> @@ -6,28 +6,33 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=155db86cdbafa7532b41f390409283eb \
>
> file://src/polkit/polkit.h;beginline=1;endline=20;md5=0a8630b0133176d0504c87a0ded39db4
> \
>
> file://docs/polkit/html/license.html;md5=d85a36709a446c10f4ee123f9dda0e38"
>
> +DEPENDS = "expat dbus-glib eggdbus intltool-native"
> +
> +PACKAGECONFIG = "${@base_contains('DISTRO_FEATURES', 'pam', 'pam', '', d)}"
> +PACKAGECONFIG[pam] = "--with-authfw=pam,--with-authfw=none,libpam,libpam"
> +
After this merged I found a few issues on the autobuilder. There were
two problems. If DISTRO_FEATURES didn't contain pam and was empty, the
PACKAGECONFIG code would not trigger at all (and not add the
authfw=none). Secondly, I think we need "shadow", not "none" as
otherwise the builds fail due to an invalid configuration.
I've pushed the two fixes for this since builds were breaking.
Cheers,
Richard
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH v2 1/4] polkit 0.104: convert pam code to PACKAGECONFIG and adhere to OE recipe styleguide
On Mon, 2012-03-05 at 08:38 +0100, Koen Kooi wrote: > Signed-off-by: Koen Kooi > --- > meta/recipes-extended/polkit/polkit_0.104.bb | 25 +++-- > 1 files changed, 15 insertions(+), 10 deletions(-) Merged to master, thanks (patches 1-4). Cheers, Richard ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
