Re: [OE-core] [PATCH v2 5/5] rust: Enable rust oe-selftest.

2024-01-22 Thread Shinde, Yash via lists.openembedded.org 

[Edited Message Follows]

On 20-01-2024 22:31, Randy MacLeod wrote:



I like that you have broken the original patch down into 5 patches that
are easier to
understand.

On 2024-01-19 10:09 a.m., yash.shi...@windriver.com wrote:


From: Yash Shinde  ( yash.shi...@windriver.com )


Tests which are failing from below modules are added to exclude list

tests/run-make
tests/rustdoc
tests/mir-opt
tests/ui-fulldeps

*
Redundent test cases whose parent dir is also present in  exclud list are
removed.

* Newly addded tests are sorted and updated.

* Overall exclude
tests count in exclude list is now reduced to 114.


We need to resolve the mips32 problems that Richard pointed out.


Should we skip all the rust tests for mips32?




In previous oe-selftest implementation, we skipped rust tests for mips32.
I think we should continue with it as rust tests are unstable with mips32.







Please submit a v3 with the mips fix/avoidance and split this exclude list
commit down into 3 steps:

1. Sort the existing list of tests
2. Remove the test cases whose parent dir is also present in the exclude
list

3. Add the new tests that are to be excluded.



This may seem really pedantic but otherwise the changes are really hard to
review.



The way I think about this is that someone looking at the commit log might
be interested
in exactly which tests are in being added to the exclude list so that
should be clear from 3.
1. won't really be of interest so most people will skip over that
2. also won't be of interest to most people
but you need 1 and 2 to make 3 be apparent to people who want that info
quickly.




For 1 the existing list of tests are already sorted.
I will send a v3 with separate commits for:

1. newly added test cases
2. removing test cases whose parent dir is also present in the exclude list
3. sorting the overall final list

Regards,
Yash





Thanks,



../Randy



* The testing is done on arm32, arm64, mips64, x86 and  x86_64 targets.

Signed-off-by: Yash Shinde  (
yash.shi...@windriver.com )
---
 meta/lib/oeqa/selftest/cases/rust.py 
| 165 +
 meta/recipes-devtools/rust/rust-source.inc | 
4 +

 2 files changed, 43 insertions(+), 126 deletions(-)

diff --git
a/meta/lib/oeqa/selftest/cases/rust.py
b/meta/lib/oeqa/selftest/cases/rust.py
index 6dbc517006..7d0efb1b01 100644
--- a/meta/lib/oeqa/selftest/cases/rust.py
+++
b/meta/lib/oeqa/selftest/cases/rust.py
@@ -40,7 +40,7 @@ def
parse_results(filename):
 class
RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase):
   
def test_rust(self, *args, **kwargs):

 # Disable Rust Oe-selftest
-self.skipTest("The Rust Oe-selftest is disabled.")
+   
#self.skipTest("The Rust Oe-selftest is disabled.")
 
 # build

remote-test-server before image build
 recipe = "rust "
@@ -73,156 +73,90 @@ class
RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase):
   
'src/librustdoc',

 'src/rustdoc-json-types',
 
'src/tools/compiletest/src/common.rs',
+   
'src/tools/jsondoclint',

'src/tools/lint-docs',
+   
'src/tools/replace-version-placeholder',

'src/tools/rust-analyzer',

'src/tools/rustdoc-themes',

 'src/tools/tidy',
'tests/assembly/asm/aarch64-outline-atomics.rs',
+
'tests/codegen/abi-efiapi.rs',
+   
'tests/codegen/abi-efiapi.rs',

'tests/codegen/abi-main-signature-32bit-c-int.rs',
   
'tests/codegen/abi-repr-ext.rs',
+   
'tests/codegen/abi-sysv64.rs',

'tests/codegen/abi-x86-interrupt.rs',
+   
'tests/codegen/align-byval.rs',
+   
'tests/codegen/align-fn.rs',
+   
'tests/codegen/asm-powerpc-clobbers.rs',
+   
'tests/codegen/async-fn-debug-awaitee-field.rs',
+
'tests/codegen/binary-search-index-no-bound-check.rs',
   
'tests/codegen/branch-protection.rs',
+   
'tests/codegen/call-metadata.rs',

'tests/codegen/catch-unwind.rs',

'tests/codegen/cf-protection.rs',
+   
'tests/codegen/debug-column.rs',
+   
'tests/codegen/debug-limited.rs',
+   
'tests/codegen/debuginfo-generic-closure-env-names.rs',
+ 
'tests/codegen/drop.rs',
+   
'tests/codegen/dst-vtable-align-nonzero.rs',
+   
'tests/codegen/enable-lto-unit-splitting.rs',

'tests/codegen/enum-bounds-check-derived-idx.rs',
+   
'tests/codegen/enum/enum-u128.rs',
+

Re: [OE-core] [PATCH v2 5/5] rust: Enable rust oe-selftest.

2024-01-22 Thread Shinde, Yash via lists.openembedded.org 


On 20-01-2024 22:31, Randy MacLeod wrote:
I like that you have broken the original patch down into 5 patches 
that are easier to

understand.

On 2024-01-19 10:09 a.m., yash.shi...@windriver.com wrote:

From: Yash Shinde

Tests which are failing from below modules are added to exclude list
tests/run-make
tests/rustdoc
tests/mir-opt
tests/ui-fulldeps

* Redundent test cases whose parent dir is also present in  exclud list are 
removed.

* Newly addded tests are sorted and updated.

* Overall exclude tests count in exclude list is now reduced to 114.

We need to resolve the mips32 problems that Richard pointed out.

Should we skip all the rust tests for mips32?


In previous oe-selftest implementation, we skipped rust tests for mips32.
I think we should continue with it as rust tests are unstable with mips32.



Please submit a v3 with the mips fix/avoidance and split this exclude 
list commit down into 3 steps:


 1. Sort the existing list of tests
 2. Remove the test cases whose parent dir is also present in the 
exclude list


 3. Add the new tests that are to be excluded.

This may seem really pedantic but otherwise the changes are really 
hard to review.


The way I think about this is that someone looking at the commit log 
might be interested
in exactly which tests are in being added to the exclude list so that 
should be clear from 3.

1. won't really be of interest so most people will skip over that
2. also won't be of interest to most people
but you need 1 and 2 to make 3 be apparent to people who want that 
info quickly.



For 1 the existing list of tests are already sorted.
I will send a v3 with separate commits for:

1. newly added test cases
2. removing test cases whose parent dir is also present in the exclude 
list 3. sorting the overall final list Regards, Yash



Thanks,

../Randy


* The testing is done on arm32, arm64, mips64, x86 and  x86_64 targets.

Signed-off-by: Yash Shinde
---
  meta/lib/oeqa/selftest/cases/rust.py   | 165 +
  meta/recipes-devtools/rust/rust-source.inc |   4 +
  2 files changed, 43 insertions(+), 126 deletions(-)

diff --git a/meta/lib/oeqa/selftest/cases/rust.py 
b/meta/lib/oeqa/selftest/cases/rust.py
index 6dbc517006..7d0efb1b01 100644
--- a/meta/lib/oeqa/selftest/cases/rust.py
+++ b/meta/lib/oeqa/selftest/cases/rust.py
@@ -40,7 +40,7 @@ def parse_results(filename):
  class RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase):
  def test_rust(self, *args, **kwargs):
  # Disable Rust Oe-selftest
-self.skipTest("The Rust Oe-selftest is disabled.")
+#self.skipTest("The Rust Oe-selftest is disabled.")
  
  # build remote-test-server before image build
  recipe = "rust" @@ -73,156 +73,90 @@ class 
RustSelfTestSystemEmulated(OESelftestTestCase, 
OEPTestResultTestCase): 'src/librustdoc', 'src/rustdoc-json-types', 
'src/tools/compiletest/src/common.rs', + 'src/tools/jsondoclint', 
'src/tools/lint-docs', + 'src/tools/replace-version-placeholder', 
'src/tools/rust-analyzer', 'src/tools/rustdoc-themes', 
'src/tools/tidy', 'tests/assembly/asm/aarch64-outline-atomics.rs', + 
'tests/codegen/abi-efiapi.rs', + 'tests/codegen/abi-efiapi.rs', 
'tests/codegen/abi-main-signature-32bit-c-int.rs', 
'tests/codegen/abi-repr-ext.rs', + 'tests/codegen/abi-sysv64.rs', 
'tests/codegen/abi-x86-interrupt.rs', + 
'tests/codegen/align-byval.rs', + 'tests/codegen/align-fn.rs', + 
'tests/codegen/asm-powerpc-clobbers.rs', + 
'tests/codegen/async-fn-debug-awaitee-field.rs', + 
'tests/codegen/binary-search-index-no-bound-check.rs', 
'tests/codegen/branch-protection.rs', + 
'tests/codegen/call-metadata.rs', 'tests/codegen/catch-unwind.rs', 
'tests/codegen/cf-protection.rs', + 'tests/codegen/debug-column.rs', 
+ 'tests/codegen/debug-limited.rs', + 
'tests/codegen/debuginfo-generic-closure-env-names.rs', + 
'tests/codegen/drop.rs', + 
'tests/codegen/dst-vtable-align-nonzero.rs', + 
'tests/codegen/enable-lto-unit-splitting.rs', 
'tests/codegen/enum-bounds-check-derived-idx.rs', + 
'tests/codegen/enum/enum-u128.rs', + 
'tests/codegen/fn-impl-trait-self.rs', 
'tests/codegen/force-unwind-tables.rs', + 
'tests/codegen/inherit_overflow.rs', + 
'tests/codegen/inherit_overflow.rs', + 
'tests/codegen/inline-function-args-debug-info.rs', 
'tests/codegen/intrinsic-no-unnamed-attr.rs', + 
'tests/codegen/intrinsics/mask.rs', + 
'tests/codegen/intrinsics/transmute-niched.rs', 
'tests/codegen/issues/issue-103840.rs', 
'tests/codegen/issues/issue-47278.rs', + 
'tests/codegen/issues/issue-73258.rs', 
'tests/codegen/issues/issue-73827-bounds-check-index-in-subexpr.rs', 
+ 'tests/codegen/issues/issue-75546.rs', + 
'tests/codegen/issues/issue-77812.rs', + 
'tests/codegen/issues/issue-98156-const-arg-temp-lifetime.rs', 
'tests/codegen/lifetime_start_end.rs', + 
'tests/codegen/llvm-ident.rs', 
'tests/codegen/local-generics-in-exe-internalized.rs', + 
'tests/codegen/mainsubprogram.rs',

Re: [OE-core] [PATCH v2 5/5] rust: Enable rust oe-selftest.

2024-01-20 Thread Randy MacLeod via lists.openembedded.org 
I like that you have broken the original patch down into 5 patches that 
are easier to

understand.

On 2024-01-19 10:09 a.m., yash.shi...@windriver.com wrote:

From: Yash Shinde

Tests which are failing from below modules are added to exclude list
tests/run-make
tests/rustdoc
tests/mir-opt
tests/ui-fulldeps

* Redundent test cases whose parent dir is also present in  exclud list are 
removed.

* Newly addded tests are sorted and updated.

* Overall exclude tests count in exclude list is now reduced to 114.

We need to resolve the mips32 problems that Richard pointed out.

Should we skip all the rust tests for mips32?


Please submit a v3 with the mips fix/avoidance and split this exclude 
list commit down into 3 steps:


 1. Sort the existing list of tests
 2. Remove the test cases whose parent dir is also present in the 
exclude list


 3. Add the new tests that are to be excluded.

This may seem really pedantic but otherwise the changes are really hard 
to review.


The way I think about this is that someone looking at the commit log 
might be interested
in exactly which tests are in being added to the exclude list so that 
should be clear from 3.

1. won't really be of interest so most people will skip over that
2. also won't be of interest to most people
but you need 1 and 2 to make 3 be apparent to people who want that info 
quickly.


Thanks,

../Randy



* The testing is done on arm32, arm64, mips64, x86 and  x86_64 targets.

Signed-off-by: Yash Shinde
---
  meta/lib/oeqa/selftest/cases/rust.py   | 165 +
  meta/recipes-devtools/rust/rust-source.inc |   4 +
  2 files changed, 43 insertions(+), 126 deletions(-)

diff --git a/meta/lib/oeqa/selftest/cases/rust.py 
b/meta/lib/oeqa/selftest/cases/rust.py
index 6dbc517006..7d0efb1b01 100644
--- a/meta/lib/oeqa/selftest/cases/rust.py
+++ b/meta/lib/oeqa/selftest/cases/rust.py
@@ -40,7 +40,7 @@ def parse_results(filename):
  class RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase):
  def test_rust(self, *args, **kwargs):
  # Disable Rust Oe-selftest
-self.skipTest("The Rust Oe-selftest is disabled.")
+#self.skipTest("The Rust Oe-selftest is disabled.")
  
  # build remote-test-server before image build
  recipe = "rust" @@ -73,156 +73,90 @@ class 
RustSelfTestSystemEmulated(OESelftestTestCase, OEPTestResultTestCase): 
'src/librustdoc', 'src/rustdoc-json-types', 
'src/tools/compiletest/src/common.rs', + 'src/tools/jsondoclint', 
'src/tools/lint-docs', + 'src/tools/replace-version-placeholder', 
'src/tools/rust-analyzer', 'src/tools/rustdoc-themes', 
'src/tools/tidy', 'tests/assembly/asm/aarch64-outline-atomics.rs', + 
'tests/codegen/abi-efiapi.rs', + 'tests/codegen/abi-efiapi.rs', 
'tests/codegen/abi-main-signature-32bit-c-int.rs', 
'tests/codegen/abi-repr-ext.rs', + 'tests/codegen/abi-sysv64.rs', 
'tests/codegen/abi-x86-interrupt.rs', + 
'tests/codegen/align-byval.rs', + 'tests/codegen/align-fn.rs', + 
'tests/codegen/asm-powerpc-clobbers.rs', + 
'tests/codegen/async-fn-debug-awaitee-field.rs', + 
'tests/codegen/binary-search-index-no-bound-check.rs', 
'tests/codegen/branch-protection.rs', + 
'tests/codegen/call-metadata.rs', 'tests/codegen/catch-unwind.rs', 
'tests/codegen/cf-protection.rs', + 'tests/codegen/debug-column.rs', + 
'tests/codegen/debug-limited.rs', + 
'tests/codegen/debuginfo-generic-closure-env-names.rs', + 
'tests/codegen/drop.rs', + 
'tests/codegen/dst-vtable-align-nonzero.rs', + 
'tests/codegen/enable-lto-unit-splitting.rs', 
'tests/codegen/enum-bounds-check-derived-idx.rs', + 
'tests/codegen/enum/enum-u128.rs', + 
'tests/codegen/fn-impl-trait-self.rs', 
'tests/codegen/force-unwind-tables.rs', + 
'tests/codegen/inherit_overflow.rs', + 
'tests/codegen/inherit_overflow.rs', + 
'tests/codegen/inline-function-args-debug-info.rs', 
'tests/codegen/intrinsic-no-unnamed-attr.rs', + 
'tests/codegen/intrinsics/mask.rs', + 
'tests/codegen/intrinsics/transmute-niched.rs', 
'tests/codegen/issues/issue-103840.rs', 
'tests/codegen/issues/issue-47278.rs', + 
'tests/codegen/issues/issue-73258.rs', 
'tests/codegen/issues/issue-73827-bounds-check-index-in-subexpr.rs', + 
'tests/codegen/issues/issue-75546.rs', + 
'tests/codegen/issues/issue-77812.rs', + 
'tests/codegen/issues/issue-98156-const-arg-temp-lifetime.rs', 
'tests/codegen/lifetime_start_end.rs', + 
'tests/codegen/llvm-ident.rs', 
'tests/codegen/local-generics-in-exe-internalized.rs', + 
'tests/codegen/mainsubprogram.rs', 
'tests/codegen/match-unoptimized.rs', + 
'tests/codegen/move-operands.rs', 
'tests/codegen/noalias-rwlockreadguard.rs', 
'tests/codegen/non-terminate/nonempty-infinite-loop.rs', 
'tests/codegen/noreturn-uninhabited.rs', 
'tests/codegen/repr-transparent-aggregates-3.rs', + 
'tests/codegen/repr/transparent-mips64.rs', 
'tests/codegen/sse42-implies-crc32.rs', 
'tests/codegen/thread-local.rs', 'tests/codegen/uninit-consts.rs', + 
'tests/mir-opt/',