Re: [OE-core] tcf-agent, matchbox-wm-2: Correct proto=git to protocol=git.
On Sat, Jul 7, 2012 at 1:54 PM, Robert P. J. Day rpj...@crashcourse.cawrote:
proto=git is not a valid parameter for the git fetcher.
NOTE: package
matchbox-wm-2-0.1+git1+01fa5465743c9ee43d040350f4405d35293e4869-r1: task
do_fetch: Succeeded
Anyway, in the git.py, code is searching for protocol parameter:
*ud.proto = ud.parm['protocol']*
*
*
... so your change seems legit.
On another hand, svn.py is using:
* proto = ud.parm.get('proto', 'svn')*
A good think would be to use the same parameter names for all protocols.
@g
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] tcf-agent, matchbox-wm-2: Correct proto=git to protocol=git.
On Mon, 2012-07-09 at 12:27 +0300, Andrei Gherzan wrote:
On Sat, Jul 7, 2012 at 1:54 PM, Robert P. J. Day
rpj...@crashcourse.ca wrote:
proto=git is not a valid parameter for the git fetcher.
NOTE: package matchbox-wm-2-0.1+git1
+01fa5465743c9ee43d040350f4405d35293e4869-r1: task do_fetch:
Succeeded
Anyway, in the git.py, code is searching for protocol parameter:
ud.proto = ud.parm['protocol']
... so your change seems legit.
On another hand, svn.py is using:
proto = ud.parm.get('proto', 'svn')
A good think would be to use the same parameter names for all
protocols.
I agree but how do we do this without breaking the world? We probably
should try and standardise it, probably to protocol.
Cheers,
Richard
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] tcf-agent, matchbox-wm-2: Correct proto=git to protocol=git.
On Mon, Jul 9, 2012 at 10:00 AM, Richard Purdie
richard.pur...@linuxfoundation.org wrote:
On Mon, 2012-07-09 at 12:27 +0300, Andrei Gherzan wrote:
On Sat, Jul 7, 2012 at 1:54 PM, Robert P. J. Day
rpj...@crashcourse.ca wrote:
proto=git is not a valid parameter for the git fetcher.
NOTE: package matchbox-wm-2-0.1+git1
+01fa5465743c9ee43d040350f4405d35293e4869-r1: task do_fetch:
Succeeded
Anyway, in the git.py, code is searching for protocol parameter:
ud.proto = ud.parm['protocol']
... so your change seems legit.
On another hand, svn.py is using:
proto = ud.parm.get('proto', 'svn')
A good think would be to use the same parameter names for all
protocols.
I agree but how do we do this without breaking the world? We probably
should try and standardise it, probably to protocol.
so may be change the keyword to protocol and have both for this
release additionally give a deprecation warning on proto and then
after 1.3 remove proto
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] tcf-agent, matchbox-wm-2: Correct proto=git to protocol=git.
On Mon, Jul 9, 2012 at 8:40 PM, Khem Raj raj.k...@gmail.com wrote:
On Mon, Jul 9, 2012 at 10:00 AM, Richard Purdie
richard.pur...@linuxfoundation.org wrote:
On Mon, 2012-07-09 at 12:27 +0300, Andrei Gherzan wrote:
On Sat, Jul 7, 2012 at 1:54 PM, Robert P. J. Day
rpj...@crashcourse.ca wrote:
proto=git is not a valid parameter for the git fetcher.
NOTE: package matchbox-wm-2-0.1+git1
+01fa5465743c9ee43d040350f4405d35293e4869-r1: task do_fetch:
Succeeded
Anyway, in the git.py, code is searching for protocol parameter:
ud.proto = ud.parm['protocol']
... so your change seems legit.
On another hand, svn.py is using:
proto = ud.parm.get('proto', 'svn')
A good think would be to use the same parameter names for all
protocols.
I agree but how do we do this without breaking the world? We probably
should try and standardise it, probably to protocol.
so may be change the keyword to protocol and have both for this
release additionally give a deprecation warning on proto and then
after 1.3 remove proto
Healthy approach. I can submit patches on this topic if nobody did it
already locally.
@g
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] tcf-agent, matchbox-wm-2: Correct proto=git to protocol=git.
On Mon, 9 Jul 2012, Andrei Gherzan wrote:
On Mon, Jul 9, 2012 at 8:40 PM, Khem Raj raj.k...@gmail.com wrote:
On Mon, Jul 9, 2012 at 10:00 AM, Richard Purdie
richard.pur...@linuxfoundation.org wrote:
On Mon, 2012-07-09 at 12:27 +0300, Andrei Gherzan wrote:
On Sat, Jul 7, 2012 at 1:54 PM, Robert P. J. Day
rpj...@crashcourse.ca wrote:
proto=git is not a valid parameter for the git fetcher.
NOTE: package matchbox-wm-2-0.1+git1
+01fa5465743c9ee43d040350f4405d35293e4869-r1: task do_fetch:
Succeeded
Anyway, in the git.py, code is searching for protocol parameter:
ud.proto = ud.parm['protocol']
... so your change seems legit.
On another hand, svn.py is using:
proto = ud.parm.get('proto', 'svn')
A good think would be to use the same parameter names for all
protocols.
I agree but how do we do this without breaking the world? We probably
should try and standardise it, probably to protocol.
so may be change the keyword to protocol and have both for this
release additionally give a deprecation warning on proto and then
after 1.3 remove proto
Healthy approach. I can submit patches on this topic if nobody did
it already locally.
i can see my work here is done. i will go find something else to
complain about. :-)
rday
--
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] tcf-agent, matchbox-wm-2: Correct proto=git to protocol=git.
Healthy approach. I can submit patches on this topic if nobody did it already locally. please do. ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
