Re: [oe] [PATCH] Revert "protobuf: stage protoc binary to sysroot"

2023-11-10 Thread Vyacheslav Yurkov

Shall we go for round 3 of the patch then? :)

I'd wait for Clément feedback and then all 3 of us can sign it off.

I would also like to have a short comment/explanation before the 
SYSROOT_DIRS as to why it's required in this particular recipe.


FTR, as expected Richard didn't like the other suggestion, because the 
size of sstate is affected by that.


Slava

On 10.11.2023 09:44, Samuli Piippo wrote:

Agreed that enabling compiler in target would be rarely used.

Having
SYSROOT_DIRS += "${bindir}"
would, however, cover both builds without additional tweaks.
Since target build doesn't have any other binaries, this wouldn't do 
anything extra with default PACKAGECONFIG.


On Fri, 10 Nov 2023 at 10:06, Vyacheslav Yurkov  
wrote:


OK, but that seems to be similar issue, although a different one :)
I recall I disabled compiler by default for target, because it's
rare use case.

So compiler can be enabled (if needed), but then perhaps another
tweak with sysroot will be necessary in the recipe? I suggest to
keep it as a comment in the recipe. What do you think?

Slava


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#106532): 
https://lists.openembedded.org/g/openembedded-devel/message/106532
Mute This Topic: https://lists.openembedded.org/mt/101679410/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [oe] [PATCH] Revert "protobuf: stage protoc binary to sysroot"

2023-11-10 Thread Vyacheslav Yurkov

OK, but that seems to be similar issue, although a different one :)
I recall I disabled compiler by default for target, because it's rare 
use case.


So compiler can be enabled (if needed), but then perhaps another tweak 
with sysroot will be necessary in the recipe? I suggest to keep it as a 
comment in the recipe. What do you think?


Slava

On 10.11.2023 08:50, Samuli Piippo wrote:


| CMake Error at 
/home/sapiippo/qt6/build/tmp/work/cortexa57-poky-linux/grpc/1.59.2/recipe-sysroot/usr/lib/cmake/protobuf/protobuf-targets.cmake:116 
(message):

|   The imported target "protobuf::protoc" references the file
|
| 
 "/home/sapiippo/qt6/build/tmp/work/cortexa57-poky-linux/grpc/1.59.2/recipe-sysroot/usr/bin/protoc-23.4.0"

|
|   but this file does not exist.  Possible reasons include:

On Fri, 10 Nov 2023 at 09:38, Vyacheslav Yurkov  
wrote:


You sure? Because I remember the test in grpc to check for
CROSS_COMPILING in cmake to avoid that.

Slava

On 10.11.2023 08:12, Samuli Piippo wrote:

This is not strictly a nativesdk issue.
If you enable PACKAGECONFIG = "compiler" for protobuf, it will
then build protoc for the target.
This will then cause grpc target build to fail in the same way as
nativesdk build.

On Fri, 10 Nov 2023 at 08:40, Vyacheslav Yurkov
 wrote:

FTR, I suggested oe-core solution in the corresponding
mailing list.

Slava

On 10.11.2023 07:19, Vyacheslav Yurkov via
lists.openembedded.org <http://lists.openembedded.org> wrote:

On 10.11.2023 02:23, Clément Péron wrote:

Hi Samuli,

    Le ven. 10 nov. 2023, 00:05, Vyacheslav Yurkov
 a écrit :

Thanks for the explanation, that was the missing piece
for me to get an understanding of the problem :)

I think it's not only me, but also others, were
confused by the fact that we are talking about
native(sdk), but try to fix something with a non-native
variable.

I've just gave it a try and have two suggestions how
this can be addressed.

1. Recipe based solution:
SYSROOT_DIRS:append:class-nativesdk = " $bindir}"


Is it not just missing something like

DEPENDS:append:class-nativesdk= " protobuf-native "
Regards
Clement


This is already implicit by DEPENDS += "protobuf". Take a
look at my second suggestion. You can see that ${bindir} is
staged for native recipes, but not for nativesdk.



2. oe-core based solution:
--- a/meta/classes-global/staging.bbclass
+++ b/meta/classes-global/staging.bbclass
@@ -26,6 +26,7 @@ SYSROOT_DIRS_NATIVE = " \
 ${localstatedir} \
 "
 SYSROOT_DIRS:append:class-native = "
${SYSROOT_DIRS_NATIVE}"
+SYSROOT_DIRS:append:class-nativesdk = "
${SYSROOT_DIRS_NATIVE}"
 SYSROOT_DIRS:append:class-cross = "
${SYSROOT_DIRS_NATIVE}"
 SYSROOT_DIRS:append:class-crosssdk = "
${SYSROOT_DIRS_NATIVE}"

The second one will invalidate nativesdk sstate, but
might cover not only grpc issue (I would assume
gdbus-codegen or any other generator has the same issue
when used for SDK build).

What are your thoughs?

Thanks,
Slava

On 09.11.2023 14:35, Samuli Piippo wrote:

DEPENDS += "protobuf" is enough to have dependencies
resolved.

Problem is that bitbake's do_populate_sysroot does not
take anything from bindir.
This leads to nativesdk-(qt)grpc's
do_prepare_recipe_sysroot to not get the protoc binary
into the recipe_sysroot as expected by CMake.

This can be fixed with SYSROOT_DIRS.

On Thu, 9 Nov 2023 at 12:19, Vyacheslav Yurkov
 wrote:

Hi Clément,
No, the issue is when you just build nativesdk
recipe (we are not at the stage to use the SDK yet).

And that was exactly my question how to propagate
the dependency correctly for nativesdk build.

Regards,
Slava




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#106530): 
https://lists.openembedded.org/g/openembedded-devel/message/106530
Mute This Topic: https://lists.openembedded.org/mt/101679410/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [oe] [PATCH] Revert "protobuf: stage protoc binary to sysroot"

2023-11-09 Thread Vyacheslav Yurkov
You sure? Because I remember the test in grpc to check for 
CROSS_COMPILING in cmake to avoid that.


Slava

On 10.11.2023 08:12, Samuli Piippo wrote:

This is not strictly a nativesdk issue.
If you enable PACKAGECONFIG = "compiler" for protobuf, it will then 
build protoc for the target.
This will then cause grpc target build to fail in the same way as 
nativesdk build.


On Fri, 10 Nov 2023 at 08:40, Vyacheslav Yurkov  
wrote:


FTR, I suggested oe-core solution in the corresponding mailing list.

Slava

On 10.11.2023 07:19, Vyacheslav Yurkov via lists.openembedded.org
<http://lists.openembedded.org> wrote:

On 10.11.2023 02:23, Clément Péron wrote:

Hi Samuli,

Le ven. 10 nov. 2023, 00:05, Vyacheslav Yurkov
 a écrit :

Thanks for the explanation, that was the missing piece for
me to get an understanding of the problem :)

I think it's not only me, but also others, were confused by
the fact that we are talking about native(sdk), but try to
fix something with a non-native variable.

I've just gave it a try and have two suggestions how this
can be addressed.

1. Recipe based solution:
SYSROOT_DIRS:append:class-nativesdk = " $bindir}"


Is it not just missing something like

DEPENDS:append:class-nativesdk= " protobuf-native "
Regards
Clement


This is already implicit by DEPENDS += "protobuf". Take a look at
my second suggestion. You can see that ${bindir} is staged for
native recipes, but not for nativesdk.



2. oe-core based solution:
--- a/meta/classes-global/staging.bbclass
+++ b/meta/classes-global/staging.bbclass
@@ -26,6 +26,7 @@ SYSROOT_DIRS_NATIVE = " \
 ${localstatedir} \
 "
 SYSROOT_DIRS:append:class-native = " ${SYSROOT_DIRS_NATIVE}"
+SYSROOT_DIRS:append:class-nativesdk = " ${SYSROOT_DIRS_NATIVE}"
 SYSROOT_DIRS:append:class-cross = " ${SYSROOT_DIRS_NATIVE}"
 SYSROOT_DIRS:append:class-crosssdk = " ${SYSROOT_DIRS_NATIVE}"

The second one will invalidate nativesdk sstate, but might
cover not only grpc issue (I would assume gdbus-codegen or
any other generator has the same issue when used for SDK build).

What are your thoughs?

Thanks,
Slava

On 09.11.2023 14:35, Samuli Piippo wrote:

DEPENDS += "protobuf" is enough to have dependencies resolved.

Problem is that bitbake's do_populate_sysroot does not take
anything from bindir.
This leads to nativesdk-(qt)grpc's
do_prepare_recipe_sysroot to not get the protoc binary into
the recipe_sysroot as expected by CMake.

This can be fixed with SYSROOT_DIRS.

On Thu, 9 Nov 2023 at 12:19, Vyacheslav Yurkov
 wrote:

Hi Clément,
No, the issue is when you just build nativesdk recipe
(we are not at the stage to use the SDK yet).

And that was exactly my question how to propagate the
dependency correctly for nativesdk build.

Regards,
Slava


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#106528): 
https://lists.openembedded.org/g/openembedded-devel/message/106528
Mute This Topic: https://lists.openembedded.org/mt/101679410/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [oe] [PATCH] Revert "protobuf: stage protoc binary to sysroot"

2023-11-09 Thread Vyacheslav Yurkov

FTR, I suggested oe-core solution in the corresponding mailing list.

Slava

On 10.11.2023 07:19, Vyacheslav Yurkov via lists.openembedded.org wrote:

On 10.11.2023 02:23, Clément Péron wrote:

Hi Samuli,

Le ven. 10 nov. 2023, 00:05, Vyacheslav Yurkov  a 
écrit :


Thanks for the explanation, that was the missing piece for me to
get an understanding of the problem :)

I think it's not only me, but also others, were confused by the
fact that we are talking about native(sdk), but try to fix
something with a non-native variable.

I've just gave it a try and have two suggestions how this can be
addressed.

1. Recipe based solution:
SYSROOT_DIRS:append:class-nativesdk = " $bindir}"


Is it not just missing something like

DEPENDS:append:class-nativesdk= " protobuf-native "
Regards
Clement


This is already implicit by DEPENDS += "protobuf". Take a look at my 
second suggestion. You can see that ${bindir} is staged for native 
recipes, but not for nativesdk.




2. oe-core based solution:
--- a/meta/classes-global/staging.bbclass
+++ b/meta/classes-global/staging.bbclass
@@ -26,6 +26,7 @@ SYSROOT_DIRS_NATIVE = " \
 ${localstatedir} \
 "
 SYSROOT_DIRS:append:class-native = " ${SYSROOT_DIRS_NATIVE}"
+SYSROOT_DIRS:append:class-nativesdk = " ${SYSROOT_DIRS_NATIVE}"
 SYSROOT_DIRS:append:class-cross = " ${SYSROOT_DIRS_NATIVE}"
 SYSROOT_DIRS:append:class-crosssdk = " ${SYSROOT_DIRS_NATIVE}"

The second one will invalidate nativesdk sstate, but might cover
not only grpc issue (I would assume gdbus-codegen or any other
generator has the same issue when used for SDK build).

What are your thoughs?

Thanks,
Slava

On 09.11.2023 14:35, Samuli Piippo wrote:

DEPENDS += "protobuf" is enough to have dependencies resolved.

Problem is that bitbake's do_populate_sysroot does not take
anything from bindir.
This leads to nativesdk-(qt)grpc's do_prepare_recipe_sysroot to
not get the protoc binary into the recipe_sysroot as expected by
CMake.

    This can be fixed with SYSROOT_DIRS.

On Thu, 9 Nov 2023 at 12:19, Vyacheslav Yurkov
 wrote:

Hi Clément,
No, the issue is when you just build nativesdk recipe (we
are not at the stage to use the SDK yet).

And that was exactly my question how to propagate the
dependency correctly for nativesdk build.

Regards,
Slava




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#106525): 
https://lists.openembedded.org/g/openembedded-devel/message/106525
Mute This Topic: https://lists.openembedded.org/mt/101679410/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [oe] [PATCH] Revert "protobuf: stage protoc binary to sysroot"

2023-11-09 Thread Vyacheslav Yurkov

On 10.11.2023 02:23, Clément Péron wrote:

Hi Samuli,

Le ven. 10 nov. 2023, 00:05, Vyacheslav Yurkov  a 
écrit :


Thanks for the explanation, that was the missing piece for me to
get an understanding of the problem :)

I think it's not only me, but also others, were confused by the
fact that we are talking about native(sdk), but try to fix
something with a non-native variable.

I've just gave it a try and have two suggestions how this can be
addressed.

1. Recipe based solution:
SYSROOT_DIRS:append:class-nativesdk = " $bindir}"


Is it not just missing something like

DEPENDS:append:class-nativesdk= " protobuf-native "
Regards
Clement


This is already implicit by DEPENDS += "protobuf". Take a look at my 
second suggestion. You can see that ${bindir} is staged for native 
recipes, but not for nativesdk.




2. oe-core based solution:
--- a/meta/classes-global/staging.bbclass
+++ b/meta/classes-global/staging.bbclass
@@ -26,6 +26,7 @@ SYSROOT_DIRS_NATIVE = " \
 ${localstatedir} \
 "
 SYSROOT_DIRS:append:class-native = " ${SYSROOT_DIRS_NATIVE}"
+SYSROOT_DIRS:append:class-nativesdk = " ${SYSROOT_DIRS_NATIVE}"
 SYSROOT_DIRS:append:class-cross = " ${SYSROOT_DIRS_NATIVE}"
 SYSROOT_DIRS:append:class-crosssdk = " ${SYSROOT_DIRS_NATIVE}"

The second one will invalidate nativesdk sstate, but might cover
not only grpc issue (I would assume gdbus-codegen or any other
generator has the same issue when used for SDK build).

What are your thoughs?

Thanks,
Slava

On 09.11.2023 14:35, Samuli Piippo wrote:

DEPENDS += "protobuf" is enough to have dependencies resolved.

Problem is that bitbake's do_populate_sysroot does not take
anything from bindir.
This leads to nativesdk-(qt)grpc's do_prepare_recipe_sysroot to
not get the protoc binary into the recipe_sysroot as expected by
CMake.

    This can be fixed with SYSROOT_DIRS.

On Thu, 9 Nov 2023 at 12:19, Vyacheslav Yurkov
 wrote:

Hi Clément,
No, the issue is when you just build nativesdk recipe (we are
not at the stage to use the SDK yet).

And that was exactly my question how to propagate the
dependency correctly for nativesdk build.

Regards,
Slava






-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#106524): 
https://lists.openembedded.org/g/openembedded-devel/message/106524
Mute This Topic: https://lists.openembedded.org/mt/101679410/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [oe] [PATCH] Revert "protobuf: stage protoc binary to sysroot"

2023-11-09 Thread Vyacheslav Yurkov
Thanks for the explanation, that was the missing piece for me to get an 
understanding of the problem :)


I think it's not only me, but also others, were confused by the fact 
that we are talking about native(sdk), but try to fix something with a 
non-native variable.


I've just gave it a try and have two suggestions how this can be addressed.

1. Recipe based solution:
SYSROOT_DIRS:append:class-nativesdk = " $bindir}"

2. oe-core based solution:
--- a/meta/classes-global/staging.bbclass
+++ b/meta/classes-global/staging.bbclass
@@ -26,6 +26,7 @@ SYSROOT_DIRS_NATIVE = " \
 ${localstatedir} \
 "
 SYSROOT_DIRS:append:class-native = " ${SYSROOT_DIRS_NATIVE}"
+SYSROOT_DIRS:append:class-nativesdk = " ${SYSROOT_DIRS_NATIVE}"
 SYSROOT_DIRS:append:class-cross = " ${SYSROOT_DIRS_NATIVE}"
 SYSROOT_DIRS:append:class-crosssdk = " ${SYSROOT_DIRS_NATIVE}"

The second one will invalidate nativesdk sstate, but might cover not 
only grpc issue (I would assume gdbus-codegen or any other generator has 
the same issue when used for SDK build).


What are your thoughs?

Thanks,
Slava

On 09.11.2023 14:35, Samuli Piippo wrote:

DEPENDS += "protobuf" is enough to have dependencies resolved.

Problem is that bitbake's do_populate_sysroot does not take anything 
from bindir.
This leads to nativesdk-(qt)grpc's do_prepare_recipe_sysroot to not 
get the protoc binary into the recipe_sysroot as expected by CMake.


This can be fixed with SYSROOT_DIRS.

On Thu, 9 Nov 2023 at 12:19, Vyacheslav Yurkov  wrote:

Hi Clément,
No, the issue is when you just build nativesdk recipe (we are not
at the stage to use the SDK yet).

And that was exactly my question how to propagate the dependency
correctly for nativesdk build.

Regards,
Slava


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#106519): 
https://lists.openembedded.org/g/openembedded-devel/message/106519
Mute This Topic: https://lists.openembedded.org/mt/101679410/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [oe] [PATCH] Revert "protobuf: stage protoc binary to sysroot"

2023-11-09 Thread Vyacheslav Yurkov

Hi Clément,
No, the issue is when you just build nativesdk recipe (we are not at the 
stage to use the SDK yet).


And that was exactly my question how to propagate the dependency 
correctly for nativesdk build.


Regards,
Slava

On 09.11.2023 01:13, Clément Péron wrote:

Hi Samuli,

Le mer. 8 nov. 2023, 22:30, Samuli Piippo  a 
écrit :


Hi Clément,

Were you able to reproduce the issue?


Sorry I'm on vacation without access to a laptop at the moment.

But if I understand the issue is not related to a target or native 
recipes issue, right?


It's only when building the SDK and then try to build an application 
with it right?


Maybe there is a missing dependency when building the SDK.

Regards,
Clement


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#106515): 
https://lists.openembedded.org/g/openembedded-devel/message/106515
Mute This Topic: https://lists.openembedded.org/mt/101679410/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [oe] [PATCH] Revert "protobuf: stage protoc binary to sysroot"

2023-10-22 Thread Vyacheslav Yurkov

I'm a bit confused here.

I just did 'find 
tmp/work/x86_64-nativesdk-pokysdk-linux/nativesdk-grpc/1.56.2/ -name 
"protoc*"' and I see protoc binary only in recipe-sysroot-native. That 
tells me that protoc, which is a part of nativesdk-protobuf-compiler, is 
not installed to recipe-sysroot.


What am I missing here?

Slava

On 20.10.2023 09:35, Martin Jansa wrote:
do_prepare_recipe_sysroot doesn't install any packages to RSS. Only 
package manager on target or in do_rootfs uses packages.


It installs the files from dependency populate_sysroot task.

On Fri, Oct 20, 2023 at 9:11 AM Samuli Piippo 
 wrote:


Dependency to the recipe name will always install all packages to RSS.
You can verify this by checking that the libprotoc.so from the
nativesdk-protobuf-compile package is in the sysroot.
The problem you are facing is the fact that binaries are not
installed into the sysroot (for nativesdk builds), so you are only
missing the bin/protoc-23.4.0 file.
The proposed and twice reverted fix for this is the aforementioned
SYSROOT_DIRS.

-samuli

On Fri, 20 Oct 2023 at 09:17, Vyacheslav Yurkov
 wrote:

I think the problem goes down to how dependencies are
populated in the sysroot. I raised this question in oe-core
mailing list
https://lists.openembedded.org/g/openembedded-core/message/189324
, but didn't get an answer yet.

DEPENDS += "protobuf" will only install the main package of
protobuf to the sysroot, because it assumes that
nativesdk-protobuf-compiler is also part of the main package
(which is not). I guess the part of the system populating
sysroot deals with recipes only, and not with packages. I'm
still trying to understand how that should be addressed properly.
My understanding is that either all packages should be
installed to sysroot (which recipe claims it provides), or we
need a way to indicate a package level dependency (i.e.
nativesdk-protobuf-compiler in this case)

Any ideas?

Slava

On 18.10.2023 14:28, Samuli Piippo wrote:

Following simple test recipe will fail now when trying to use
Protobuf with CMake.

inherit cmake
DEPENDS += "protobuf"

do_configure:prepend() {
    echo "find_package(Protobuf CONFIG)" > ${S}/CMakeLists.txt
}

BBCLASSEXTEND = "nativesdk"

---
CMake Error at

tmp/work/x86_64-nativesdk-pokysdk-linux/nativesdk-test/1.0/recipe-sysroot/usr/local/oe-sdk-hardcoded-buildpath/sysroots/x86_64-pokysdk-linux/usr/lib/cmake/protobuf/protobuf-targets.cmake:107
(message):
  The imported target "protobuf::protoc" references the file

 
"tmp/work/x86_64-nativesdk-pokysdk-linux/nativesdk-test/1.0/recipe-sysroot/usr/local/oe-sdk-hardcoded-buildpath/sysroots/x86_64-pokysdk-linux/usr/bin/protoc-23.4.0"

  but this file does not exist.
---

I don't quite see why every project/recipe should fix this
independently when the simple workaround for this
yocto-specific issue is available (namely the use
of SYSROOT_DIRS).

-samuli

ps. qtgrpc recipe and other Qt6 recipes are now visible in
the layerindex
https://layers.openembedded.org/layerindex/recipe/348210/


On Thu, 12 Oct 2023 at 15:06, Vyacheslav Yurkov
 wrote:

I'd like to follow-up on this and say that I see this
issue now with nativesdk build, in particular
nativesdk-grpc recipe fails in master with the same
error. I hope that's partially related to the issue
everybody is confused about, but I'd like understand how
to properly fix it.

|   The imported target "protobuf::protoc" references the
file
|
|

"/home/uvv/projects/poky/build/tmp/work/x86_64-nativesdk-pokysdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot/usr/local/oe-sdk-hardcoded-buildpath/sysroots/x86_64-pokysdk-linux/usr/bin/protoc-23.4.0"
|
|   but this file does not exist.  Possible reasons include:
|
|   * The file was deleted, renamed, or moved to another
location.

The protoc-23.4.0 file already exists in the
recipe-sysroot-native.

And we do want protoc to be present in the SDK, but
nativesdk build is a cross-compilation, because
SDKMACHINE and HOST might be different.
In this particular grpc case there's an option to say
where the actual protoc executable is (

-D_gRPC_PROTOBUF_PROTOC_EXECUTABLE=/home/uvv/projects/poky/build/tmp/work/x86_64-nativesdk-pokysdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot-native/usr/

Re: [oe] [PATCH] Revert "protobuf: stage protoc binary to sysroot"

2023-10-20 Thread Vyacheslav Yurkov
I think the problem goes down to how dependencies are populated in the 
sysroot. I raised this question in oe-core mailing list 
https://lists.openembedded.org/g/openembedded-core/message/189324 , but 
didn't get an answer yet.


DEPENDS += "protobuf" will only install the main package of protobuf to 
the sysroot, because it assumes that nativesdk-protobuf-compiler is also 
part of the main package (which is not). I guess the part of the system 
populating sysroot deals with recipes only, and not with packages. I'm 
still trying to understand how that should be addressed properly.
My understanding is that either all packages should be installed to 
sysroot (which recipe claims it provides), or we need a way to indicate 
a package level dependency (i.e. nativesdk-protobuf-compiler in this case)


Any ideas?

Slava

On 18.10.2023 14:28, Samuli Piippo wrote:
Following simple test recipe will fail now when trying to use Protobuf 
with CMake.


inherit cmake
DEPENDS += "protobuf"

do_configure:prepend() {
    echo "find_package(Protobuf CONFIG)" > ${S}/CMakeLists.txt
}

BBCLASSEXTEND = "nativesdk"

---
CMake Error at 
tmp/work/x86_64-nativesdk-pokysdk-linux/nativesdk-test/1.0/recipe-sysroot/usr/local/oe-sdk-hardcoded-buildpath/sysroots/x86_64-pokysdk-linux/usr/lib/cmake/protobuf/protobuf-targets.cmake:107 
(message):

  The imported target "protobuf::protoc" references the file

 
"tmp/work/x86_64-nativesdk-pokysdk-linux/nativesdk-test/1.0/recipe-sysroot/usr/local/oe-sdk-hardcoded-buildpath/sysroots/x86_64-pokysdk-linux/usr/bin/protoc-23.4.0"

  but this file does not exist.
---

I don't quite see why every project/recipe should fix this 
independently when the simple workaround for this yocto-specific issue 
is available (namely the use of SYSROOT_DIRS).


-samuli

ps. qtgrpc recipe and other Qt6 recipes are now visible in the 
layerindex https://layers.openembedded.org/layerindex/recipe/348210/



On Thu, 12 Oct 2023 at 15:06, Vyacheslav Yurkov  
wrote:


I'd like to follow-up on this and say that I see this issue now
with nativesdk build, in particular nativesdk-grpc recipe fails in
master with the same error. I hope that's partially related to the
issue everybody is confused about, but I'd like understand how to
properly fix it.

|   The imported target "protobuf::protoc" references the file
|
|

"/home/uvv/projects/poky/build/tmp/work/x86_64-nativesdk-pokysdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot/usr/local/oe-sdk-hardcoded-buildpath/sysroots/x86_64-pokysdk-linux/usr/bin/protoc-23.4.0"
|
|   but this file does not exist.  Possible reasons include:
|
|   * The file was deleted, renamed, or moved to another location.

The protoc-23.4.0 file already exists in the recipe-sysroot-native.

And we do want protoc to be present in the SDK, but nativesdk
build is a cross-compilation, because SDKMACHINE and HOST might be
different.
In this particular grpc case there's an option to say where the
actual protoc executable is (

-D_gRPC_PROTOBUF_PROTOC_EXECUTABLE=/home/uvv/projects/poky/build/tmp/work/x86_64-nativesdk-pokysdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot-native/usr/bin/protoc
is passed to grpc).

So there shouldn't be any issues here, but nativesdk build still
fails.

Looking into it further I see that protoc is actually packaged by
protobuf-compiler package, but when I try to add a package
dependency to grpc recipe I get this:

nativesdk-protobuf RPROVIDES nativesdk-protobuf-compiler

Moreover, if I go into devshell and forcefully install
nativesdk-libprotobuf-compiler, then `bitbake nativesdk-grpc` is
happy and compiles!

So something wrong with the dependencies in protobuf recipe, but I
can't figure out yet what exactly. Any ideas?

Regards,
Slava


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#105610): 
https://lists.openembedded.org/g/openembedded-devel/message/105610
Mute This Topic: https://lists.openembedded.org/mt/101679410/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [oe] [PATCH] Revert "protobuf: stage protoc binary to sysroot"

2023-10-12 Thread Vyacheslav Yurkov
I'd like to follow-up on this and say that I see this issue now with 
nativesdk build, in particular nativesdk-grpc recipe fails in master 
with the same error. I hope that's partially related to the issue 
everybody is confused about, but I'd like understand how to properly fix it.


|   The imported target "protobuf::protoc" references the file
|
| 
"/home/uvv/projects/poky/build/tmp/work/x86_64-nativesdk-pokysdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot/usr/local/oe-sdk-hardcoded-buildpath/sysroots/x86_64-pokysdk-linux/usr/bin/protoc-23.4.0"

|
|   but this file does not exist.  Possible reasons include:
|
|   * The file was deleted, renamed, or moved to another location.

The protoc-23.4.0 file already exists in the recipe-sysroot-native.

And we do want protoc to be present in the SDK, but nativesdk build is a 
cross-compilation, because SDKMACHINE and HOST might be different.
In this particular grpc case there's an option to say where the actual 
protoc executable is ( 
-D_gRPC_PROTOBUF_PROTOC_EXECUTABLE=/home/uvv/projects/poky/build/tmp/work/x86_64-nativesdk-pokysdk-linux/nativesdk-grpc/1.56.2/recipe-sysroot-native/usr/bin/protoc 
is passed to grpc).


So there shouldn't be any issues here, but nativesdk build still fails.

Looking into it further I see that protoc is actually packaged by 
protobuf-compiler package, but when I try to add a package dependency to 
grpc recipe I get this:


nativesdk-protobuf RPROVIDES nativesdk-protobuf-compiler

Moreover, if I go into devshell and forcefully install 
nativesdk-libprotobuf-compiler, then `bitbake nativesdk-grpc` is happy 
and compiles!


So something wrong with the dependencies in protobuf recipe, but I can't 
figure out yet what exactly. Any ideas?


Regards,
Slava

On 02.10.2023 18:25, Vyacheslav Yurkov via lists.openembedded.org wrote:

On 01.10.2023 20:22, Martin Jansa wrote:


Issue with .cmake file from protobuf, right?


No, it's the issue with the cmake of the project that uses protobuf. 
But that depends on a user case, perhaps I didn't get it properly.



If we can properly fix it at the recipe level, then why should we
keep this workaround/hack?

Also if you really need it, you can have a .bbappend for
protoc/grpc in the downstream layer. But I would be in favor to
avoid this by default no?


I haven't seen any proper fix for this exact issue. Yes you can patch 
.cmake generation not to include bindir when building for target 
(while it needs it for native build), but then that change will break 
possible use of protobuf on target, so the SYSROOT_DIRS still seems 
like lesser evil here.


Here are some examples from meta-ros:
https://github.com/ros/meta-ros/commit/875ceed4b1c693c2eb0f2b7ea85385be576a62cc
https://github.com/ros/meta-ros/commit/67c03755543655ad0634e078bc30d8ab9969a16c
https://github.com/ros/meta-ros/commit/5e61eb0520d2841c0da7e14eecc833b3c4104533
https://github.com/ros/meta-ros/commit/a53bb7cc8b45a72b704e75311d68b37a6db50cdf

I don't care about protobuf, but the explanation from Samuli looks 
like the same issue as what I remember from above and I don't see how 
SYSROOT_DIRS causes mixing executables or any issues for installing 
them for target.


I didn't look at the original issue of Samuli, but your issue is also 
fixed by a workaround. IMHO, the proper fix would be not to make CMake 
"happy" by providing a binary it can't use, but a proper export of 
cross-compiled tools for 
https://github.com/geographiclib/geographiclib/blob/main/CMakeLists.txt 
library. I'd say the workflow should be similar to protobuf/grpc 
recipes, i.e. a native recipe builds the libraries only, and the 
target recipe builds tools and libraries.


Regards,
Slava

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#105450): 
https://lists.openembedded.org/g/openembedded-devel/message/105450
Mute This Topic: https://lists.openembedded.org/mt/101679410/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [oe] [meta-filesystems][PATCH 1/7] Add static-passwd and static-group files

2023-10-12 Thread Vyacheslav Yurkov

Thanks for the patch.

Is there any way to ensure (have a QA?) this file is updated / not 
forgotten when somebody else adds new id in the recipe?


Slava

On 10.10.2023 11:39, Fabien Thomas wrote:

In order to pass reproducible tests, recipes that use the
useradd class must have static ids configured.

Signed-off-by: Fabien Thomas 
Reviewed-by: Yoann Congal 
---
  meta-filesystems/files/static-passwd-meta-filesystems | 3 +++
  1 file changed, 3 insertions(+)
  create mode 100644 meta-filesystems/files/static-passwd-meta-filesystems

diff --git a/meta-filesystems/files/static-passwd-meta-filesystems 
b/meta-filesystems/files/static-passwd-meta-filesystems
new file mode 100644
index 0..157697f3e
--- /dev/null
+++ b/meta-filesystems/files/static-passwd-meta-filesystems
@@ -0,0 +1,3 @@
+fsgqa:x:700:nogroup::/:/bin/nologin
+123456-fsgqa:x:701:nogroup::/:/bin/nologin
+fsgqa2:x:702:nogroup::/:/bin/nologin
\ No newline at end of file



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#105449): 
https://lists.openembedded.org/g/openembedded-devel/message/105449
Mute This Topic: https://lists.openembedded.org/mt/101871602/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [oe] [PATCH] Revert "protobuf: stage protoc binary to sysroot"

2023-10-02 Thread Vyacheslav Yurkov

On 01.10.2023 20:22, Martin Jansa wrote:


Issue with .cmake file from protobuf, right?


No, it's the issue with the cmake of the project that uses protobuf. But 
that depends on a user case, perhaps I didn't get it properly.



If we can properly fix it at the recipe level, then why should we
keep this workaround/hack?

Also if you really need it, you can have a .bbappend for
protoc/grpc in the downstream layer. But I would be in favor to
avoid this by default no?


I haven't seen any proper fix for this exact issue. Yes you can patch 
.cmake generation not to include bindir when building for target 
(while it needs it for native build), but then that change will break 
possible use of protobuf on target, so the SYSROOT_DIRS still seems 
like lesser evil here.


Here are some examples from meta-ros:
https://github.com/ros/meta-ros/commit/875ceed4b1c693c2eb0f2b7ea85385be576a62cc
https://github.com/ros/meta-ros/commit/67c03755543655ad0634e078bc30d8ab9969a16c
https://github.com/ros/meta-ros/commit/5e61eb0520d2841c0da7e14eecc833b3c4104533
https://github.com/ros/meta-ros/commit/a53bb7cc8b45a72b704e75311d68b37a6db50cdf

I don't care about protobuf, but the explanation from Samuli looks 
like the same issue as what I remember from above and I don't see how 
SYSROOT_DIRS causes mixing executables or any issues for installing 
them for target.


I didn't look at the original issue of Samuli, but your issue is also 
fixed by a workaround. IMHO, the proper fix would be not to make CMake 
"happy" by providing a binary it can't use, but a proper export of 
cross-compiled tools for 
https://github.com/geographiclib/geographiclib/blob/main/CMakeLists.txt 
library. I'd say the workflow should be similar to protobuf/grpc 
recipes, i.e. a native recipe builds the libraries only, and the target 
recipe builds tools and libraries.


Regards,
Slava

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#105307): 
https://lists.openembedded.org/g/openembedded-devel/message/105307
Mute This Topic: https://lists.openembedded.org/mt/101679410/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [oe] [PATCH] Revert "protobuf: stage protoc binary to sysroot"

2023-09-30 Thread Vyacheslav Yurkov
I agree, protoc should _not_ be in sysroot, because target binary can't 
run on host system.


Vyacheslav

On 30.09.2023 19:30, Clément Péron wrote:

This reverts commit a0557fe5433620717eeb00d3b16801711337b1a4.

As said by Ross[Ø]:
"Putting the _target_ protoc into the sysroot for executation at _build_
time isn't useful because even if it has the right architecture, the
tune might be incompatible.  Recipes which want protoc should just depend
on protobuf-native."

This has been reverted recently by Samuli[1]:
"If protoc is enabled for the build, recipes using protobuf will
fail when protoc is not available in the recipe sysroot"

Be the revert is incorret as This is an issue coming from qtgrpc
other recipes that use protobuf or gRPC compiler, proplery looks for
the binary in the correct sysroot folder.

Qtgrpc recipe should fix this issue at the recipe level, for example this
is what I've done for "etcd-cpp-apiv3" recipe[2] that doesn't need this
patch to properly compile.

So keeping this hack doesn't seems to be a correct fix.

Note that qtgrpc recipe isn't available on meta-oe nor any other public
layers.

0: 
https://patchwork.yoctoproject.org/project/oe/patch/20230904161230.377450-1-ross.bur...@arm.com/
1: 
https://patchwork.yoctoproject.org/project/oe/patch/20230927051101.3088498-1-samuli.pii...@qt.io/
2: 
https://github.com/etcd-cpp-apiv3/etcd-cpp-apiv3/commit/47f0d9e0326f3cc31c801a0ecf7312d1049ece3e

CC: Samuli Piippo 
CC: Ross Burton 
Signed-off-by: Clément Péron 
---
  meta-oe/recipes-devtools/protobuf/protobuf_4.23.4.bb | 3 ---
  1 file changed, 3 deletions(-)

diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_4.23.4.bb 
b/meta-oe/recipes-devtools/protobuf/protobuf_4.23.4.bb
index 06d73d648..1edc21cdf 100644
--- a/meta-oe/recipes-devtools/protobuf/protobuf_4.23.4.bb
+++ b/meta-oe/recipes-devtools/protobuf/protobuf_4.23.4.bb
@@ -101,9 +101,6 @@ PACKAGE_BEFORE_PN = "${PN}-compiler ${PN}-lite"
  FILES:${PN}-compiler = "${bindir} ${libdir}/libprotoc${SOLIBS}"
  FILES:${PN}-lite = "${libdir}/libprotobuf-lite${SOLIBS}"
  
-# CMake requires binaries to exist in sysroot, even if they have wrong architecture.

-SYSROOT_DIRS += "${bindir}"
-
  RDEPENDS:${PN}-compiler = "${PN}"
  RDEPENDS:${PN}-dev += "${PN}-compiler"
  RDEPENDS:${PN}-ptest = "bash ${@bb.utils.contains('PACKAGECONFIG', 'python', 
'python3-protobuf', '', d)}"






-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#105290): 
https://lists.openembedded.org/g/openembedded-devel/message/105290
Mute This Topic: https://lists.openembedded.org/mt/101679410/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-filesystems][PATCH v2 3/3] overlayfs-tools: Install fsck binary

2023-09-29 Thread Vyacheslav Yurkov
Two projects, overlayfs-tools and overlayfs-progs, were combined
upstream.

Signed-off-by: Vyacheslav Yurkov 
---
 ...-Makefile-proper-location-of-LDFLAGS.patch | 32 ---
 .../overlayfs/overlayfs-progs_git.bb  | 32 ---
 .../overlayfs/overlayfs-tools_git.bb  |  5 +--
 .../xfstests/xfstests_2023.03.05.bb   |  2 +-
 4 files changed, 2 insertions(+), 69 deletions(-)
 delete mode 100644 
meta-filesystems/recipes-utils/overlayfs/overlayfs-progs/0001-Makefile-proper-location-of-LDFLAGS.patch
 delete mode 100644 
meta-filesystems/recipes-utils/overlayfs/overlayfs-progs_git.bb

diff --git 
a/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs/0001-Makefile-proper-location-of-LDFLAGS.patch
 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs/0001-Makefile-proper-location-of-LDFLAGS.patch
deleted file mode 100644
index 2c001834b..0
--- 
a/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs/0001-Makefile-proper-location-of-LDFLAGS.patch
+++ /dev/null
@@ -1,32 +0,0 @@
-From 8eeaee82dcfdf47f16ad880e416b722827f41bdb Mon Sep 17 00:00:00 2001
-From: Vyacheslav Yurkov 
-Date: Mon, 23 May 2022 19:37:32 +0200
-Subject: [PATCH] Makefile: proper location of LDFLAGS
-
-Signed-off-by: Vyacheslav Yurkov 

-Upstream-Status: Pending
-
- Makefile | 4 ++--
- 1 file changed, 2 insertions(+), 2 deletions(-)
-
-diff --git a/Makefile b/Makefile
-index e3c5207..14b155e 100644
 a/Makefile
-+++ b/Makefile
-@@ -1,5 +1,5 @@
- CFLAGS = -Wall -g
--LFLAGS = -lm
-+LDFLAGS = -lm
- CC = gcc
- 
- all: overlay
-@@ -7,7 +7,7 @@ all: overlay
- objects = fsck.o common.o lib.o check.o mount.o path.o overlayfs.o
- 
- overlay: $(objects)
--  $(CC) $(LFLAGS) $(objects) -o fsck.overlay
-+  $(CC) $(objects) -o fsck.overlay $(LDFLAGS) 
- 
- .c.o:
-   $(CC) $(CFLAGS) -c $<
diff --git a/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs_git.bb 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs_git.bb
deleted file mode 100644
index 9d58b9a63..0
--- a/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs_git.bb
+++ /dev/null
@@ -1,32 +0,0 @@
-SUMMARY = "File system check utility for OverlayFS"
-HOMEPAGE = "https://github.com/hisilicon/overlayfs-progs;
-LICENSE = "PD"
-LIC_FILES_CHKSUM = 
"file://${COREBASE}/meta/files/common-licenses/PD;md5=b3597d12946881e13cb3b548d1173851"
-
-SRC_URI = "\
-
git://github.com/hisilicon/overlayfs-progs.git;protocol=https;branch=master \
-file://0001-Makefile-proper-location-of-LDFLAGS.patch \
-"
-
-PV = "1.0+git${SRCPV}"
-SRCREV = "e10ef686570d9c7eff42f52461593a5c15da56bd"
-
-S = "${WORKDIR}/git"
-B = "${S}"
-
-# Required to have the fts.h header for musl
-DEPENDS:append:libc-musl = " fts"
-# Fix the missing fts libs when using musl
-EXTRA_OEMAKE:append:libc-musl = " LDFLAGS='-lfts'"
-
-EXTRA_OEMAKE += "'CC=${CC} -O2' "
-TARGET_CC_ARCH += "${LDFLAGS}"
-
-do_compile () {
-oe_runmake
-}
-
-do_install () {
-install -d ${D}${bindir}
-install -m 0755 ${B}/fsck.overlay ${D}${bindir}
-}
diff --git a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
index de5155133..ca2ec9cc4 100644
--- a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
+++ b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
@@ -21,11 +21,8 @@ EXTRA_OEMAKE += "'CC=${CC} -O2'"
 EXTRA_OEMAKE:append:libc-musl = " LDLIBS=-lfts"
 TARGET_CC_ARCH += "${LDFLAGS}"
 
-do_compile () {
-oe_runmake
-}
-
 do_install () {
 install -d ${D}${bindir}
 install -m 0755 ${B}/overlay ${D}${bindir}
+install -m 0755 ${B}/fsck.overlay ${D}${bindir}
 }
diff --git a/meta-filesystems/recipes-utils/xfstests/xfstests_2023.03.05.bb 
b/meta-filesystems/recipes-utils/xfstests/xfstests_2023.03.05.bb
index fdfe04574..cfb6e4fd8 100644
--- a/meta-filesystems/recipes-utils/xfstests/xfstests_2023.03.05.bb
+++ b/meta-filesystems/recipes-utils/xfstests/xfstests_2023.03.05.bb
@@ -28,7 +28,7 @@ RDEPENDS:${PN} += "\
 e2fsprogs-resize2fs \
 libaio \
 libcap-bin \
-overlayfs-progs \
+overlayfs-tools \
 perl \
 python3 \
 python3-core \
-- 
2.35.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#105279): 
https://lists.openembedded.org/g/openembedded-devel/message/105279
Mute This Topic: https://lists.openembedded.org/mt/101667946/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-filesystems][PATCH v2 2/3] overlayfs-tools: Bump up the version

2023-09-29 Thread Vyacheslav Yurkov
Drop the patches, they have been merged upstream.

Signed-off-by: Vyacheslav Yurkov 
---
 ...-so-that-it-compiles-on-Ubuntu-20.04.patch | 43 ---
 .../0002-makefile-fix-linking-flags.patch | 33 --
 .../overlayfs/overlayfs-tools_git.bb  |  4 +-
 3 files changed, 1 insertion(+), 79 deletions(-)
 delete mode 100644 
meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0001-Fixed-includes-so-that-it-compiles-on-Ubuntu-20.04.patch
 delete mode 100644 
meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0002-makefile-fix-linking-flags.patch

diff --git 
a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0001-Fixed-includes-so-that-it-compiles-on-Ubuntu-20.04.patch
 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0001-Fixed-includes-so-that-it-compiles-on-Ubuntu-20.04.patch
deleted file mode 100644
index ed84d92c7..0
--- 
a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0001-Fixed-includes-so-that-it-compiles-on-Ubuntu-20.04.patch
+++ /dev/null
@@ -1,43 +0,0 @@
-From 81b4fbb5f52044cb348534c23f10b3884972b09b Mon Sep 17 00:00:00 2001
-From: Beat Schaer 
-Date: Fri, 19 Mar 2021 08:18:58 +0100
-Subject: [PATCH] Fixed includes so that it compiles on Ubuntu 20.04
-

-Upstream-Status: Pending
-
- logic.c | 3 +--
- main.c  | 3 ++-
- 2 files changed, 3 insertions(+), 3 deletions(-)
-
-diff --git a/logic.c b/logic.c
-index 97767f5..47ebfaa 100644
 a/logic.c
-+++ b/logic.c
-@@ -7,8 +7,7 @@
- #include 
- #include 
- #include 
--#include 
--#include 
-+#include 
- #include 
- #include 
- #include "logic.h"
-diff --git a/main.c b/main.c
-index aa11239..f462b98 100644
 a/main.c
-+++ b/main.c
-@@ -12,7 +12,8 @@
- #include 
- #include 
- #include 
--#include 
-+#include 
-+#include 
- #ifndef _SYS_STAT_H
-   #include 
- #endif
--- 
-2.25.1
-
diff --git 
a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0002-makefile-fix-linking-flags.patch
 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0002-makefile-fix-linking-flags.patch
deleted file mode 100644
index 8fbb250f0..0
--- 
a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0002-makefile-fix-linking-flags.patch
+++ /dev/null
@@ -1,33 +0,0 @@
-From b4ff5886797e72d1c21da43261ca7648412f3186 Mon Sep 17 00:00:00 2001
-From: Vyacheslav Yurkov 
-Date: Mon, 23 May 2022 19:53:21 +0200
-Subject: [PATCH] makefile: fix linking flags
-
-LDLIBS should be placed at the end according to
-https://www.gnu.org/software/make/manual/html_node/Catalogue-of-Rules.html
-
-Signed-off-by: Vyacheslav Yurkov 

-Upstream-Status: Pending
-
- makefile | 4 ++--
- 1 file changed, 2 insertions(+), 2 deletions(-)
-
-diff --git a/makefile b/makefile
-index fb1bed4..038c7ce 100644
 a/makefile
-+++ b/makefile
-@@ -1,11 +1,11 @@
- CFLAGS = -Wall -std=c99
--LFLAGS = -lm
-+LDLIBS = -lm
- CC = gcc
- 
- all: overlay
- 
- overlay: main.o logic.o sh.o
--  $(CC) $(LFLAGS) main.o logic.o sh.o -o overlay
-+  $(CC) main.o logic.o sh.o -o overlay $(LDLIBS) 
- 
- main.o: main.c logic.h
-   $(CC) $(CFLAGS) -c main.c
diff --git a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
index c638be9af..de5155133 100644
--- a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
+++ b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
@@ -5,12 +5,10 @@ LIC_FILES_CHKSUM = 
"file://LICENSE.txt;md5=f312a7c4d02230e8f2b537295d375c69"
 
 SRC_URI = "\
 git://github.com/kmxz/overlayfs-tools.git;protocol=https;branch=master \
-file://0001-Fixed-includes-so-that-it-compiles-on-Ubuntu-20.04.patch \
-file://0002-makefile-fix-linking-flags.patch \
 "
 
 PV = "1.0+git${SRCPV}"
-SRCREV = "291c7f4a3fb548d06c572700650c2e3bccb0cd27"
+SRCREV = "b5e5a829895ac98ccfe4629fbfbd8b819262bd00"
 
 S = "${WORKDIR}/git"
 B = "${S}"
-- 
2.35.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#105278): 
https://lists.openembedded.org/g/openembedded-devel/message/105278
Mute This Topic: https://lists.openembedded.org/mt/101667944/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-filesystems][PATCH v2 1/3] overlayfs-tools: Drop unneeded dependency

2023-09-29 Thread Vyacheslav Yurkov
Signed-off-by: Vyacheslav Yurkov 
---
 meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
index eb6e4963a..c638be9af 100644
--- a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
+++ b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
@@ -15,7 +15,6 @@ SRCREV = "291c7f4a3fb548d06c572700650c2e3bccb0cd27"
 S = "${WORKDIR}/git"
 B = "${S}"
 
-DEPENDS += "attr"
 # Required to have the fts.h header for musl
 DEPENDS:append:libc-musl = " fts"
 
-- 
2.35.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#105277): 
https://lists.openembedded.org/g/openembedded-devel/message/105277
Mute This Topic: https://lists.openembedded.org/mt/101667942/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [oe] [meta-filesystems][PATCH 3/3] overlayfs-tools: Install fsck binary

2023-09-29 Thread Vyacheslav Yurkov
Thanks for catching this. I'd rather change the dependency in V2.

Slava

On Fri, Sep 29, 2023, 10:22 Khem Raj  wrote:

> On Fri, Sep 29, 2023 at 6:38 AM Vyacheslav Yurkov 
> wrote:
> >
> > Two projects, overlayfs-tools and overlayfs-progs, were combined
> > upstream.
>
> Merging into one is fine however there are dependencies on
> overlayfs-progs so perhaps we need to add
> RPROVIDES = "overlayfs-progs" to overlayfs-tools_git.bb and then
> update the recipes e.g. xftests to depend on overayfs-tools
>
> >
> > Signed-off-by: Vyacheslav Yurkov 
> > ---
> >  ...-Makefile-proper-location-of-LDFLAGS.patch | 32 ---
> >  .../overlayfs/overlayfs-progs_git.bb  | 32 ---
> >  .../overlayfs/overlayfs-tools_git.bb  |  5 +--
> >  3 files changed, 1 insertion(+), 68 deletions(-)
> >  delete mode 100644
> meta-filesystems/recipes-utils/overlayfs/overlayfs-progs/0001-Makefile-proper-location-of-LDFLAGS.patch
> >  delete mode 100644 meta-filesystems/recipes-utils/overlayfs/
> overlayfs-progs_git.bb
> >
> > diff --git
> a/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs/0001-Makefile-proper-location-of-LDFLAGS.patch
> b/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs/0001-Makefile-proper-location-of-LDFLAGS.patch
> > deleted file mode 100644
> > index 2c001834b..0
> > ---
> a/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs/0001-Makefile-proper-location-of-LDFLAGS.patch
> > +++ /dev/null
> > @@ -1,32 +0,0 @@
> > -From 8eeaee82dcfdf47f16ad880e416b722827f41bdb Mon Sep 17 00:00:00 2001
> > -From: Vyacheslav Yurkov 
> > -Date: Mon, 23 May 2022 19:37:32 +0200
> > -Subject: [PATCH] Makefile: proper location of LDFLAGS
> > -
> > -Signed-off-by: Vyacheslav Yurkov 
> > 
> > -Upstream-Status: Pending
> > -
> > - Makefile | 4 ++--
> > - 1 file changed, 2 insertions(+), 2 deletions(-)
> > -
> > -diff --git a/Makefile b/Makefile
> > -index e3c5207..14b155e 100644
> >  a/Makefile
> > -+++ b/Makefile
> > -@@ -1,5 +1,5 @@
> > - CFLAGS = -Wall -g
> > --LFLAGS = -lm
> > -+LDFLAGS = -lm
> > - CC = gcc
> > -
> > - all: overlay
> > -@@ -7,7 +7,7 @@ all: overlay
> > - objects = fsck.o common.o lib.o check.o mount.o path.o overlayfs.o
> > -
> > - overlay: $(objects)
> > --  $(CC) $(LFLAGS) $(objects) -o fsck.overlay
> > -+  $(CC) $(objects) -o fsck.overlay $(LDFLAGS)
> > -
> > - .c.o:
> > -   $(CC) $(CFLAGS) -c $<
> > diff --git a/meta-filesystems/recipes-utils/overlayfs/
> overlayfs-progs_git.bb b/meta-filesystems/recipes-utils/overlayfs/
> overlayfs-progs_git.bb
> > deleted file mode 100644
> > index 9d58b9a63..0
> > --- a/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs_git.bb
> > +++ /dev/null
> > @@ -1,32 +0,0 @@
> > -SUMMARY = "File system check utility for OverlayFS"
> > -HOMEPAGE = "https://github.com/hisilicon/overlayfs-progs;
> > -LICENSE = "PD"
> > -LIC_FILES_CHKSUM =
> "file://${COREBASE}/meta/files/common-licenses/PD;md5=b3597d12946881e13cb3b548d1173851"
> > -
> > -SRC_URI = "\
> > -git://
> github.com/hisilicon/overlayfs-progs.git;protocol=https;branch=master \
> > -file://0001-Makefile-proper-location-of-LDFLAGS.patch \
> > -"
> > -
> > -PV = "1.0+git${SRCPV}"
> > -SRCREV = "e10ef686570d9c7eff42f52461593a5c15da56bd"
> > -
> > -S = "${WORKDIR}/git"
> > -B = "${S}"
> > -
> > -# Required to have the fts.h header for musl
> > -DEPENDS:append:libc-musl = " fts"
> > -# Fix the missing fts libs when using musl
> > -EXTRA_OEMAKE:append:libc-musl = " LDFLAGS='-lfts'"
> > -
> > -EXTRA_OEMAKE += "'CC=${CC} -O2' "
> > -TARGET_CC_ARCH += "${LDFLAGS}"
> > -
> > -do_compile () {
> > -oe_runmake
> > -}
> > -
> > -do_install () {
> > -install -d ${D}${bindir}
> > -install -m 0755 ${B}/fsck.overlay ${D}${bindir}
> > -}
> > diff --git a/meta-filesystems/recipes-utils/overlayfs/
> overlayfs-tools_git.bb b/meta-filesystems/recipes-utils/overlayfs/
> overlayfs-tools_git.bb
> > index de5155133..ca2ec9cc4 100644
> > --- a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
> > +++ b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
> > @@ -21,11 +21,8 @@ EXTRA_OEMAKE += "'CC=${CC} -O2'"
> >  EXTRA_OEMAKE:append:libc-musl = " LDLIBS=-lfts"
> >  TARGET_CC_ARCH += "${LDFLAGS}"
> >
> > -do_compile () {
> > -oe_runmake
> > -}
> > -
> >  do_install () {
> >  install -d ${D}${bindir}
> >  install -m 0755 ${B}/overlay ${D}${bindir}
> > +install -m 0755 ${B}/fsck.overlay ${D}${bindir}
> >  }
> > --
> > 2.35.1
> >
> >
> > 
> >
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#105259): 
https://lists.openembedded.org/g/openembedded-devel/message/105259
Mute This Topic: https://lists.openembedded.org/mt/101657502/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-filesystems][PATCH 3/3] overlayfs-tools: Install fsck binary

2023-09-29 Thread Vyacheslav Yurkov
Two projects, overlayfs-tools and overlayfs-progs, were combined
upstream.

Signed-off-by: Vyacheslav Yurkov 
---
 ...-Makefile-proper-location-of-LDFLAGS.patch | 32 ---
 .../overlayfs/overlayfs-progs_git.bb  | 32 ---
 .../overlayfs/overlayfs-tools_git.bb  |  5 +--
 3 files changed, 1 insertion(+), 68 deletions(-)
 delete mode 100644 
meta-filesystems/recipes-utils/overlayfs/overlayfs-progs/0001-Makefile-proper-location-of-LDFLAGS.patch
 delete mode 100644 
meta-filesystems/recipes-utils/overlayfs/overlayfs-progs_git.bb

diff --git 
a/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs/0001-Makefile-proper-location-of-LDFLAGS.patch
 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs/0001-Makefile-proper-location-of-LDFLAGS.patch
deleted file mode 100644
index 2c001834b..0
--- 
a/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs/0001-Makefile-proper-location-of-LDFLAGS.patch
+++ /dev/null
@@ -1,32 +0,0 @@
-From 8eeaee82dcfdf47f16ad880e416b722827f41bdb Mon Sep 17 00:00:00 2001
-From: Vyacheslav Yurkov 
-Date: Mon, 23 May 2022 19:37:32 +0200
-Subject: [PATCH] Makefile: proper location of LDFLAGS
-
-Signed-off-by: Vyacheslav Yurkov 

-Upstream-Status: Pending
-
- Makefile | 4 ++--
- 1 file changed, 2 insertions(+), 2 deletions(-)
-
-diff --git a/Makefile b/Makefile
-index e3c5207..14b155e 100644
 a/Makefile
-+++ b/Makefile
-@@ -1,5 +1,5 @@
- CFLAGS = -Wall -g
--LFLAGS = -lm
-+LDFLAGS = -lm
- CC = gcc
- 
- all: overlay
-@@ -7,7 +7,7 @@ all: overlay
- objects = fsck.o common.o lib.o check.o mount.o path.o overlayfs.o
- 
- overlay: $(objects)
--  $(CC) $(LFLAGS) $(objects) -o fsck.overlay
-+  $(CC) $(objects) -o fsck.overlay $(LDFLAGS) 
- 
- .c.o:
-   $(CC) $(CFLAGS) -c $<
diff --git a/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs_git.bb 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs_git.bb
deleted file mode 100644
index 9d58b9a63..0
--- a/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs_git.bb
+++ /dev/null
@@ -1,32 +0,0 @@
-SUMMARY = "File system check utility for OverlayFS"
-HOMEPAGE = "https://github.com/hisilicon/overlayfs-progs;
-LICENSE = "PD"
-LIC_FILES_CHKSUM = 
"file://${COREBASE}/meta/files/common-licenses/PD;md5=b3597d12946881e13cb3b548d1173851"
-
-SRC_URI = "\
-
git://github.com/hisilicon/overlayfs-progs.git;protocol=https;branch=master \
-file://0001-Makefile-proper-location-of-LDFLAGS.patch \
-"
-
-PV = "1.0+git${SRCPV}"
-SRCREV = "e10ef686570d9c7eff42f52461593a5c15da56bd"
-
-S = "${WORKDIR}/git"
-B = "${S}"
-
-# Required to have the fts.h header for musl
-DEPENDS:append:libc-musl = " fts"
-# Fix the missing fts libs when using musl
-EXTRA_OEMAKE:append:libc-musl = " LDFLAGS='-lfts'"
-
-EXTRA_OEMAKE += "'CC=${CC} -O2' "
-TARGET_CC_ARCH += "${LDFLAGS}"
-
-do_compile () {
-oe_runmake
-}
-
-do_install () {
-install -d ${D}${bindir}
-install -m 0755 ${B}/fsck.overlay ${D}${bindir}
-}
diff --git a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
index de5155133..ca2ec9cc4 100644
--- a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
+++ b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
@@ -21,11 +21,8 @@ EXTRA_OEMAKE += "'CC=${CC} -O2'"
 EXTRA_OEMAKE:append:libc-musl = " LDLIBS=-lfts"
 TARGET_CC_ARCH += "${LDFLAGS}"
 
-do_compile () {
-oe_runmake
-}
-
 do_install () {
 install -d ${D}${bindir}
 install -m 0755 ${B}/overlay ${D}${bindir}
+install -m 0755 ${B}/fsck.overlay ${D}${bindir}
 }
-- 
2.35.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#105245): 
https://lists.openembedded.org/g/openembedded-devel/message/105245
Mute This Topic: https://lists.openembedded.org/mt/101657502/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-filesystems][PATCH 2/3] overlayfs-tools: Bump up the version

2023-09-29 Thread Vyacheslav Yurkov
Drop the patches, they have been merged upstream.

Signed-off-by: Vyacheslav Yurkov 
---
 ...-so-that-it-compiles-on-Ubuntu-20.04.patch | 43 ---
 .../0002-makefile-fix-linking-flags.patch | 33 --
 .../overlayfs/overlayfs-tools_git.bb  |  4 +-
 3 files changed, 1 insertion(+), 79 deletions(-)
 delete mode 100644 
meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0001-Fixed-includes-so-that-it-compiles-on-Ubuntu-20.04.patch
 delete mode 100644 
meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0002-makefile-fix-linking-flags.patch

diff --git 
a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0001-Fixed-includes-so-that-it-compiles-on-Ubuntu-20.04.patch
 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0001-Fixed-includes-so-that-it-compiles-on-Ubuntu-20.04.patch
deleted file mode 100644
index ed84d92c7..0
--- 
a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0001-Fixed-includes-so-that-it-compiles-on-Ubuntu-20.04.patch
+++ /dev/null
@@ -1,43 +0,0 @@
-From 81b4fbb5f52044cb348534c23f10b3884972b09b Mon Sep 17 00:00:00 2001
-From: Beat Schaer 
-Date: Fri, 19 Mar 2021 08:18:58 +0100
-Subject: [PATCH] Fixed includes so that it compiles on Ubuntu 20.04
-

-Upstream-Status: Pending
-
- logic.c | 3 +--
- main.c  | 3 ++-
- 2 files changed, 3 insertions(+), 3 deletions(-)
-
-diff --git a/logic.c b/logic.c
-index 97767f5..47ebfaa 100644
 a/logic.c
-+++ b/logic.c
-@@ -7,8 +7,7 @@
- #include 
- #include 
- #include 
--#include 
--#include 
-+#include 
- #include 
- #include 
- #include "logic.h"
-diff --git a/main.c b/main.c
-index aa11239..f462b98 100644
 a/main.c
-+++ b/main.c
-@@ -12,7 +12,8 @@
- #include 
- #include 
- #include 
--#include 
-+#include 
-+#include 
- #ifndef _SYS_STAT_H
-   #include 
- #endif
--- 
-2.25.1
-
diff --git 
a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0002-makefile-fix-linking-flags.patch
 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0002-makefile-fix-linking-flags.patch
deleted file mode 100644
index 8fbb250f0..0
--- 
a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0002-makefile-fix-linking-flags.patch
+++ /dev/null
@@ -1,33 +0,0 @@
-From b4ff5886797e72d1c21da43261ca7648412f3186 Mon Sep 17 00:00:00 2001
-From: Vyacheslav Yurkov 
-Date: Mon, 23 May 2022 19:53:21 +0200
-Subject: [PATCH] makefile: fix linking flags
-
-LDLIBS should be placed at the end according to
-https://www.gnu.org/software/make/manual/html_node/Catalogue-of-Rules.html
-
-Signed-off-by: Vyacheslav Yurkov 

-Upstream-Status: Pending
-
- makefile | 4 ++--
- 1 file changed, 2 insertions(+), 2 deletions(-)
-
-diff --git a/makefile b/makefile
-index fb1bed4..038c7ce 100644
 a/makefile
-+++ b/makefile
-@@ -1,11 +1,11 @@
- CFLAGS = -Wall -std=c99
--LFLAGS = -lm
-+LDLIBS = -lm
- CC = gcc
- 
- all: overlay
- 
- overlay: main.o logic.o sh.o
--  $(CC) $(LFLAGS) main.o logic.o sh.o -o overlay
-+  $(CC) main.o logic.o sh.o -o overlay $(LDLIBS) 
- 
- main.o: main.c logic.h
-   $(CC) $(CFLAGS) -c main.c
diff --git a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
index c638be9af..de5155133 100644
--- a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
+++ b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
@@ -5,12 +5,10 @@ LIC_FILES_CHKSUM = 
"file://LICENSE.txt;md5=f312a7c4d02230e8f2b537295d375c69"
 
 SRC_URI = "\
 git://github.com/kmxz/overlayfs-tools.git;protocol=https;branch=master \
-file://0001-Fixed-includes-so-that-it-compiles-on-Ubuntu-20.04.patch \
-file://0002-makefile-fix-linking-flags.patch \
 "
 
 PV = "1.0+git${SRCPV}"
-SRCREV = "291c7f4a3fb548d06c572700650c2e3bccb0cd27"
+SRCREV = "b5e5a829895ac98ccfe4629fbfbd8b819262bd00"
 
 S = "${WORKDIR}/git"
 B = "${S}"
-- 
2.35.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#105244): 
https://lists.openembedded.org/g/openembedded-devel/message/105244
Mute This Topic: https://lists.openembedded.org/mt/101657501/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-filesystems][PATCH 1/3] overlayfs-tools: Drop unneeded dependency

2023-09-29 Thread Vyacheslav Yurkov
Signed-off-by: Vyacheslav Yurkov 
---
 meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
index eb6e4963a..c638be9af 100644
--- a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
+++ b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
@@ -15,7 +15,6 @@ SRCREV = "291c7f4a3fb548d06c572700650c2e3bccb0cd27"
 S = "${WORKDIR}/git"
 B = "${S}"
 
-DEPENDS += "attr"
 # Required to have the fts.h header for musl
 DEPENDS:append:libc-musl = " fts"
 
-- 
2.35.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#105243): 
https://lists.openembedded.org/g/openembedded-devel/message/105243
Mute This Topic: https://lists.openembedded.org/mt/101657500/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [oe] [meta-oe][PATCH] protobuf: stage protoc binary to sysroot

2023-09-28 Thread Vyacheslav Yurkov
I think I was the one who originally removed protoc, because it's not 
useful in the sysroot. Even if you satisfy cmake so it can find protoc 
target, the next step is that it will try to use it, which will 
obviously fail.


The only reason to put it on the target sysroot would be if you really 
going to use it _on the target_. But I guess this can be done via 
bbappend in the user layer.


Vyacheslav

On 27.09.2023 07:19, Samuli Piippo wrote:
Re-applying this patch as it got removed in 
https://patchwork.yoctoproject.org/project/oe/patch/20230904161230.377450-1-ross.bur...@arm.com/


On Wed, 27 Sept 2023 at 08:11, Samuli Piippo via 
lists.openembedded.org  
 wrote:


From: Samuli Piippo 

If protoc is enabled for the build, recipes using protobuf will
fail when protoc is not available in the recipe sysroot:

|   The imported target "protobuf::protoc" references the file
|
|

".../recipe-sysroot/usr/local/oe-sdk-hardcoded-buildpath/sysroots/x86_64-pokysdk-linux/usr/bin/protoc-3.21.5.0"
|
|   but this file does not exist.  Possible reasons include:
|
|   * The file was deleted, renamed, or moved to another location.
|
|   * An install or uninstall procedure did not complete successfully.
|
|   * The installation package was faulty and contained
|
|

".../recipe-sysroot/usr/local/oe-sdk-hardcoded-buildpath/sysroots/x86_64-pokysdk-linux/usr/lib/cmake/protobuf/protobuf-targets.cmake"
|
|   but not all the files it references.

Use SYSROOT_DIRS to stage the binary to sysroot so it's always
available for other recipes.

Signed-off-by: Samuli Piippo 
Signed-off-by: Khem Raj 
---
 meta-oe/recipes-devtools/protobuf/protobuf_3.21.12.bb
 | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.12.bb

b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.12.bb

index d95e1c20f..06b21a0d6 100644
--- a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.12.bb

+++ b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.12.bb

@@ -92,6 +92,9 @@ PACKAGE_BEFORE_PN = "${PN}-compiler ${PN}-lite"
 FILES:${PN}-compiler = "${bindir} ${libdir}/libprotoc${SOLIBS}"
 FILES:${PN}-lite = "${libdir}/libprotobuf-lite${SOLIBS}"

+# CMake requires binaries to exist in sysroot, even if they have
wrong architecture.
+SYSROOT_DIRS += "${bindir}"
+
 RDEPENDS:${PN}-compiler = "${PN}"
 RDEPENDS:${PN}-dev += "${PN}-compiler"
 RDEPENDS:${PN}-ptest = "bash
${@bb.utils.contains('PACKAGECONFIG', 'python',
'python3-protobuf', '', d)}"
-- 
2.25.1






-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#105224): 
https://lists.openembedded.org/g/openembedded-devel/message/105224
Mute This Topic: https://lists.openembedded.org/mt/101612304/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-networking][PATCH] opcua: Add new recipe

2022-10-03 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

open62541 (http://open62541.org) is an open source and free implementation
of OPC Unified Architecture according to IEC62541 standard

The patch exclude git-related files from installation directory
Upstream-Status: Accepted
https://github.com/open62541/open62541/commit/a0328d4cb527f9778a262fc4a6b42bfbdffc38e9

Signed-off-by: Vyacheslav Yurkov 
---
 ...1-fix-build-do-not-install-git-files.patch | 22 +++
 .../opcua/open62541_1.3.3.bb  | 38 +++
 2 files changed, 60 insertions(+)
 create mode 100644 
meta-networking/recipes-protocols/opcua/open62541/0001-fix-build-do-not-install-git-files.patch
 create mode 100644 meta-networking/recipes-protocols/opcua/open62541_1.3.3.bb

diff --git 
a/meta-networking/recipes-protocols/opcua/open62541/0001-fix-build-do-not-install-git-files.patch
 
b/meta-networking/recipes-protocols/opcua/open62541/0001-fix-build-do-not-install-git-files.patch
new file mode 100644
index 0..44ee7b92c
--- /dev/null
+++ 
b/meta-networking/recipes-protocols/opcua/open62541/0001-fix-build-do-not-install-git-files.patch
@@ -0,0 +1,22 @@
+From a490e82dca5a669b0af27a13d74759d8f77e2333 Mon Sep 17 00:00:00 2001
+From: Vyacheslav Yurkov 
+Date: Mon, 3 Oct 2022 18:25:15 +0200
+Subject: [PATCH] fix(build): do not install git files
+
+Signed-off-by: Vyacheslav Yurkov 
+---
+ CMakeLists.txt | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 1934374e..bc5c8bad 100644
+--- a/CMakeLists.txt
 b/CMakeLists.txt
+@@ -1703,6 +1703,7 @@ install(DIRECTORY ${UA_install_tools_dirs}
+ FILES_MATCHING
+ PATTERN "*"
+ PATTERN "*.pyc" EXCLUDE
++PATTERN ".git*" EXCLUDE
+ )
+ 
+ install(FILES ${UA_install_tools_files} DESTINATION 
${open62541_install_tools_dir})
diff --git a/meta-networking/recipes-protocols/opcua/open62541_1.3.3.bb 
b/meta-networking/recipes-protocols/opcua/open62541_1.3.3.bb
new file mode 100644
index 0..317697262
--- /dev/null
+++ b/meta-networking/recipes-protocols/opcua/open62541_1.3.3.bb
@@ -0,0 +1,38 @@
+DESCRIPTION = "open62541 is an implementation of OPC UA (OPC Unified 
Architecture)"
+HOMEPAGE = "https://github.com/open62541/open62541.git;
+LICENSE = "MPL-2.0 & BSD-3-Clause & MIT"
+LIC_FILES_CHKSUM = "\
+file://LICENSE;md5=815ca599c9df247a0c7f619bab123dad \
+file://deps/mdnsd/LICENSE;md5=3bb4047dc4095cd7336de3e2a9be94f0 \
+file://deps/mqtt-c/LICENSE;md5=9226377baf0b79174c89a1ab55592456 \
+"
+
+SRCREV_FORMAT = "opcua_mdnsd_ua-nodeset_mqtt-c"
+SRCREV_opcua = "ff73268829359639531ff02905c889f73a77b408"
+SRCREV_mdnsd = "3151afe5899dba5125dffa9f4cf3ae1fe2edc0f0"
+SRCREV_ua-nodeset = "f71b3f411d5cb16097c3ae0c744f67ad45535ffb"
+SRCREV_mqtt-c = "f69ce1e7fd54f3b1834c9c9137ce0ec5d703cb4d"
+
+SRC_URI = " \
+
git://github.com/open62541/open62541.git;name=opcua;branch=1.3;protocol=https \
+
git://github.com/Pro/mdnsd.git;name=mdnsd;protocol=https;branch=master;destsuffix=git/deps/mdnsd
 \
+
git://github.com/OPCFoundation/UA-Nodeset;name=ua-nodeset;protocol=https;branch=v1.04;destsuffix=git/deps/ua-nodeset
 \
+
git://github.com/LiamBindle/MQTT-C.git;name=mqtt-c;protocol=https;branch=master;destsuffix=git/deps/mqtt-c
 \
+file://0001-fix-build-do-not-install-git-files.patch \
+"
+
+S = "${WORKDIR}/git"
+
+inherit cmake python3native
+
+EXTRA_OECMAKE += "\
+-DBUILD_SHARED_LIBS=ON \
+-DUA_NAMESPACE_ZERO=FULL \
+-DUA_LOGLEVEL=600 \
+"
+
+PACKAGECONFIG ?= "encryption pubsub pubsub-eth"
+PACKAGECONFIG[amalgamation] = "-DUA_ENABLE_AMALGAMATION=ON, 
-DUA_ENABLE_AMALGAMATION=OFF"
+PACKAGECONFIG[encryption] = "-DUA_ENABLE_ENCRYPTION=ON, 
-DUA_ENABLE_ENCRYPTION=OFF, mbedtls"
+PACKAGECONFIG[pubsub] = "-DUA_ENABLE_PUBSUB=ON, -DUA_ENABLE_PUBSUB=OFF"
+PACKAGECONFIG[pubsub-eth] = "-DUA_ENABLE_PUBSUB_ETH_UADP=ON, 
-DUA_ENABLE_PUBSUB_ETH_UADP=OFF"
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#99046): 
https://lists.openembedded.org/g/openembedded-devel/message/99046
Mute This Topic: https://lists.openembedded.org/mt/94108224/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-oe][PATCH v3] protobuf: disable protoc binary for target

2022-08-27 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

When applications want to use protoc during the build, the target binary
has to be disabled in order to avoid following error:

|   The imported target "protobuf::protoc" references the file
|
|  "/recipe-sysroot/usr/bin/protoc-"
|
|   but this file does not exist.  Possible reasons include:
|
|   * The file was deleted, renamed, or moved to another location.
|
|   * An install or uninstall procedure did not complete successfully.
|
|   * The installation package was faulty and contained
|
|  "/recipe-sysroot/usr/lib/cmake/protobuf/protobuf-targets.cmake"
|
|   but not all the files it references.

Signed-off-by: Vyacheslav Yurkov 
---
 meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb 
b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
index 83dabc9f8..0d8648e2f 100644
--- a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
+++ b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
@@ -25,7 +25,9 @@ S = "${WORKDIR}/git"
 inherit cmake pkgconfig ptest
 
 PACKAGECONFIG ??= ""
+PACKAGECONFIG:class-native ?= "compiler"
 PACKAGECONFIG[python] = ",,"
+PACKAGECONFIG[compiler] = 
"-Dprotobuf_BUILD_PROTOC_BINARIES=ON,-Dprotobuf_BUILD_PROTOC_BINARIES=OFF"
 
 EXTRA_OECMAKE += "\
 -Dprotobuf_BUILD_SHARED_LIBS=ON \
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#98489): 
https://lists.openembedded.org/g/openembedded-devel/message/98489
Mute This Topic: https://lists.openembedded.org/mt/93286773/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [oe] [meta-oe][PATCH v2] protobuf: disable protoc binary for target

2022-08-27 Thread Vyacheslav Yurkov

On 27.08.2022 11:18, Khem Raj wrote:

On Sat, Aug 27, 2022 at 1:00 AM Vyacheslav Yurkov  wrote:

From: Vyacheslav Yurkov 

When applications want to use protoc during the build, the target binary
has to be disabled in order to avoid following error:

|   The imported target "protobuf::protoc" references the file
|
|  "/recipe-sysroot/usr/bin/protoc-"
|
|   but this file does not exist.  Possible reasons include:
|
|   * The file was deleted, renamed, or moved to another location.
|
|   * An install or uninstall procedure did not complete successfully.
|
|   * The installation package was faulty and contained
|
|  "/recipe-sysroot/usr/lib/cmake/protobuf/protobuf-targets.cmake"
|
|   but not all the files it references.

Signed-off-by: Vyacheslav Yurkov 
---
  meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb | 7 +++
  1 file changed, 7 insertions(+)

diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb 
b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
index 83dabc9f8..e36179363 100644
--- a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
+++ b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
@@ -34,6 +34,13 @@ EXTRA_OECMAKE += "\
  -Dprotobuf_BUILD_EXAMPLES=OFF \
  "

+# Configuration below allows to cross-compile protobuf applications
+# and use native protoc binary in your recipes. In order to use protoc
+# on the target, set protobuf_BUILD_PROTOC_BINARIES to ON in your bbappend
+EXTRA_OECMAKE:append:class-target = " \
+ -Dprotobuf_BUILD_PROTOC_BINARIES=OFF \
+"
+

can we make it a packageconfig perhaps ?



Makes sense. Any suggestions about the name? So far only something like 
"compiler" comes to mind.


Vyacheslav

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#98488): 
https://lists.openembedded.org/g/openembedded-devel/message/98488
Mute This Topic: https://lists.openembedded.org/mt/93286129/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-oe][PATCH v2] protobuf: disable protoc binary for target

2022-08-27 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

When applications want to use protoc during the build, the target binary
has to be disabled in order to avoid following error:

|   The imported target "protobuf::protoc" references the file
|
|  "/recipe-sysroot/usr/bin/protoc-"
|
|   but this file does not exist.  Possible reasons include:
|
|   * The file was deleted, renamed, or moved to another location.
|
|   * An install or uninstall procedure did not complete successfully.
|
|   * The installation package was faulty and contained
|
|  "/recipe-sysroot/usr/lib/cmake/protobuf/protobuf-targets.cmake"
|
|   but not all the files it references.

Signed-off-by: Vyacheslav Yurkov 
---
 meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb 
b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
index 83dabc9f8..e36179363 100644
--- a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
+++ b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
@@ -34,6 +34,13 @@ EXTRA_OECMAKE += "\
 -Dprotobuf_BUILD_EXAMPLES=OFF \
 "
 
+# Configuration below allows to cross-compile protobuf applications
+# and use native protoc binary in your recipes. In order to use protoc
+# on the target, set protobuf_BUILD_PROTOC_BINARIES to ON in your bbappend
+EXTRA_OECMAKE:append:class-target = " \
+ -Dprotobuf_BUILD_PROTOC_BINARIES=OFF \
+"
+
 TEST_SRC_DIR = "examples"
 LANG_SUPPORT = "cpp ${@bb.utils.contains('PACKAGECONFIG', 'python', 'python', 
'', d)}"
 
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#98486): 
https://lists.openembedded.org/g/openembedded-devel/message/98486
Mute This Topic: https://lists.openembedded.org/mt/93286129/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [oe] [meta-oe][PATCH] protobuf: disable protoc binary for targe

2022-08-27 Thread Vyacheslav Yurkov

On master-next please

Thanks,
Vyacheslav

On 27.08.2022 09:55, Vyacheslav Yurkov via lists.openembedded.org wrote:

From: Vyacheslav Yurkov 

When applications want to use protoc during the build, the target binary
has to be disabled in order to avoid following error:

|   The imported target "protobuf::protoc" references the file
|
|  "/recipe-sysroot/usr/bin/protoc-"
|
|   but this file does not exist.  Possible reasons include:
|
|   * The file was deleted, renamed, or moved to another location.
|
|   * An install or uninstall procedure did not complete successfully.
|
|   * The installation package was faulty and contained
|
|  "/recipe-sysroot/usr/lib/cmake/protobuf/protobuf-targets.cmake"
|
|   but not all the files it references.

Signed-off-by: Vyacheslav Yurkov 
---
  meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb | 7 +++
  1 file changed, 7 insertions(+)

diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb 
b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
index 83dabc9f8..e36179363 100644
--- a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
+++ b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
@@ -34,6 +34,13 @@ EXTRA_OECMAKE += "\
  -Dprotobuf_BUILD_EXAMPLES=OFF \
  "
  
+# Configuration below allows to cross-compile protobuf applications

+# and use native protoc binary in your recipes. In order to use protoc
+# on the target, set protobuf_BUILD_PROTOC_BINARIES to ON in your bbappend
+EXTRA_OECMAKE:append:class-target = " \
+ -Dprotobuf_BUILD_PROTOC_BINARIES=OFF \
+"
+
  TEST_SRC_DIR = "examples"
  LANG_SUPPORT = "cpp ${@bb.utils.contains('PACKAGECONFIG', 'python', 'python', '', 
d)}"
  








-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#98485): 
https://lists.openembedded.org/g/openembedded-devel/message/98485
Mute This Topic: https://lists.openembedded.org/mt/93286108/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-oe][PATCH] protobuf: disable protoc binary for targe

2022-08-27 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

When applications want to use protoc during the build, the target binary
has to be disabled in order to avoid following error:

|   The imported target "protobuf::protoc" references the file
|
|  "/recipe-sysroot/usr/bin/protoc-"
|
|   but this file does not exist.  Possible reasons include:
|
|   * The file was deleted, renamed, or moved to another location.
|
|   * An install or uninstall procedure did not complete successfully.
|
|   * The installation package was faulty and contained
|
|  "/recipe-sysroot/usr/lib/cmake/protobuf/protobuf-targets.cmake"
|
|   but not all the files it references.

Signed-off-by: Vyacheslav Yurkov 
---
 meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb 
b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
index 83dabc9f8..e36179363 100644
--- a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
+++ b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
@@ -34,6 +34,13 @@ EXTRA_OECMAKE += "\
 -Dprotobuf_BUILD_EXAMPLES=OFF \
 "
 
+# Configuration below allows to cross-compile protobuf applications
+# and use native protoc binary in your recipes. In order to use protoc
+# on the target, set protobuf_BUILD_PROTOC_BINARIES to ON in your bbappend
+EXTRA_OECMAKE:append:class-target = " \
+ -Dprotobuf_BUILD_PROTOC_BINARIES=OFF \
+"
+
 TEST_SRC_DIR = "examples"
 LANG_SUPPORT = "cpp ${@bb.utils.contains('PACKAGECONFIG', 'python', 'python', 
'', d)}"
 
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#98484): 
https://lists.openembedded.org/g/openembedded-devel/message/98484
Mute This Topic: https://lists.openembedded.org/mt/93286108/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-oe][PATCH v2 1/2] protobuf: 3.19.4 -> 3.21.5 upgrade

2022-08-26 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

Drop the patch that was accepted upstream

Signed-off-by: Vyacheslav Yurkov 
---
 .../0001-Fix-linking-error-with-ld-gold.patch |  6 +-
 ...r-init-prio-for-extension-attributes.patch | 79 ---
 ...ude-descriptor.cc-when-building-libp.patch |  8 +-
 ...e-respect-CXX-LDFLAGS-variables-fix-.patch | 10 +--
 .../0001-protobuf-fix-configure-error.patch   | 10 +--
 ...{protobuf_3.19.4.bb => protobuf_3.21.5.bb} |  5 +-
 6 files changed, 16 insertions(+), 102 deletions(-)
 delete mode 100644 
meta-oe/recipes-devtools/protobuf/protobuf/0001-Lower-init-prio-for-extension-attributes.patch
 rename meta-oe/recipes-devtools/protobuf/{protobuf_3.19.4.bb => 
protobuf_3.21.5.bb} (95%)

diff --git 
a/meta-oe/recipes-devtools/protobuf/protobuf/0001-Fix-linking-error-with-ld-gold.patch
 
b/meta-oe/recipes-devtools/protobuf/protobuf/0001-Fix-linking-error-with-ld-gold.patch
index 488c1f6ff..2bcb13873 100644
--- 
a/meta-oe/recipes-devtools/protobuf/protobuf/0001-Fix-linking-error-with-ld-gold.patch
+++ 
b/meta-oe/recipes-devtools/protobuf/protobuf/0001-Fix-linking-error-with-ld-gold.patch
@@ -1,4 +1,4 @@
-From ddb9c5147883f8b27b4205450139e4a115d9961f Mon Sep 17 00:00:00 2001
+From a91130bb95528743a3f7253f8fe945b7505047d5 Mon Sep 17 00:00:00 2001
 From: Kyungjik Min 
 Date: Mon, 28 Dec 2020 15:56:09 +0900
 Subject: [PATCH] Fix linking error with ld-gold
@@ -19,6 +19,7 @@ N/A
 :Issues Addressed:
 [PLAT-130467] Fix build error for libgoogleassistant with latest
   protobuf-3.11.4
+
 ---
  src/libprotobuf-lite.map | 2 ++
  src/libprotobuf.map  | 2 ++
@@ -64,6 +65,3 @@ index 391554669..a1853ca6c 100644
  
local:
  *;
--- 
-2.17.1
-
diff --git 
a/meta-oe/recipes-devtools/protobuf/protobuf/0001-Lower-init-prio-for-extension-attributes.patch
 
b/meta-oe/recipes-devtools/protobuf/protobuf/0001-Lower-init-prio-for-extension-attributes.patch
deleted file mode 100644
index a1200e01c..0
--- 
a/meta-oe/recipes-devtools/protobuf/protobuf/0001-Lower-init-prio-for-extension-attributes.patch
+++ /dev/null
@@ -1,79 +0,0 @@
-From 8ff34dbff1eac612326b492d0b2cb93901ad7e2b Mon Sep 17 00:00:00 2001
-From: Jani Nurminen 
-Date: Fri, 24 Sep 2021 09:56:11 +0200
-Subject: [PATCH] Lower init prio for extension attributes
-MIME-Version: 1.0
-Content-Type: text/plain; charset=UTF-8
-Content-Transfer-Encoding: 8bit
-
-Added PROTOBUF_EXTENSION_ATTRIBUTE_INIT_PRIORITY in
-code generation for extension attributes.
-It has lower prio than PROTOBUF_ATTRIBUTE_INIT_PRIORITY to
-ensure that extension attributes are initialized after
-other attribute.
-This is needed in some applications to avoid segmentation fault.
-
-Reported by Karl-Herman Näslund.
-
-Signed-off-by: Jani Nurminen 
-
-Rebase on master
-
-Signed-off-by: He Zhe 

- src/google/protobuf/compiler/cpp/cpp_extension.cc |  2 +-
- src/google/protobuf/port_def.inc  | 12 
- src/google/protobuf/port_undef.inc|  1 +
- 3 files changed, 14 insertions(+), 1 deletion(-)
-
-diff --git a/src/google/protobuf/compiler/cpp/cpp_extension.cc 
b/src/google/protobuf/compiler/cpp/cpp_extension.cc
-index 8604da5f2..984345ebe 100644
 a/src/google/protobuf/compiler/cpp/cpp_extension.cc
-+++ b/src/google/protobuf/compiler/cpp/cpp_extension.cc
-@@ -164,7 +164,7 @@ void ExtensionGenerator::GenerateDefinition(io::Printer* 
printer) {
-   }
- 
-   format(
--  "PROTOBUF_ATTRIBUTE_INIT_PRIORITY "
-+  "PROTOBUF_EXTENSION_ATTRIBUTE_INIT_PRIORITY "
-   "::$proto_ns$::internal::ExtensionIdentifier< $extendee$,\n"
-   "::$proto_ns$::internal::$type_traits$, $field_type$, $packed$ >\n"
-   "  $scoped_name$($constant_name$, $1$);\n",
-diff --git a/src/google/protobuf/port_def.inc 
b/src/google/protobuf/port_def.inc
-index 7e9119112..a5117090d 100644
 a/src/google/protobuf/port_def.inc
-+++ b/src/google/protobuf/port_def.inc
-@@ -614,6 +614,18 @@
- #define PROTOBUF_ATTRIBUTE_INIT_PRIORITY
- #endif
- 
-+// Some embedded systems get a segmentation fault if extension attributes are
-+// initialized with higher or equal priority as other attributes. This gives
-+// extension attributes high priority, but lower than other attributes.
-+#ifdef PROTOBUF_EXTENSION_ATTRIBUTE_INIT_PRIORITY
-+#error PROTOBUF_EXTENSION_ATTRIBUTE_INIT_PRIORITY was previously defined
-+#endif
-+#if PROTOBUF_GNUC_MIN(3, 0) && (!defined(__APPLE__) || defined(__clang__)) && 
!((defined(sun) || defined(__sun)) && (defined(__SVR4) || defined(__svr4__)))
-+#define PROTOBUF_EXTENSION_ATTRIBUTE_INIT_PRIORITY 
__attribute__((init_priority((103
-+#else
-+#define PROTOBUF_EXTENSION_ATTRIBUTE_INIT_PRIORITY
-+#endif
-+
- #ifdef PROTOBUF_PRAGMA_INIT_SEG
- #error PROTOBUF_PRAGMA_INIT_SEG was previously defined
- #endif
-diff --git a/src/google/protobuf/port_undef.inc 
b/src/google/protobuf/port_undef.inc
-index ccc5daf56..2b28f3a31 100644
 a/

[oe] [meta-oe][PATCH v2 2/2] protobuf: change build system to cmake

2022-08-26 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

Autotools support has been removed and replaced completely by CMake.

See related issues for details:
https://github.com/protocolbuffers/protobuf/issues/7911
https://github.com/protocolbuffers/protobuf/pull/10132

Drop autotools patches too.

Signed-off-by: Vyacheslav Yurkov 
---
 ...ude-descriptor.cc-when-building-libp.patch | 30 --
 .../0001-protobuf-fix-configure-error.patch   | 31 ---
 .../protobuf/protobuf_3.21.5.bb   | 23 +-
 3 files changed, 16 insertions(+), 68 deletions(-)
 delete mode 100644 
meta-oe/recipes-devtools/protobuf/protobuf/0001-Makefile.am-include-descriptor.cc-when-building-libp.patch
 delete mode 100644 
meta-oe/recipes-devtools/protobuf/protobuf/0001-protobuf-fix-configure-error.patch

diff --git 
a/meta-oe/recipes-devtools/protobuf/protobuf/0001-Makefile.am-include-descriptor.cc-when-building-libp.patch
 
b/meta-oe/recipes-devtools/protobuf/protobuf/0001-Makefile.am-include-descriptor.cc-when-building-libp.patch
deleted file mode 100644
index 59d43072c..0
--- 
a/meta-oe/recipes-devtools/protobuf/protobuf/0001-Makefile.am-include-descriptor.cc-when-building-libp.patch
+++ /dev/null
@@ -1,30 +0,0 @@
-From 76980e1c84374e8bfa4dffcca78c5050783e83b9 Mon Sep 17 00:00:00 2001
-From: Martin Jansa 
-Date: Thu, 27 Jun 2019 13:27:18 +
-Subject: [PATCH] Makefile.am: include descriptor.pb.cc when building
- libprotoc.so
-
-* otherwise plugin.pb.o has undefined symbol 
scc_info_FileDescriptorProto_google_2fprotobuf_2fdescriptor_2eproto
-  and build with gold fails with:
-  
core2-32-oe-linux/protobuf/3.8.0-r0/recipe-sysroot-native/usr/bin/i686-oe-linux/../../libexec/i686-oe-linux/gcc/i686-oe-linux/9.1.0/ld.bfd:
 ./.libs/libprotoc.so: undefined reference to 
`descriptor_table_google_2fprotobuf_2fdescriptor_2eproto'
-  
core2-32-oe-linux/protobuf/3.8.0-r0/recipe-sysroot-native/usr/bin/i686-oe-linux/../../libexec/i686-oe-linux/gcc/i686-oe-linux/9.1.0/ld.bfd:
 ./.libs/libprotoc.so: undefined reference to 
`scc_info_FileDescriptorProto_google_2fprotobuf_2fdescriptor_2eproto'
-
-Upstream-Status: Pending
-Signed-off-by: Martin Jansa 
-

- src/Makefile.am | 1 +
- 1 file changed, 1 insertion(+)
-
-diff --git a/src/Makefile.am b/src/Makefile.am
-index e6a7dc7fd..6b0fe6686 100644
 a/src/Makefile.am
-+++ b/src/Makefile.am
-@@ -326,6 +326,7 @@ libprotoc_la_LDFLAGS += 
-Wl,--version-script=$(srcdir)/libprotoc.map
- EXTRA_libprotoc_la_DEPENDENCIES = libprotoc.map
- endif
- libprotoc_la_SOURCES = \
-+  google/protobuf/descriptor.pb.cc \
-   google/protobuf/compiler/code_generator.cc   \
-   google/protobuf/compiler/command_line_interface.cc   \
-   google/protobuf/compiler/cpp/enum.cc \
diff --git 
a/meta-oe/recipes-devtools/protobuf/protobuf/0001-protobuf-fix-configure-error.patch
 
b/meta-oe/recipes-devtools/protobuf/protobuf/0001-protobuf-fix-configure-error.patch
deleted file mode 100644
index 7c87dbe26..0
--- 
a/meta-oe/recipes-devtools/protobuf/protobuf/0001-protobuf-fix-configure-error.patch
+++ /dev/null
@@ -1,31 +0,0 @@
-From 2649fe191ad3f086274a9bf1520212a4c715c944 Mon Sep 17 00:00:00 2001
-From: Changqing Li 
-Date: Wed, 18 Jul 2018 17:52:34 +0800
-Subject: [PATCH] protobuf: fix configure error
-
-fix below error:
-gnu-configize: 'configure.ac' or 'configure.in' is required
-
-third_party/googletest is git submodule of protobuf. Above error
-caused by missing submodule googletest.
-
-Upstream-Status: Inappropriate [oe-specific]
-
-Signed-off-by: Changqing Li 
-

- configure.ac | 1 -
- 1 file changed, 1 deletion(-)
-
-diff --git a/configure.ac b/configure.ac
-index 375a79d93..1d73cd73f 100644
 a/configure.ac
-+++ b/configure.ac
-@@ -241,7 +241,6 @@ AC_SUBST([LIBLOG_LIBS])
- #   too.
- export CFLAGS
- export CXXFLAGS
--AC_CONFIG_SUBDIRS([third_party/googletest])
- 
- AC_CONFIG_FILES([Makefile src/Makefile benchmarks/Makefile 
conformance/Makefile protobuf.pc protobuf-lite.pc])
- AC_OUTPUT
diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb 
b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
index a8828ec40..83dabc9f8 100644
--- a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
+++ b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
@@ -14,8 +14,6 @@ SRCREV = "ab840345966d0fa8e7100d771c92a73bfbadd25c"
 
 SRC_URI = 
"git://github.com/protocolbuffers/protobuf.git;branch=21.x;protocol=https \
file://run-ptest \
-   file://0001-protobuf-fix-configure-error.patch \
-   
file://0001-Makefile.am-include-descriptor.cc-when-building-libp.patch \

file://0001-examples-Makefile-respect-CXX-LDFLAGS-variables-fix-.patch \
file://0001-Fix-linking-error-with-ld-gold.patch \
"
@@ -24,12 +22,17 @@ SRC_URI:append:mipsel:toolchain-clang = " 
file://0001-Fix-build-on-mips-clang.

[oe] [meta-oe][PATCH 3/3] protobuf: correct ptest dependency

2022-08-25 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

Signed-off-by: Vyacheslav Yurkov 
---
 meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb 
b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
index 6af02de0e..572a461bc 100644
--- a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
+++ b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
@@ -93,7 +93,7 @@ FILES:${PN}-lite = "${libdir}/libprotobuf-lite${SOLIBS}"
 
 RDEPENDS:${PN}-compiler = "${PN}"
 RDEPENDS:${PN}-dev += "${PN}-compiler"
-RDEPENDS:${PN}-ptest = "bash ${@bb.utils.contains('PACKAGECONFIG', 'python', 
'python-protobuf', '', d)}"
+RDEPENDS:${PN}-ptest = "bash ${@bb.utils.contains('PACKAGECONFIG', 'python', 
'python3-protobuf', '', d)}"
 
 MIPS_INSTRUCTION_SET = "mips"
 
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#98432): 
https://lists.openembedded.org/g/openembedded-devel/message/98432
Mute This Topic: https://lists.openembedded.org/mt/93246135/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-oe][PATCH 2/3] protobuf: change build system to cmake

2022-08-25 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

Autotools support has been removed and replaced completely by CMake.

See related issues for details:
https://github.com/protocolbuffers/protobuf/issues/7911
https://github.com/protocolbuffers/protobuf/pull/10132

Drop autotools patches too.

Signed-off-by: Vyacheslav Yurkov 
---
 ...ude-descriptor.cc-when-building-libp.patch | 30 --
 .../0001-protobuf-fix-configure-error.patch   | 31 ---
 .../protobuf/protobuf_3.21.5.bb   | 25 ++-
 3 files changed, 18 insertions(+), 68 deletions(-)
 delete mode 100644 
meta-oe/recipes-devtools/protobuf/protobuf/0001-Makefile.am-include-descriptor.cc-when-building-libp.patch
 delete mode 100644 
meta-oe/recipes-devtools/protobuf/protobuf/0001-protobuf-fix-configure-error.patch

diff --git 
a/meta-oe/recipes-devtools/protobuf/protobuf/0001-Makefile.am-include-descriptor.cc-when-building-libp.patch
 
b/meta-oe/recipes-devtools/protobuf/protobuf/0001-Makefile.am-include-descriptor.cc-when-building-libp.patch
deleted file mode 100644
index 59d43072c..0
--- 
a/meta-oe/recipes-devtools/protobuf/protobuf/0001-Makefile.am-include-descriptor.cc-when-building-libp.patch
+++ /dev/null
@@ -1,30 +0,0 @@
-From 76980e1c84374e8bfa4dffcca78c5050783e83b9 Mon Sep 17 00:00:00 2001
-From: Martin Jansa 
-Date: Thu, 27 Jun 2019 13:27:18 +
-Subject: [PATCH] Makefile.am: include descriptor.pb.cc when building
- libprotoc.so
-
-* otherwise plugin.pb.o has undefined symbol 
scc_info_FileDescriptorProto_google_2fprotobuf_2fdescriptor_2eproto
-  and build with gold fails with:
-  
core2-32-oe-linux/protobuf/3.8.0-r0/recipe-sysroot-native/usr/bin/i686-oe-linux/../../libexec/i686-oe-linux/gcc/i686-oe-linux/9.1.0/ld.bfd:
 ./.libs/libprotoc.so: undefined reference to 
`descriptor_table_google_2fprotobuf_2fdescriptor_2eproto'
-  
core2-32-oe-linux/protobuf/3.8.0-r0/recipe-sysroot-native/usr/bin/i686-oe-linux/../../libexec/i686-oe-linux/gcc/i686-oe-linux/9.1.0/ld.bfd:
 ./.libs/libprotoc.so: undefined reference to 
`scc_info_FileDescriptorProto_google_2fprotobuf_2fdescriptor_2eproto'
-
-Upstream-Status: Pending
-Signed-off-by: Martin Jansa 
-

- src/Makefile.am | 1 +
- 1 file changed, 1 insertion(+)
-
-diff --git a/src/Makefile.am b/src/Makefile.am
-index e6a7dc7fd..6b0fe6686 100644
 a/src/Makefile.am
-+++ b/src/Makefile.am
-@@ -326,6 +326,7 @@ libprotoc_la_LDFLAGS += 
-Wl,--version-script=$(srcdir)/libprotoc.map
- EXTRA_libprotoc_la_DEPENDENCIES = libprotoc.map
- endif
- libprotoc_la_SOURCES = \
-+  google/protobuf/descriptor.pb.cc \
-   google/protobuf/compiler/code_generator.cc   \
-   google/protobuf/compiler/command_line_interface.cc   \
-   google/protobuf/compiler/cpp/enum.cc \
diff --git 
a/meta-oe/recipes-devtools/protobuf/protobuf/0001-protobuf-fix-configure-error.patch
 
b/meta-oe/recipes-devtools/protobuf/protobuf/0001-protobuf-fix-configure-error.patch
deleted file mode 100644
index 7c87dbe26..0
--- 
a/meta-oe/recipes-devtools/protobuf/protobuf/0001-protobuf-fix-configure-error.patch
+++ /dev/null
@@ -1,31 +0,0 @@
-From 2649fe191ad3f086274a9bf1520212a4c715c944 Mon Sep 17 00:00:00 2001
-From: Changqing Li 
-Date: Wed, 18 Jul 2018 17:52:34 +0800
-Subject: [PATCH] protobuf: fix configure error
-
-fix below error:
-gnu-configize: 'configure.ac' or 'configure.in' is required
-
-third_party/googletest is git submodule of protobuf. Above error
-caused by missing submodule googletest.
-
-Upstream-Status: Inappropriate [oe-specific]
-
-Signed-off-by: Changqing Li 
-

- configure.ac | 1 -
- 1 file changed, 1 deletion(-)
-
-diff --git a/configure.ac b/configure.ac
-index 375a79d93..1d73cd73f 100644
 a/configure.ac
-+++ b/configure.ac
-@@ -241,7 +241,6 @@ AC_SUBST([LIBLOG_LIBS])
- #   too.
- export CFLAGS
- export CXXFLAGS
--AC_CONFIG_SUBDIRS([third_party/googletest])
- 
- AC_CONFIG_FILES([Makefile src/Makefile benchmarks/Makefile 
conformance/Makefile protobuf.pc protobuf-lite.pc])
- AC_OUTPUT
diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb 
b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
index a8828ec40..6af02de0e 100644
--- a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
+++ b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
@@ -14,8 +14,6 @@ SRCREV = "ab840345966d0fa8e7100d771c92a73bfbadd25c"
 
 SRC_URI = 
"git://github.com/protocolbuffers/protobuf.git;branch=21.x;protocol=https \
file://run-ptest \
-   file://0001-protobuf-fix-configure-error.patch \
-   
file://0001-Makefile.am-include-descriptor.cc-when-building-libp.patch \

file://0001-examples-Makefile-respect-CXX-LDFLAGS-variables-fix-.patch \
file://0001-Fix-linking-error-with-ld-gold.patch \
"
@@ -24,12 +22,19 @@ SRC_URI:append:mipsel:toolchain-clang = " 
file://0001-Fix-build-on-mips-clang.

[oe] [meta-oe][PATCH 1/3] protobuf: 3.19.4 -> 3.21.5 upgrade

2022-08-25 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

Drop the patch that was accepted upstream

Signed-off-by: Vyacheslav Yurkov 
---
 .../0001-Fix-linking-error-with-ld-gold.patch |  6 +-
 ...r-init-prio-for-extension-attributes.patch | 79 ---
 ...ude-descriptor.cc-when-building-libp.patch |  8 +-
 ...e-respect-CXX-LDFLAGS-variables-fix-.patch | 10 +--
 .../0001-protobuf-fix-configure-error.patch   | 10 +--
 ...{protobuf_3.19.4.bb => protobuf_3.21.5.bb} |  5 +-
 6 files changed, 16 insertions(+), 102 deletions(-)
 delete mode 100644 
meta-oe/recipes-devtools/protobuf/protobuf/0001-Lower-init-prio-for-extension-attributes.patch
 rename meta-oe/recipes-devtools/protobuf/{protobuf_3.19.4.bb => 
protobuf_3.21.5.bb} (95%)

diff --git 
a/meta-oe/recipes-devtools/protobuf/protobuf/0001-Fix-linking-error-with-ld-gold.patch
 
b/meta-oe/recipes-devtools/protobuf/protobuf/0001-Fix-linking-error-with-ld-gold.patch
index 488c1f6ff..2bcb13873 100644
--- 
a/meta-oe/recipes-devtools/protobuf/protobuf/0001-Fix-linking-error-with-ld-gold.patch
+++ 
b/meta-oe/recipes-devtools/protobuf/protobuf/0001-Fix-linking-error-with-ld-gold.patch
@@ -1,4 +1,4 @@
-From ddb9c5147883f8b27b4205450139e4a115d9961f Mon Sep 17 00:00:00 2001
+From a91130bb95528743a3f7253f8fe945b7505047d5 Mon Sep 17 00:00:00 2001
 From: Kyungjik Min 
 Date: Mon, 28 Dec 2020 15:56:09 +0900
 Subject: [PATCH] Fix linking error with ld-gold
@@ -19,6 +19,7 @@ N/A
 :Issues Addressed:
 [PLAT-130467] Fix build error for libgoogleassistant with latest
   protobuf-3.11.4
+
 ---
  src/libprotobuf-lite.map | 2 ++
  src/libprotobuf.map  | 2 ++
@@ -64,6 +65,3 @@ index 391554669..a1853ca6c 100644
  
local:
  *;
--- 
-2.17.1
-
diff --git 
a/meta-oe/recipes-devtools/protobuf/protobuf/0001-Lower-init-prio-for-extension-attributes.patch
 
b/meta-oe/recipes-devtools/protobuf/protobuf/0001-Lower-init-prio-for-extension-attributes.patch
deleted file mode 100644
index a1200e01c..0
--- 
a/meta-oe/recipes-devtools/protobuf/protobuf/0001-Lower-init-prio-for-extension-attributes.patch
+++ /dev/null
@@ -1,79 +0,0 @@
-From 8ff34dbff1eac612326b492d0b2cb93901ad7e2b Mon Sep 17 00:00:00 2001
-From: Jani Nurminen 
-Date: Fri, 24 Sep 2021 09:56:11 +0200
-Subject: [PATCH] Lower init prio for extension attributes
-MIME-Version: 1.0
-Content-Type: text/plain; charset=UTF-8
-Content-Transfer-Encoding: 8bit
-
-Added PROTOBUF_EXTENSION_ATTRIBUTE_INIT_PRIORITY in
-code generation for extension attributes.
-It has lower prio than PROTOBUF_ATTRIBUTE_INIT_PRIORITY to
-ensure that extension attributes are initialized after
-other attribute.
-This is needed in some applications to avoid segmentation fault.
-
-Reported by Karl-Herman Näslund.
-
-Signed-off-by: Jani Nurminen 
-
-Rebase on master
-
-Signed-off-by: He Zhe 

- src/google/protobuf/compiler/cpp/cpp_extension.cc |  2 +-
- src/google/protobuf/port_def.inc  | 12 
- src/google/protobuf/port_undef.inc|  1 +
- 3 files changed, 14 insertions(+), 1 deletion(-)
-
-diff --git a/src/google/protobuf/compiler/cpp/cpp_extension.cc 
b/src/google/protobuf/compiler/cpp/cpp_extension.cc
-index 8604da5f2..984345ebe 100644
 a/src/google/protobuf/compiler/cpp/cpp_extension.cc
-+++ b/src/google/protobuf/compiler/cpp/cpp_extension.cc
-@@ -164,7 +164,7 @@ void ExtensionGenerator::GenerateDefinition(io::Printer* 
printer) {
-   }
- 
-   format(
--  "PROTOBUF_ATTRIBUTE_INIT_PRIORITY "
-+  "PROTOBUF_EXTENSION_ATTRIBUTE_INIT_PRIORITY "
-   "::$proto_ns$::internal::ExtensionIdentifier< $extendee$,\n"
-   "::$proto_ns$::internal::$type_traits$, $field_type$, $packed$ >\n"
-   "  $scoped_name$($constant_name$, $1$);\n",
-diff --git a/src/google/protobuf/port_def.inc 
b/src/google/protobuf/port_def.inc
-index 7e9119112..a5117090d 100644
 a/src/google/protobuf/port_def.inc
-+++ b/src/google/protobuf/port_def.inc
-@@ -614,6 +614,18 @@
- #define PROTOBUF_ATTRIBUTE_INIT_PRIORITY
- #endif
- 
-+// Some embedded systems get a segmentation fault if extension attributes are
-+// initialized with higher or equal priority as other attributes. This gives
-+// extension attributes high priority, but lower than other attributes.
-+#ifdef PROTOBUF_EXTENSION_ATTRIBUTE_INIT_PRIORITY
-+#error PROTOBUF_EXTENSION_ATTRIBUTE_INIT_PRIORITY was previously defined
-+#endif
-+#if PROTOBUF_GNUC_MIN(3, 0) && (!defined(__APPLE__) || defined(__clang__)) && 
!((defined(sun) || defined(__sun)) && (defined(__SVR4) || defined(__svr4__)))
-+#define PROTOBUF_EXTENSION_ATTRIBUTE_INIT_PRIORITY 
__attribute__((init_priority((103
-+#else
-+#define PROTOBUF_EXTENSION_ATTRIBUTE_INIT_PRIORITY
-+#endif
-+
- #ifdef PROTOBUF_PRAGMA_INIT_SEG
- #error PROTOBUF_PRAGMA_INIT_SEG was previously defined
- #endif
-diff --git a/src/google/protobuf/port_undef.inc 
b/src/google/protobuf/port_undef.inc
-index ccc5daf56..2b28f3a31 100644
 a/

[oe] [meta-filesystems][PATCH v2] xfstests: add new recipe

2022-05-29 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

File system QA test suite

Signed-off-by: Vyacheslav Yurkov 
---
 .../recipes-utils/xfstests/xfstests_git.bb| 61 +++
 1 file changed, 61 insertions(+)
 create mode 100644 meta-filesystems/recipes-utils/xfstests/xfstests_git.bb

diff --git a/meta-filesystems/recipes-utils/xfstests/xfstests_git.bb 
b/meta-filesystems/recipes-utils/xfstests/xfstests_git.bb
new file mode 100644
index 0..868fa0330
--- /dev/null
+++ b/meta-filesystems/recipes-utils/xfstests/xfstests_git.bb
@@ -0,0 +1,61 @@
+SUMMARY = "File system QA test suite"
+LICENSE = "GPL-2.0-only"
+LIC_FILES_CHKSUM = 
"file://LICENSES/GPL-2.0;md5=74274e8a218423e49eefdea80bc55038"
+
+SRCREV_FORMAT = "xfstests_unionmount"
+
+SRC_URI = "\
+
git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git;branch=master;name=xfstests
 \
+
git://github.com/amir73il/unionmount-testsuite.git;branch=master;protocol=https;name=unionmount;destsuffix=unionmount-testsuite
 \
+"
+
+SRCREV_xfstests = "37881397f1aa62df3c63468049c80b301b0e89eb"
+SRCREV_unionmount = "cec4c51a3bf8ba80bb99fc74b302749d4e3d2f1d"
+
+S = "${WORKDIR}/git"
+
+inherit autotools-brokensep useradd
+
+DEPENDS += "xfsprogs acl"
+RDEPENDS:${PN} += "\
+bash \
+bc \
+coreutils \
+e2fsprogs \
+e2fsprogs-tune2fs \
+e2fsprogs-resize2fs \
+libcap-bin \
+overlayfs-progs \
+perl \
+python3 \
+python3-core \
+xfsprogs \
+acl \
+"
+
+USERADD_PACKAGES = "${PN}"
+# these users are necessary to run the tests
+USERADD_PARAM:${PN} = "-U -m fsgqa; -N 123456-fsgqa; -N fsgqa2"
+
+EXTRA_OECONF = "INSTALL_USER=root INSTALL_GROUP=root"
+
+# install-sh script in the project is outdated
+# we use the one from the latest libtool to solve installation issues
+# It looks like the upstream is not interested in having it fixed :(
+# https://www.spinics.net/lists/fstests/msg16981.html
+do_configure:prepend() {
+cp ${STAGING_DIR_NATIVE}${datadir}/libtool/build-aux/install-sh ${B}
+}
+
+do_install:append() {
+unionmount_target_dir=${D}/usr/xfstests/unionmount-testsuite
+install -d ${D}/usr/xfstests/unionmount-testsuite/tests
+install -D ${WORKDIR}/unionmount-testsuite/tests/* -t 
$unionmount_target_dir/tests
+install ${WORKDIR}/unionmount-testsuite/*.py -t $unionmount_target_dir
+install ${WORKDIR}/unionmount-testsuite/run -t $unionmount_target_dir
+install ${WORKDIR}/unionmount-testsuite/README -t $unionmount_target_dir
+}
+
+FILES:${PN} += "\
+/usr/xfstests \
+"
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#97316): 
https://lists.openembedded.org/g/openembedded-devel/message/97316
Mute This Topic: https://lists.openembedded.org/mt/91408542/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [oe] [meta-filesystems][PATCH] xfstests: add new recipe

2022-05-28 Thread Vyacheslav Yurkov

Requires a recipe from master-next, so should be queued respectively.

Thanks,
Vyacheslav

On 28.05.2022 10:46, Vyacheslav Yurkov via lists.openembedded.org wrote:

From: Vyacheslav Yurkov 

File system QA test suite

Signed-off-by: Vyacheslav Yurkov 
---
  .../recipes-utils/xfstests/xfstests_git.bb| 61 +++
  1 file changed, 61 insertions(+)
  create mode 100644 meta-filesystems/recipes-utils/xfstests/xfstests_git.bb

diff --git a/meta-filesystems/recipes-utils/xfstests/xfstests_git.bb 
b/meta-filesystems/recipes-utils/xfstests/xfstests_git.bb
new file mode 100644
index 0..238dbf889
--- /dev/null
+++ b/meta-filesystems/recipes-utils/xfstests/xfstests_git.bb
@@ -0,0 +1,61 @@
+SUMMARY = "File system QA test suite"
+LICENSE = "GPL-2.0"
+LIC_FILES_CHKSUM = 
"file://LICENSES/GPL-2.0;md5=74274e8a218423e49eefdea80bc55038"
+
+SRCREV_FORMAT = "xfstests_unionmount"
+
+SRC_URI = "\
+
git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git;branch=master;name=xfstests
 \
+
git://github.com/amir73il/unionmount-testsuite.git;branch=master;protocol=https;name=unionmount;destsuffix=unionmount-testsuite
 \
+"
+
+SRCREV_xfstests = "37881397f1aa62df3c63468049c80b301b0e89eb"
+SRCREV_unionmount = "cec4c51a3bf8ba80bb99fc74b302749d4e3d2f1d"
+
+S = "${WORKDIR}/git"
+
+inherit autotools-brokensep useradd
+
+DEPENDS += "xfsprogs acl"
+RDEPENDS:${PN} += "\
+bash \
+bc \
+coreutils \
+e2fsprogs \
+e2fsprogs-tune2fs \
+e2fsprogs-resize2fs \
+libcap-bin \
+overlayfs-progs \
+perl \
+python3 \
+python3-core \
+xfsprogs \
+acl \
+"
+
+USERADD_PACKAGES = "${PN}"
+# these users are necessary to run the tests
+USERADD_PARAM:${PN} = "-U -m fsgqa; -N 123456-fsgqa; -N fsgqa2"
+
+EXTRA_OECONF = "INSTALL_USER=root INSTALL_GROUP=root"
+
+# install-sh script in the project is outdated
+# we use the one from the latest libtool to solve installation issues
+# It looks like the upstream is not interested in having it fixed :(
+# https://www.spinics.net/lists/fstests/msg16981.html
+do_configure:prepend() {
+cp ${STAGING_DIR_NATIVE}${datadir}/libtool/build-aux/install-sh ${B}
+}
+
+do_install:append() {
+unionmount_target_dir=${D}/usr/xfstests/unionmount-testsuite
+install -d ${D}/usr/xfstests/unionmount-testsuite/tests
+install -D ${WORKDIR}/unionmount-testsuite/tests/* -t 
$unionmount_target_dir/tests
+install ${WORKDIR}/unionmount-testsuite/*.py -t $unionmount_target_dir
+install ${WORKDIR}/unionmount-testsuite/run -t $unionmount_target_dir
+install ${WORKDIR}/unionmount-testsuite/README -t $unionmount_target_dir
+}
+
+FILES:${PN} += "\
+/usr/xfstests \
+"




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#97312): 
https://lists.openembedded.org/g/openembedded-devel/message/97312
Mute This Topic: https://lists.openembedded.org/mt/91392360/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-filesystems][PATCH] xfstests: add new recipe

2022-05-28 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

File system QA test suite

Signed-off-by: Vyacheslav Yurkov 
---
 .../recipes-utils/xfstests/xfstests_git.bb| 61 +++
 1 file changed, 61 insertions(+)
 create mode 100644 meta-filesystems/recipes-utils/xfstests/xfstests_git.bb

diff --git a/meta-filesystems/recipes-utils/xfstests/xfstests_git.bb 
b/meta-filesystems/recipes-utils/xfstests/xfstests_git.bb
new file mode 100644
index 0..238dbf889
--- /dev/null
+++ b/meta-filesystems/recipes-utils/xfstests/xfstests_git.bb
@@ -0,0 +1,61 @@
+SUMMARY = "File system QA test suite"
+LICENSE = "GPL-2.0"
+LIC_FILES_CHKSUM = 
"file://LICENSES/GPL-2.0;md5=74274e8a218423e49eefdea80bc55038"
+
+SRCREV_FORMAT = "xfstests_unionmount"
+
+SRC_URI = "\
+
git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git;branch=master;name=xfstests
 \
+
git://github.com/amir73il/unionmount-testsuite.git;branch=master;protocol=https;name=unionmount;destsuffix=unionmount-testsuite
 \
+"
+
+SRCREV_xfstests = "37881397f1aa62df3c63468049c80b301b0e89eb"
+SRCREV_unionmount = "cec4c51a3bf8ba80bb99fc74b302749d4e3d2f1d"
+
+S = "${WORKDIR}/git"
+
+inherit autotools-brokensep useradd
+
+DEPENDS += "xfsprogs acl"
+RDEPENDS:${PN} += "\
+bash \
+bc \
+coreutils \
+e2fsprogs \
+e2fsprogs-tune2fs \
+e2fsprogs-resize2fs \
+libcap-bin \
+overlayfs-progs \
+perl \
+python3 \
+python3-core \
+xfsprogs \
+acl \
+"
+
+USERADD_PACKAGES = "${PN}"
+# these users are necessary to run the tests
+USERADD_PARAM:${PN} = "-U -m fsgqa; -N 123456-fsgqa; -N fsgqa2"
+
+EXTRA_OECONF = "INSTALL_USER=root INSTALL_GROUP=root"
+
+# install-sh script in the project is outdated
+# we use the one from the latest libtool to solve installation issues
+# It looks like the upstream is not interested in having it fixed :(
+# https://www.spinics.net/lists/fstests/msg16981.html
+do_configure:prepend() {
+cp ${STAGING_DIR_NATIVE}${datadir}/libtool/build-aux/install-sh ${B}
+}
+
+do_install:append() {
+unionmount_target_dir=${D}/usr/xfstests/unionmount-testsuite
+install -d ${D}/usr/xfstests/unionmount-testsuite/tests
+install -D ${WORKDIR}/unionmount-testsuite/tests/* -t 
$unionmount_target_dir/tests
+install ${WORKDIR}/unionmount-testsuite/*.py -t $unionmount_target_dir
+install ${WORKDIR}/unionmount-testsuite/run -t $unionmount_target_dir
+install ${WORKDIR}/unionmount-testsuite/README -t $unionmount_target_dir
+}
+
+FILES:${PN} += "\
+/usr/xfstests \
+"
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#97311): 
https://lists.openembedded.org/g/openembedded-devel/message/97311
Mute This Topic: https://lists.openembedded.org/mt/91392360/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-filesystems][PATCH v2] overlayfs-tools: add new recipe

2022-05-23 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

This package provides maintenance tools for OverlayFS, such as vacuum,
diff, merge, and deref

Signed-off-by: Vyacheslav Yurkov 
---
 ...-so-that-it-compiles-on-Ubuntu-20.04.patch | 41 +++
 .../0002-makefile-fix-linking-flags.patch | 31 ++
 .../overlayfs/overlayfs-tools_git.bb  | 34 +++
 3 files changed, 106 insertions(+)
 create mode 100644 
meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0001-Fixed-includes-so-that-it-compiles-on-Ubuntu-20.04.patch
 create mode 100644 
meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0002-makefile-fix-linking-flags.patch
 create mode 100644 
meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb

diff --git 
a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0001-Fixed-includes-so-that-it-compiles-on-Ubuntu-20.04.patch
 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0001-Fixed-includes-so-that-it-compiles-on-Ubuntu-20.04.patch
new file mode 100644
index 0..f7490ebce
--- /dev/null
+++ 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0001-Fixed-includes-so-that-it-compiles-on-Ubuntu-20.04.patch
@@ -0,0 +1,41 @@
+From 81b4fbb5f52044cb348534c23f10b3884972b09b Mon Sep 17 00:00:00 2001
+From: Beat Schaer 
+Date: Fri, 19 Mar 2021 08:18:58 +0100
+Subject: [PATCH] Fixed includes so that it compiles on Ubuntu 20.04
+
+---
+ logic.c | 3 +--
+ main.c  | 3 ++-
+ 2 files changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/logic.c b/logic.c
+index 97767f5..47ebfaa 100644
+--- a/logic.c
 b/logic.c
+@@ -7,8 +7,7 @@
+ #include 
+ #include 
+ #include 
+-#include 
+-#include 
++#include 
+ #include 
+ #include 
+ #include "logic.h"
+diff --git a/main.c b/main.c
+index aa11239..f462b98 100644
+--- a/main.c
 b/main.c
+@@ -12,7 +12,8 @@
+ #include 
+ #include 
+ #include 
+-#include 
++#include 
++#include 
+ #ifndef _SYS_STAT_H
+   #include 
+ #endif
+-- 
+2.25.1
+
diff --git 
a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0002-makefile-fix-linking-flags.patch
 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0002-makefile-fix-linking-flags.patch
new file mode 100644
index 0..cf4de18a7
--- /dev/null
+++ 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools/0002-makefile-fix-linking-flags.patch
@@ -0,0 +1,31 @@
+From b4ff5886797e72d1c21da43261ca7648412f3186 Mon Sep 17 00:00:00 2001
+From: Vyacheslav Yurkov 
+Date: Mon, 23 May 2022 19:53:21 +0200
+Subject: [PATCH] makefile: fix linking flags
+
+LDLIBS should be placed at the end according to
+https://www.gnu.org/software/make/manual/html_node/Catalogue-of-Rules.html
+
+Signed-off-by: Vyacheslav Yurkov 
+---
+ makefile | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/makefile b/makefile
+index fb1bed4..038c7ce 100644
+--- a/makefile
 b/makefile
+@@ -1,11 +1,11 @@
+ CFLAGS = -Wall -std=c99
+-LFLAGS = -lm
++LDLIBS = -lm
+ CC = gcc
+ 
+ all: overlay
+ 
+ overlay: main.o logic.o sh.o
+-  $(CC) $(LFLAGS) main.o logic.o sh.o -o overlay
++  $(CC) main.o logic.o sh.o -o overlay $(LDLIBS) 
+ 
+ main.o: main.c logic.h
+   $(CC) $(CFLAGS) -c main.c
diff --git a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
new file mode 100644
index 0..eb6e4963a
--- /dev/null
+++ b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
@@ -0,0 +1,34 @@
+DESCRIPTION = "Maintenance tools for OverlayFS"
+HOMEPAGE = "https://github.com/kmxz/overlayfs-tools;
+LICENSE = "WTFPL"
+LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=f312a7c4d02230e8f2b537295d375c69"
+
+SRC_URI = "\
+git://github.com/kmxz/overlayfs-tools.git;protocol=https;branch=master \
+file://0001-Fixed-includes-so-that-it-compiles-on-Ubuntu-20.04.patch \
+file://0002-makefile-fix-linking-flags.patch \
+"
+
+PV = "1.0+git${SRCPV}"
+SRCREV = "291c7f4a3fb548d06c572700650c2e3bccb0cd27"
+
+S = "${WORKDIR}/git"
+B = "${S}"
+
+DEPENDS += "attr"
+# Required to have the fts.h header for musl
+DEPENDS:append:libc-musl = " fts"
+
+EXTRA_OEMAKE += "'CC=${CC} -O2'"
+# Fix the missing fts libs when using musl
+EXTRA_OEMAKE:append:libc-musl = " LDLIBS=-lfts"
+TARGET_CC_ARCH += "${LDFLAGS}"
+
+do_compile () {
+oe_runmake
+}
+
+do_install () {
+install -d ${D}${bindir}
+install -m 0755 ${B}/overlay ${D}${bindir}
+}
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#97237): 
https://lists.openembedded.org/g/openembedded-devel/message/97237
Mute This Topic: https://lists.openembedded.org/mt/91294623/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-filesystems][PATCH v3] overlayfs-progs: add new recipe

2022-05-23 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

overlayfs-progs contains fsck.overlay, which is used to check and optionally
repair underlying directories of overlay-filesystem.

Signed-off-by: Vyacheslav Yurkov 
---
 ...-Makefile-proper-location-of-LDFLAGS.patch | 30 +
 .../overlayfs/overlayfs-progs_git.bb  | 32 +++
 2 files changed, 62 insertions(+)
 create mode 100644 
meta-filesystems/recipes-utils/overlayfs/overlayfs-progs/0001-Makefile-proper-location-of-LDFLAGS.patch
 create mode 100644 
meta-filesystems/recipes-utils/overlayfs/overlayfs-progs_git.bb

diff --git 
a/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs/0001-Makefile-proper-location-of-LDFLAGS.patch
 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs/0001-Makefile-proper-location-of-LDFLAGS.patch
new file mode 100644
index 0..d9f285d94
--- /dev/null
+++ 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs/0001-Makefile-proper-location-of-LDFLAGS.patch
@@ -0,0 +1,30 @@
+From 8eeaee82dcfdf47f16ad880e416b722827f41bdb Mon Sep 17 00:00:00 2001
+From: Vyacheslav Yurkov 
+Date: Mon, 23 May 2022 19:37:32 +0200
+Subject: [PATCH] Makefile: proper location of LDFLAGS
+
+Signed-off-by: Vyacheslav Yurkov 
+---
+ Makefile | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/Makefile b/Makefile
+index e3c5207..14b155e 100644
+--- a/Makefile
 b/Makefile
+@@ -1,5 +1,5 @@
+ CFLAGS = -Wall -g
+-LFLAGS = -lm
++LDFLAGS = -lm
+ CC = gcc
+ 
+ all: overlay
+@@ -7,7 +7,7 @@ all: overlay
+ objects = fsck.o common.o lib.o check.o mount.o path.o overlayfs.o
+ 
+ overlay: $(objects)
+-  $(CC) $(LFLAGS) $(objects) -o fsck.overlay
++  $(CC) $(objects) -o fsck.overlay $(LDFLAGS) 
+ 
+ .c.o:
+   $(CC) $(CFLAGS) -c $<
diff --git a/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs_git.bb 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs_git.bb
new file mode 100644
index 0..9d58b9a63
--- /dev/null
+++ b/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs_git.bb
@@ -0,0 +1,32 @@
+SUMMARY = "File system check utility for OverlayFS"
+HOMEPAGE = "https://github.com/hisilicon/overlayfs-progs;
+LICENSE = "PD"
+LIC_FILES_CHKSUM = 
"file://${COREBASE}/meta/files/common-licenses/PD;md5=b3597d12946881e13cb3b548d1173851"
+
+SRC_URI = "\
+
git://github.com/hisilicon/overlayfs-progs.git;protocol=https;branch=master \
+file://0001-Makefile-proper-location-of-LDFLAGS.patch \
+"
+
+PV = "1.0+git${SRCPV}"
+SRCREV = "e10ef686570d9c7eff42f52461593a5c15da56bd"
+
+S = "${WORKDIR}/git"
+B = "${S}"
+
+# Required to have the fts.h header for musl
+DEPENDS:append:libc-musl = " fts"
+# Fix the missing fts libs when using musl
+EXTRA_OEMAKE:append:libc-musl = " LDFLAGS='-lfts'"
+
+EXTRA_OEMAKE += "'CC=${CC} -O2' "
+TARGET_CC_ARCH += "${LDFLAGS}"
+
+do_compile () {
+oe_runmake
+}
+
+do_install () {
+install -d ${D}${bindir}
+install -m 0755 ${B}/fsck.overlay ${D}${bindir}
+}
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#97236): 
https://lists.openembedded.org/g/openembedded-devel/message/97236
Mute This Topic: https://lists.openembedded.org/mt/91294279/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-filesystems][PATCH v2] overlayfs-progs: add new recipe

2022-05-23 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

overlayfs-progs contains fsck.overlay, which is used to check and optionally
repair underlying directories of overlay-filesystem.

Signed-off-by: Vyacheslav Yurkov 
---
 ...-Makefile-proper-location-of-LDFLAGS.patch | 30 +
 .../overlayfs/overlayfs-progs_git.bb  | 33 +++
 2 files changed, 63 insertions(+)
 create mode 100644 
meta-filesystems/recipes-utils/overlayfs/overlayfs-progs/0001-Makefile-proper-location-of-LDFLAGS.patch
 create mode 100644 
meta-filesystems/recipes-utils/overlayfs/overlayfs-progs_git.bb

diff --git 
a/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs/0001-Makefile-proper-location-of-LDFLAGS.patch
 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs/0001-Makefile-proper-location-of-LDFLAGS.patch
new file mode 100644
index 0..d9f285d94
--- /dev/null
+++ 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs/0001-Makefile-proper-location-of-LDFLAGS.patch
@@ -0,0 +1,30 @@
+From 8eeaee82dcfdf47f16ad880e416b722827f41bdb Mon Sep 17 00:00:00 2001
+From: Vyacheslav Yurkov 
+Date: Mon, 23 May 2022 19:37:32 +0200
+Subject: [PATCH] Makefile: proper location of LDFLAGS
+
+Signed-off-by: Vyacheslav Yurkov 
+---
+ Makefile | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/Makefile b/Makefile
+index e3c5207..14b155e 100644
+--- a/Makefile
 b/Makefile
+@@ -1,5 +1,5 @@
+ CFLAGS = -Wall -g
+-LFLAGS = -lm
++LDFLAGS = -lm
+ CC = gcc
+ 
+ all: overlay
+@@ -7,7 +7,7 @@ all: overlay
+ objects = fsck.o common.o lib.o check.o mount.o path.o overlayfs.o
+ 
+ overlay: $(objects)
+-  $(CC) $(LFLAGS) $(objects) -o fsck.overlay
++  $(CC) $(objects) -o fsck.overlay $(LDFLAGS) 
+ 
+ .c.o:
+   $(CC) $(CFLAGS) -c $<
diff --git a/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs_git.bb 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs_git.bb
new file mode 100644
index 0..bc3cc64e7
--- /dev/null
+++ b/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs_git.bb
@@ -0,0 +1,33 @@
+SUMMARY = "File system check utility for OverlayFS"
+HOMEPAGE = "https://github.com/hisilicon/overlayfs-progs;
+LICENSE = "PD"
+LIC_FILES_CHKSUM = 
"file://${COREBASE}/meta/files/common-licenses/PD;md5=b3597d12946881e13cb3b548d1173851"
+
+SRC_URI = "\
+
git://github.com/hisilicon/overlayfs-progs.git;protocol=https;branch=master \
+file://0001-Makefile-proper-location-of-LDFLAGS.patch \
+"
+
+PV = "1.0+git${SRCPV}"
+SRCREV = "e10ef686570d9c7eff42f52461593a5c15da56bd"
+
+S = "${WORKDIR}/git"
+B = "${S}"
+
+# Required to have the fts.h header for musl
+DEPENDS:append:libc-musl = " fts"
+# Fix the missing fts libs when using musl
+EXTRA_OEMAKE:append:libc-musl = " LDFLAGS='-lfts'"
+#LDLIBS:append:libc-musl = " -lfts"
+
+EXTRA_OEMAKE += "'CC=${CC} -O2' "
+TARGET_CC_ARCH += "${LDFLAGS}"
+
+do_compile () {
+oe_runmake
+}
+
+do_install () {
+install -d ${D}${bindir}
+install -m 0755 ${B}/fsck.overlay ${D}${bindir}
+}
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#97235): 
https://lists.openembedded.org/g/openembedded-devel/message/97235
Mute This Topic: https://lists.openembedded.org/mt/91294255/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-filesystems][PATCH] overlayfs-progs: add new recipe

2022-05-22 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

overlayfs-progs contains fsck.overlay, which is used to check and optionally
repair underlying directories of overlay-filesystem.

Signed-off-by: Vyacheslav Yurkov 
---
 .../overlayfs/overlayfs-progs_git.bb  | 24 +++
 1 file changed, 24 insertions(+)
 create mode 100644 
meta-filesystems/recipes-utils/overlayfs/overlayfs-progs_git.bb

diff --git a/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs_git.bb 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs_git.bb
new file mode 100644
index 0..2f173b259
--- /dev/null
+++ b/meta-filesystems/recipes-utils/overlayfs/overlayfs-progs_git.bb
@@ -0,0 +1,24 @@
+SUMMARY = "File system check utility for OverlayFS"
+HOMEPAGE = "https://github.com/hisilicon/overlayfs-progs;
+LICENSE = "PD"
+LIC_FILES_CHKSUM = 
"file://${COREBASE}/meta/files/common-licenses/PD;md5=b3597d12946881e13cb3b548d1173851"
+
+SRC_URI = 
"git://github.com/hisilicon/overlayfs-progs.git;protocol=https;branch=master"
+
+PV = "1.0+git${SRCPV}"
+SRCREV = "e10ef686570d9c7eff42f52461593a5c15da56bd"
+
+S = "${WORKDIR}/git"
+B = "${S}"
+
+EXTRA_OEMAKE += "'CC=${CC} -O2'"
+TARGET_CC_ARCH += "${LDFLAGS}"
+
+do_compile () {
+oe_runmake
+}
+
+do_install () {
+install -d ${D}${bindir}
+install -m 0755 ${B}/fsck.overlay ${D}${bindir}
+}
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#97221): 
https://lists.openembedded.org/g/openembedded-devel/message/97221
Mute This Topic: https://lists.openembedded.org/mt/91275909/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-filesystems][PATCH] overlayfs-tools: add new recipe

2022-05-22 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

This package provides maintenance tools for OverlayFS, such as vacuum,
diff, merge, and deref

Signed-off-by: Vyacheslav Yurkov 
---
 ...-so-that-it-compiles-on-Ubuntu-20.04.patch | 41 +++
 .../overlayfs/overlayfs-tools_git.bb  | 28 +
 2 files changed, 69 insertions(+)
 create mode 100644 
meta-filesystems/recipes-utils/overlayfs/files/0001-Fixed-includes-so-that-it-compiles-on-Ubuntu-20.04.patch
 create mode 100644 
meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb

diff --git 
a/meta-filesystems/recipes-utils/overlayfs/files/0001-Fixed-includes-so-that-it-compiles-on-Ubuntu-20.04.patch
 
b/meta-filesystems/recipes-utils/overlayfs/files/0001-Fixed-includes-so-that-it-compiles-on-Ubuntu-20.04.patch
new file mode 100644
index 0..f7490ebce
--- /dev/null
+++ 
b/meta-filesystems/recipes-utils/overlayfs/files/0001-Fixed-includes-so-that-it-compiles-on-Ubuntu-20.04.patch
@@ -0,0 +1,41 @@
+From 81b4fbb5f52044cb348534c23f10b3884972b09b Mon Sep 17 00:00:00 2001
+From: Beat Schaer 
+Date: Fri, 19 Mar 2021 08:18:58 +0100
+Subject: [PATCH] Fixed includes so that it compiles on Ubuntu 20.04
+
+---
+ logic.c | 3 +--
+ main.c  | 3 ++-
+ 2 files changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/logic.c b/logic.c
+index 97767f5..47ebfaa 100644
+--- a/logic.c
 b/logic.c
+@@ -7,8 +7,7 @@
+ #include 
+ #include 
+ #include 
+-#include 
+-#include 
++#include 
+ #include 
+ #include 
+ #include "logic.h"
+diff --git a/main.c b/main.c
+index aa11239..f462b98 100644
+--- a/main.c
 b/main.c
+@@ -12,7 +12,8 @@
+ #include 
+ #include 
+ #include 
+-#include 
++#include 
++#include 
+ #ifndef _SYS_STAT_H
+   #include 
+ #endif
+-- 
+2.25.1
+
diff --git a/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb 
b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
new file mode 100644
index 0..b0406fbae
--- /dev/null
+++ b/meta-filesystems/recipes-utils/overlayfs/overlayfs-tools_git.bb
@@ -0,0 +1,28 @@
+DESCRIPTION = "Maintenance tools for OverlayFS"
+HOMEPAGE = "https://github.com/kmxz/overlayfs-tools;
+LICENSE = "WTFPL"
+LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=f312a7c4d02230e8f2b537295d375c69"
+
+SRC_URI = "\
+git://github.com/kmxz/overlayfs-tools.git;protocol=https;branch=master \
+file://0001-Fixed-includes-so-that-it-compiles-on-Ubuntu-20.04.patch \
+"
+
+PV = "1.0+git${SRCPV}"
+SRCREV = "291c7f4a3fb548d06c572700650c2e3bccb0cd27"
+
+S = "${WORKDIR}/git"
+B = "${S}"
+
+DEPENDS += "attr"
+EXTRA_OEMAKE += "'CC=${CC} -O2'"
+TARGET_CC_ARCH += "${LDFLAGS}"
+
+do_compile () {
+oe_runmake
+}
+
+do_install () {
+install -d ${D}${bindir}
+install -m 0755 ${B}/overlay ${D}${bindir}
+}
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#97220): 
https://lists.openembedded.org/g/openembedded-devel/message/97220
Mute This Topic: https://lists.openembedded.org/mt/91275863/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-filesystems][PATCH] packagegroup-meta-filesystems: fix build issue

2022-05-22 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

The packagegroup has to be arch dependent to address build failure:
ERROR: packagegroup-meta-filesystems-1.0-r0 do_package_write_rpm: An allarch 
packagegroup shouldn't depend on packages which are dynamically renamed (fuse 
to libfuse2)
ERROR: packagegroup-meta-filesystems-1.0-r0 do_package_write_rpm: An allarch 
packagegroup shouldn't depend on packages which are dynamically renamed 
(fuse-dev to libfuse-dev)

Signed-off-by: Vyacheslav Yurkov 
---
 .../packageconfigs/packagegroup-meta-filesystems.bb  | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/meta-filesystems/recipes-filesystems/packageconfigs/packagegroup-meta-filesystems.bb
 
b/meta-filesystems/recipes-filesystems/packageconfigs/packagegroup-meta-filesystems.bb
index 75591c31f..1954b5979 100644
--- 
a/meta-filesystems/recipes-filesystems/packageconfigs/packagegroup-meta-filesystems.bb
+++ 
b/meta-filesystems/recipes-filesystems/packageconfigs/packagegroup-meta-filesystems.bb
@@ -1,5 +1,6 @@
 SUMMARY = "Meta-filesystem packagegroups"
 
+PACKAGE_ARCH = "${TUNE_PKGARCH}"
 inherit packagegroup
 
 PROVIDES = "${PACKAGES}"
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#97219): 
https://lists.openembedded.org/g/openembedded-devel/message/97219
Mute This Topic: https://lists.openembedded.org/mt/91273545/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-oe][PATCH] polkit: add udisks2 rule

2022-05-12 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

The rule allows non-priviledged users from plugdev group to
mount/unmount block devices

Signed-off-by: Vyacheslav Yurkov 
---
 .../files/50-org.freedesktop.udiskie.rules| 24 +++
 .../polkit/polkit-group-rule-udisks2.bb   | 17 +
 2 files changed, 41 insertions(+)
 create mode 100644 
meta-oe/recipes-extended/polkit/files/50-org.freedesktop.udiskie.rules
 create mode 100644 meta-oe/recipes-extended/polkit/polkit-group-rule-udisks2.bb

diff --git 
a/meta-oe/recipes-extended/polkit/files/50-org.freedesktop.udiskie.rules 
b/meta-oe/recipes-extended/polkit/files/50-org.freedesktop.udiskie.rules
new file mode 100644
index 00..2ffa4087a8
--- /dev/null
+++ b/meta-oe/recipes-extended/polkit/files/50-org.freedesktop.udiskie.rules
@@ -0,0 +1,24 @@
+polkit.addRule(function(action, subject) {
+  var YES = polkit.Result.YES;
+  var permission = {
+// required for udisks1:
+"org.freedesktop.udisks.filesystem-mount": YES,
+"org.freedesktop.udisks.luks-unlock": YES,
+"org.freedesktop.udisks.drive-eject": YES,
+"org.freedesktop.udisks.drive-detach": YES,
+// required for udisks2:
+"org.freedesktop.udisks2.filesystem-mount": YES,
+"org.freedesktop.udisks2.encrypted-unlock": YES,
+"org.freedesktop.udisks2.eject-media": YES,
+"org.freedesktop.udisks2.power-off-drive": YES,
+// required for udisks2 if using udiskie from another seat (e.g. systemd):
+"org.freedesktop.udisks2.filesystem-mount-other-seat": YES,
+"org.freedesktop.udisks2.filesystem-unmount-others": YES,
+"org.freedesktop.udisks2.encrypted-unlock-other-seat": YES,
+"org.freedesktop.udisks2.eject-media-other-seat": YES,
+"org.freedesktop.udisks2.power-off-drive-other-seat": YES
+  };
+  if (subject.isInGroup("plugdev")) {
+return permission[action.id];
+  }
+});
diff --git a/meta-oe/recipes-extended/polkit/polkit-group-rule-udisks2.bb 
b/meta-oe/recipes-extended/polkit/polkit-group-rule-udisks2.bb
new file mode 100644
index 00..ae024d0328
--- /dev/null
+++ b/meta-oe/recipes-extended/polkit/polkit-group-rule-udisks2.bb
@@ -0,0 +1,17 @@
+DESCRIPTION = "Polkit rule to allow non-priviledged users mount/umount block 
devices via udisks2"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = 
"file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda2f7b4f302"
+
+require polkit-group-rule.inc
+
+# The file originates from https://github.com/coldfix/udiskie/wiki/Permissions
+SRC_URI = "file://50-org.freedesktop.udiskie.rules"
+
+RDEPENDS_${PN} += "udisks2"
+
+do_install() {
+install -m 0755 ${WORKDIR}/50-org.freedesktop.udiskie.rules 
${D}${sysconfdir}/polkit-1/rules.d
+}
+
+USERADD_PACKAGES = "${PN}"
+GROUPADD_PARAM:${PN} = "--system plugdev"
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#97047): 
https://lists.openembedded.org/g/openembedded-devel/message/97047
Mute This Topic: https://lists.openembedded.org/mt/91053339/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-oe][PATCH] sdbus-c++: disable code generation tools

2022-03-16 Thread Vyacheslav Yurkov
Tools are covered by sdbus-c++-tools recipe. It doesn't make sense to
compile them here too.

Signed-off-by: Vyacheslav Yurkov 
---
 meta-oe/recipes-core/sdbus-c++/sdbus-c++_1.0.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-oe/recipes-core/sdbus-c++/sdbus-c++_1.0.0.bb 
b/meta-oe/recipes-core/sdbus-c++/sdbus-c++_1.0.0.bb
index 0e07868ba..39f0b4c56 100644
--- a/meta-oe/recipes-core/sdbus-c++/sdbus-c++_1.0.0.bb
+++ b/meta-oe/recipes-core/sdbus-c++/sdbus-c++_1.0.0.bb
@@ -21,7 +21,7 @@ SRCREV = "65782bbf435d91e5eb6af9ddab110df406a824a9"
 SRC_URI = 
"git://github.com/Kistler-Group/sdbus-cpp.git;protocol=https;branch=master"
 SRC_URI += "file://run-ptest"
 
-EXTRA_OECMAKE = "-DBUILD_CODE_GEN=ON \
+EXTRA_OECMAKE = "-DBUILD_CODE_GEN=OFF \
  -DBUILD_DOC=ON \
  -DBUILD_DOXYGEN_DOC=OFF"
 
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#96024): 
https://lists.openembedded.org/g/openembedded-devel/message/96024
Mute This Topic: https://lists.openembedded.org/mt/89827863/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [oe] [OE-core] [meta-java] why openjdk-8-native is need to build openjdk-8 ?

2021-10-21 Thread Vyacheslav Yurkov

I believe this should be sent to openembedded-devel@lists.openembedded.org

Vyacheslav

On 21.10.2021 12:11, Akira Shibakawa wrote:

Hi.
I have a question about openjdk-8 recipe.

openjdk-8 seems to be built using openjdk-8-native as boot JDK.
And the openjdk-8-native seems to be built using icedtea7 as boot JDK.

Why openjdk-8-native is need to build openjdk-8 ?
Isn't it simpler to build openjdk-8 using icedtea7 as boot JDK?

regards




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#93523): 
https://lists.openembedded.org/g/openembedded-devel/message/93523
Mute This Topic: https://lists.openembedded.org/mt/86498146/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-oe][PATCH] grpc: upgrade 1.38.1 -> 1.41.0

2021-10-12 Thread Vyacheslav Yurkov
Drop the patch that fixes cross compilation, because it's already in
1.41.0. Add the patch for regression fix [1], which should be dropped on
the recipe upgrade.

[1] https://github.com/grpc/grpc/issues/26857

Signed-off-by: Vyacheslav Yurkov 
---
 ...8fb0ee826e73323e06ac6166ac038ee71f6a.patch | 107 ++
 ...compilation-with-gRPC_BUILD_GRPC_CPP.patch |  55 -
 .../grpc/{grpc_1.38.1.bb => grpc_1.41.0.bb}   |   6 +-
 3 files changed, 110 insertions(+), 58 deletions(-)
 create mode 100644 
meta-oe/recipes-devtools/grpc/grpc/0001-cmake-revert-db88fb0ee826e73323e06ac6166ac038ee71f6a.patch
 delete mode 100644 
meta-oe/recipes-devtools/grpc/grpc/0002-cmake-fix-cross-compilation-with-gRPC_BUILD_GRPC_CPP.patch
 rename meta-oe/recipes-devtools/grpc/{grpc_1.38.1.bb => grpc_1.41.0.bb} (95%)

diff --git 
a/meta-oe/recipes-devtools/grpc/grpc/0001-cmake-revert-db88fb0ee826e73323e06ac6166ac038ee71f6a.patch
 
b/meta-oe/recipes-devtools/grpc/grpc/0001-cmake-revert-db88fb0ee826e73323e06ac6166ac038ee71f6a.patch
new file mode 100644
index 0..d9cfa009f
--- /dev/null
+++ 
b/meta-oe/recipes-devtools/grpc/grpc/0001-cmake-revert-db88fb0ee826e73323e06ac6166ac038ee71f6a.patch
@@ -0,0 +1,107 @@
+From 50d54458324c1a19eefb9968e4cb556dbd34b875 Mon Sep 17 00:00:00 2001
+From: Vyacheslav Yurkov 
+Date: Tue, 12 Oct 2021 19:11:40 +0200
+Subject: [PATCH] cmake: revert db88fb0ee826e73323e06ac6166ac038ee71f6a
+ (#27626)
+
+Fix regression introduced by previous commit. Original problem that
+commit was trying to fix was solved by modification of grpc recipe in
+meta-openembedded project repository
+
+Fixes #26857
+
+Signed-off-by: Vyacheslav Yurkov 
+---
+ CMakeLists.txt| 16 
+ templates/CMakeLists.txt.template |  2 --
+ 2 files changed, 8 insertions(+), 10 deletions(-)
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 0e8fbdee8b..02cd48bee4 100644
+--- a/CMakeLists.txt
 b/CMakeLists.txt
+@@ -3828,7 +3828,7 @@ foreach(_hdr
+ endforeach()
+ 
+ 
+-if(gRPC_INSTALL AND NOT CMAKE_CROSSCOMPILING)
++if(gRPC_INSTALL)
+   install(TARGETS grpc_plugin_support EXPORT gRPCTargets
+ RUNTIME DESTINATION ${gRPC_INSTALL_BINDIR}
+ LIBRARY DESTINATION ${gRPC_INSTALL_LIBDIR}
+@@ -11679,7 +11679,7 @@ target_link_libraries(grpc_cpp_plugin
+ 
+ 
+ 
+-if(gRPC_INSTALL AND NOT CMAKE_CROSSCOMPILING)
++if(gRPC_INSTALL)
+   install(TARGETS grpc_cpp_plugin EXPORT gRPCTargets
+ RUNTIME DESTINATION ${gRPC_INSTALL_BINDIR}
+ LIBRARY DESTINATION ${gRPC_INSTALL_LIBDIR}
+@@ -11718,7 +11718,7 @@ target_link_libraries(grpc_csharp_plugin
+ 
+ 
+ 
+-if(gRPC_INSTALL AND NOT CMAKE_CROSSCOMPILING)
++if(gRPC_INSTALL)
+   install(TARGETS grpc_csharp_plugin EXPORT gRPCTargets
+ RUNTIME DESTINATION ${gRPC_INSTALL_BINDIR}
+ LIBRARY DESTINATION ${gRPC_INSTALL_LIBDIR}
+@@ -11757,7 +11757,7 @@ target_link_libraries(grpc_node_plugin
+ 
+ 
+ 
+-if(gRPC_INSTALL AND NOT CMAKE_CROSSCOMPILING)
++if(gRPC_INSTALL)
+   install(TARGETS grpc_node_plugin EXPORT gRPCTargets
+ RUNTIME DESTINATION ${gRPC_INSTALL_BINDIR}
+ LIBRARY DESTINATION ${gRPC_INSTALL_LIBDIR}
+@@ -11796,7 +11796,7 @@ target_link_libraries(grpc_objective_c_plugin
+ 
+ 
+ 
+-if(gRPC_INSTALL AND NOT CMAKE_CROSSCOMPILING)
++if(gRPC_INSTALL)
+   install(TARGETS grpc_objective_c_plugin EXPORT gRPCTargets
+ RUNTIME DESTINATION ${gRPC_INSTALL_BINDIR}
+ LIBRARY DESTINATION ${gRPC_INSTALL_LIBDIR}
+@@ -11835,7 +11835,7 @@ target_link_libraries(grpc_php_plugin
+ 
+ 
+ 
+-if(gRPC_INSTALL AND NOT CMAKE_CROSSCOMPILING)
++if(gRPC_INSTALL)
+   install(TARGETS grpc_php_plugin EXPORT gRPCTargets
+ RUNTIME DESTINATION ${gRPC_INSTALL_BINDIR}
+ LIBRARY DESTINATION ${gRPC_INSTALL_LIBDIR}
+@@ -11874,7 +11874,7 @@ target_link_libraries(grpc_python_plugin
+ 
+ 
+ 
+-if(gRPC_INSTALL AND NOT CMAKE_CROSSCOMPILING)
++if(gRPC_INSTALL)
+   install(TARGETS grpc_python_plugin EXPORT gRPCTargets
+ RUNTIME DESTINATION ${gRPC_INSTALL_BINDIR}
+ LIBRARY DESTINATION ${gRPC_INSTALL_LIBDIR}
+@@ -11913,7 +11913,7 @@ target_link_libraries(grpc_ruby_plugin
+ 
+ 
+ 
+-if(gRPC_INSTALL AND NOT CMAKE_CROSSCOMPILING)
++if(gRPC_INSTALL)
+   install(TARGETS grpc_ruby_plugin EXPORT gRPCTargets
+ RUNTIME DESTINATION ${gRPC_INSTALL_BINDIR}
+ LIBRARY DESTINATION ${gRPC_INSTALL_LIBDIR}
+diff --git a/templates/CMakeLists.txt.template 
b/templates/CMakeLists.txt.template
+index 0f0883e09c..b9a5bc4144 100644
+--- a/templates/CMakeLists.txt.template
 b/templates/CMakeLists.txt.template
+@@ -695,8 +695,6 @@
+   # grpcpp_channelz doesn't build with protobuf-lite, so no install required
+   # See https://github.com/grpc/grpc/issues/22826
+   if(gRPC_INSTALL AND NOT gRPC_USE_PROTO_LITE)
+-  % elif tgt.build == 'protoc':
+-  if(gRPC_INSTALL AND NOT CMAKE_CROSSCOMPILING)
+   % else:
+   if(gRPC_INSTALL)
+   % endif
diff --git 
a/meta-oe/recipes-devtools/grpc/grpc/0002-cmake-fix-cross-compilation-with-gRPC_BUILD_GRPC_CPP.patch
 
b/meta-oe/recipes-devtools/grp

[oe] [meta-oe][PATCH 2/2] grpc: fix cross-compilation of grpc applications

2021-10-04 Thread Vyacheslav Yurkov
Backport a patch from grpc/master to be able to build c++ applications
when gRPC_BUILD_GRPC_CPP_PLUGIN=OFF. The patch should be dropped on the
recipe upgrade

Signed-off-by: Vyacheslav Yurkov 
---
 ...compilation-with-gRPC_BUILD_GRPC_CPP.patch | 55 +++
 meta-oe/recipes-devtools/grpc/grpc_1.38.1.bb  |  1 +
 2 files changed, 56 insertions(+)
 create mode 100644 
meta-oe/recipes-devtools/grpc/grpc/0002-cmake-fix-cross-compilation-with-gRPC_BUILD_GRPC_CPP.patch

diff --git 
a/meta-oe/recipes-devtools/grpc/grpc/0002-cmake-fix-cross-compilation-with-gRPC_BUILD_GRPC_CPP.patch
 
b/meta-oe/recipes-devtools/grpc/grpc/0002-cmake-fix-cross-compilation-with-gRPC_BUILD_GRPC_CPP.patch
new file mode 100644
index 0..ce660f5cc
--- /dev/null
+++ 
b/meta-oe/recipes-devtools/grpc/grpc/0002-cmake-fix-cross-compilation-with-gRPC_BUILD_GRPC_CPP.patch
@@ -0,0 +1,55 @@
+From 83a66aa45d63d79cbccc47a65998723a7d2d7637 Mon Sep 17 00:00:00 2001
+From: Thomas De Schampheleire 
+Date: Wed, 23 Jun 2021 14:22:59 +0200
+Subject: [PATCH] cmake: fix cross-compilation with
+ gRPC_BUILD_GRPC_CPP_PLUGIN=OFF (#26292)
+
+* cmake: fix cross-compilation with gRPC_BUILD_GRPC_CPP_PLUGIN=OFF
+
+When cross-compiling gRPC, a _native_ version of 'grpc_cpp_plugin' is
+searched in the environment. For most use cases, a _cross_ version of this
+file is not needed and gRPC_BUILD_GRPC_CPP_PLUGIN can be set to OFF.
+
+However, when cross-building with -DgRPC_BUILD_GRPC_CPP_PLUGIN=OFF, there
+are some build errors, for example:
+
+make[3]: *** No rule to make target 'grpc_cpp_plugin', needed by 
'gens/src/proto/grpc/reflection/v1alpha/reflection.grpc.pb.cc'.  Stop.
+
+This is because there is still a hard dependency on 'grpc_cpp_plugin' for
+these targets, not taking into account the cross-compilation case.
+
+Fix by depending on the variable gRPC_CPP_PLUGIN, which is set correctly for
+either cross or native case.
+
+* regenerate projects
+---
+ CMakeLists.txt| 2 +-
+ templates/CMakeLists.txt.template | 2 +-
+ 2 files changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index eeaf0b43c7..c60a64917a 100644
+--- a/CMakeLists.txt
 b/CMakeLists.txt
+@@ -319,7 +319,7 @@ function(protobuf_generate_grpc_cpp)
+--plugin=protoc-gen-grpc=${_gRPC_CPP_PLUGIN}
+${_protobuf_include_path}
+${REL_FIL}
+-  DEPENDS ${ABS_FIL} ${_gRPC_PROTOBUF_PROTOC} grpc_cpp_plugin
++  DEPENDS ${ABS_FIL} ${_gRPC_PROTOBUF_PROTOC} ${_gRPC_CPP_PLUGIN}
+   WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
+   COMMENT "Running gRPC C++ protocol buffer compiler on ${FIL}"
+   VERBATIM)
+diff --git a/templates/CMakeLists.txt.template 
b/templates/CMakeLists.txt.template
+index cef2534cbd..f0afe5108e 100644
+--- a/templates/CMakeLists.txt.template
 b/templates/CMakeLists.txt.template
+@@ -389,7 +389,7 @@
+  --plugin=protoc-gen-grpc=<%text>${_gRPC_CPP_PLUGIN}
+  <%text>${_protobuf_include_path}
+  <%text>${REL_FIL}
+-DEPENDS <%text>${ABS_FIL} 
<%text>${_gRPC_PROTOBUF_PROTOC} grpc_cpp_plugin
++DEPENDS <%text>${ABS_FIL} 
<%text>${_gRPC_PROTOBUF_PROTOC} <%text>${_gRPC_CPP_PLUGIN}
+ WORKING_DIRECTORY <%text>${CMAKE_CURRENT_SOURCE_DIR}
+ COMMENT "Running gRPC C++ protocol buffer compiler on 
<%text>${FIL}"
+ VERBATIM)
diff --git a/meta-oe/recipes-devtools/grpc/grpc_1.38.1.bb 
b/meta-oe/recipes-devtools/grpc/grpc_1.38.1.bb
index e2b86dad1..dfb44b819 100644
--- a/meta-oe/recipes-devtools/grpc/grpc_1.38.1.bb
+++ b/meta-oe/recipes-devtools/grpc/grpc_1.38.1.bb
@@ -23,6 +23,7 @@ S = "${WORKDIR}/git"
 SRCREV_grpc = "96b73272eadc01afb5fb45b92b408c47e4387274"
 BRANCH = "v1.38.x"
 SRC_URI = 
"git://github.com/grpc/grpc.git;protocol=https;name=grpc;branch=${BRANCH} \
+   
file://0002-cmake-fix-cross-compilation-with-gRPC_BUILD_GRPC_CPP.patch \
"
 # Fixes build with older compilers 4.8 especially on ubuntu 14.04
 CXXFLAGS:append:class-native = " -Wl,--no-as-needed"
-- 
2.28.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#93199): 
https://lists.openembedded.org/g/openembedded-devel/message/93199
Mute This Topic: https://lists.openembedded.org/mt/86077705/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-oe][PATCH 1/2] grpc: fix cross-compilation of grpc applications

2021-10-04 Thread Vyacheslav Yurkov
When we build an application that uses grpc for the target, following
error occurs

CMake Error at /recipe-sysroot/usr/lib/cmake/grpc/gRPCTargets.cmake:179 (message):
|   The imported target "gRPC::grpc_cpp_plugin" references the file
|
|  "/recipe-sysroot/usr/bin/grpc_cpp_plugin"
|
|   but this file does not exist.  Possible reasons include:
|
|   * The file was deleted, renamed, or moved to another location.
|
|   * An install or uninstall procedure did not complete successfully.
|
|   * The installation package was faulty and contained
|
|  "/recipe-sysroot/usr/lib/cmake/grpc/gRPCTargets.cmake"
|
|   but not all the files it references.
|
| Call Stack (most recent call first):
|   /recipe-sysroot/usr/lib/cmake/grpc/gRPCConfig.cmake:25 (include)
|   CMakeLists.txt:4 (find_package)

That's because target grpc was built with CPP plugin support and
referenes it from CMake config file. This commit disables CPP plugin
build for the target, and sets dependency on compiler for native and SDK
builds

Signed-off-by: Vyacheslav Yurkov 
---
 meta-oe/recipes-devtools/grpc/grpc_1.38.1.bb | 7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-devtools/grpc/grpc_1.38.1.bb 
b/meta-oe/recipes-devtools/grpc/grpc_1.38.1.bb
index b4f10662d..e2b86dad1 100644
--- a/meta-oe/recipes-devtools/grpc/grpc_1.38.1.bb
+++ b/meta-oe/recipes-devtools/grpc/grpc_1.38.1.bb
@@ -13,7 +13,11 @@ DEPENDS:append:class-nativesdk = " grpc-native "
 PACKAGE_BEFORE_PN = "${PN}-compiler"
 
 RDEPENDS:${PN}-compiler = "${PN}"
-RDEPENDS:${PN}-dev += "${PN}-compiler"
+RDEPENDS:${PN}-dev:class_native += "${PN}-compiler"
+# Configuration above allows to cross-compile gRPC applications
+# In order to compile applications on the target, use the dependency below
+# Both dependencies are mutually exclusive
+# RDEPENDS:${PN}-dev += "${PN}-compiler"
 
 S = "${WORKDIR}/git"
 SRCREV_grpc = "96b73272eadc01afb5fb45b92b408c47e4387274"
@@ -39,6 +43,7 @@ EXTRA_OECMAKE = " \
 "
 
 PACKAGECONFIG ??= "cpp shared"
+PACKAGECONFIG_class-target ?= "shared"
 PACKAGECONFIG[cpp] = 
"-DgRPC_BUILD_GRPC_CPP_PLUGIN=ON,-DgRPC_BUILD_GRPC_CPP_PLUGIN=OFF"
 PACKAGECONFIG[csharp] = 
"-DgRPC_BUILD_GRPC_CSHARP_PLUGIN=ON,-DgRPC_BUILD_GRPC_CSHARP_PLUGIN=OFF"
 PACKAGECONFIG[node] = 
"-DgRPC_BUILD_GRPC_NODE_PLUGIN=ON,-DgRPC_BUILD_GRPC_NODE_PLUGIN=OFF"
-- 
2.28.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#93198): 
https://lists.openembedded.org/g/openembedded-devel/message/93198
Mute This Topic: https://lists.openembedded.org/mt/86077704/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-oe][PATCH 0/2] gRPC Pull Request

2021-10-04 Thread Vyacheslav Yurkov
The following changes since commit 037f38cc68aabb9e36e92862af258f46874e0c13:

  gpsd: inherit pkgconfig (2021-09-30 11:04:32 -0700)

are available in the Git repository at:

  git://github.com/UVV-gh/meta-openembedded bugfix/grpc-sdk
  https://github.com/UVV-gh/meta-openembedded/tree/bugfix/grpc-sdk

Vyacheslav Yurkov (2):
  grpc: fix cross-compilation of grpc applications
  grpc: fix cross-compilation of grpc applications

 ...compilation-with-gRPC_BUILD_GRPC_CPP.patch | 55 +++
 meta-oe/recipes-devtools/grpc/grpc_1.38.1.bb  |  8 ++-
 2 files changed, 62 insertions(+), 1 deletion(-)
 create mode 100644 
meta-oe/recipes-devtools/grpc/grpc/0002-cmake-fix-cross-compilation-with-gRPC_BUILD_GRPC_CPP.patch

-- 
2.28.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#93197): 
https://lists.openembedded.org/g/openembedded-devel/message/93197
Mute This Topic: https://lists.openembedded.org/mt/86077703/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-python][PATCH] python3-aiohttp: added missing RDEPENDs

2020-12-01 Thread Vyacheslav Yurkov
aiohttp implicitly RDEPENDs on html, json, and socketserver modules,
which are part of python3 recipe. They can't be properly imported if
they are missing from RDEPENDS

Signed-off-by: Vyacheslav Yurkov 
---
 meta-python/recipes-devtools/python/python3-aiohttp_3.7.2.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta-python/recipes-devtools/python/python3-aiohttp_3.7.2.bb 
b/meta-python/recipes-devtools/python/python3-aiohttp_3.7.2.bb
index 6cd5a4cab..c98e3aee7 100644
--- a/meta-python/recipes-devtools/python/python3-aiohttp_3.7.2.bb
+++ b/meta-python/recipes-devtools/python/python3-aiohttp_3.7.2.bb
@@ -13,8 +13,11 @@ RDEPENDS_${PN} = "\
 ${PYTHON_PN}-async-timeout \
 ${PYTHON_PN}-attrs \
 ${PYTHON_PN}-chardet \
+${PYTHON_PN}-html \
 ${PYTHON_PN}-idna-ssl \
+${PYTHON_PN}-json \
 ${PYTHON_PN}-misc \
 ${PYTHON_PN}-multidict \
+${PYTHON_PN}-netserver \
 ${PYTHON_PN}-yarl \
 "
-- 
2.28.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#88194): 
https://lists.openembedded.org/g/openembedded-devel/message/88194
Mute This Topic: https://lists.openembedded.org/mt/78654131/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe] [meta-java][PATCH v2] icedtea7-native: set unique download file names

2020-06-29 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

Add package names to download file names. This allows to avoid name
collisions in case PREMIRRORS are used and all source archives reside in
the same directory. Fixed mixed indentation.

Signed-off-by: Vyacheslav Yurkov 
---
 recipes-core/icedtea/icedtea7-native.inc  | 47 +--
 .../icedtea/openjdk-7-release-03b147.inc  | 40 +---
 2 files changed, 46 insertions(+), 41 deletions(-)

diff --git a/recipes-core/icedtea/icedtea7-native.inc 
b/recipes-core/icedtea/icedtea7-native.inc
index b0b9419..f117f4a 100644
--- a/recipes-core/icedtea/icedtea7-native.inc
+++ b/recipes-core/icedtea/icedtea7-native.inc
@@ -67,31 +67,28 @@ export ALT_FREETYPE_LIB_PATH = "${STAGING_LIBDIR}"
 INSANE_SKIP_${PN} = "already-stripped"
 
 EXTRA_OECONF = "\
-   --with-parallel-jobs=${@openjdk_build_helper_get_parallel_make(d)} \
-   \
---disable-tests \
---disable-hotspot-tests \
---disable-langtools-tests \
---disable-jdk-tests \
---disable-pulse-java \
---disable-docs \
---disable-nss \
---disable-system-lcms \
-   --disable-system-gtk \
-   \
-   --with-jdk-home=${WORKDIR}/fake-jdk \
-   --with-javac=${STAGING_BINDIR_NATIVE}/javac \
-   --with-rhino=${STAGING_DATADIR_NATIVE}/java/rhino.jar \
-   \
-   --with-openjdk-src-zip=${DL_DIR}/${OPENJDK_FILE} \
---with-hotspot-src-zip=${DL_DIR}/${HOTSPOT_FILE} \
---with-corba-src-zip=${DL_DIR}/${CORBA_FILE} \
---with-jaxp-src-zip=${DL_DIR}/${JAXP_FILE} \
---with-jaxws-src-zip=${DL_DIR}/${JAXWS_FILE} \
---with-jdk-src-zip=${DL_DIR}/${JDK_FILE} \
---with-langtools-src-zip=${DL_DIR}/${LANGTOOLS_FILE} \
-ac_cv_path_UNZIP_BIN="${STAGING_BINDIR_NATIVE}/unzip" \
-  "
+--with-parallel-jobs=${@openjdk_build_helper_get_parallel_make(d)} \
+--disable-tests \
+--disable-hotspot-tests \
+--disable-langtools-tests \
+--disable-jdk-tests \
+--disable-pulse-java \
+--disable-docs \
+--disable-nss \
+--disable-system-lcms \
+--disable-system-gtk \
+--with-jdk-home=${WORKDIR}/fake-jdk \
+--with-javac=${STAGING_BINDIR_NATIVE}/javac \
+--with-rhino=${STAGING_DATADIR_NATIVE}/java/rhino.jar \
+--with-openjdk-src-zip=${DL_DIR}/${OPENJDK_FILE_DOWNLOAD} \
+--with-hotspot-src-zip=${DL_DIR}/${HOTSPOT_FILE_DOWNLOAD} \
+--with-corba-src-zip=${DL_DIR}/${CORBA_FILE_DOWNLOAD} \
+--with-jaxp-src-zip=${DL_DIR}/${JAXP_FILE_DOWNLOAD} \
+--with-jaxws-src-zip=${DL_DIR}/${JAXWS_FILE_DOWNLOAD} \
+--with-jdk-src-zip=${DL_DIR}/${JDK_FILE_DOWNLOAD} \
+--with-langtools-src-zip=${DL_DIR}/${LANGTOOLS_FILE_DOWNLOAD} \
+ac_cv_path_UNZIP_BIN="${STAGING_BINDIR_NATIVE}/unzip" \
+"
 
 JDK_DIR = "icedtea7-native"
 
diff --git a/recipes-core/icedtea/openjdk-7-release-03b147.inc 
b/recipes-core/icedtea/openjdk-7-release-03b147.inc
index 9816c0c..b504667 100644
--- a/recipes-core/icedtea/openjdk-7-release-03b147.inc
+++ b/recipes-core/icedtea/openjdk-7-release-03b147.inc
@@ -13,50 +13,58 @@ ICEDTEA_PREFIX = "icedtea7-forest-2.1"
 ICEDTEA_HG_URL = "http://icedtea.classpath.org/hg/release/${ICEDTEA_PREFIX};
 
 OPENJDK_CHANGESET = "22cc03983e20"
-OPENJDK_FILE = "${OPENJDK_CHANGESET}.tar.bz2"
-OPENJDK_URI = 
"${ICEDTEA_HG_URL}/archive/${OPENJDK_FILE};name=openjdk;unpack=false"
+OPENJDK_FILE_UPSTREAM = "${OPENJDK_CHANGESET}.tar.bz2"
+OPENJDK_FILE_DOWNLOAD = "openjdk-${OPENJDK_CHANGESET}.tar.bz2"
+OPENJDK_URI = 
"${ICEDTEA_HG_URL}/archive/${OPENJDK_FILE_UPSTREAM};name=openjdk;unpack=false;downloadfilename=${OPENJDK_FILE_DOWNLOAD}"
 SRC_URI[openjdk.md5sum] = "f98b0f7a69f9427a5b3775dc89cb"
 SRC_URI[openjdk.sha256sum] = 
"758227833982371e3a94def84226a947f8dbbd176517f313b8cb96840bdea41e"
 
 HOTSPOT_CHANGESET = "8b7c4c5f6ba9"
-HOTSPOT_FILE = "${HOTSPOT_CHANGESET}.tar.gz"
-HOTSPOT_URI = 
"${ICEDTEA_HG_URL}/hotspot/archive/${HOTSPOT_FILE};name=hotspot;unpack=false"
+HOTSPOT_FILE_UPSTREAM = "${HOTSPOT_CHANGESET}.tar.gz"
+HOTSPOT_FILE_DOWNLOAD = "hotspot-${HOTSPOT_CHANGESET}.tar.gz"
+HOTSPOT_URI = 
"${ICEDTEA_HG_URL}/hotspot/archive/${HOTSPOT_FILE_UPSTREAM};name=hotspot;unpack=false;downloadfilename=${HOTSPOT_FILE_DOWNLOAD}"
 SRC_URI[hotspot.md5sum] = "cb45a8f19d77acc1f4f48e75e36a27fe"
 SRC_URI[hotspot.sha256sum] = 
"22866990d143e76ced94b76defa3051e5e5d9a51fd272d63daa0df272d6406a2"
 
 CORBA_CHANGESET = "5617f6c5cc94"
-CORBA_FILE = "${CORBA_CHANGESET}.tar.gz"
-CORBA_URI = 
"${ICEDTEA_HG_URL}/corba/archive/${CORBA_FILE};name=corba;unpack=false"
+CORBA_FILE_UPSTREAM = "${CORBA_CHANGESET}.tar.gz"
+CORBA_FILE_DOWNLOAD = "corba-${CORBA_CHANGESET}.tar.gz"
+CORBA_URI = 
&quo

Re: [oe] [meta-java][PATCH] icedtea7-native: set unique download file names

2020-06-23 Thread Vyacheslav Yurkov

Hi Richards,
Thanks for the quick review.

The problem is that the whole file in general has tabs/spaces mixed, 
even just withing EXTRA_OECONF declaration. It's also not clear to me 
why two empty lines needed in it. In my patch I simply left indentation 
as it was in original file. Do you think it would be better just to 
change the whole EXTRA_OECONF to spaces?


Thanks,
Vyacheslav

On 23.06.2020 20:08, Richard Leitner wrote:

Hi Vyacheslav,
thanks for your patch. Please find my comments inline.

On Tue, Jun 23, 2020 at 02:23:41PM +0200, Vyacheslav Yurkov wrote:

From: Vyacheslav Yurkov 

It would be great if you could describe the change in a few more words
here. Thanks!


Signed-off-by: Vyacheslav Yurkov 
---
  recipes-core/icedtea/icedtea7-native.inc  | 14 +++
  .../icedtea/openjdk-7-release-03b147.inc  | 40 +++
  2 files changed, 31 insertions(+), 23 deletions(-)

diff --git a/recipes-core/icedtea/icedtea7-native.inc 
b/recipes-core/icedtea/icedtea7-native.inc
index b0b9419..70738e7 100644
--- a/recipes-core/icedtea/icedtea7-native.inc
+++ b/recipes-core/icedtea/icedtea7-native.inc
@@ -83,13 +83,13 @@ EXTRA_OECONF = "\
--with-javac=${STAGING_BINDIR_NATIVE}/javac \
--with-rhino=${STAGING_DATADIR_NATIVE}/java/rhino.jar \
\
-   --with-openjdk-src-zip=${DL_DIR}/${OPENJDK_FILE} \
---with-hotspot-src-zip=${DL_DIR}/${HOTSPOT_FILE} \
---with-corba-src-zip=${DL_DIR}/${CORBA_FILE} \
---with-jaxp-src-zip=${DL_DIR}/${JAXP_FILE} \
---with-jaxws-src-zip=${DL_DIR}/${JAXWS_FILE} \
---with-jdk-src-zip=${DL_DIR}/${JDK_FILE} \
---with-langtools-src-zip=${DL_DIR}/${LANGTOOLS_FILE} \
+   --with-openjdk-src-zip=${DL_DIR}/${OPENJDK_FILE_DOWNLOAD} \

Looks like you have some whitespace issues here.

Apart from that the patch looks good, therefore I'm looking forward to a
v2. Thanks!

regards;rl

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#85301): 
https://lists.openembedded.org/g/openembedded-devel/message/85301
Mute This Topic: https://lists.openembedded.org/mt/75058545/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[oe] [meta-java][PATCH] icedtea7-native: set unique download file names

2020-06-23 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

Signed-off-by: Vyacheslav Yurkov 
---
 recipes-core/icedtea/icedtea7-native.inc  | 14 +++
 .../icedtea/openjdk-7-release-03b147.inc  | 40 +++
 2 files changed, 31 insertions(+), 23 deletions(-)

diff --git a/recipes-core/icedtea/icedtea7-native.inc 
b/recipes-core/icedtea/icedtea7-native.inc
index b0b9419..70738e7 100644
--- a/recipes-core/icedtea/icedtea7-native.inc
+++ b/recipes-core/icedtea/icedtea7-native.inc
@@ -83,13 +83,13 @@ EXTRA_OECONF = "\
--with-javac=${STAGING_BINDIR_NATIVE}/javac \
--with-rhino=${STAGING_DATADIR_NATIVE}/java/rhino.jar \
\
-   --with-openjdk-src-zip=${DL_DIR}/${OPENJDK_FILE} \
---with-hotspot-src-zip=${DL_DIR}/${HOTSPOT_FILE} \
---with-corba-src-zip=${DL_DIR}/${CORBA_FILE} \
---with-jaxp-src-zip=${DL_DIR}/${JAXP_FILE} \
---with-jaxws-src-zip=${DL_DIR}/${JAXWS_FILE} \
---with-jdk-src-zip=${DL_DIR}/${JDK_FILE} \
---with-langtools-src-zip=${DL_DIR}/${LANGTOOLS_FILE} \
+   --with-openjdk-src-zip=${DL_DIR}/${OPENJDK_FILE_DOWNLOAD} \
+--with-hotspot-src-zip=${DL_DIR}/${HOTSPOT_FILE_DOWNLOAD} \
+--with-corba-src-zip=${DL_DIR}/${CORBA_FILE_DOWNLOAD} \
+--with-jaxp-src-zip=${DL_DIR}/${JAXP_FILE_DOWNLOAD} \
+--with-jaxws-src-zip=${DL_DIR}/${JAXWS_FILE_DOWNLOAD} \
+--with-jdk-src-zip=${DL_DIR}/${JDK_FILE_DOWNLOAD} \
+--with-langtools-src-zip=${DL_DIR}/${LANGTOOLS_FILE_DOWNLOAD} \
 ac_cv_path_UNZIP_BIN="${STAGING_BINDIR_NATIVE}/unzip" \
   "
 
diff --git a/recipes-core/icedtea/openjdk-7-release-03b147.inc 
b/recipes-core/icedtea/openjdk-7-release-03b147.inc
index 9816c0c..b504667 100644
--- a/recipes-core/icedtea/openjdk-7-release-03b147.inc
+++ b/recipes-core/icedtea/openjdk-7-release-03b147.inc
@@ -13,50 +13,58 @@ ICEDTEA_PREFIX = "icedtea7-forest-2.1"
 ICEDTEA_HG_URL = "http://icedtea.classpath.org/hg/release/${ICEDTEA_PREFIX};
 
 OPENJDK_CHANGESET = "22cc03983e20"
-OPENJDK_FILE = "${OPENJDK_CHANGESET}.tar.bz2"
-OPENJDK_URI = 
"${ICEDTEA_HG_URL}/archive/${OPENJDK_FILE};name=openjdk;unpack=false"
+OPENJDK_FILE_UPSTREAM = "${OPENJDK_CHANGESET}.tar.bz2"
+OPENJDK_FILE_DOWNLOAD = "openjdk-${OPENJDK_CHANGESET}.tar.bz2"
+OPENJDK_URI = 
"${ICEDTEA_HG_URL}/archive/${OPENJDK_FILE_UPSTREAM};name=openjdk;unpack=false;downloadfilename=${OPENJDK_FILE_DOWNLOAD}"
 SRC_URI[openjdk.md5sum] = "f98b0f7a69f9427a5b3775dc89cb"
 SRC_URI[openjdk.sha256sum] = 
"758227833982371e3a94def84226a947f8dbbd176517f313b8cb96840bdea41e"
 
 HOTSPOT_CHANGESET = "8b7c4c5f6ba9"
-HOTSPOT_FILE = "${HOTSPOT_CHANGESET}.tar.gz"
-HOTSPOT_URI = 
"${ICEDTEA_HG_URL}/hotspot/archive/${HOTSPOT_FILE};name=hotspot;unpack=false"
+HOTSPOT_FILE_UPSTREAM = "${HOTSPOT_CHANGESET}.tar.gz"
+HOTSPOT_FILE_DOWNLOAD = "hotspot-${HOTSPOT_CHANGESET}.tar.gz"
+HOTSPOT_URI = 
"${ICEDTEA_HG_URL}/hotspot/archive/${HOTSPOT_FILE_UPSTREAM};name=hotspot;unpack=false;downloadfilename=${HOTSPOT_FILE_DOWNLOAD}"
 SRC_URI[hotspot.md5sum] = "cb45a8f19d77acc1f4f48e75e36a27fe"
 SRC_URI[hotspot.sha256sum] = 
"22866990d143e76ced94b76defa3051e5e5d9a51fd272d63daa0df272d6406a2"
 
 CORBA_CHANGESET = "5617f6c5cc94"
-CORBA_FILE = "${CORBA_CHANGESET}.tar.gz"
-CORBA_URI = 
"${ICEDTEA_HG_URL}/corba/archive/${CORBA_FILE};name=corba;unpack=false"
+CORBA_FILE_UPSTREAM = "${CORBA_CHANGESET}.tar.gz"
+CORBA_FILE_DOWNLOAD = "corba-${CORBA_CHANGESET}.tar.gz"
+CORBA_URI = 
"${ICEDTEA_HG_URL}/corba/archive/${CORBA_FILE_UPSTREAM};name=corba;unpack=false;downloadfilename=${CORBA_FILE_DOWNLOAD}"
 SRC_URI[corba.md5sum] = "920f1a788a7fdef29a5cd70892331251"
 SRC_URI[corba.sha256sum] = 
"963915483530f311ff313635f79ed11ea7ce5a1c0dbee5d1acb1994132857fa3"
 
 JAXP_CHANGESET = "7a8825b15df6"
-JAXP_FILE = "${JAXP_CHANGESET}.tar.gz"
-JAXP_URI = "${ICEDTEA_HG_URL}/jaxp/archive/${JAXP_FILE};name=jaxp;unpack=false"
+JAXP_FILE_UPSTREAM = "${JAXP_CHANGESET}.tar.gz"
+JAXP_FILE_DOWNLOAD = "jaxp-${JAXP_CHANGESET}.tar.gz"
+JAXP_URI = 
"${ICEDTEA_HG_URL}/jaxp/archive/${JAXP_FILE_UPSTREAM};name=jaxp;unpack=false;downloadfilename=${JAXP_FILE_DOWNLOAD}"
 SRC_URI[jaxp.md5sum] = "a0982b6df79739127871e355a40ca5a6"
 SRC_URI[jaxp.sha256sum] = 
"297c8dbeed5afa5395b6be06b17282d53f8a888c2909074dfc1605afc0daf1c2"
 
 JAXWS_CHANGESET = "7edfbfe974f2"
-JAXWS_FILE = "${JAXWS_CHANGESET}.tar.gz"
-JAXWS_URI = 
"${ICEDTEA_HG_URL}/jaxws/archive/${JAXWS_FILE};name=jaxws;unpack=false"
+JAXWS_FILE_UPSTREAM = "${JAXWS_CHANGESET}.tar.gz"
+JAXWS_FILE_DOWNLOAD = "jaxws-${JAXWS_CHANGESET}.tar.gz"
+JAXWS_URI = 
"${ICEDTEA_HG_URL}/jaxws/archive/$

[oe] [meta-java][PATCH] jlex: set unique file name for download

2020-06-23 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

Signed-off-by: Vyacheslav Yurkov 
---
 recipes-core/jlex/jlex_1.2.6.bb | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/recipes-core/jlex/jlex_1.2.6.bb b/recipes-core/jlex/jlex_1.2.6.bb
index b8f9ffb..3c14e4c 100644
--- a/recipes-core/jlex/jlex_1.2.6.bb
+++ b/recipes-core/jlex/jlex_1.2.6.bb
@@ -1,7 +1,9 @@
 SUMMARY = "Lexical analyzer generator for Java"
 AUTHOR = "Elliot Berk, A. Appel, C. Scott Ananian"
+
+JLEX_MAIN_FILENAME = "jlex-${PV}-Main.java"
 LICENSE = "JLEX"
-LIC_FILES_CHKSUM = 
"file://Main.java;beginline=148;endline=166;md5=9bf4a6a951053991db64f9d7330d648a"
+LIC_FILES_CHKSUM = 
"file://${JLEX_MAIN_FILENAME};beginline=148;endline=166;md5=9bf4a6a951053991db64f9d7330d648a"
 
 PACKAGE_ARCH = "${TUNE_PKGARCH}"
 
@@ -10,7 +12,7 @@ RDEPENDS_${PN}_class-native = ""
 
 inherit java-library
 
-SRC_URI = 
"http://www.cs.princeton.edu/~appel/modern/java/JLex/Archive/${PV}/Main.java \
+SRC_URI = 
"http://www.cs.princeton.edu/~appel/modern/java/JLex/Archive/${PV}/Main.java;downloadfilename=${JLEX_MAIN_FILENAME}
 \
file://jlex \
   "
 
@@ -26,6 +28,7 @@ do_configure() {
 
 do_compile() {
mkdir -p build
+   cp ${JLEX_MAIN_FILENAME} Main.java
 
javac -d build Main.java
 
-- 
2.25.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#85283): 
https://lists.openembedded.org/g/openembedded-devel/message/85283
Mute This Topic: https://lists.openembedded.org/mt/75056809/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


[oe] [meta-python][PATCH] python3-arpeggio: add new recipe

2020-04-08 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

Arpeggio is a recursive descent parser with memoization based on
PEG grammars (aka Packrat parser)

Signed-off-by: Vyacheslav Yurkov 
---
 .../python/python3-arpeggio_1.9.2.bb  | 15 +++
 1 file changed, 15 insertions(+)
 create mode 100644 
meta-python/recipes-devtools/python/python3-arpeggio_1.9.2.bb

diff --git a/meta-python/recipes-devtools/python/python3-arpeggio_1.9.2.bb 
b/meta-python/recipes-devtools/python/python3-arpeggio_1.9.2.bb
new file mode 100644
index 0..802a5b2ea
--- /dev/null
+++ b/meta-python/recipes-devtools/python/python3-arpeggio_1.9.2.bb
@@ -0,0 +1,15 @@
+SUMMARY = "Arpeggio is a recursive descent parser with memoization based on 
PEG grammars (aka Packrat parser)"
+HOMEPAGE = "https://pypi.org/project/Arpeggio/;
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=33b8d1ba459a2fa4d801acfd1d1b7ceb"
+
+SRC_URI[md5sum] = "39667a626217c670bc63be6e904a"
+SRC_URI[sha256sum] = 
"948ce06163a48a72c97f4fe79ad3d1c1330b6fec4f22ece182fb60ef60bd022b"
+
+PYPI_PACKAGE = "Arpeggio"
+inherit pypi setuptools3
+
+# setup.py of Arpeggio needs this.
+DEPENDS += "${PYTHON_PN}-pytest-runner-native"
+
+BBCLASSEXTEND = "native nativesdk"
-- 
2.25.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#83816): 
https://lists.openembedded.org/g/openembedded-devel/message/83816
Mute This Topic: https://lists.openembedded.org/mt/72872904/21656
Group Owner: openembedded-devel+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub  
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [oe] [meta-java][PATCH] jamvm: Disable inlining

2019-05-10 Thread Vyacheslav Yurkov

Hi Marek,
Thanks for your patch. I can confirm that this resolves the Illegal 
instruction issue for me on gcc-7.4 and Morty branch. I don't think 
there should be any difference for master branch regarding this fix, in 
other words it must be applicable to master too.


Thanks,
Vyacheslav

On 30/04/2019 09:48, Belisko Marek wrote:

Ping. any comments on this?

On Thu, Mar 7, 2019 at 12:57 PM Marek Belisko 
wrote:


This will fix crashes seen when build openjdk-8:

ERROR: jaxp1.3-native-1.4.01-r0 do_compile: Function failed: do_compile
(log file is located at
/home/jenkins/my_build/tmp/work/x86_64-linux/jaxp1.3-native/1.4.01-r0/temp/log.do_compile.28894)
ERROR: Logfile of failure stored in:
/home/jenkins/my_build/tmp/work/x86_64-linux/jaxp1.3-native/1.4.01-r0/temp/log.do_compile.28894
Log data follows:
| DEBUG: Executing shell function do_compile
| Illegal instruction (core dumped)
| WARNING: exit code 132 from a shell command.
| ERROR: Function failed: do_compile (log file is located at
/home/jenkins/my_build/tmp/work/x86_64-linux/jaxp1.3-native/1.4.01-r0/temp/log.do_compile.28894)
ERROR: Task
(virtual:native:/home/jenkins/meta-java/recipes-core/xml-commons/jaxp1.3_1.4.01.bb:do_compile)
failed with exit code '1'


Signed-off-by: Marek Belisko 
---
  recipes-core/jamvm/jamvm.inc | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-core/jamvm/jamvm.inc b/recipes-core/jamvm/jamvm.inc
index fc21380..8a1ed63 100644
--- a/recipes-core/jamvm/jamvm.inc
+++ b/recipes-core/jamvm/jamvm.inc
@@ -29,7 +29,7 @@ do_configure_append_class-native() {
  }


-EXTRA_OECONF = "--with-classpath-install-dir=${prefix}
--libdir=${libdir}/jamvm --enable-ffi"
+EXTRA_OECONF = "--with-classpath-install-dir=${prefix}
--libdir=${libdir}/jamvm --enable-ffi --disable-int-inlining"

  # Needed for big compilation targets like OpenJDK
  CFLAGS_append_class-native = " -DDEFAULT_MAX_HEAP=1024*MB"
--
2.7.4



marek

--
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


[oe] [meta-oe][PATCH] glog: fix installation path

2018-12-05 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

When glog is compiled with multilib support, it shouldn't use hardcoded paths.
Paths substitued by CMake should be used instead.

Signed-off-by: Vyacheslav Yurkov 
Tested-by: Martin Jansa 
---
 .../glog/0003-installation-path-fix.patch | 65 +++
 meta-oe/recipes-support/glog/glog_0.3.5.bb|  1 +
 2 files changed, 66 insertions(+)
 create mode 100644 
meta-oe/recipes-support/glog/glog/0003-installation-path-fix.patch

diff --git a/meta-oe/recipes-support/glog/glog/0003-installation-path-fix.patch 
b/meta-oe/recipes-support/glog/glog/0003-installation-path-fix.patch
new file mode 100644
index 0..641f70cb2
--- /dev/null
+++ b/meta-oe/recipes-support/glog/glog/0003-installation-path-fix.patch
@@ -0,0 +1,65 @@
+diff -uNr a/CMakeLists.txt b/CMakeLists.txt
+--- a/CMakeLists.txt   2018-12-05 12:55:59.630792054 +0100
 b/CMakeLists.txt   2018-12-05 13:00:22.922269200 +0100
+@@ -403,10 +403,15 @@
+ 
+ set_target_properties (glog PROPERTIES PUBLIC_HEADER "${GLOG_PUBLIC_H}")
+ 
++set (_glog_CMake_BINDIR ${CMAKE_INSTALL_BINDIR})
++set (_glog_CMake_INCLUDE_DIR ${CMAKE_INSTALL_INCLUDEDIR})
++set (_glog_CMake_LIBDIR ${CMAKE_INSTALL_LIBDIR})
++set (_glog_CMake_INSTALLDIR ${_glog_CMake_LIBDIR}/cmake/glog)
++
+ target_include_directories (glog BEFORE PUBLIC
+   "$"
+   "$"
+-  "$"
++  "$"
+   PRIVATE ${CMAKE_CURRENT_BINARY_DIR}
+   PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/src)
+ 
+@@ -543,10 +548,10 @@
+ 
+ install (TARGETS glog
+   EXPORT glog-targets
+-  RUNTIME DESTINATION bin
+-  PUBLIC_HEADER DESTINATION include/glog
+-  LIBRARY DESTINATION lib
+-  ARCHIVE DESTINATION lib)
++  RUNTIME DESTINATION ${_glog_CMake_BINDIR}
++  PUBLIC_HEADER DESTINATION ${_glog_CMake_INCLUDE_DIR}/glog
++  LIBRARY DESTINATION ${_glog_CMake_LIBDIR}
++  ARCHIVE DESTINATION ${_glog_CMake_LIBDIR})
+ 
+ if (gflags_FOUND)
+   set (gflags_DEPENDENCY "find_dependency (gflags ${gflags_VERSION})")
+@@ -554,7 +559,7 @@
+ 
+ configure_package_config_file (glog-config.cmake.in
+   ${CMAKE_CURRENT_BINARY_DIR}/glog-config.cmake
+-  INSTALL_DESTINATION lib/cmake/glog
++  INSTALL_DESTINATION ${_glog_CMake_INSTALLDIR}
+   NO_CHECK_REQUIRED_COMPONENTS_MACRO)
+ 
+ write_basic_package_version_file (glog-config-version.cmake VERSION
+@@ -567,6 +572,7 @@
+   ${CMAKE_CURRENT_BINARY_DIR}/glog-config.cmake
+   ${CMAKE_CURRENT_BINARY_DIR}/glog-config-version.cmake
+   ${CMAKE_CURRENT_SOURCE_DIR}/cmake/FindLibunwind.cmake
+-  DESTINATION lib/cmake/glog)
++  DESTINATION ${_glog_CMake_INSTALLDIR})
+ 
+-install (EXPORT glog-targets NAMESPACE glog:: DESTINATION lib/cmake/glog)
++install (EXPORT glog-targets NAMESPACE glog:: DESTINATION
++  ${_glog_CMake_INSTALLDIR})
+diff -uNr a/glog-config.cmake.in b/glog-config.cmake.in
+--- a/glog-config.cmake.in 2018-12-05 12:55:59.630792054 +0100
 b/glog-config.cmake.in 2018-12-05 13:05:19.547196843 +0100
+@@ -4,6 +4,7 @@
+ 
+ @gflags_DEPENDENCY@
+ 
++list (APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}")
+ find_dependency (Libunwind)
+ 
+ include ("${CMAKE_CURRENT_LIST_DIR}/glog-targets.cmake")
diff --git a/meta-oe/recipes-support/glog/glog_0.3.5.bb 
b/meta-oe/recipes-support/glog/glog_0.3.5.bb
index 5e58450c2..3de01ef5b 100644
--- a/meta-oe/recipes-support/glog/glog_0.3.5.bb
+++ b/meta-oe/recipes-support/glog/glog_0.3.5.bb
@@ -12,6 +12,7 @@ SRC_URI = " \
 git://github.com/google/glog.git;branch=v035 \
 file://0001-Rework-CMake-glog-VERSION-management.patch \
 file://0002-Find-Libunwind-during-configure.patch \
+file://0003-installation-path-fix.patch \
 "
 
 SRCREV = "a6a166db069520dbbd653c97c2e5b12e08a8bb26"
-- 
2.19.1

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [meta-oe][PATCH v3] glog: fixed the build for mips and other platforms

2018-11-29 Thread Vyacheslav Yurkov
Hi Martin,
I guess this issue is supposed to be fixed in glog master already, because
it uses ${CMAKE_INSTALL_LIBDIR}, not hard-coded "lib". I will backport a
patch for that

Regards,
Vyacheslav

On Thu, Nov 29, 2018 at 4:51 PM Martin Jansa  wrote:

> Hi,
>
> there is one more issue when multilib is enabled.
>
> ERROR: QA Issue: glog: Files/directories were installed but not shipped in
> any package:
>   /usr/lib/libglog.so.0.3.5
>   /usr/lib/libglog.so.0
>   /usr/lib/libglog.so
>   /usr/lib/cmake
>   /usr/lib/cmake/glog
>   /usr/lib/cmake/glog/glog-config-version.cmake
>   /usr/lib/cmake/glog/FindLibunwind.cmake
>   /usr/lib/cmake/glog/glog-targets-noconfig.cmake
>   /usr/lib/cmake/glog/glog-config.cmake
>   /usr/lib/cmake/glog/glog-targets.cmake
> Please set FILES such that these items are packaged. Alternatively if they
> are unneeded, avoid installing them or delete them within do_install.
> glog: 10 installed and not shipped files. [installed-vs-shipped]
>
> It shouldn't hardcode "lib" directory and it should respect libdir from OE
> environment instead (in this case /usr/lib64).
>
> On Tue, Nov 20, 2018 at 3:57 PM Vyacheslav Yurkov 
> wrote:
>
>> From: Vyacheslav Yurkov 
>>
>> According to build log
>> http://errors.yoctoproject.org/Errors/Details/201286/
>> FindLibunwind wokred only for x86, arm, and x86_64. This patch extends the
>> cmake module to work with mips, ia64, ppc(64) and other architectures
>> supported
>> by libunwind
>>
>> Signed-off-by: Vyacheslav Yurkov 
>> ---
>>  ...0002-Find-Libunwind-during-configure.patch | 53 +++
>>  1 file changed, 30 insertions(+), 23 deletions(-)
>>
>> diff --git
>> a/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
>> b/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
>> index 3a6f824ea..15cf67fd2 100644
>> ---
>> a/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
>> +++
>> b/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
>> @@ -1,11 +1,11 @@
>>  diff -uNr a/cmake/FindLibunwind.cmake b/cmake/FindLibunwind.cmake
>>  --- a/cmake/FindLibunwind.cmake1970-01-01 01:00:00.0
>> +0100
>> -+++ b/cmake/FindLibunwind.cmake2018-11-02 14:04:35.460437058
>> +0100
>> -@@ -0,0 +1,37 @@
>>  b/cmake/FindLibunwind.cmake2018-11-20 15:53:48.799078114
>> +0100
>> +@@ -0,0 +1,54 @@
>>  +# - Try to find libunwind
>>  +# Once done this will define
>>  +#
>> -+#  LIBUNWIND_FOUND - system has libunwind
>> ++#  Libunwind_FOUND - system has libunwind
>>  +#  unwind - cmake target for libunwind
>>  +
>>  +find_library (UNWIND_LIBRARY NAMES unwind DOC "unwind library")
>> @@ -15,11 +15,24 @@ diff -uNr a/cmake/FindLibunwind.cmake
>> b/cmake/FindLibunwind.cmake
>>  +
>>  +if (CMAKE_SYSTEM_PROCESSOR MATCHES "^arm")
>>  +set(LIBUNWIND_ARCH "arm")
>> ++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^aarch64")
>> ++set(LIBUNWIND_ARCH "aarch64")
>>  +elseif (CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64" OR
>> -+CMAKE_SYSTEM_PROCESSOR STREQUAL "amd64")
>> ++CMAKE_SYSTEM_PROCESSOR STREQUAL "amd64" OR
>> ++CMAKE_SYSTEM_PROCESSOR STREQUAL "corei7-64")
>>  +set(LIBUNWIND_ARCH "x86_64")
>>  +elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^i.86$")
>>  +set(LIBUNWIND_ARCH "x86")
>> ++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^ppc64")
>> ++set(LIBUNWIND_ARCH "ppc64")
>> ++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^ppc")
>> ++set(LIBUNWIND_ARCH "ppc32")
>> ++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^mips")
>> ++set(LIBUNWIND_ARCH "mips")
>> ++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^hppa")
>> ++set(LIBUNWIND_ARCH "hppa")
>> ++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^ia64")
>> ++set(LIBUNWIND_ARCH "ia64")
>>  +endif()
>>  +
>>  +find_library (UNWIND_LIBRARY_PLATFORM NAMES "unwind-${LIBUNWIND_ARCH}"
>> DOC "unwind library platform")
>> @@ -35,13 +48,17 @@ diff -uNr a/cmake/FindLibunwind.cmake
>> b/cmake/FindLibunwind.cmake
>>  +
>>  +mark_as_advanced (UNWIND_LIBRARY UNWIND_LIBRARY_PLATFORM)
>>  +
>> -+add_library(unwind INTERFACE IMPORTED)
>> -+set_target_properties(unwind PROPERTIES
>> -+INTERFACE_LINK_LIBRARIES
>> &qu

[oe] [meta-oe][PATCH v3] glog: fixed the build for mips and other platforms

2018-11-20 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

According to build log http://errors.yoctoproject.org/Errors/Details/201286/
FindLibunwind wokred only for x86, arm, and x86_64. This patch extends the
cmake module to work with mips, ia64, ppc(64) and other architectures supported
by libunwind

Signed-off-by: Vyacheslav Yurkov 
---
 ...0002-Find-Libunwind-during-configure.patch | 53 +++
 1 file changed, 30 insertions(+), 23 deletions(-)

diff --git 
a/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch 
b/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
index 3a6f824ea..15cf67fd2 100644
--- 
a/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
+++ 
b/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
@@ -1,11 +1,11 @@
 diff -uNr a/cmake/FindLibunwind.cmake b/cmake/FindLibunwind.cmake
 --- a/cmake/FindLibunwind.cmake1970-01-01 01:00:00.0 +0100
-+++ b/cmake/FindLibunwind.cmake2018-11-02 14:04:35.460437058 +0100
-@@ -0,0 +1,37 @@
 b/cmake/FindLibunwind.cmake2018-11-20 15:53:48.799078114 +0100
+@@ -0,0 +1,54 @@
 +# - Try to find libunwind
 +# Once done this will define
 +#
-+#  LIBUNWIND_FOUND - system has libunwind
++#  Libunwind_FOUND - system has libunwind
 +#  unwind - cmake target for libunwind
 +
 +find_library (UNWIND_LIBRARY NAMES unwind DOC "unwind library")
@@ -15,11 +15,24 @@ diff -uNr a/cmake/FindLibunwind.cmake 
b/cmake/FindLibunwind.cmake
 +
 +if (CMAKE_SYSTEM_PROCESSOR MATCHES "^arm")
 +set(LIBUNWIND_ARCH "arm")
++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^aarch64")
++set(LIBUNWIND_ARCH "aarch64")
 +elseif (CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64" OR
-+CMAKE_SYSTEM_PROCESSOR STREQUAL "amd64")
++CMAKE_SYSTEM_PROCESSOR STREQUAL "amd64" OR
++CMAKE_SYSTEM_PROCESSOR STREQUAL "corei7-64")
 +set(LIBUNWIND_ARCH "x86_64")
 +elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^i.86$")
 +set(LIBUNWIND_ARCH "x86")
++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^ppc64")
++set(LIBUNWIND_ARCH "ppc64")
++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^ppc")
++set(LIBUNWIND_ARCH "ppc32")
++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^mips")
++set(LIBUNWIND_ARCH "mips")
++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^hppa")
++set(LIBUNWIND_ARCH "hppa")
++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^ia64")
++set(LIBUNWIND_ARCH "ia64")
 +endif()
 +
 +find_library (UNWIND_LIBRARY_PLATFORM NAMES "unwind-${LIBUNWIND_ARCH}" DOC 
"unwind library platform")
@@ -35,13 +48,17 @@ diff -uNr a/cmake/FindLibunwind.cmake 
b/cmake/FindLibunwind.cmake
 +
 +mark_as_advanced (UNWIND_LIBRARY UNWIND_LIBRARY_PLATFORM)
 +
-+add_library(unwind INTERFACE IMPORTED)
-+set_target_properties(unwind PROPERTIES
-+INTERFACE_LINK_LIBRARIES "${UNWIND_LIBRARY};${UNWIND_LIBRARY_PLATFORM}"
-+)
++if (Libunwind_FOUND)
++add_library(unwind INTERFACE IMPORTED)
++set_target_properties(unwind PROPERTIES
++INTERFACE_LINK_LIBRARIES 
"${UNWIND_LIBRARY};${UNWIND_LIBRARY_PLATFORM}"
++)
++else()
++message("Can't find libunwind library")
++endif()
 diff -uNr a/CMakeLists.txt b/CMakeLists.txt
 a/CMakeLists.txt   2018-11-02 14:02:21.784835854 +0100
-+++ b/CMakeLists.txt   2018-11-02 14:03:16.796935594 +0100
+--- a/CMakeLists.txt   2018-11-20 15:49:07.576278417 +0100
 b/CMakeLists.txt   2018-11-20 15:49:32.106819928 +0100
 @@ -58,7 +58,6 @@
  check_include_file (execinfo.h HAVE_EXECINFO_H)
  check_include_file (glob.h HAVE_GLOB_H)
@@ -91,23 +108,13 @@ diff -uNr a/CMakeLists.txt b/CMakeLists.txt
DESTINATION lib/cmake/glog)
  
  install (EXPORT glog-targets NAMESPACE glog:: DESTINATION lib/cmake/glog)
-Binary files a/.git/index and b/.git/index differ
 diff -uNr a/glog-config.cmake.in b/glog-config.cmake.in
 a/glog-config.cmake.in 2018-11-02 14:02:21.784835854 +0100
-+++ b/glog-config.cmake.in 2018-11-02 14:03:16.796935594 +0100
-@@ -4,4 +4,15 @@
+--- a/glog-config.cmake.in 2018-11-20 15:49:07.576278417 +0100
 b/glog-config.cmake.in 2018-11-20 15:52:32.330418489 +0100
+@@ -4,4 +4,6 @@
  
  @gflags_DEPENDENCY@
  
-+# Record the state of the CMake module path when this script was
-+# called so that we can ensure that we leave it in the same state on
-+# exit as it was on entry, but modify it locally.
-+set(UNWIND_CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH})
-+
-+set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}")
 +find_dependency (Libunwind)
-+
-+# Restore original module path
-+set(CMAKE_MODULE_PATH "${UNWIND_CMAKE_MODULE_PATH}")
 +
  include ("${CMAKE_CURRENT_LIST_DIR}/glog-targets.cmake")
-- 
2.19.1

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


[oe] [meta-oe][PATCH v2] glog: fixed the build for mips and other platforms

2018-11-20 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

According to build log http://errors.yoctoproject.org/Errors/Details/201286/
FindLibunwind wokred only for x86, arm, and x86_64. This patch extends the
cmake module to work with mips, ia64, ppc(64) and other architectures supported
by libunwind

Signed-off-by: Vyacheslav Yurkov 
---
 ...0002-Find-Libunwind-during-configure.patch | 34 ++-
 1 file changed, 25 insertions(+), 9 deletions(-)

diff --git 
a/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch 
b/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
index 3a6f824ea..9ee01bfc3 100644
--- 
a/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
+++ 
b/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
@@ -1,11 +1,11 @@
 diff -uNr a/cmake/FindLibunwind.cmake b/cmake/FindLibunwind.cmake
 --- a/cmake/FindLibunwind.cmake1970-01-01 01:00:00.0 +0100
-+++ b/cmake/FindLibunwind.cmake2018-11-02 14:04:35.460437058 +0100
-@@ -0,0 +1,37 @@
 b/cmake/FindLibunwind.cmake2018-11-19 16:07:17.652031645 +0100
+@@ -0,0 +1,54 @@
 +# - Try to find libunwind
 +# Once done this will define
 +#
-+#  LIBUNWIND_FOUND - system has libunwind
++#  Libunwind_FOUND - system has libunwind
 +#  unwind - cmake target for libunwind
 +
 +find_library (UNWIND_LIBRARY NAMES unwind DOC "unwind library")
@@ -15,11 +15,24 @@ diff -uNr a/cmake/FindLibunwind.cmake 
b/cmake/FindLibunwind.cmake
 +
 +if (CMAKE_SYSTEM_PROCESSOR MATCHES "^arm")
 +set(LIBUNWIND_ARCH "arm")
++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^aarch64")
++set(LIBUNWIND_ARCH "aarch64")
 +elseif (CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64" OR
-+CMAKE_SYSTEM_PROCESSOR STREQUAL "amd64")
++CMAKE_SYSTEM_PROCESSOR STREQUAL "amd64" OR
++CMAKE_SYSTEM_PROCESSOR STREQUAL "corei7-64")
 +set(LIBUNWIND_ARCH "x86_64")
 +elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^i.86$")
 +set(LIBUNWIND_ARCH "x86")
++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^ppc64")
++set(LIBUNWIND_ARCH "ppc64")
++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^ppc")
++set(LIBUNWIND_ARCH "ppc32")
++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^mips")
++set(LIBUNWIND_ARCH "mips")
++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^hppa")
++set(LIBUNWIND_ARCH "hppa")
++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^ia64")
++set(LIBUNWIND_ARCH "ia64")
 +endif()
 +
 +find_library (UNWIND_LIBRARY_PLATFORM NAMES "unwind-${LIBUNWIND_ARCH}" DOC 
"unwind library platform")
@@ -35,13 +48,17 @@ diff -uNr a/cmake/FindLibunwind.cmake 
b/cmake/FindLibunwind.cmake
 +
 +mark_as_advanced (UNWIND_LIBRARY UNWIND_LIBRARY_PLATFORM)
 +
++if (NOT Libunwind_FOUND)
++message("Can't find libunwind library")
++endif()
++
 +add_library(unwind INTERFACE IMPORTED)
 +set_target_properties(unwind PROPERTIES
 +INTERFACE_LINK_LIBRARIES "${UNWIND_LIBRARY};${UNWIND_LIBRARY_PLATFORM}"
 +)
 diff -uNr a/CMakeLists.txt b/CMakeLists.txt
 a/CMakeLists.txt   2018-11-02 14:02:21.784835854 +0100
-+++ b/CMakeLists.txt   2018-11-02 14:03:16.796935594 +0100
+--- a/CMakeLists.txt   2018-11-19 15:55:05.293665965 +0100
 b/CMakeLists.txt   2018-11-19 15:57:37.828381535 +0100
 @@ -58,7 +58,6 @@
  check_include_file (execinfo.h HAVE_EXECINFO_H)
  check_include_file (glob.h HAVE_GLOB_H)
@@ -91,10 +108,9 @@ diff -uNr a/CMakeLists.txt b/CMakeLists.txt
DESTINATION lib/cmake/glog)
  
  install (EXPORT glog-targets NAMESPACE glog:: DESTINATION lib/cmake/glog)
-Binary files a/.git/index and b/.git/index differ
 diff -uNr a/glog-config.cmake.in b/glog-config.cmake.in
 a/glog-config.cmake.in 2018-11-02 14:02:21.784835854 +0100
-+++ b/glog-config.cmake.in 2018-11-02 14:03:16.796935594 +0100
+--- a/glog-config.cmake.in 2018-11-19 15:55:05.293665965 +0100
 b/glog-config.cmake.in 2018-11-19 15:57:37.828381535 +0100
 @@ -4,4 +4,15 @@
  
  @gflags_DEPENDENCY@
-- 
2.19.1

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [meta-oe][PATCH] glog: fixed the build for mips and other platforms

2018-11-19 Thread Vyacheslav Yurkov
I don't see that it would be supported on these architectures. At lease
this is what first paragraph on https://github.com/libunwind/libunwind says:



This library supports several architecture/operating-system combinations:



Linux/x86-64: Works well. Linux/x86: Works well. Linux/ARM: Works well.
Linux/IA-64: Works well. Linux/PARISC: Works well, but C library missing
unwind-info. HP-UX/IA-64: Mostly works but known to have some serious
limitations. MIPS: Newly added. Linux/AArch64: Works well. Linux/PPC64:
Newly added. Linux/SuperH: Newly added. FreeBSD/i386: Works well.
FreeBSD/x86-64: Newly added (FreeBSD architecture is known as amd64).
Linux/Tilegx: Newly added (64-bit mode only).



I guess if someone wants to use glog on those, glog has to be compiled
without libunwind support. In that case the libunwind check needs to fall
through without fatal message. I will change that part.



Vyacheslav


On Mon, Nov 19, 2018 at 10:26 PM Khem Raj  wrote:

> On Mon, Nov 19, 2018 at 7:19 AM Vyacheslav Yurkov 
> wrote:
> >
> > From: Vyacheslav Yurkov 
> >
> > According to build log
> http://errors.yoctoproject.org/Errors/Details/201286/
> > FindLibunwind wokred only for x86, arm, and x86_64. This patch extends
> the
> > cmake module to work with mips, ia64, ppc(64) and other architectures
> supported
> > by libunwind
>
> It would be good to add riscv64 and arc to this list as well.
>
> >
> > Signed-off-by: Vyacheslav Yurkov 
> > ---
> >  ...0002-Find-Libunwind-during-configure.patch | 34 ++-
> >  1 file changed, 25 insertions(+), 9 deletions(-)
> >
> > diff --git
> a/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
> b/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
> > index 3a6f824ea..4ad302cbe 100644
> > ---
> a/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
> > +++
> b/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
> > @@ -1,11 +1,11 @@
> >  diff -uNr a/cmake/FindLibunwind.cmake b/cmake/FindLibunwind.cmake
> >  --- a/cmake/FindLibunwind.cmake1970-01-01 01:00:00.0
> +0100
> > -+++ b/cmake/FindLibunwind.cmake2018-11-02 14:04:35.460437058
> +0100
> > -@@ -0,0 +1,37 @@
> >  b/cmake/FindLibunwind.cmake2018-11-19 16:07:17.652031645
> +0100
> > +@@ -0,0 +1,54 @@
> >  +# - Try to find libunwind
> >  +# Once done this will define
> >  +#
> > -+#  LIBUNWIND_FOUND - system has libunwind
> > ++#  Libunwind_FOUND - system has libunwind
> >  +#  unwind - cmake target for libunwind
> >  +
> >  +find_library (UNWIND_LIBRARY NAMES unwind DOC "unwind library")
> > @@ -15,11 +15,24 @@ diff -uNr a/cmake/FindLibunwind.cmake
> b/cmake/FindLibunwind.cmake
> >  +
> >  +if (CMAKE_SYSTEM_PROCESSOR MATCHES "^arm")
> >  +set(LIBUNWIND_ARCH "arm")
> > ++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^aarch64")
> > ++set(LIBUNWIND_ARCH "aarch64")
> >  +elseif (CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64" OR
> > -+CMAKE_SYSTEM_PROCESSOR STREQUAL "amd64")
> > ++CMAKE_SYSTEM_PROCESSOR STREQUAL "amd64" OR
> > ++CMAKE_SYSTEM_PROCESSOR STREQUAL "corei7-64")
> >  +set(LIBUNWIND_ARCH "x86_64")
> >  +elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^i.86$")
> >  +set(LIBUNWIND_ARCH "x86")
> > ++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^ppc64")
> > ++set(LIBUNWIND_ARCH "ppc64")
> > ++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^ppc")
> > ++set(LIBUNWIND_ARCH "ppc32")
> > ++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^mips")
> > ++set(LIBUNWIND_ARCH "mips")
> > ++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^hppa")
> > ++set(LIBUNWIND_ARCH "hppa")
> > ++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^ia64")
> > ++set(LIBUNWIND_ARCH "ia64")
> >  +endif()
> >  +
> >  +find_library (UNWIND_LIBRARY_PLATFORM NAMES "unwind-${LIBUNWIND_ARCH}"
> DOC "unwind library platform")
> > @@ -35,13 +48,17 @@ diff -uNr a/cmake/FindLibunwind.cmake
> b/cmake/FindLibunwind.cmake
> >  +
> >  +mark_as_advanced (UNWIND_LIBRARY UNWIND_LIBRARY_PLATFORM)
> >  +
> > ++if (NOT Libunwind_FOUND)
> > ++message(FATAL_ERROR "Can't find libunwind library")
> > ++endif()
> > ++
> >  +add_library(unwind INTERFACE IMPORTED)
> >  +set_target_properties(unwind PROPERTIES
> >  +INTERF

[oe] [meta-oe][PATCH] glog: fixed the build for mips and other platforms

2018-11-19 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

According to build log http://errors.yoctoproject.org/Errors/Details/201286/
FindLibunwind wokred only for x86, arm, and x86_64. This patch extends the
cmake module to work with mips, ia64, ppc(64) and other architectures supported
by libunwind

Signed-off-by: Vyacheslav Yurkov 
---
 ...0002-Find-Libunwind-during-configure.patch | 34 ++-
 1 file changed, 25 insertions(+), 9 deletions(-)

diff --git 
a/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch 
b/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
index 3a6f824ea..4ad302cbe 100644
--- 
a/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
+++ 
b/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
@@ -1,11 +1,11 @@
 diff -uNr a/cmake/FindLibunwind.cmake b/cmake/FindLibunwind.cmake
 --- a/cmake/FindLibunwind.cmake1970-01-01 01:00:00.0 +0100
-+++ b/cmake/FindLibunwind.cmake2018-11-02 14:04:35.460437058 +0100
-@@ -0,0 +1,37 @@
 b/cmake/FindLibunwind.cmake2018-11-19 16:07:17.652031645 +0100
+@@ -0,0 +1,54 @@
 +# - Try to find libunwind
 +# Once done this will define
 +#
-+#  LIBUNWIND_FOUND - system has libunwind
++#  Libunwind_FOUND - system has libunwind
 +#  unwind - cmake target for libunwind
 +
 +find_library (UNWIND_LIBRARY NAMES unwind DOC "unwind library")
@@ -15,11 +15,24 @@ diff -uNr a/cmake/FindLibunwind.cmake 
b/cmake/FindLibunwind.cmake
 +
 +if (CMAKE_SYSTEM_PROCESSOR MATCHES "^arm")
 +set(LIBUNWIND_ARCH "arm")
++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^aarch64")
++set(LIBUNWIND_ARCH "aarch64")
 +elseif (CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64" OR
-+CMAKE_SYSTEM_PROCESSOR STREQUAL "amd64")
++CMAKE_SYSTEM_PROCESSOR STREQUAL "amd64" OR
++CMAKE_SYSTEM_PROCESSOR STREQUAL "corei7-64")
 +set(LIBUNWIND_ARCH "x86_64")
 +elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^i.86$")
 +set(LIBUNWIND_ARCH "x86")
++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^ppc64")
++set(LIBUNWIND_ARCH "ppc64")
++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^ppc")
++set(LIBUNWIND_ARCH "ppc32")
++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^mips")
++set(LIBUNWIND_ARCH "mips")
++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^hppa")
++set(LIBUNWIND_ARCH "hppa")
++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^ia64")
++set(LIBUNWIND_ARCH "ia64")
 +endif()
 +
 +find_library (UNWIND_LIBRARY_PLATFORM NAMES "unwind-${LIBUNWIND_ARCH}" DOC 
"unwind library platform")
@@ -35,13 +48,17 @@ diff -uNr a/cmake/FindLibunwind.cmake 
b/cmake/FindLibunwind.cmake
 +
 +mark_as_advanced (UNWIND_LIBRARY UNWIND_LIBRARY_PLATFORM)
 +
++if (NOT Libunwind_FOUND)
++message(FATAL_ERROR "Can't find libunwind library")
++endif()
++
 +add_library(unwind INTERFACE IMPORTED)
 +set_target_properties(unwind PROPERTIES
 +INTERFACE_LINK_LIBRARIES "${UNWIND_LIBRARY};${UNWIND_LIBRARY_PLATFORM}"
 +)
 diff -uNr a/CMakeLists.txt b/CMakeLists.txt
 a/CMakeLists.txt   2018-11-02 14:02:21.784835854 +0100
-+++ b/CMakeLists.txt   2018-11-02 14:03:16.796935594 +0100
+--- a/CMakeLists.txt   2018-11-19 15:55:05.293665965 +0100
 b/CMakeLists.txt   2018-11-19 15:57:37.828381535 +0100
 @@ -58,7 +58,6 @@
  check_include_file (execinfo.h HAVE_EXECINFO_H)
  check_include_file (glob.h HAVE_GLOB_H)
@@ -91,10 +108,9 @@ diff -uNr a/CMakeLists.txt b/CMakeLists.txt
DESTINATION lib/cmake/glog)
  
  install (EXPORT glog-targets NAMESPACE glog:: DESTINATION lib/cmake/glog)
-Binary files a/.git/index and b/.git/index differ
 diff -uNr a/glog-config.cmake.in b/glog-config.cmake.in
 a/glog-config.cmake.in 2018-11-02 14:02:21.784835854 +0100
-+++ b/glog-config.cmake.in 2018-11-02 14:03:16.796935594 +0100
+--- a/glog-config.cmake.in 2018-11-19 15:55:05.293665965 +0100
 b/glog-config.cmake.in 2018-11-19 15:57:37.828381535 +0100
 @@ -4,4 +4,15 @@
  
  @gflags_DEPENDENCY@
-- 
2.19.1

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [meta-oe][PATCH v2] glog: updated libunwind look up function

2018-11-18 Thread Vyacheslav Yurkov
Hi Khem,
I see where it fails. Looking into it.

Vyacheslav

On Sat, Nov 17, 2018 at 9:55 PM Khem Raj  wrote:

> Hi Vyacheslav
>
> This is causing a regression building cesres-solver
> see
> http://errors.yoctoproject.org/Errors/Details/201286/
>
> Please look into it as soon as you can. I am inclined to
> revert this patch otherwise.
>
> On Sun, Nov 4, 2018 at 11:20 PM Vyacheslav Yurkov 
> wrote:
> >
> > From: Vyacheslav Yurkov 
> >
> > Updated FindLinunwind cmake file to locate libunwind properly in the
> system.
> > This includes settings all needed defines in config.h file, which are
> used
> > for glog compilation. Changed unwind cmake target to interface, because
> in
> > cross-compilation environment we could link against several libunwind
> shared
> > libraries.
> >
> > Signed-off-by: Vyacheslav Yurkov 
> > ---
> >  ...0001-find-libunwind-during-configure.patch |  30 -
> >  ...0002-Find-Libunwind-during-configure.patch | 113 ++
> >  meta-oe/recipes-support/glog/glog_0.3.5.bb|   6 +-
> >  3 files changed, 115 insertions(+), 34 deletions(-)
> >  delete mode 100644
> meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch
> >  create mode 100644
> meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
> >
> > diff --git
> a/meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch
> b/meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch
> > deleted file mode 100644
> > index 33dc9d38a..0
> > ---
> a/meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch
> > +++ /dev/null
> > @@ -1,30 +0,0 @@
> > -diff -ur git/CMakeLists.txt ../0.3.5-r0.unwind/git/CMakeLists.txt
> >  git/CMakeLists.txt 2018-10-08 08:54:15.118989400 +0200
> > -+++ ../0.3.5-r0.unwind/git/CMakeLists.txt  2018-10-05
> 16:26:59.745922318 +0200
> > -@@ -384,7 +384,9 @@
> > - set_target_properties (glog PROPERTIES POSITION_INDEPENDENT_CODE ON)
> > -
> > - if (UNWIND_LIBRARY)
> > --  target_link_libraries (glog PUBLIC ${UNWIND_LIBRARY})
> > -+  add_library(unwind SHARED IMPORTED)
> > -+  set_target_properties(unwind PROPERTIES IMPORTED_LOCATION
> ${UNWIND_LIBRARY})
> > -+  target_link_libraries (glog PUBLIC unwind)
> > - endif (UNWIND_LIBRARY)
> > -
> > - if (HAVE_PTHREAD)
> > -diff -ur git/glog-config.cmake.in ../0.3.5-r0.unwind/git/
> glog-config.cmake.in
> >  git/glog-config.cmake.in   2018-10-08 08:54:15.122989699 +0200
> > -+++ ../0.3.5-r0.unwind/git/glog-config.cmake.in2018-10-08
> 08:14:48.550745810 +0200
> > -@@ -4,4 +4,12 @@
> > -
> > - @gflags_DEPENDENCY@
> > -
> > -+find_library (UNWIND_LIBRARY NAMES unwind DOC "unwind library")
> > -+mark_as_advanced (UNWIND_LIBRARY)
> > -+
> > -+if (UNWIND_LIBRARY)
> > -+  add_library(unwind SHARED IMPORTED)
> > -+  set_target_properties(unwind PROPERTIES IMPORTED_LOCATION
> ${UNWIND_LIBRARY})
> > -+endif (UNWIND_LIBRARY)
> > -+
> > - include ("${CMAKE_CURRENT_LIST_DIR}/glog-targets.cmake")
> > diff --git
> a/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
> b/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
> > new file mode 100644
> > index 0..3a6f824ea
> > --- /dev/null
> > +++
> b/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
> > @@ -0,0 +1,113 @@
> > +diff -uNr a/cmake/FindLibunwind.cmake b/cmake/FindLibunwind.cmake
> > +--- a/cmake/FindLibunwind.cmake1970-01-01 01:00:00.0
> +0100
> >  b/cmake/FindLibunwind.cmake2018-11-02 14:04:35.460437058
> +0100
> > +@@ -0,0 +1,37 @@
> > ++# - Try to find libunwind
> > ++# Once done this will define
> > ++#
> > ++#  LIBUNWIND_FOUND - system has libunwind
> > ++#  unwind - cmake target for libunwind
> > ++
> > ++find_library (UNWIND_LIBRARY NAMES unwind DOC "unwind library")
> > ++include (CheckIncludeFile)
> > ++check_include_file (libunwind.h HAVE_LIBUNWIND_H)
> > ++check_include_file (unwind.h HAVE_UNWIND_H)
> > ++
> > ++if (CMAKE_SYSTEM_PROCESSOR MATCHES "^arm")
> > ++set(LIBUNWIND_ARCH "arm")
> > ++elseif (CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64" OR
> > ++CMAKE_SYSTEM_PROCESSOR STREQUAL "amd64")
> > ++set(LIBUNWIND_ARCH "x86_64")
> > ++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^i.86$")
> > ++se

[oe] [meta-oe][PATCH v2] glog: updated libunwind look up function

2018-11-04 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

Updated FindLinunwind cmake file to locate libunwind properly in the system.
This includes settings all needed defines in config.h file, which are used
for glog compilation. Changed unwind cmake target to interface, because in
cross-compilation environment we could link against several libunwind shared
libraries.

Signed-off-by: Vyacheslav Yurkov 
---
 ...0001-find-libunwind-during-configure.patch |  30 -
 ...0002-Find-Libunwind-during-configure.patch | 113 ++
 meta-oe/recipes-support/glog/glog_0.3.5.bb|   6 +-
 3 files changed, 115 insertions(+), 34 deletions(-)
 delete mode 100644 
meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch
 create mode 100644 
meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch

diff --git 
a/meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch 
b/meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch
deleted file mode 100644
index 33dc9d38a..0
--- 
a/meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch
+++ /dev/null
@@ -1,30 +0,0 @@
-diff -ur git/CMakeLists.txt ../0.3.5-r0.unwind/git/CMakeLists.txt
 git/CMakeLists.txt 2018-10-08 08:54:15.118989400 +0200
-+++ ../0.3.5-r0.unwind/git/CMakeLists.txt  2018-10-05 16:26:59.745922318 
+0200
-@@ -384,7 +384,9 @@
- set_target_properties (glog PROPERTIES POSITION_INDEPENDENT_CODE ON)
- 
- if (UNWIND_LIBRARY)
--  target_link_libraries (glog PUBLIC ${UNWIND_LIBRARY})
-+  add_library(unwind SHARED IMPORTED)
-+  set_target_properties(unwind PROPERTIES IMPORTED_LOCATION ${UNWIND_LIBRARY})
-+  target_link_libraries (glog PUBLIC unwind)
- endif (UNWIND_LIBRARY)
- 
- if (HAVE_PTHREAD)
-diff -ur git/glog-config.cmake.in ../0.3.5-r0.unwind/git/glog-config.cmake.in
 git/glog-config.cmake.in   2018-10-08 08:54:15.122989699 +0200
-+++ ../0.3.5-r0.unwind/git/glog-config.cmake.in2018-10-08 
08:14:48.550745810 +0200
-@@ -4,4 +4,12 @@
- 
- @gflags_DEPENDENCY@
- 
-+find_library (UNWIND_LIBRARY NAMES unwind DOC "unwind library")
-+mark_as_advanced (UNWIND_LIBRARY)
-+
-+if (UNWIND_LIBRARY)
-+  add_library(unwind SHARED IMPORTED)
-+  set_target_properties(unwind PROPERTIES IMPORTED_LOCATION ${UNWIND_LIBRARY})
-+endif (UNWIND_LIBRARY)
-+
- include ("${CMAKE_CURRENT_LIST_DIR}/glog-targets.cmake")
diff --git 
a/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch 
b/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
new file mode 100644
index 0..3a6f824ea
--- /dev/null
+++ 
b/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
@@ -0,0 +1,113 @@
+diff -uNr a/cmake/FindLibunwind.cmake b/cmake/FindLibunwind.cmake
+--- a/cmake/FindLibunwind.cmake1970-01-01 01:00:00.0 +0100
 b/cmake/FindLibunwind.cmake2018-11-02 14:04:35.460437058 +0100
+@@ -0,0 +1,37 @@
++# - Try to find libunwind
++# Once done this will define
++#
++#  LIBUNWIND_FOUND - system has libunwind
++#  unwind - cmake target for libunwind
++
++find_library (UNWIND_LIBRARY NAMES unwind DOC "unwind library")
++include (CheckIncludeFile)
++check_include_file (libunwind.h HAVE_LIBUNWIND_H)
++check_include_file (unwind.h HAVE_UNWIND_H)
++
++if (CMAKE_SYSTEM_PROCESSOR MATCHES "^arm")
++set(LIBUNWIND_ARCH "arm")
++elseif (CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64" OR
++CMAKE_SYSTEM_PROCESSOR STREQUAL "amd64")
++set(LIBUNWIND_ARCH "x86_64")
++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^i.86$")
++set(LIBUNWIND_ARCH "x86")
++endif()
++
++find_library (UNWIND_LIBRARY_PLATFORM NAMES "unwind-${LIBUNWIND_ARCH}" DOC 
"unwind library platform")
++if (UNWIND_LIBRARY_PLATFORM)
++set(HAVE_LIB_UNWIND "1")
++endif()
++
++include(FindPackageHandleStandardArgs)
++# handle the QUIETLY and REQUIRED arguments and set Libunwind_FOUND to TRUE
++# if all listed variables are TRUE
++find_package_handle_standard_args(Libunwind DEFAULT_MSG
++UNWIND_LIBRARY HAVE_LIBUNWIND_H HAVE_UNWIND_H HAVE_LIB_UNWIND)
++
++mark_as_advanced (UNWIND_LIBRARY UNWIND_LIBRARY_PLATFORM)
++
++add_library(unwind INTERFACE IMPORTED)
++set_target_properties(unwind PROPERTIES
++INTERFACE_LINK_LIBRARIES "${UNWIND_LIBRARY};${UNWIND_LIBRARY_PLATFORM}"
++)
+diff -uNr a/CMakeLists.txt b/CMakeLists.txt
+--- a/CMakeLists.txt   2018-11-02 14:02:21.784835854 +0100
 b/CMakeLists.txt   2018-11-02 14:03:16.796935594 +0100
+@@ -58,7 +58,6 @@
+ check_include_file (execinfo.h HAVE_EXECINFO_H)
+ check_include_file (glob.h HAVE_GLOB_H)
+ check_include_file (inttypes.h HAVE_INTTYPES_H)
+-check_include_file (libunwind.h HAVE_LIBUNWIND_H)
+ check_include_file (memory.h HAVE_MEMORY_H)
+ check_include_file (pwd.h HAVE_PWD_H)
+ check_include_file (stdint.h HAVE_STDINT_H)
+@@ -74,7 +73,6 @@
+ check_include_file (

[oe] [meta-oe][PATCH] glog: updated libunwind look up function

2018-11-02 Thread Vyacheslav Yurkov
From: Vyacheslav Yurkov 

Updated FindLinunwind cmake file to locate libunwind properly in the system.
This includes settings all needed defines in config.h file, which are used
for glog compilation. Changed unwind cmake target to interface, because in
cross-compilation environment we could link against several libunwind shared
libraries.

Signed-off-by: Vyacheslav Yurkov 
---
 ...0001-find-libunwind-during-configure.patch |  30 -
 ...0002-Find-Libunwind-during-configure.patch | 113 ++
 meta-oe/recipes-support/glog/glog_0.3.5.bb|   6 +-
 3 files changed, 115 insertions(+), 34 deletions(-)
 delete mode 100644 
meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch
 create mode 100644 
meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch

diff --git 
a/meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch 
b/meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch
deleted file mode 100644
index 33dc9d38a..0
--- 
a/meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch
+++ /dev/null
@@ -1,30 +0,0 @@
-diff -ur git/CMakeLists.txt ../0.3.5-r0.unwind/git/CMakeLists.txt
 git/CMakeLists.txt 2018-10-08 08:54:15.118989400 +0200
-+++ ../0.3.5-r0.unwind/git/CMakeLists.txt  2018-10-05 16:26:59.745922318 
+0200
-@@ -384,7 +384,9 @@
- set_target_properties (glog PROPERTIES POSITION_INDEPENDENT_CODE ON)
- 
- if (UNWIND_LIBRARY)
--  target_link_libraries (glog PUBLIC ${UNWIND_LIBRARY})
-+  add_library(unwind SHARED IMPORTED)
-+  set_target_properties(unwind PROPERTIES IMPORTED_LOCATION ${UNWIND_LIBRARY})
-+  target_link_libraries (glog PUBLIC unwind)
- endif (UNWIND_LIBRARY)
- 
- if (HAVE_PTHREAD)
-diff -ur git/glog-config.cmake.in ../0.3.5-r0.unwind/git/glog-config.cmake.in
 git/glog-config.cmake.in   2018-10-08 08:54:15.122989699 +0200
-+++ ../0.3.5-r0.unwind/git/glog-config.cmake.in2018-10-08 
08:14:48.550745810 +0200
-@@ -4,4 +4,12 @@
- 
- @gflags_DEPENDENCY@
- 
-+find_library (UNWIND_LIBRARY NAMES unwind DOC "unwind library")
-+mark_as_advanced (UNWIND_LIBRARY)
-+
-+if (UNWIND_LIBRARY)
-+  add_library(unwind SHARED IMPORTED)
-+  set_target_properties(unwind PROPERTIES IMPORTED_LOCATION ${UNWIND_LIBRARY})
-+endif (UNWIND_LIBRARY)
-+
- include ("${CMAKE_CURRENT_LIST_DIR}/glog-targets.cmake")
diff --git 
a/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch 
b/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
new file mode 100644
index 0..24c53707d
--- /dev/null
+++ 
b/meta-oe/recipes-support/glog/glog/0002-Find-Libunwind-during-configure.patch
@@ -0,0 +1,113 @@
+diff -uNr a/cmake/FindLibunwind.cmake b/cmake/FindLibunwind.cmake
+--- a/cmake/FindLibunwind.cmake1970-01-01 01:00:00.0 +0100
 b/cmake/FindLibunwind.cmake2018-11-02 14:04:35.460437058 +0100
+@@ -0,0 +1,37 @@
++# - Try to find libunwind
++# Once done this will define
++#
++#  LIBUNWIND_FOUND - system has libunwind
++#  unwind - cmake target for libunwind
++
++find_library (UNWIND_LIBRARY NAMES unwind DOC "unwind library")
++include (CheckIncludeFile)
++check_include_file (libunwind.h HAVE_LIBUNWIND_H)
++check_include_file (unwind.h HAVE_UNWIND_H)
++
++if (CMAKE_SYSTEM_PROCESSOR MATCHES "^arm")
++set(LIBUNWIND_ARCH "arm")
++elseif (CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64" OR
++CMAKE_SYSTEM_PROCESSOR STREQUAL "amd64" OR
++set(LIBUNWIND_ARCH "x86_64")
++elseif (CMAKE_SYSTEM_PROCESSOR MATCHES "^i.86$")
++set(LIBUNWIND_ARCH "x86")
++endif()
++
++find_library (UNWIND_LIBRARY_PLATFORM NAMES "unwind-${LIBUNWIND_ARCH}" DOC 
"unwind library platform")
++if (UNWIND_LIBRARY_PLATFORM)
++set(HAVE_LIB_UNWIND "1")
++endif()
++
++include(FindPackageHandleStandardArgs)
++# handle the QUIETLY and REQUIRED arguments and set Libunwind_FOUND to TRUE
++# if all listed variables are TRUE
++find_package_handle_standard_args(Libunwind DEFAULT_MSG
++UNWIND_LIBRARY HAVE_LIBUNWIND_H HAVE_UNWIND_H HAVE_LIB_UNWIND)
++
++mark_as_advanced (UNWIND_LIBRARY UNWIND_LIBRARY_PLATFORM)
++
++add_library(unwind INTERFACE IMPORTED)
++set_target_properties(unwind PROPERTIES
++INTERFACE_LINK_LIBRARIES "${UNWIND_LIBRARY};${UNWIND_LIBRARY_PLATFORM}"
++)
+diff -uNr a/CMakeLists.txt b/CMakeLists.txt
+--- a/CMakeLists.txt   2018-11-02 14:02:21.784835854 +0100
 b/CMakeLists.txt   2018-11-02 14:03:16.796935594 +0100
+@@ -58,7 +58,6 @@
+ check_include_file (execinfo.h HAVE_EXECINFO_H)
+ check_include_file (glob.h HAVE_GLOB_H)
+ check_include_file (inttypes.h HAVE_INTTYPES_H)
+-check_include_file (libunwind.h HAVE_LIBUNWIND_H)
+ check_include_file (memory.h HAVE_MEMORY_H)
+ check_include_file (pwd.h HAVE_PWD_H)
+ check_include_file (stdint.h HAVE_STDINT_H)
+@@ -74,7 +73,6 @@
+ check_include_file (

[oe] [meta-oe][PATCH] glog: fixed shared library versioning

2018-10-17 Thread Vyacheslav Yurkov
Build glog as a shared library by default. Backported CMake patch
from master that sets SONAME properly. Updated the patch for libunwind look up
and added libunwind as a run-time dependency

Signed-off-by: Vyacheslav Yurkov 
---
 ...0001-find-libunwind-during-configure.patch | 80 +
 .../glog/0002-rework-cmake-glog-version.patch | 87 +++
 meta-oe/recipes-support/glog/glog_0.3.5.bb|  7 +-
 3 files changed, 153 insertions(+), 21 deletions(-)
 create mode 100644 
meta-oe/recipes-support/glog/glog/0002-rework-cmake-glog-version.patch

diff --git 
a/meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch 
b/meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch
index 33dc9d38a..6becdc15f 100644
--- 
a/meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch
+++ 
b/meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch
@@ -1,30 +1,74 @@
-diff -ur git/CMakeLists.txt ../0.3.5-r0.unwind/git/CMakeLists.txt
 git/CMakeLists.txt 2018-10-08 08:54:15.118989400 +0200
-+++ ../0.3.5-r0.unwind/git/CMakeLists.txt  2018-10-05 16:26:59.745922318 
+0200
-@@ -384,7 +384,9 @@
+diff -ur --new-file git/cmake/FindLibunwind.cmake 
../0.3.5-r0.unwind/git/cmake/FindLibunwind.cmake
+--- git/cmake/FindLibunwind.cmake  1970-01-01 01:00:00.0 +0100
 ../0.3.5-r0.unwind/git/cmake/FindLibunwind.cmake   2018-10-09 
09:43:59.803216273 +0200
+@@ -0,0 +1,17 @@
++# - Try to find libunwind
++# Once done this will define
++#
++#  LIBUNWIND_FOUND - system has libunwind
++#  unwind - cmake target for libunwind
++
++find_library (UNWIND_LIBRARY NAMES unwind DOC "unwind library")
++
++include(FindPackageHandleStandardArgs)
++# handle the QUIETLY and REQUIRED arguments and set Libunwind_FOUND to TRUE
++# if all listed variables are TRUE
++find_package_handle_standard_args(Libunwind DEFAULT_MSG UNWIND_LIBRARY)
++
++mark_as_advanced (UNWIND_LIBRARY)
++
++add_library(unwind SHARED IMPORTED)
++set_target_properties(unwind PROPERTIES IMPORTED_LOCATION ${UNWIND_LIBRARY})
+diff -ur --new-file git/CMakeLists.txt ../0.3.5-r0.unwind/git/CMakeLists.txt
+--- git/CMakeLists.txt 2018-10-09 10:31:33.483584675 +0200
 ../0.3.5-r0.unwind/git/CMakeLists.txt  2018-10-09 09:43:59.799215966 
+0200
+@@ -118,8 +118,7 @@
+ 
+ check_library_exists (unwind get_static_proc_name "" HAVE_LIB_UNWIND)
+ 
+-find_library (UNWIND_LIBRARY NAMES unwind DOC "unwind library")
+-mark_as_advanced (UNWIND_LIBRARY)
++find_package(Libunwind)
+ 
+ check_c_source_compiles ("
+ #include 
+@@ -383,9 +382,9 @@
+ 
  set_target_properties (glog PROPERTIES POSITION_INDEPENDENT_CODE ON)
  
- if (UNWIND_LIBRARY)
+-if (UNWIND_LIBRARY)
 -  target_link_libraries (glog PUBLIC ${UNWIND_LIBRARY})
-+  add_library(unwind SHARED IMPORTED)
-+  set_target_properties(unwind PROPERTIES IMPORTED_LOCATION ${UNWIND_LIBRARY})
+-endif (UNWIND_LIBRARY)
++if (Libunwind_FOUND)
 +  target_link_libraries (glog PUBLIC unwind)
- endif (UNWIND_LIBRARY)
++endif (Libunwind_FOUND)
  
  if (HAVE_PTHREAD)
-diff -ur git/glog-config.cmake.in ../0.3.5-r0.unwind/git/glog-config.cmake.in
 git/glog-config.cmake.in   2018-10-08 08:54:15.122989699 +0200
-+++ ../0.3.5-r0.unwind/git/glog-config.cmake.in2018-10-08 
08:14:48.550745810 +0200
-@@ -4,4 +4,12 @@
+   target_link_libraries (glog PUBLIC ${CMAKE_THREAD_LIBS_INIT})
+@@ -578,6 +577,7 @@
+ install (FILES
+   ${CMAKE_CURRENT_BINARY_DIR}/glog-config.cmake
+   ${CMAKE_CURRENT_BINARY_DIR}/glog-config-version.cmake
++  ${CMAKE_CURRENT_SOURCE_DIR}/cmake/FindLibunwind.cmake
+   DESTINATION lib/cmake/glog)
+ 
+ install (EXPORT glog-targets NAMESPACE glog:: DESTINATION lib/cmake/glog)
+diff -ur --new-file git/glog-config.cmake.in 
../0.3.5-r0.unwind/git/glog-config.cmake.in
+--- git/glog-config.cmake.in   2018-10-09 10:31:33.487584975 +0200
 ../0.3.5-r0.unwind/git/glog-config.cmake.in2018-10-09 
09:43:59.799215966 +0200
+@@ -4,4 +4,15 @@
  
  @gflags_DEPENDENCY@
  
-+find_library (UNWIND_LIBRARY NAMES unwind DOC "unwind library")
-+mark_as_advanced (UNWIND_LIBRARY)
++# Record the state of the CMake module path when this script was
++# called so that we can ensure that we leave it in the same state on
++# exit as it was on entry, but modify it locally.
++set(UNWIND_CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH})
++
++set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}")
++find_dependency (Libunwind)
 +
-+if (UNWIND_LIBRARY)
-+  add_library(unwind SHARED IMPORTED)
-+  set_target_properties(unwind PROPERTIES IMPORTED_LOCATION ${UNWIND_LIBRARY})
-+endif (UNWIND_LIBRARY)
++# Restore original module path
++set(CMAKE_MODULE_PATH "${UNWIND_CMAKE_MODULE_PATH}")
 +
  include ("${CMAKE_CURRENT_LIST_DIR}/glog-targets.cmake")
diff --git 
a/meta-oe/recipes-support/glog/glog/0002-rework-cmake-glog-version.patch 
b/meta-oe/recipes-support/glog/glog/0002-rework-cmake-glog-version.pat

Re: [oe] [meta-oe][PATCH] glog: upgrade 0.3.4 -> 0.3.5

2018-10-15 Thread Vyacheslav Yurkov
Hi Martin,
Thanks for the comment.

Thanks for comments. I will add this patch and I also what to append
RDEPENDS_${PN} += "libunwind".
I plan to send the updates this week.

Vyacheslav

On Mon, Oct 15, 2018 at 1:11 PM Martin Jansa  wrote:

> On Tue, Oct 09, 2018 at 11:52:36AM +0200, Vyacheslav Yurkov wrote:
> > Well, two obvious reasons:
> > - glog fixes between 0.3.4 and 0.3.5
> > - cmake support, which simplifies dependency handling when SDK generation
> > is involved (for example for libraries like ceres-solver)
> >
> > I need to update my patch for finding libunwind, so I will send another
> > version soon. The question I have now is that glog builds static library
> by
> > default. What is the policy in that regard? Should a shared library be
> > preferred by default?
>
> I know I'm a bit late, but I have some questions about shared library.
>
> The preferred default should IMHO be the same as with 0.3.4 version
> which was shared library, but that's easy to add with small bbappend
> having:
> EXTRA_OECMAKE += "-DBUILD_SHARED_LIBS=ON"
>
> but unfortunately the SONAME in the library changed from:
> objdump -x usr/lib/libglog.so.0.0.0 | grep SONAME
>   SONAME   libglog.so.0
> in 0.3.4 to:
> objdump -x usr/lib/libglog.so.0.3.5  | grep SONAME
>   SONAME   libglog.so.0.3.5
>
> Which breaks all our prebuilt binaries which now correctly complain that
> there isn't libglog.so.0 provider in dependencies:
> QA Issue: /usr/lib/libfoo.so.1.2.3 contained in package libfoo requires
> libglog.so.0, but no providers found in RDEPENDS_libfoo
>
> Which is quite unfortunate for minor upgrade. Did they really change the
> ABI (and expect to change it in all future minor upgrades) or is this
> change just unexpected side-effect of using cmake instead of autotools?
>
> It looks the later, because if I build 0.3.5 version with autotools I
> get:
> objdump -x usr/lib/libglog.so.0.0.0 | grep SONAME
>   SONAME   libglog.so.0
>
> and there is patch for SOVERSION here as well:
> https://github.com/google/or-tools/blob/master/patches/glog.patch
>
> applied in master:
> https://github.com/google/glog/blob/master/CMakeLists.txt#L493
>
> https://github.com/google/glog/commit/6b6e38a7d53fe01f42ce34384cf4ba4c50e8cb65#diff-af3b638bc2a3e6c650974192a53c7291
>
> patch coming with this change backported to make it possible again to
> use the shared library.
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [meta-oe][PATCH] catch2: new package

2018-10-11 Thread Vyacheslav Yurkov
You should use it instead
ALLOW_EMPTY_${PN} = "1"

The header-only package is required during the build (for dependent
recipes) and for SDK, this is where -dev package would be used. But if you
create main empty package, it would be installed in the image, which is
basically useless.

Vyacheslav

On Thu, Oct 11, 2018 at 3:02 PM Bartosz Golaszewski  wrote:

> czw., 11 paź 2018 o 11:35 Vyacheslav Yurkov 
> napisał(a):
> >
> > Hi Bartosz,
> > As I learned quite recently, you have to do the following for
> header-only libraries:
> > RDEPENDS_${PN}-dev = ""
> > RRECOMMENDS_${PN}-dbg = "${PN}-dev (= ${EXTENDPKGV})"
> >
>
> Any hint on what it does exactly and why it's needed?
>
> Bart
>
> > Regards,
> > Vyacheslav
> >
> > On Thu, Oct 11, 2018 at 11:08 AM Bartosz Golaszewski 
> wrote:
> >>
> >> From: Bartosz Golaszewski 
> >>
> >> Add a recipe for the catch2 testing framework. There's a bug upstream
> >> which makes it impossible to build with gcc7 so include a patch.
> >>
> >> Signed-off-by: Bartosz Golaszewski 
> >> ---
> >>  .../0001-internal-fix-build-in-GCC-7.patch| 35 +++
> >>  meta-oe/recipes-test/catch2/catch2_2.4.1.bb   | 25 +
> >>  2 files changed, 60 insertions(+)
> >>  create mode 100644
> meta-oe/recipes-test/catch2/catch2/0001-internal-fix-build-in-GCC-7.patch
> >>  create mode 100644 meta-oe/recipes-test/catch2/catch2_2.4.1.bb
> >>
> >> diff --git
> a/meta-oe/recipes-test/catch2/catch2/0001-internal-fix-build-in-GCC-7.patch
> b/meta-oe/recipes-test/catch2/catch2/0001-internal-fix-build-in-GCC-7.patch
> >> new file mode 100644
> >> index 0..606398afa
> >> --- /dev/null
> >> +++
> b/meta-oe/recipes-test/catch2/catch2/0001-internal-fix-build-in-GCC-7.patch
> >> @@ -0,0 +1,35 @@
> >> +From 857bf7e83db330682a4c722d0b57be1e4481f4e2 Mon Sep 17 00:00:00 2001
> >> +From: Bartosz Golaszewski 
> >> +Date: Thu, 11 Oct 2018 09:44:24 +0200
> >> +Subject: [PATCH] internal: fix build in GCC 7
> >> +
> >> +The following error is emitted by gcc 7:
> >> +
> >> +include/internal/catch_tostring.cpp:217:21: error: comparison is
> always true due to limited range of data type [-Werror=type-limits]
> >> +|  } else if ('\0' <= value && value < ' ') {
> >> +| ~^~~~
> >> +| cc1plus: all warnings being treated as errors
> >> +
> >> +We can drop the first part of the if.
> >> +
> >> +Signed-off-by: Bartosz Golaszewski 
> >> +---
> >> + include/internal/catch_tostring.cpp | 2 +-
> >> + 1 file changed, 1 insertion(+), 1 deletion(-)
> >> +
> >> +diff --git a/include/internal/catch_tostring.cpp
> b/include/internal/catch_tostring.cpp
> >> +index 4e0c027d..59cc8dec 100644
> >> +--- a/include/internal/catch_tostring.cpp
> >>  b/include/internal/catch_tostring.cpp
> >> +@@ -214,7 +214,7 @@ std::string StringMaker::convert(char value)
> {
> >> + return "'\\n'";
> >> + } else if (value == '\t') {
> >> + return "'\\t'";
> >> +-} else if ('\0' <= value && value < ' ') {
> >> ++} else if (value < ' ') {
> >> + return ::Catch::Detail::stringify(static_cast int>(value));
> >> + } else {
> >> + char chstr[] = "' '";
> >> +--
> >> +2.19.1
> >> +
> >> diff --git a/meta-oe/recipes-test/catch2/catch2_2.4.1.bb
> b/meta-oe/recipes-test/catch2/catch2_2.4.1.bb
> >> new file mode 100644
> >> index 0..ba14a362c
> >> --- /dev/null
> >> +++ b/meta-oe/recipes-test/catch2/catch2_2.4.1.bb
> >> @@ -0,0 +1,25 @@
> >> +DESCRIPTION = "A modern, C++-native, header-only, test framework for
> unit-tests, \
> >> +TDD and BDD - using C++11, C++14, C++17 and later."
> >> +AUTHOR = "Phil Nash, Martin Horenovsky and others"
> >> +HOMEPAGE = "https://github.com/catchorg/Catch2;
> >> +LICENSE = "BSL-1.0"
> >> +LIC_FILES_CHKSUM =
> "file://LICENSE.txt;md5=e4224ccaecb14d942c71d31bef20d78c"
> >> +
> >> +SRC_URI = "git://github.com/catchorg/Catch2.git \
> >> +   file://0001-internal-fix-build-in-GCC-7.patch"
> >> +SRCREV = "9e1bdca4667295fcb16265eae00efa8423f07007"
> >> +
> >> +S = "${WORKDIR}/git"
> >> +
> >> +DEPENDS = "python-native"
> >> +
> >> +inherit cmake python3native
> >> +
> >> +# Header-only library
> >> +ALLOW_EMPTY_${PN} = "1"
> >> +
> >> +do_install_append() {
> >> +rm ${D}/usr/share/Catch2/lldbinit
> >> +rm ${D}/usr/share/Catch2/gdbinit
> >> +rmdir ${D}/usr/share/Catch2/
> >> +}
> >> --
> >> 2.19.1
> >>
> >> --
>
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [meta-oe][PATCH] catch2: new package

2018-10-11 Thread Vyacheslav Yurkov
Hi Bartosz,
As I learned quite recently, you have to do the following for header-only
libraries:
RDEPENDS_${PN}-dev = ""
RRECOMMENDS_${PN}-dbg = "${PN}-dev (= ${EXTENDPKGV})"

Regards,
Vyacheslav

On Thu, Oct 11, 2018 at 11:08 AM Bartosz Golaszewski  wrote:

> From: Bartosz Golaszewski 
>
> Add a recipe for the catch2 testing framework. There's a bug upstream
> which makes it impossible to build with gcc7 so include a patch.
>
> Signed-off-by: Bartosz Golaszewski 
> ---
>  .../0001-internal-fix-build-in-GCC-7.patch| 35 +++
>  meta-oe/recipes-test/catch2/catch2_2.4.1.bb   | 25 +
>  2 files changed, 60 insertions(+)
>  create mode 100644
> meta-oe/recipes-test/catch2/catch2/0001-internal-fix-build-in-GCC-7.patch
>  create mode 100644 meta-oe/recipes-test/catch2/catch2_2.4.1.bb
>
> diff --git
> a/meta-oe/recipes-test/catch2/catch2/0001-internal-fix-build-in-GCC-7.patch
> b/meta-oe/recipes-test/catch2/catch2/0001-internal-fix-build-in-GCC-7.patch
> new file mode 100644
> index 0..606398afa
> --- /dev/null
> +++
> b/meta-oe/recipes-test/catch2/catch2/0001-internal-fix-build-in-GCC-7.patch
> @@ -0,0 +1,35 @@
> +From 857bf7e83db330682a4c722d0b57be1e4481f4e2 Mon Sep 17 00:00:00 2001
> +From: Bartosz Golaszewski 
> +Date: Thu, 11 Oct 2018 09:44:24 +0200
> +Subject: [PATCH] internal: fix build in GCC 7
> +
> +The following error is emitted by gcc 7:
> +
> +include/internal/catch_tostring.cpp:217:21: error: comparison is always
> true due to limited range of data type [-Werror=type-limits]
> +|  } else if ('\0' <= value && value < ' ') {
> +| ~^~~~
> +| cc1plus: all warnings being treated as errors
> +
> +We can drop the first part of the if.
> +
> +Signed-off-by: Bartosz Golaszewski 
> +---
> + include/internal/catch_tostring.cpp | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/include/internal/catch_tostring.cpp
> b/include/internal/catch_tostring.cpp
> +index 4e0c027d..59cc8dec 100644
> +--- a/include/internal/catch_tostring.cpp
>  b/include/internal/catch_tostring.cpp
> +@@ -214,7 +214,7 @@ std::string StringMaker::convert(char value) {
> + return "'\\n'";
> + } else if (value == '\t') {
> + return "'\\t'";
> +-} else if ('\0' <= value && value < ' ') {
> ++} else if (value < ' ') {
> + return ::Catch::Detail::stringify(static_cast int>(value));
> + } else {
> + char chstr[] = "' '";
> +--
> +2.19.1
> +
> diff --git a/meta-oe/recipes-test/catch2/catch2_2.4.1.bb
> b/meta-oe/recipes-test/catch2/catch2_2.4.1.bb
> new file mode 100644
> index 0..ba14a362c
> --- /dev/null
> +++ b/meta-oe/recipes-test/catch2/catch2_2.4.1.bb
> @@ -0,0 +1,25 @@
> +DESCRIPTION = "A modern, C++-native, header-only, test framework for
> unit-tests, \
> +TDD and BDD - using C++11, C++14, C++17 and later."
> +AUTHOR = "Phil Nash, Martin Horenovsky and others"
> +HOMEPAGE = "https://github.com/catchorg/Catch2;
> +LICENSE = "BSL-1.0"
> +LIC_FILES_CHKSUM =
> "file://LICENSE.txt;md5=e4224ccaecb14d942c71d31bef20d78c"
> +
> +SRC_URI = "git://github.com/catchorg/Catch2.git \
> +   file://0001-internal-fix-build-in-GCC-7.patch"
> +SRCREV = "9e1bdca4667295fcb16265eae00efa8423f07007"
> +
> +S = "${WORKDIR}/git"
> +
> +DEPENDS = "python-native"
> +
> +inherit cmake python3native
> +
> +# Header-only library
> +ALLOW_EMPTY_${PN} = "1"
> +
> +do_install_append() {
> +rm ${D}/usr/share/Catch2/lldbinit
> +rm ${D}/usr/share/Catch2/gdbinit
> +rmdir ${D}/usr/share/Catch2/
> +}
> --
> 2.19.1
>
> --
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [meta-oe][PATCH] glog: upgrade 0.3.4 -> 0.3.5

2018-10-09 Thread Vyacheslav Yurkov
Well, two obvious reasons:
- glog fixes between 0.3.4 and 0.3.5
- cmake support, which simplifies dependency handling when SDK generation
is involved (for example for libraries like ceres-solver)

I need to update my patch for finding libunwind, so I will send another
version soon. The question I have now is that glog builds static library by
default. What is the policy in that regard? Should a shared library be
preferred by default?

Vyacheslav

On Mon, Oct 8, 2018 at 3:42 PM Khem Raj  wrote:

> On Mon, Oct 8, 2018 at 2:18 AM Vyacheslav Yurkov 
> wrote:
> >
> > Upgraded glog recipe to a new stable version in favor of cmake
> configuration
> > Old configure.ac patch is removed.
> >
> > Another cmake patch is added. When UNWIND_LIBRARY is used directly as a
> public
> > dependency then absolute path is stored in cmake config file.
> > This is an issue when glog is used as part of generated SDK, which was
> built
> > on another machine. When SDK is installed on developer's machine,
> > cmake config contains a full path to non-existent location.
> > The solution is to find libunwind during configure stage and store target
> > name as a dependency, not a full path
> >
> > Signed-off-by: Vyacheslav Yurkov 
> > ---
> >  ...gure.ac-Allow-user-to-disable-gflags.patch | 35 ---
> >  ...0001-find-libunwind-during-configure.patch | 30 
> >  .../glog/{glog_0.3.4.bb => glog_0.3.5.bb} | 13 +++
> >  3 files changed, 37 insertions(+), 41 deletions(-)
> >  delete mode 100644
> meta-oe/recipes-support/glog/glog/0001-configure.ac-Allow-user-to-disable-gflags.patch
> >  create mode 100644
> meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch
> >  rename meta-oe/recipes-support/glog/{glog_0.3.4.bb => glog_0.3.5.bb}
> (55%)
> >
> > diff --git
> a/meta-oe/recipes-support/glog/glog/0001-configure.ac-Allow-user-to-disable-gflags.patch
> b/meta-oe/recipes-support/glog/glog/0001-configure.ac-Allow-user-to-disable-gflags.patch
> > deleted file mode 100644
> > index 596281ff6..0
> > ---
> a/meta-oe/recipes-support/glog/glog/0001-configure.ac-Allow-user-to-disable-gflags.patch
> > +++ /dev/null
> > @@ -1,35 +0,0 @@
> > -From 0fabde0515e180c53961c27346dd7a79cffa4c1f Mon Sep 17 00:00:00 2001
> > -From: Ricardo Ribalda Delgado 
> > -Date: Thu, 11 Aug 2016 11:49:36 +0200
> > -Subject: [PATCH] configure.ac: Allow user to disable gflags
> > -
> > -Under some circumstances like cross-compilation, the user might not want
> > -to enable support for gflags.
> > -
> > -This patch allows support for --without-gflags
> > -
> > -Signed-off-by: Ricardo Ribalda Delgado 
> > 
> > - configure.ac | 6 +-
> > - 1 file changed, 5 insertions(+), 1 deletion(-)
> > -
> > -diff --git a/configure.ac b/configure.ac
> > -index 7b4d21e7ae8a..eba5e5cda1ea 100644
> >  a/configure.ac
> > -+++ b/configure.ac
> > -@@ -136,7 +136,11 @@ AC_ARG_WITH(gflags,
> AS_HELP_STRING[--with-gflags=GFLAGS_DIR],
> > -   CFLAGS="$CFLAGS $GFLAGS_CFLAGS"
> > -   LIBS="$LIBS $GFLAGS_LIBS"
> > - )
> > --AC_CHECK_LIB(gflags, main, ac_cv_have_libgflags=1,
> ac_cv_have_libgflags=0)
> > -+if test x"$with_gflags" = x"no"; then
> > -+  ac_cv_have_libgflags=0
> > -+else
> > -+  AC_CHECK_LIB(gflags, main, ac_cv_have_libgflags=1,
> ac_cv_have_libgflags=0)
> > -+fi
> > - if test x"$ac_cv_have_libgflags" = x"1"; then
> > -   AC_DEFINE(HAVE_LIB_GFLAGS, 1, [define if you have google gflags
> library])
> > -   if test x"$GFLAGS_LIBS" = x""; then
> > ---
> > -2.8.1
> > -
> > diff --git
> a/meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch
> b/meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch
> > new file mode 100644
> > index 0..33dc9d38a
> > --- /dev/null
> > +++
> b/meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch
> > @@ -0,0 +1,30 @@
> > +diff -ur git/CMakeLists.txt ../0.3.5-r0.unwind/git/CMakeLists.txt
> > +--- git/CMakeLists.txt 2018-10-08 08:54:15.118989400 +0200
> >  ../0.3.5-r0.unwind/git/CMakeLists.txt  2018-10-05
> 16:26:59.745922318 +0200
> > +@@ -384,7 +384,9 @@
> > + set_target_properties (glog PROPERTIES POSITION_INDEPENDENT_CODE ON)
> > +
> > + if (UNWIND_LIBRARY)
> > +-  target_link_libraries (glog PUBLIC ${UNWIND_LIBRARY})
> > ++  add_library(unwind SHARED IMPORTED)
> > ++  set_target_properties(unwind 

[oe] [meta-oe][PATCH] glog: upgrade 0.3.4 -> 0.3.5

2018-10-08 Thread Vyacheslav Yurkov
Upgraded glog recipe to a new stable version in favor of cmake configuration
Old configure.ac patch is removed.

Another cmake patch is added. When UNWIND_LIBRARY is used directly as a public
dependency then absolute path is stored in cmake config file.
This is an issue when glog is used as part of generated SDK, which was built
on another machine. When SDK is installed on developer's machine,
cmake config contains a full path to non-existent location.
The solution is to find libunwind during configure stage and store target
name as a dependency, not a full path

Signed-off-by: Vyacheslav Yurkov 
---
 ...gure.ac-Allow-user-to-disable-gflags.patch | 35 ---
 ...0001-find-libunwind-during-configure.patch | 30 
 .../glog/{glog_0.3.4.bb => glog_0.3.5.bb} | 13 +++
 3 files changed, 37 insertions(+), 41 deletions(-)
 delete mode 100644 
meta-oe/recipes-support/glog/glog/0001-configure.ac-Allow-user-to-disable-gflags.patch
 create mode 100644 
meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch
 rename meta-oe/recipes-support/glog/{glog_0.3.4.bb => glog_0.3.5.bb} (55%)

diff --git 
a/meta-oe/recipes-support/glog/glog/0001-configure.ac-Allow-user-to-disable-gflags.patch
 
b/meta-oe/recipes-support/glog/glog/0001-configure.ac-Allow-user-to-disable-gflags.patch
deleted file mode 100644
index 596281ff6..0
--- 
a/meta-oe/recipes-support/glog/glog/0001-configure.ac-Allow-user-to-disable-gflags.patch
+++ /dev/null
@@ -1,35 +0,0 @@
-From 0fabde0515e180c53961c27346dd7a79cffa4c1f Mon Sep 17 00:00:00 2001
-From: Ricardo Ribalda Delgado 
-Date: Thu, 11 Aug 2016 11:49:36 +0200
-Subject: [PATCH] configure.ac: Allow user to disable gflags
-
-Under some circumstances like cross-compilation, the user might not want
-to enable support for gflags.
-
-This patch allows support for --without-gflags
-
-Signed-off-by: Ricardo Ribalda Delgado 

- configure.ac | 6 +-
- 1 file changed, 5 insertions(+), 1 deletion(-)
-
-diff --git a/configure.ac b/configure.ac
-index 7b4d21e7ae8a..eba5e5cda1ea 100644
 a/configure.ac
-+++ b/configure.ac
-@@ -136,7 +136,11 @@ AC_ARG_WITH(gflags, 
AS_HELP_STRING[--with-gflags=GFLAGS_DIR],
-   CFLAGS="$CFLAGS $GFLAGS_CFLAGS"
-   LIBS="$LIBS $GFLAGS_LIBS"
- )
--AC_CHECK_LIB(gflags, main, ac_cv_have_libgflags=1, ac_cv_have_libgflags=0)
-+if test x"$with_gflags" = x"no"; then
-+  ac_cv_have_libgflags=0
-+else
-+  AC_CHECK_LIB(gflags, main, ac_cv_have_libgflags=1, ac_cv_have_libgflags=0)
-+fi
- if test x"$ac_cv_have_libgflags" = x"1"; then
-   AC_DEFINE(HAVE_LIB_GFLAGS, 1, [define if you have google gflags library])
-   if test x"$GFLAGS_LIBS" = x""; then
--- 
-2.8.1
-
diff --git 
a/meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch 
b/meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch
new file mode 100644
index 0..33dc9d38a
--- /dev/null
+++ 
b/meta-oe/recipes-support/glog/glog/0001-find-libunwind-during-configure.patch
@@ -0,0 +1,30 @@
+diff -ur git/CMakeLists.txt ../0.3.5-r0.unwind/git/CMakeLists.txt
+--- git/CMakeLists.txt 2018-10-08 08:54:15.118989400 +0200
 ../0.3.5-r0.unwind/git/CMakeLists.txt  2018-10-05 16:26:59.745922318 
+0200
+@@ -384,7 +384,9 @@
+ set_target_properties (glog PROPERTIES POSITION_INDEPENDENT_CODE ON)
+ 
+ if (UNWIND_LIBRARY)
+-  target_link_libraries (glog PUBLIC ${UNWIND_LIBRARY})
++  add_library(unwind SHARED IMPORTED)
++  set_target_properties(unwind PROPERTIES IMPORTED_LOCATION ${UNWIND_LIBRARY})
++  target_link_libraries (glog PUBLIC unwind)
+ endif (UNWIND_LIBRARY)
+ 
+ if (HAVE_PTHREAD)
+diff -ur git/glog-config.cmake.in ../0.3.5-r0.unwind/git/glog-config.cmake.in
+--- git/glog-config.cmake.in   2018-10-08 08:54:15.122989699 +0200
 ../0.3.5-r0.unwind/git/glog-config.cmake.in2018-10-08 
08:14:48.550745810 +0200
+@@ -4,4 +4,12 @@
+ 
+ @gflags_DEPENDENCY@
+ 
++find_library (UNWIND_LIBRARY NAMES unwind DOC "unwind library")
++mark_as_advanced (UNWIND_LIBRARY)
++
++if (UNWIND_LIBRARY)
++  add_library(unwind SHARED IMPORTED)
++  set_target_properties(unwind PROPERTIES IMPORTED_LOCATION ${UNWIND_LIBRARY})
++endif (UNWIND_LIBRARY)
++
+ include ("${CMAKE_CURRENT_LIST_DIR}/glog-targets.cmake")
diff --git a/meta-oe/recipes-support/glog/glog_0.3.4.bb 
b/meta-oe/recipes-support/glog/glog_0.3.5.bb
similarity index 55%
rename from meta-oe/recipes-support/glog/glog_0.3.4.bb
rename to meta-oe/recipes-support/glog/glog_0.3.5.bb
index d7c1974c6..bf7df53f3 100644
--- a/meta-oe/recipes-support/glog/glog_0.3.4.bb
+++ b/meta-oe/recipes-support/glog/glog_0.3.5.bb
@@ -9,15 +9,16 @@ LIC_FILES_CHKSUM = 
"file://COPYING;md5=dc9db360e0bbd4e46672f3fd91dd6c4b"
 DEPENDS = "libunwind"
 
 SRC_URI = " \
-git://github.com/google/glog.git \
-file://0001-configure.ac-Allow-user-to-disable-gflag

[oe] [meta-oe][PATCH v2] ceres-solver: Removed empty package

2018-10-05 Thread Vyacheslav Yurkov
By default ceres-solver provides a static library and headers.
This change removes an empty package and sets an implicit dependency
on dev and dbg packages.

Signed-off-by: Vyacheslav Yurkov 
---
 meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb 
b/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb
index ad7c8f2a3..a62e5ef23 100644
--- a/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb
+++ b/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb
@@ -14,4 +14,6 @@ S = "${WORKDIR}/git"
 inherit cmake
 
 # Only a static library and headers are created
-ALLOW_EMPTY_${PN} = "1"
+RDEPENDS_${PN}-dev = ""
+RRECOMMENDS_${PN}-dev = "${PN}-staticdev"
+RRECOMMENDS_${PN}-dbg = "${PN}-dev (= ${EXTENDPKGV})"
-- 
2.19.0

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [meta-oe][PATCH] ceres-solver: Removed empty package

2018-10-05 Thread Vyacheslav Yurkov
I'm bit behind with oe-core (not on master) and was not aware of that.
Anyway I was about to send v2, because I realized that static library and
headers should come together, and it doesn't make sense to specify two
packages.

Vyacheslav

On Fri, Oct 5, 2018 at 11:43 AM Martin Jansa  wrote:

> On Fri, Oct 05, 2018 at 11:17:22AM +0200, Vyacheslav Yurkov wrote:
> > By default ceres-solver provides a static library and headers.
> > This change removes an empty package and sets an implicit dependency
> > on dev and dbg packages.
> >
> > It also addresses missing cmake configuration files in dev package.
> >
> > Signed-off-by: Vyacheslav Yurkov 
> > ---
> >  meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb | 5 -
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb
> b/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb
> > index ad7c8f2a3..13ca8efab 100644
> > --- a/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb
> > +++ b/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb
> > @@ -13,5 +13,8 @@ S = "${WORKDIR}/git"
> >
> >  inherit cmake
> >
> > +FILES_${PN}-dev += "${libdir}/cmake/"
>
> Why is this needed? cmake files are packaged automatically since oe-core
> commit:
>
> commit 543e39ad5e2baa0f1ece013a89483783e6b15dd9
> Author: Andre McCurdy 
> Date:   Tue Jun 26 12:48:11 2018 -0700
>
> bitbake.conf: handle cmake -dev files packaging with default rules
>
> > +
> >  # Only a static library and headers are created
> > -ALLOW_EMPTY_${PN} = "1"
> > +RDEPENDS_${PN}-dev = ""
> > +RRECOMMENDS_${PN}-dbg = "${PN}-dev (= ${EXTENDPKGV})"
> > --
> > 2.19.0
> >
> > --
> > ___
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
> --
> Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com
>
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


[oe] [meta-oe][PATCH] ceres-solver: Removed empty package

2018-10-05 Thread Vyacheslav Yurkov
By default ceres-solver provides a static library and headers.
This change removes an empty package and sets an implicit dependency
on dev and dbg packages.

It also addresses missing cmake configuration files in dev package.

Signed-off-by: Vyacheslav Yurkov 
---
 meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb 
b/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb
index ad7c8f2a3..13ca8efab 100644
--- a/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb
+++ b/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb
@@ -13,5 +13,8 @@ S = "${WORKDIR}/git"
 
 inherit cmake
 
+FILES_${PN}-dev += "${libdir}/cmake/"
+
 # Only a static library and headers are created
-ALLOW_EMPTY_${PN} = "1"
+RDEPENDS_${PN}-dev = ""
+RRECOMMENDS_${PN}-dbg = "${PN}-dev (= ${EXTENDPKGV})"
-- 
2.19.0

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [meta-oe][PATCH v2] libeigen: allow empty packages

2018-10-04 Thread Vyacheslav Yurkov
On Thu, Oct 4, 2018 at 10:34 AM Martin Jansa  wrote:

> > If there's another way to solve this, I'm all ears. BTW, ceres-solver
> recipe itself has ALLOW_EMPTY_${PN} = "1" already. I believe the reason is
> the same as here.
>
> Use bitbake -g my-image-dev to find out what package is depending on
> libeigen package and fix it there. Are you sure it's (only) from
> ceres-solver? Isn't libeigen listed in my-image-dev as well?
>

That makes sense. Indeed it was. I removed it from the image and it worked
well! Thanks for the hint. Now the only dependency on libeigen is
ceres-solver.

Adding ALLOW_EMPTY here is just hiding the issue somewhere else. It makes
> sense when the package might be empty based on some configuration (e.g.
> PACKAGECONFIGs), but in general ALLOW_EMPTY is bad idea. It also allows end
> user to do "opkg install libeigen" and assuming he got something useful
> when it installs something, which isn't true he just wasted few bytes of
> storage for completely empty package.
>

I have a bit different use case. I don't use package manager :)
But the point of having it in the image was to automatically put libeigen
into generated SDK. I checked it again, and SDK still generates properly
with libeigen-dev included.


> And when you're there you can remove ALLOW_EMPTY from ceres-solver as well
> :).
>

I will check if RDEPENDS_${PN}-dev works with ceres-solver as well. If it
does, then the patch from me will come ;)

Thanks again,
Vyacheslav


>
> Cheers,
>
> On Thu, Oct 4, 2018 at 9:04 AM Vyacheslav Yurkov 
> wrote:
>
>> Hi Martin,
>> Thanks for your comment. I did see discussion in the mailing list that
>> RDEPENDS_${PN}-dev is supposed to solve it, but it doesn't. To be fare, I
>> tried it again now:
>> - bitbake libeigen -c cleanall
>> - bitbake ceres-solver -c cleanall
>> - reverted my ALLOW_EMPTY_${PN} = "1" change
>> - bitbake my-image
>>
>> After last step I got:
>> ERROR: my-image-dev-1.0-r0 do_rootfs: libeigen not found in the feeds
>> (x86 corei7-64 core2-64 x86_64 noarch any all) in
>> /home/uvv/projects/yocto-x86/build/tmp/deploy/rpm.
>> ERROR: my-image-dev-1.0-r0 do_rootfs: This is often caused by an empty
>> package declared in a recipe's PACKAGES variable. (Empty packages are not
>> constructed unless ALLOW_EMPTY_ = '1' is used.)
>> ERROR: my-image-dev-1.0-r0 do_rootfs: Function failed: do_rootfs
>>
>> If there's another way to solve this, I'm all ears. BTW, ceres-solver
>> recipe itself has ALLOW_EMPTY_${PN} = "1" already. I believe the reason is
>> the same as here.
>>
>> Regards,
>> Vyacheslav
>>
>> On Wed, Oct 3, 2018 at 8:35 AM Martin Jansa 
>> wrote:
>>
>>> On Wed, Oct 03, 2018 at 08:24:22AM +0200, Vyacheslav Yurkov wrote:
>>> > libeigen is header-only library.
>>> > All headers go into dev package, therefore the main package is empty.
>>> > Dependency on the dev package doesn't work, so you have to allow
>>> > empty package for build to succeed for recipes that depend on libeigen
>>> > (e.g. ceres-solver). Otherwise an error occurs that empty packages
>>> > are not allowed.
>>>
>>> I still don't understand what the issue is, there is already
>>> RDEPENDS_${PN}-dev = "" and similar for ${PN}-dbg.
>>>
>>> Creating empty libeigen package to satisfy dependency from ceres-solver
>>> doesn't really fix anything (just installs useless empty package on
>>> target).
>>>
>>> > Signed-off-by: Vyacheslav Yurkov 
>>> > ---
>>> >  meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb | 1 +
>>> >  1 file changed, 1 insertion(+)
>>> >
>>> > diff --git a/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
>>> b/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
>>> > index 31a42a9d6..a59320655 100644
>>> > --- a/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
>>> > +++ b/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
>>> > @@ -18,3 +18,4 @@ FILES_${PN}-dev = "${includedir}
>>> ${datadir}/eigen3/cmake ${datadir}/cmake/Module
>>> >  # ${PN} is empty so we need to tweak -dev and -dbg package
>>> dependencies
>>> >  RDEPENDS_${PN}-dev = ""
>>> >  RRECOMMENDS_${PN}-dbg = "${PN}-dev (= ${EXTENDPKGV})"
>>> > +ALLOW_EMPTY_${PN} = "1"
>>> > --
>>> > 2.17.0
>>> >
>>> > --
>>> > ___
>>> > Openembedded-devel mailing list
>>> > Openembedded-devel@lists.openembedded.org
>>> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>>
>>> --
>>> Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com
>>>
>>
>>
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [meta-oe][PATCH v2] libeigen: allow empty packages

2018-10-04 Thread Vyacheslav Yurkov
 Hi Martin,
Thanks for your comment. I did see discussion in the mailing list that
RDEPENDS_${PN}-dev is supposed to solve it, but it doesn't. To be fare, I
tried it again now:
- bitbake libeigen -c cleanall
- bitbake ceres-solver -c cleanall
- reverted my ALLOW_EMPTY_${PN} = "1" change
- bitbake my-image

After last step I got:
ERROR: my-image-dev-1.0-r0 do_rootfs: libeigen not found in the feeds (x86
corei7-64 core2-64 x86_64 noarch any all) in
/home/uvv/projects/yocto-x86/build/tmp/deploy/rpm.
ERROR: my-image-dev-1.0-r0 do_rootfs: This is often caused by an empty
package declared in a recipe's PACKAGES variable. (Empty packages are not
constructed unless ALLOW_EMPTY_ = '1' is used.)
ERROR: my-image-dev-1.0-r0 do_rootfs: Function failed: do_rootfs

If there's another way to solve this, I'm all ears. BTW, ceres-solver
recipe itself has ALLOW_EMPTY_${PN} = "1" already. I believe the reason is
the same as here.

Regards,
Vyacheslav

On Wed, Oct 3, 2018 at 8:35 AM Martin Jansa  wrote:

> On Wed, Oct 03, 2018 at 08:24:22AM +0200, Vyacheslav Yurkov wrote:
> > libeigen is header-only library.
> > All headers go into dev package, therefore the main package is empty.
> > Dependency on the dev package doesn't work, so you have to allow
> > empty package for build to succeed for recipes that depend on libeigen
> > (e.g. ceres-solver). Otherwise an error occurs that empty packages
> > are not allowed.
>
> I still don't understand what the issue is, there is already
> RDEPENDS_${PN}-dev = "" and similar for ${PN}-dbg.
>
> Creating empty libeigen package to satisfy dependency from ceres-solver
> doesn't really fix anything (just installs useless empty package on
> target).
>
> > Signed-off-by: Vyacheslav Yurkov 
> > ---
> >  meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
> b/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
> > index 31a42a9d6..a59320655 100644
> > --- a/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
> > +++ b/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
> > @@ -18,3 +18,4 @@ FILES_${PN}-dev = "${includedir}
> ${datadir}/eigen3/cmake ${datadir}/cmake/Module
> >  # ${PN} is empty so we need to tweak -dev and -dbg package dependencies
> >  RDEPENDS_${PN}-dev = ""
> >  RRECOMMENDS_${PN}-dbg = "${PN}-dev (= ${EXTENDPKGV})"
> > +ALLOW_EMPTY_${PN} = "1"
> > --
> > 2.17.0
> >
> > --
> > ___
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
> --
> Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com
>
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


[oe] [meta-oe][PATCH v2] libeigen: allow empty packages

2018-10-03 Thread Vyacheslav Yurkov
libeigen is header-only library.
All headers go into dev package, therefore the main package is empty.
Dependency on the dev package doesn't work, so you have to allow
empty package for build to succeed for recipes that depend on libeigen
(e.g. ceres-solver). Otherwise an error occurs that empty packages
are not allowed.

Signed-off-by: Vyacheslav Yurkov 
---
 meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb 
b/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
index 31a42a9d6..a59320655 100644
--- a/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
+++ b/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
@@ -18,3 +18,4 @@ FILES_${PN}-dev = "${includedir} ${datadir}/eigen3/cmake 
${datadir}/cmake/Module
 # ${PN} is empty so we need to tweak -dev and -dbg package dependencies
 RDEPENDS_${PN}-dev = ""
 RRECOMMENDS_${PN}-dbg = "${PN}-dev (= ${EXTENDPKGV})"
+ALLOW_EMPTY_${PN} = "1"
-- 
2.17.0

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [meta-oe][PATCH] libeigen: allow empty packages

2018-10-02 Thread Vyacheslav Yurkov

Hi Khem,
It's a build time failure. libeigen is header-only library.
All headers go into dev package, therefore the main package is empty. 
Dependency on the dev package doesn't work, AFAIK, so you have to allow 
empty package for build to succeed. Otherwise I get an error that empty 
packages are not allowed. I reproduced it when I built ceres-solver 
recipe (although I don't use the latest poky). Perhaps I'm missing 
something and it has been solved in the latest poky?


Vyacheslav

On 02/10/2018 17:14, Khem Raj wrote:

Hi Vyacheslav

On Tue, Oct 2, 2018 at 1:33 AM Vyacheslav Yurkov  wrote:

When libeigen is used as a dependency (e.g. in ceres library),
the build is broken because empty packages are not constructed be default


can you explain a bit more on whats going on? it is a runtime failure
or build time failure.


Signed-off-by: Vyacheslav Yurkov 
---
  meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb | 1 +
  1 file changed, 1 insertion(+)

diff --git a/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb 
b/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
index 31a42a9d6..a59320655 100644
--- a/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
+++ b/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
@@ -18,3 +18,4 @@ FILES_${PN}-dev = "${includedir} ${datadir}/eigen3/cmake 
${datadir}/cmake/Module
  # ${PN} is empty so we need to tweak -dev and -dbg package dependencies
  RDEPENDS_${PN}-dev = ""
  RRECOMMENDS_${PN}-dbg = "${PN}-dev (= ${EXTENDPKGV})"
+ALLOW_EMPTY_${PN} = "1"
--
2.19.0

--
___


--
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


[oe] [meta-oe][PATCH] libeigen: allow empty packages

2018-10-02 Thread Vyacheslav Yurkov
When libeigen is used as a dependency (e.g. in ceres library),
the build is broken because empty packages are not constructed be default

Signed-off-by: Vyacheslav Yurkov 
---
 meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb 
b/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
index 31a42a9d6..a59320655 100644
--- a/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
+++ b/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
@@ -18,3 +18,4 @@ FILES_${PN}-dev = "${includedir} ${datadir}/eigen3/cmake 
${datadir}/cmake/Module
 # ${PN} is empty so we need to tweak -dev and -dbg package dependencies
 RDEPENDS_${PN}-dev = ""
 RRECOMMENDS_${PN}-dbg = "${PN}-dev (= ${EXTENDPKGV})"
+ALLOW_EMPTY_${PN} = "1"
-- 
2.19.0

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel