Re: [oe][meta-oe][PATCH] jemalloc: Fix autoheader
Apparently I do not understand autotools :)
Please drop this patch
On 12/15/21 12:30 PM, Joshua Watt wrote:
Fixes configure.ac to comply with more recent autoconf instead of
disabling autoheader
Signed-off-by: Joshua Watt
---
...1-Support-latest-version-of-autoconf.patch | 877 ++
.../jemalloc/jemalloc_5.2.1.bb| 3 +-
2 files changed, 878 insertions(+), 2 deletions(-)
create mode 100644
meta-oe/recipes-devtools/jemalloc/files/0001-Support-latest-version-of-autoconf.patch
diff --git
a/meta-oe/recipes-devtools/jemalloc/files/0001-Support-latest-version-of-autoconf.patch
b/meta-oe/recipes-devtools/jemalloc/files/0001-Support-latest-version-of-autoconf.patch
new file mode 100644
index 0..b59bce54d
--- /dev/null
+++
b/meta-oe/recipes-devtools/jemalloc/files/0001-Support-latest-version-of-autoconf.patch
@@ -0,0 +1,877 @@
+From 1c3438dae66e699cf3c5f519d2f981b31d61122d Mon Sep 17 00:00:00 2001
+From: Joshua Watt
+Date: Wed, 15 Dec 2021 12:17:49 -0600
+Subject: [PATCH] Support latest version of autoconf
+
+Newer versions of autoconf requires the description field to be
+specified for AC_DEFINE or it will emit errors like:
+
+ autoheader: warning: missing template: JEMALLOC_BACKGROUND_THREAD
+
+Upstream-Status: Submitted [https://github.com/jemalloc/jemalloc/pull/2177]
+Signed-off-by: Joshua Watt
+---
+ configure.ac | 235 ++-
+ 1 file changed, 118 insertions(+), 117 deletions(-)
+
+diff --git a/configure.ac b/configure.ac
+index 261d81c0..ab366315 100644
+--- a/configure.ac
b/configure.ac
+@@ -237,11 +237,11 @@ fi
+ if test "x$GCC" = "xyes" ; then
+ JE_CFLAGS_ADD([-std=gnu11])
+ if test "x$je_cv_cflags_added" = "x-std=gnu11" ; then
+-AC_DEFINE_UNQUOTED([JEMALLOC_HAS_RESTRICT])
++AC_DEFINE_UNQUOTED([JEMALLOC_HAS_RESTRICT], [ ], [ ])
+ else
+ JE_CFLAGS_ADD([-std=gnu99])
+ if test "x$je_cv_cflags_added" = "x-std=gnu99" ; then
+- AC_DEFINE_UNQUOTED([JEMALLOC_HAS_RESTRICT])
++ AC_DEFINE_UNQUOTED([JEMALLOC_HAS_RESTRICT], [ ], [ ])
+ fi
+ fi
+ JE_CFLAGS_ADD([-Wall])
+@@ -319,7 +319,7 @@ AC_SUBST([EXTRA_CXXFLAGS])
+
+ AC_C_BIGENDIAN([ac_cv_big_endian=1], [ac_cv_big_endian=0])
+ if test "x${ac_cv_big_endian}" = "x1" ; then
+- AC_DEFINE_UNQUOTED([JEMALLOC_BIG_ENDIAN], [ ])
++ AC_DEFINE_UNQUOTED([JEMALLOC_BIG_ENDIAN], [ ], [ ])
+ fi
+
+ if test "x${je_cv_msvc}" = "xyes" -a "x${ac_cv_header_inttypes_h}" = "xno";
then
+@@ -339,7 +339,7 @@ else
+ AC_MSG_ERROR([Unsupported pointer size: ${ac_cv_sizeof_void_p}])
+ fi
+ fi
+-AC_DEFINE_UNQUOTED([LG_SIZEOF_PTR], [$LG_SIZEOF_PTR])
++AC_DEFINE_UNQUOTED([LG_SIZEOF_PTR], [$LG_SIZEOF_PTR], [ ])
+
+ AC_CHECK_SIZEOF([int])
+ if test "x${ac_cv_sizeof_int}" = "x8" ; then
+@@ -349,7 +349,7 @@ elif test "x${ac_cv_sizeof_int}" = "x4" ; then
+ else
+ AC_MSG_ERROR([Unsupported int size: ${ac_cv_sizeof_int}])
+ fi
+-AC_DEFINE_UNQUOTED([LG_SIZEOF_INT], [$LG_SIZEOF_INT])
++AC_DEFINE_UNQUOTED([LG_SIZEOF_INT], [$LG_SIZEOF_INT], [ ])
+
+ AC_CHECK_SIZEOF([long])
+ if test "x${ac_cv_sizeof_long}" = "x8" ; then
+@@ -359,7 +359,7 @@ elif test "x${ac_cv_sizeof_long}" = "x4" ; then
+ else
+ AC_MSG_ERROR([Unsupported long size: ${ac_cv_sizeof_long}])
+ fi
+-AC_DEFINE_UNQUOTED([LG_SIZEOF_LONG], [$LG_SIZEOF_LONG])
++AC_DEFINE_UNQUOTED([LG_SIZEOF_LONG], [$LG_SIZEOF_LONG], [ ])
+
+ AC_CHECK_SIZEOF([long long])
+ if test "x${ac_cv_sizeof_long_long}" = "x8" ; then
+@@ -369,7 +369,7 @@ elif test "x${ac_cv_sizeof_long_long}" = "x4" ; then
+ else
+ AC_MSG_ERROR([Unsupported long long size: ${ac_cv_sizeof_long_long}])
+ fi
+-AC_DEFINE_UNQUOTED([LG_SIZEOF_LONG_LONG], [$LG_SIZEOF_LONG_LONG])
++AC_DEFINE_UNQUOTED([LG_SIZEOF_LONG_LONG], [$LG_SIZEOF_LONG_LONG], [ ])
+
+ AC_CHECK_SIZEOF([intmax_t])
+ if test "x${ac_cv_sizeof_intmax_t}" = "x16" ; then
+@@ -381,7 +381,7 @@ elif test "x${ac_cv_sizeof_intmax_t}" = "x4" ; then
+ else
+ AC_MSG_ERROR([Unsupported intmax_t size: ${ac_cv_sizeof_intmax_t}])
+ fi
+-AC_DEFINE_UNQUOTED([LG_SIZEOF_INTMAX_T], [$LG_SIZEOF_INTMAX_T])
++AC_DEFINE_UNQUOTED([LG_SIZEOF_INTMAX_T], [$LG_SIZEOF_INTMAX_T], [ ])
+
+ AC_CANONICAL_HOST
+ dnl CPU-specific settings.
+@@ -411,8 +411,8 @@ case "${host_cpu}" in
+ HAVE_CPU_SPINWAIT=0
+ ;;
+ esac
+-AC_DEFINE_UNQUOTED([HAVE_CPU_SPINWAIT], [$HAVE_CPU_SPINWAIT])
+-AC_DEFINE_UNQUOTED([CPU_SPINWAIT], [$CPU_SPINWAIT])
++AC_DEFINE_UNQUOTED([HAVE_CPU_SPINWAIT], [$HAVE_CPU_SPINWAIT], [ ])
++AC_DEFINE_UNQUOTED([CPU_SPINWAIT], [$CPU_SPINWAIT], [ ])
+
+ AC_ARG_WITH([lg_vaddr],
+ [AS_HELP_STRING([--with-lg-vaddr=], [Number of significant
virtual address bits])],
+@@ -477,7 +477,7 @@ typedef unsigned __int32 uint32_t;
+ LG_VADDR="${je_cv_lg_vaddr}"
+ fi
+ if test "x${LG_VADDR}" != "xerror" ; then
+-AC_DEFINE_UNQUOTED([LG_VADDR], [$LG_VADDR])
++AC_DEFINE_UNQUOTED([LG_VADDR], [$LG_VADDR], [ ])
+ else
+ AC_MSG_ERROR([cannot determine number of
[oe][meta-oe][PATCH] jemalloc: Fix autoheader
Fixes configure.ac to comply with more recent autoconf instead of
disabling autoheader
Signed-off-by: Joshua Watt
---
...1-Support-latest-version-of-autoconf.patch | 877 ++
.../jemalloc/jemalloc_5.2.1.bb| 3 +-
2 files changed, 878 insertions(+), 2 deletions(-)
create mode 100644
meta-oe/recipes-devtools/jemalloc/files/0001-Support-latest-version-of-autoconf.patch
diff --git
a/meta-oe/recipes-devtools/jemalloc/files/0001-Support-latest-version-of-autoconf.patch
b/meta-oe/recipes-devtools/jemalloc/files/0001-Support-latest-version-of-autoconf.patch
new file mode 100644
index 0..b59bce54d
--- /dev/null
+++
b/meta-oe/recipes-devtools/jemalloc/files/0001-Support-latest-version-of-autoconf.patch
@@ -0,0 +1,877 @@
+From 1c3438dae66e699cf3c5f519d2f981b31d61122d Mon Sep 17 00:00:00 2001
+From: Joshua Watt
+Date: Wed, 15 Dec 2021 12:17:49 -0600
+Subject: [PATCH] Support latest version of autoconf
+
+Newer versions of autoconf requires the description field to be
+specified for AC_DEFINE or it will emit errors like:
+
+ autoheader: warning: missing template: JEMALLOC_BACKGROUND_THREAD
+
+Upstream-Status: Submitted [https://github.com/jemalloc/jemalloc/pull/2177]
+Signed-off-by: Joshua Watt
+---
+ configure.ac | 235 ++-
+ 1 file changed, 118 insertions(+), 117 deletions(-)
+
+diff --git a/configure.ac b/configure.ac
+index 261d81c0..ab366315 100644
+--- a/configure.ac
b/configure.ac
+@@ -237,11 +237,11 @@ fi
+ if test "x$GCC" = "xyes" ; then
+ JE_CFLAGS_ADD([-std=gnu11])
+ if test "x$je_cv_cflags_added" = "x-std=gnu11" ; then
+-AC_DEFINE_UNQUOTED([JEMALLOC_HAS_RESTRICT])
++AC_DEFINE_UNQUOTED([JEMALLOC_HAS_RESTRICT], [ ], [ ])
+ else
+ JE_CFLAGS_ADD([-std=gnu99])
+ if test "x$je_cv_cflags_added" = "x-std=gnu99" ; then
+- AC_DEFINE_UNQUOTED([JEMALLOC_HAS_RESTRICT])
++ AC_DEFINE_UNQUOTED([JEMALLOC_HAS_RESTRICT], [ ], [ ])
+ fi
+ fi
+ JE_CFLAGS_ADD([-Wall])
+@@ -319,7 +319,7 @@ AC_SUBST([EXTRA_CXXFLAGS])
+
+ AC_C_BIGENDIAN([ac_cv_big_endian=1], [ac_cv_big_endian=0])
+ if test "x${ac_cv_big_endian}" = "x1" ; then
+- AC_DEFINE_UNQUOTED([JEMALLOC_BIG_ENDIAN], [ ])
++ AC_DEFINE_UNQUOTED([JEMALLOC_BIG_ENDIAN], [ ], [ ])
+ fi
+
+ if test "x${je_cv_msvc}" = "xyes" -a "x${ac_cv_header_inttypes_h}" = "xno";
then
+@@ -339,7 +339,7 @@ else
+ AC_MSG_ERROR([Unsupported pointer size: ${ac_cv_sizeof_void_p}])
+ fi
+ fi
+-AC_DEFINE_UNQUOTED([LG_SIZEOF_PTR], [$LG_SIZEOF_PTR])
++AC_DEFINE_UNQUOTED([LG_SIZEOF_PTR], [$LG_SIZEOF_PTR], [ ])
+
+ AC_CHECK_SIZEOF([int])
+ if test "x${ac_cv_sizeof_int}" = "x8" ; then
+@@ -349,7 +349,7 @@ elif test "x${ac_cv_sizeof_int}" = "x4" ; then
+ else
+ AC_MSG_ERROR([Unsupported int size: ${ac_cv_sizeof_int}])
+ fi
+-AC_DEFINE_UNQUOTED([LG_SIZEOF_INT], [$LG_SIZEOF_INT])
++AC_DEFINE_UNQUOTED([LG_SIZEOF_INT], [$LG_SIZEOF_INT], [ ])
+
+ AC_CHECK_SIZEOF([long])
+ if test "x${ac_cv_sizeof_long}" = "x8" ; then
+@@ -359,7 +359,7 @@ elif test "x${ac_cv_sizeof_long}" = "x4" ; then
+ else
+ AC_MSG_ERROR([Unsupported long size: ${ac_cv_sizeof_long}])
+ fi
+-AC_DEFINE_UNQUOTED([LG_SIZEOF_LONG], [$LG_SIZEOF_LONG])
++AC_DEFINE_UNQUOTED([LG_SIZEOF_LONG], [$LG_SIZEOF_LONG], [ ])
+
+ AC_CHECK_SIZEOF([long long])
+ if test "x${ac_cv_sizeof_long_long}" = "x8" ; then
+@@ -369,7 +369,7 @@ elif test "x${ac_cv_sizeof_long_long}" = "x4" ; then
+ else
+ AC_MSG_ERROR([Unsupported long long size: ${ac_cv_sizeof_long_long}])
+ fi
+-AC_DEFINE_UNQUOTED([LG_SIZEOF_LONG_LONG], [$LG_SIZEOF_LONG_LONG])
++AC_DEFINE_UNQUOTED([LG_SIZEOF_LONG_LONG], [$LG_SIZEOF_LONG_LONG], [ ])
+
+ AC_CHECK_SIZEOF([intmax_t])
+ if test "x${ac_cv_sizeof_intmax_t}" = "x16" ; then
+@@ -381,7 +381,7 @@ elif test "x${ac_cv_sizeof_intmax_t}" = "x4" ; then
+ else
+ AC_MSG_ERROR([Unsupported intmax_t size: ${ac_cv_sizeof_intmax_t}])
+ fi
+-AC_DEFINE_UNQUOTED([LG_SIZEOF_INTMAX_T], [$LG_SIZEOF_INTMAX_T])
++AC_DEFINE_UNQUOTED([LG_SIZEOF_INTMAX_T], [$LG_SIZEOF_INTMAX_T], [ ])
+
+ AC_CANONICAL_HOST
+ dnl CPU-specific settings.
+@@ -411,8 +411,8 @@ case "${host_cpu}" in
+ HAVE_CPU_SPINWAIT=0
+ ;;
+ esac
+-AC_DEFINE_UNQUOTED([HAVE_CPU_SPINWAIT], [$HAVE_CPU_SPINWAIT])
+-AC_DEFINE_UNQUOTED([CPU_SPINWAIT], [$CPU_SPINWAIT])
++AC_DEFINE_UNQUOTED([HAVE_CPU_SPINWAIT], [$HAVE_CPU_SPINWAIT], [ ])
++AC_DEFINE_UNQUOTED([CPU_SPINWAIT], [$CPU_SPINWAIT], [ ])
+
+ AC_ARG_WITH([lg_vaddr],
+ [AS_HELP_STRING([--with-lg-vaddr=], [Number of significant
virtual address bits])],
+@@ -477,7 +477,7 @@ typedef unsigned __int32 uint32_t;
+ LG_VADDR="${je_cv_lg_vaddr}"
+ fi
+ if test "x${LG_VADDR}" != "xerror" ; then
+-AC_DEFINE_UNQUOTED([LG_VADDR], [$LG_VADDR])
++AC_DEFINE_UNQUOTED([LG_VADDR], [$LG_VADDR], [ ])
+ else
+ AC_MSG_ERROR([cannot determine number of significant virtual address
bits])
+ fi
+@@ -499,7 +499,7 @@ typedef unsigned __int32 uint32_t;
+
