Re: [oe] [RFC meta-gnome][PATCH 07/16] geocode-glib: add recipe for geocode-glib library

2018-10-30 Thread Burton, Ross 
On Tue, 30 Oct 2018 at 03:43, Khem Raj  wrote:
> > +SRC_URI = "git://
> > gitlab.gnome.org/GNOME/geocode-glib.git;protocol=http;branch=master;tag=3.26.0
>
> hmm tags are floating kind of commits so they would result in checking
> remote repo on every fetch task it would be better to use a hard coded SHA

Or the tarball, https://download.gnome.org/sources/geocode-glib/3.26/

Note that gnome.bbclass pretty much sets up SRC_URI for you.

Ross
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [RFC meta-gnome][PATCH 07/16] geocode-glib: add recipe for geocode-glib library

2018-10-29 Thread Khem Raj 
On Mon, Oct 29, 2018 at 9:42 AM brendank310  wrote:

> From: Brendan Kerrigan 
>
> Signed-off-by: Brendan Kerrigan 
> ---
>  .../recipes-gnome/gnome3/geocode-glib_git.bb  | 21 +++
>  1 file changed, 21 insertions(+)
>  create mode 100644 meta-gnome/recipes-gnome/gnome3/geocode-glib_git.bb
>
> diff --git a/meta-gnome/recipes-gnome/gnome3/geocode-glib_git.bb
> b/meta-gnome/recipes-gnome/gnome3/geocode-glib_git.bb
> new file mode 100644
> index 0..73332e374
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/geocode-glib_git.bb
> @@ -0,0 +1,21 @@
> +DESCRIPTION = "Geocode Library for glib"
> +LICENSE = "GPLv2"


The checksum seems to be operating on a COPYING.LIB can you confirm its not
LGPL but rather GPL

>
> +DEPENDS = " \
> +   glib-2.0 \
> +   json-glib \
> +   libsoup-2.4 \
> +  "
> +
> +LIC_FILES_CHKSUM =
> "file://COPYING.LIB;md5=55ca817ccb7d5b5b66355690e9abc605"
> +
> +SRC_URI = "git://
> gitlab.gnome.org/GNOME/geocode-glib.git;protocol=http;branch=master;tag=3.26.0
> \
> +   "
> +


hmm tags are floating kind of commits so they would result in checking
remote repo on every fetch task it would be better to use a hard coded SHA

>
> +EXTRA_OEMESON += " -Denable-installed-tests=false -Denable-gtk-doc=false "
> +
> +FILES_${PN} += "${datadir}"
> +
> +S = "${WORKDIR}/git"
> +
> +inherit pkgconfig meson gobject-introspection
> +
> --
> 2.17.1
>
> --
> ___
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

[oe] [RFC meta-gnome][PATCH 07/16] geocode-glib: add recipe for geocode-glib library

2018-10-29 Thread brendank310 
From: Brendan Kerrigan 

Signed-off-by: Brendan Kerrigan 
---
 .../recipes-gnome/gnome3/geocode-glib_git.bb  | 21 +++
 1 file changed, 21 insertions(+)
 create mode 100644 meta-gnome/recipes-gnome/gnome3/geocode-glib_git.bb

diff --git a/meta-gnome/recipes-gnome/gnome3/geocode-glib_git.bb 
b/meta-gnome/recipes-gnome/gnome3/geocode-glib_git.bb
new file mode 100644
index 0..73332e374
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/geocode-glib_git.bb
@@ -0,0 +1,21 @@
+DESCRIPTION = "Geocode Library for glib"
+LICENSE = "GPLv2"
+DEPENDS = " \
+   glib-2.0 \
+   json-glib \
+   libsoup-2.4 \
+  "
+
+LIC_FILES_CHKSUM = "file://COPYING.LIB;md5=55ca817ccb7d5b5b66355690e9abc605"
+
+SRC_URI = 
"git://gitlab.gnome.org/GNOME/geocode-glib.git;protocol=http;branch=master;tag=3.26.0
 \
+   "
+
+EXTRA_OEMESON += " -Denable-installed-tests=false -Denable-gtk-doc=false "
+
+FILES_${PN} += "${datadir}"
+
+S = "${WORKDIR}/git"
+
+inherit pkgconfig meson gobject-introspection
+
-- 
2.17.1

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel