Re: [oe] [RFC meta-gnome][PATCH 16/16] gnome-tweak-tool: add recipe for the GNOME Tweak tool

2018-10-30 Thread Burton, Ross
On Tue, 30 Oct 2018 at 03:43, Khem Raj  wrote:
> > +LICENSE = "GPLv2"
> This seems should be GPL-3.0 as that’s what
> Being checksummed few lines below

> > +LIC_FILES_CHKSUM =
> > "file://LICENSES/GPL-3.0;md5=9eef91148a9b14ec7f9df333daebc746"

There's also a CCO license file in there which should be referred to
in LICENSE and checksummed.

Ross
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [RFC meta-gnome][PATCH 16/16] gnome-tweak-tool: add recipe for the GNOME Tweak tool

2018-10-29 Thread Khem Raj
On Mon, Oct 29, 2018 at 9:43 AM brendank310  wrote:

> From: Brendan Kerrigan 
>
> Signed-off-by:  Brendan Kerrigan 
> ---
>  .../recipes-gnome/gnome3/gnome-tweaks_git.bb  | 19 +++
>  1 file changed, 19 insertions(+)
>  create mode 100644 meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
>
> diff --git a/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
> b/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
> new file mode 100644
> index 0..fe305c922
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
> @@ -0,0 +1,19 @@
> +DESCRIPTION = "GNOME Tweaks"
> +LICENSE = "GPLv2"


This seems should be GPL-3.0 as that’s what
Being checksummed few lines below

>
> +DEPENDS = " \
> +gnome-shell \
> +  "
> +
> +LIC_FILES_CHKSUM =
> "file://LICENSES/GPL-3.0;md5=9eef91148a9b14ec7f9df333daebc746"
> +
> +SRC_URI = "git://
> gitlab.gnome.org/GNOME/gnome-tweaks.git;protocol=http;branch=master;tag=3.30.1
> \
> +   "
> +
> +S = "${WORKDIR}/git"
> +
> +FILES_${PN} += "${libdir}"
> +FILES_${PN} += "${datadir}"
> +
> +inherit pkgconfig meson gobject-introspection gettext
> +
> +
> --
> 2.17.1
>
> --
> ___
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [RFC meta-gnome][PATCH 16/16] gnome-tweak-tool: add recipe for the GNOME Tweak tool

2018-10-29 Thread Andreas Müller
On Mon, Oct 29, 2018 at 5:42 PM brendank310  wrote:
>
> From: Brendan Kerrigan 
>
> Signed-off-by:  Brendan Kerrigan 
> ---
>  .../recipes-gnome/gnome3/gnome-tweaks_git.bb  | 19 +++
>  1 file changed, 19 insertions(+)
>  create mode 100644 meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
>
> diff --git a/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb 
> b/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
> new file mode 100644
> index 0..fe305c922
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
> @@ -0,0 +1,19 @@
> +DESCRIPTION = "GNOME Tweaks"
^ Maybe I have missed this in other patches: SUMMARY is default short
description
> +LICENSE = "GPLv2"
> +DEPENDS = " \
> +gnome-shell \
> +  "
> +
> +LIC_FILES_CHKSUM = 
> "file://LICENSES/GPL-3.0;md5=9eef91148a9b14ec7f9df333daebc746"
> +
> +SRC_URI = 
> "git://gitlab.gnome.org/GNOME/gnome-tweaks.git;protocol=http;branch=master;tag=3.30.1
>  \
> +   "
> +
> +S = "${WORKDIR}/git"
> +
> +FILES_${PN} += "${libdir}"
> +FILES_${PN} += "${datadir}"
^ again libdir necessary? / one staetment / end of recipe
> +
> +inherit pkgconfig meson gobject-introspection gettext
> +
> +
> --
> 2.17.1
>
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


[oe] [RFC meta-gnome][PATCH 16/16] gnome-tweak-tool: add recipe for the GNOME Tweak tool

2018-10-29 Thread brendank310
From: Brendan Kerrigan 

Signed-off-by:  Brendan Kerrigan 
---
 .../recipes-gnome/gnome3/gnome-tweaks_git.bb  | 19 +++
 1 file changed, 19 insertions(+)
 create mode 100644 meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb

diff --git a/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb 
b/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
new file mode 100644
index 0..fe305c922
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
@@ -0,0 +1,19 @@
+DESCRIPTION = "GNOME Tweaks"
+LICENSE = "GPLv2"
+DEPENDS = " \
+gnome-shell \
+  "
+
+LIC_FILES_CHKSUM = 
"file://LICENSES/GPL-3.0;md5=9eef91148a9b14ec7f9df333daebc746"
+
+SRC_URI = 
"git://gitlab.gnome.org/GNOME/gnome-tweaks.git;protocol=http;branch=master;tag=3.30.1
 \
+   "
+
+S = "${WORKDIR}/git"
+
+FILES_${PN} += "${libdir}"
+FILES_${PN} += "${datadir}"
+
+inherit pkgconfig meson gobject-introspection gettext
+
+
-- 
2.17.1

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel