[oe] [meta-handheld][PATCH] h3800.conf: fix MACHINE_FEATURES

2013-10-14 Thread Andrea Adami
Signed-off-by: Andrea Adami andrea.ad...@gmail.com
---
 conf/machine/h3800.conf | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/conf/machine/h3800.conf b/conf/machine/h3800.conf
index 0c3cf15..53f3940 100644
--- a/conf/machine/h3800.conf
+++ b/conf/machine/h3800.conf
@@ -2,7 +2,5 @@
 #@NAME: Compaq iPAQ 38xx
 #@DESCRIPTION: Machine configuration for the Compaq iPAQ 38xx devices
 
-#this machine will be primarily focussed on the 2.6 port
-MACHINE_FEATURES = touchscreen apm alsa pcmcia bluetooth irda usbgadget 
screen vfat qvga
-
 require conf/machine/h3600.conf
+MACHINE_FEATURES += pcmcia bluetooth
-- 
1.8.1.5

___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [meta-handheld][PATCH] h3800.conf: fix MACHINE_FEATURES

2013-10-14 Thread Paul Eggleton
On Monday 14 October 2013 17:39:52 Andrea Adami wrote:
 Signed-off-by: Andrea Adami andrea.ad...@gmail.com
 ---
  conf/machine/h3800.conf | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
 
 diff --git a/conf/machine/h3800.conf b/conf/machine/h3800.conf
 index 0c3cf15..53f3940 100644
 --- a/conf/machine/h3800.conf
 +++ b/conf/machine/h3800.conf
 @@ -2,7 +2,5 @@
  #@NAME: Compaq iPAQ 38xx
  #@DESCRIPTION: Machine configuration for the Compaq iPAQ 38xx devices
 
 -#this machine will be primarily focussed on the 2.6 port
 -MACHINE_FEATURES = touchscreen apm alsa pcmcia bluetooth irda usbgadget
 screen vfat qvga -
  require conf/machine/h3600.conf
 +MACHINE_FEATURES += pcmcia bluetooth

I don't particularly like this. I'd rather these files stay separate for now.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [meta-handheld][PATCH] h3800.conf: fix MACHINE_FEATURES

2013-10-14 Thread Andrea Adami
On Mon, Oct 14, 2013 at 5:54 PM, Paul Eggleton
paul.eggle...@linux.intel.com wrote:
 On Monday 14 October 2013 17:39:52 Andrea Adami wrote:
 Signed-off-by: Andrea Adami andrea.ad...@gmail.com
 ---
  conf/machine/h3800.conf | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

 diff --git a/conf/machine/h3800.conf b/conf/machine/h3800.conf
 index 0c3cf15..53f3940 100644
 --- a/conf/machine/h3800.conf
 +++ b/conf/machine/h3800.conf
 @@ -2,7 +2,5 @@
  #@NAME: Compaq iPAQ 38xx
  #@DESCRIPTION: Machine configuration for the Compaq iPAQ 38xx devices

 -#this machine will be primarily focussed on the 2.6 port
 -MACHINE_FEATURES = touchscreen apm alsa pcmcia bluetooth irda usbgadget
 screen vfat qvga -
  require conf/machine/h3600.conf
 +MACHINE_FEATURES += pcmcia bluetooth

 I don't particularly like this. I'd rather these files stay separate for now.

 Cheers,
 Paul

I understand but see, the include resets the MACHINE_FEATURES as-it-is...

Cheers

Andrea


 --

 Paul Eggleton
 Intel Open Source Technology Centre
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [meta-handheld][PATCH] h3800.conf: fix MACHINE_FEATURES

2013-10-14 Thread Eric Bénard
Hi Andrea,

Le Mon, 14 Oct 2013 17:39:52 +0200,
Andrea Adami andrea.ad...@gmail.com a écrit :
  require conf/machine/h3600.conf
 +MACHINE_FEATURES += pcmcia bluetooth

not directly related to your patch, but I have an old H3600 with a
compactflash extension (both covered of dust ;-) : which image would you
recommend to build to test on this PDA ?

Thanks,
Eric
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [meta-handheld][PATCH] h3800.conf: fix MACHINE_FEATURES

2013-10-14 Thread Paul Eggleton
On Monday 14 October 2013 18:24:38 Andrea Adami wrote:
 On Mon, Oct 14, 2013 at 5:54 PM, Paul Eggleton
 
 paul.eggle...@linux.intel.com wrote:
  On Monday 14 October 2013 17:39:52 Andrea Adami wrote:
  Signed-off-by: Andrea Adami andrea.ad...@gmail.com
  ---
  
   conf/machine/h3800.conf | 4 +---
   1 file changed, 1 insertion(+), 3 deletions(-)
  
  diff --git a/conf/machine/h3800.conf b/conf/machine/h3800.conf
  index 0c3cf15..53f3940 100644
  --- a/conf/machine/h3800.conf
  +++ b/conf/machine/h3800.conf
  @@ -2,7 +2,5 @@
  
   #@NAME: Compaq iPAQ 38xx
   #@DESCRIPTION: Machine configuration for the Compaq iPAQ 38xx devices
  
  -#this machine will be primarily focussed on the 2.6 port
  -MACHINE_FEATURES = touchscreen apm alsa pcmcia bluetooth irda usbgadget
  screen vfat qvga -
  
   require conf/machine/h3600.conf
  
  +MACHINE_FEATURES += pcmcia bluetooth
  
  I don't particularly like this. I'd rather these files stay separate for
  now.
  
  Cheers,
  Paul
 
 I understand but see, the include resets the MACHINE_FEATURES as-it-is...

Oops, I had missed that this file was doing a require already. My apologies.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel