Re: [oe] [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
On Monday 11 May 2015 21:52:00 Martin Jansa wrote: > On Mon, May 11, 2015 at 12:43:41PM -0700, Khem Raj wrote: > > On Mon, May 11, 2015 at 12:00 PM, Martin Jansa wrote: > > > RDEPENDS adds dependency only between do_package tasks for build time > > > dependency you need do_configure depending on do_populate_sysroot > > > > its do_build which will depend on do_package_write task in case of > > RDEPENDS > > and do_package_write task will then recurse further to build it. > > > Build Dependencies > > > BitBake uses the > linkend='var-DEPENDS'>DEPENDS variable to > manage build time dependencies. > The "deptask" varflag for tasks signifies the task of each > item listed in DEPENDS that must > complete before that task can be executed. > Here is an example: > > do_configure[deptask] = "do_populate_sysroot" > > In this example, the > do_populate_sysroot task of each item in > DEPENDS must complete before > do_configure can execute. > > > > > > Runtime Dependencies > > > BitBake uses the > linkend='var-PACKAGES'>PACKAGES, linkend='var-RDEPENDS'>RDEPENDS, and linkend='var-RRECOMMENDS'>RRECOMMENDS variables > to manage runtime dependencies. > > > > The PACKAGES variable lists runtime > packages. > Each of those packages can have > RDEPENDS and RRECOMMENDS runtime > dependencies. The "rdeptask" flag for tasks is used to signify the task of > each item runtime dependency which must have completed before that task can > be executed. > > do_package_qa[rdeptask] = "do_packagedata" > > In the previous example, the > do_packagedata task of each item in > RDEPENDS must have completed before > do_package_qa can execute. > > > > so again, RDEPENDS isn't good enough for build time dependencies This is correct. Even an explicit RDEPENDS within the recipe does not add any dependency from do_configure on do_populate_sysroot, so if there is a build time dependency you definitely need DEPENDS as well. I do agree though that the warning message needs improvement in order to be as clear as possible. Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
On 05/11/2015 12:46 PM, Khem Raj wrote: On Mon, May 11, 2015 at 12:43 PM, Khem Raj wrote: On Mon, May 11, 2015 at 12:00 PM, Martin Jansa wrote: RDEPENDS adds dependency only between do_package tasks for build time dependency you need do_configure depending on do_populate_sysroot its do_build which will depend on do_package_write task in case of RDEPENDS and do_package_write task will then recurse further to build it. backtracking on warning WARNING: QA Issue: networkmanager rdepends on polkit, but it isn't a build dependency? [build-deps] for me the warning went away with the current change but I guess I didn't poke it enough. its confusing to me. It says 'rdepends' but then expects it in build-dependency and not build-rdep or somesuch but lets say it depends on buildtime then I agree adding it to third place is needed and may be adding to 4th place too if shlib is not detecting it. I will change it to both places. thanks for the feedback. - armin -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
On Mon, May 11, 2015 at 12:46:13PM -0700, Khem Raj wrote: > On Mon, May 11, 2015 at 12:43 PM, Khem Raj wrote: > > On Mon, May 11, 2015 at 12:00 PM, Martin Jansa > > wrote: > >> > >> RDEPENDS adds dependency only between do_package tasks for build time > >> dependency you need do_configure depending on do_populate_sysroot > > > > its do_build which will depend on do_package_write task in case of RDEPENDS > > and do_package_write task will then recurse further to build it. > > backtracking on warning > > WARNING: QA Issue: networkmanager rdepends on polkit, but it isn't a > build dependency? [build-deps] > > its confusing to me. It says 'rdepends' but then expects it in > build-dependency and not build-rdep or somesuch It says "rdepends" because that dependency was added by shlib providers code to RDEPENDS. But that means that some binary is linked against library provided by polkit -> it's build time dependency autodetected in do_configure -> needs polkit in DEPENDS. > but lets say it depends on buildtime then I agree adding it to third > place is needed and may be adding to 4th place too > if shlib is not detecting it. It needs it only in 3rd, because shlib code works correctly, otherwise you wouldn't see this QA warning. In other words the QA check warns about runtime dependencies being added by shlibs code without having their providers in build time dependencies. -- Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
On Mon, May 11, 2015 at 12:43:41PM -0700, Khem Raj wrote: > On Mon, May 11, 2015 at 12:00 PM, Martin Jansa wrote: > > > > RDEPENDS adds dependency only between do_package tasks for build time > > dependency you need do_configure depending on do_populate_sysroot > > its do_build which will depend on do_package_write task in case of RDEPENDS > and do_package_write task will then recurse further to build it. Build Dependencies BitBake uses the DEPENDS variable to manage build time dependencies. The "deptask" varflag for tasks signifies the task of each item listed in DEPENDS that must complete before that task can be executed. Here is an example: do_configure[deptask] = "do_populate_sysroot" In this example, the do_populate_sysroot task of each item in DEPENDS must complete before do_configure can execute. Runtime Dependencies BitBake uses the PACKAGES, RDEPENDS, and RRECOMMENDS variables to manage runtime dependencies. The PACKAGES variable lists runtime packages. Each of those packages can have RDEPENDS and RRECOMMENDS runtime dependencies. The "rdeptask" flag for tasks is used to signify the task of each item runtime dependency which must have completed before that task can be executed. do_package_qa[rdeptask] = "do_packagedata" In the previous example, the do_packagedata task of each item in RDEPENDS must have completed before do_package_qa can execute. so again, RDEPENDS isn't good enough for build time dependencies -- Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
On Mon, May 11, 2015 at 12:43 PM, Khem Raj wrote: > On Mon, May 11, 2015 at 12:00 PM, Martin Jansa wrote: >> >> RDEPENDS adds dependency only between do_package tasks for build time >> dependency you need do_configure depending on do_populate_sysroot > > its do_build which will depend on do_package_write task in case of RDEPENDS > and do_package_write task will then recurse further to build it. backtracking on warning WARNING: QA Issue: networkmanager rdepends on polkit, but it isn't a build dependency? [build-deps] its confusing to me. It says 'rdepends' but then expects it in build-dependency and not build-rdep or somesuch but lets say it depends on buildtime then I agree adding it to third place is needed and may be adding to 4th place too if shlib is not detecting it. -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
On Mon, May 11, 2015 at 12:00 PM, Martin Jansa wrote: > > RDEPENDS adds dependency only between do_package tasks for build time > dependency you need do_configure depending on do_populate_sysroot its do_build which will depend on do_package_write task in case of RDEPENDS and do_package_write task will then recurse further to build it. -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
On Mon, May 11, 2015 at 11:44:11AM -0700, Khem Raj wrote: > On Mon, May 11, 2015 at 2:09 AM, Martin Jansa wrote: > >> +PACKAGECONFIG[polkit] = "--enable-polkit, --disable-polkit, , polkit" > > > > Shouldn't it have polkit as build time dependency (3rd argument, not 4th) > > if something is added to RDEPENDS it automatically gets added to DEPENDS too No that's not true. RDEPENDS adds dependency only between do_package tasks for build time dependency you need do_configure depending on do_populate_sysroot -- Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
On Mon, May 11, 2015 at 2:09 AM, Martin Jansa wrote: >> +PACKAGECONFIG[polkit] = "--enable-polkit, --disable-polkit, , polkit" > > Shouldn't it have polkit as build time dependency (3rd argument, not 4th) if something is added to RDEPENDS it automatically gets added to DEPENDS too -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
On Mon, May 04, 2015 at 08:18:20PM -0700, Armin Kuster wrote:
> WARNING: QA Issue: networkmanager rdepends on polkit, but it isn't a build
> dependency? [build-deps]
>
> Signed-off-by: Armin Kuster
> ---
> .../recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb | 3
> ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git
> a/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
>
> b/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
> index 8d37c98..36a4a7e 100644
> ---
> a/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
> +++
> b/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
> @@ -37,11 +37,12 @@ PACKAGECONFIG ??=
> "${@base_contains('DISTRO_FEATURES','systemd','systemd','conso
> PACKAGECONFIG[systemd] = " \
> --with-systemdsystemunitdir=${systemd_unitdir}/system
> --with-session-tracking=systemd --enable-polkit, \
> --without-systemdsystemunitdir, \
> -polkit \
> +polkit, polkit \
> "
> # consolekit is not picked by shlibs, so add it to RDEPENDS too
> PACKAGECONFIG[consolekit] =
> "--with-session-tracking=consolekit,,consolekit,consolekit"
> PACKAGECONFIG[concheck] = "--enable-concheck,--disable-concheck,libsoup-2.4"
> +PACKAGECONFIG[polkit] = "--enable-polkit, --disable-polkit, , polkit"
Shouldn't it have polkit as build time dependency (3rd argument, not 4th)
Also the subject is wrong, it's networkmanager, not networkingmanager.
>
> # Work around dbus permission problems since we lack a proper at_console
> do_install_prepend() {
> --
> 2.3.5
>
> --
> ___
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com
--
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
[Re: [meta-networking][PATCH] networkingmanager: QA warning for rdepends on
polkit] On 15.05.08 (Fri 10:02) akuster808 wrote:
> Joe,
>
>
> On 05/08/2015 08:12 AM, Joe MacDonald wrote:
> >Hi Armin,
> >
> >I don't know if you've noticed, but it looks like this caused an issue
> >with the current world build:
>
> You mean the Galaxy build Martin does? no I have not.
I noticed it because the commit log was updated when I was cherry
picking out of master-next, that's how I found it. :)
> >commit 00ea492451d221fcc4af5613732035184b8ee43a
> >Author: Armin Kuster
> >Date: Sat Apr 4 14:52:03 2015 -0700
> >
> > networkmanger: meta-oe world build failes
> >
> > ERROR: Nothing RPROVIDES 'dnsmasq' (but
> > /home/akuster/oss/clean/meta-openembedded/meta-oe/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
> > RDEPENDS on or otherwise requires it)
> > NOTE: Runtime target 'dnsmasq' is unbuildable, removing...
> > Missing or unbuildable dependency chain was: ['dnsmasq']
> > ERROR: Required build target 'networkmanager' has no buildable
> > providers.
> > Missing or unbuildable dependency chain was: ['networkmanager',
> > 'dnsmasq']
> >
> > move networkmanager from meta-oe to meta-networking.
> >
> > Signed-off-by: Armin Kuster
> >
> >I'll see if I can reproduce it, it's not obvious to me on the surface
> >why this would be an issue with your patch.
>
> maybe it prefers to live in meta-oe ; )
Maybe it's freaked out being moved closer to dnsmasq or something.
We'll see.
-J.
> thanks.
> >
> >-J.
> >
> >[[meta-networking][PATCH] networkingmanager: QA warning for rdepends on
> >polkit] On 15.05.04 (Mon 20:18) Armin Kuster wrote:
> >
> >>WARNING: QA Issue: networkmanager rdepends on polkit, but it isn't a build
> >>dependency? [build-deps]
> >>
> >>Signed-off-by: Armin Kuster
> >>---
> >> .../recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb |
> >> 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >>diff --git
> >>a/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
> >>
> >>b/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
> >>index 8d37c98..36a4a7e 100644
> >>---
> >>a/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
> >>+++
> >>b/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
> >>@@ -37,11 +37,12 @@ PACKAGECONFIG ??=
> >>"${@base_contains('DISTRO_FEATURES','systemd','systemd','conso
> >> PACKAGECONFIG[systemd] = " \
> >> --with-systemdsystemunitdir=${systemd_unitdir}/system
> >> --with-session-tracking=systemd --enable-polkit, \
> >> --without-systemdsystemunitdir, \
> >>-polkit \
> >>+polkit, polkit \
> >> "
> >> # consolekit is not picked by shlibs, so add it to RDEPENDS too
> >> PACKAGECONFIG[consolekit] =
> >> "--with-session-tracking=consolekit,,consolekit,consolekit"
> >> PACKAGECONFIG[concheck] =
> >> "--enable-concheck,--disable-concheck,libsoup-2.4"
> >>+PACKAGECONFIG[polkit] = "--enable-polkit, --disable-polkit, , polkit"
> >>
> >> # Work around dbus permission problems since we lack a proper at_console
> >> do_install_prepend() {
--
-Joe MacDonald.
:wq
signature.asc
Description: Digital signature
--
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
Joe,
On 05/08/2015 08:12 AM, Joe MacDonald wrote:
Hi Armin,
I don't know if you've noticed, but it looks like this caused an issue
with the current world build:
You mean the Galaxy build Martin does? no I have not.
commit 00ea492451d221fcc4af5613732035184b8ee43a
Author: Armin Kuster
Date: Sat Apr 4 14:52:03 2015 -0700
networkmanger: meta-oe world build failes
ERROR: Nothing RPROVIDES 'dnsmasq' (but
/home/akuster/oss/clean/meta-openembedded/meta-oe/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
RDEPENDS on or otherwise requires it)
NOTE: Runtime target 'dnsmasq' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['dnsmasq']
ERROR: Required build target 'networkmanager' has no buildable providers.
Missing or unbuildable dependency chain was: ['networkmanager', 'dnsmasq']
move networkmanager from meta-oe to meta-networking.
Signed-off-by: Armin Kuster
I'll see if I can reproduce it, it's not obvious to me on the surface
why this would be an issue with your patch.
maybe it prefers to live in meta-oe ; )
thanks.
-J.
[[meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit]
On 15.05.04 (Mon 20:18) Armin Kuster wrote:
WARNING: QA Issue: networkmanager rdepends on polkit, but it isn't a build
dependency? [build-deps]
Signed-off-by: Armin Kuster
---
.../recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
a/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
b/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
index 8d37c98..36a4a7e 100644
---
a/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
+++
b/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
@@ -37,11 +37,12 @@ PACKAGECONFIG ??=
"${@base_contains('DISTRO_FEATURES','systemd','systemd','conso
PACKAGECONFIG[systemd] = " \
--with-systemdsystemunitdir=${systemd_unitdir}/system
--with-session-tracking=systemd --enable-polkit, \
--without-systemdsystemunitdir, \
-polkit \
+polkit, polkit \
"
# consolekit is not picked by shlibs, so add it to RDEPENDS too
PACKAGECONFIG[consolekit] =
"--with-session-tracking=consolekit,,consolekit,consolekit"
PACKAGECONFIG[concheck] = "--enable-concheck,--disable-concheck,libsoup-2.4"
+PACKAGECONFIG[polkit] = "--enable-polkit, --disable-polkit, , polkit"
# Work around dbus permission problems since we lack a proper at_console
do_install_prepend() {
--
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
Hi Armin,
I don't know if you've noticed, but it looks like this caused an issue
with the current world build:
commit 00ea492451d221fcc4af5613732035184b8ee43a
Author: Armin Kuster
Date: Sat Apr 4 14:52:03 2015 -0700
networkmanger: meta-oe world build failes
ERROR: Nothing RPROVIDES 'dnsmasq' (but
/home/akuster/oss/clean/meta-openembedded/meta-oe/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
RDEPENDS on or otherwise requires it)
NOTE: Runtime target 'dnsmasq' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['dnsmasq']
ERROR: Required build target 'networkmanager' has no buildable providers.
Missing or unbuildable dependency chain was: ['networkmanager', 'dnsmasq']
move networkmanager from meta-oe to meta-networking.
Signed-off-by: Armin Kuster
I'll see if I can reproduce it, it's not obvious to me on the surface
why this would be an issue with your patch.
-J.
[[meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit]
On 15.05.04 (Mon 20:18) Armin Kuster wrote:
> WARNING: QA Issue: networkmanager rdepends on polkit, but it isn't a build
> dependency? [build-deps]
>
> Signed-off-by: Armin Kuster
> ---
> .../recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb | 3
> ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git
> a/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
>
> b/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
> index 8d37c98..36a4a7e 100644
> ---
> a/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
> +++
> b/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
> @@ -37,11 +37,12 @@ PACKAGECONFIG ??=
> "${@base_contains('DISTRO_FEATURES','systemd','systemd','conso
> PACKAGECONFIG[systemd] = " \
> --with-systemdsystemunitdir=${systemd_unitdir}/system
> --with-session-tracking=systemd --enable-polkit, \
> --without-systemdsystemunitdir, \
> -polkit \
> +polkit, polkit \
> "
> # consolekit is not picked by shlibs, so add it to RDEPENDS too
> PACKAGECONFIG[consolekit] =
> "--with-session-tracking=consolekit,,consolekit,consolekit"
> PACKAGECONFIG[concheck] = "--enable-concheck,--disable-concheck,libsoup-2.4"
> +PACKAGECONFIG[polkit] = "--enable-polkit, --disable-polkit, , polkit"
>
> # Work around dbus permission problems since we lack a proper at_console
> do_install_prepend() {
--
-Joe MacDonald.
:wq
signature.asc
Description: Digital signature
--
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
[oe] [meta-networking][PATCH] networkingmanager: QA warning for rdepends on polkit
WARNING: QA Issue: networkmanager rdepends on polkit, but it isn't a build
dependency? [build-deps]
Signed-off-by: Armin Kuster
---
.../recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
a/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
b/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
index 8d37c98..36a4a7e 100644
---
a/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
+++
b/meta-networking/recipes-connectivity/networkmanager/networkmanager_0.9.8.10.bb
@@ -37,11 +37,12 @@ PACKAGECONFIG ??=
"${@base_contains('DISTRO_FEATURES','systemd','systemd','conso
PACKAGECONFIG[systemd] = " \
--with-systemdsystemunitdir=${systemd_unitdir}/system
--with-session-tracking=systemd --enable-polkit, \
--without-systemdsystemunitdir, \
-polkit \
+polkit, polkit \
"
# consolekit is not picked by shlibs, so add it to RDEPENDS too
PACKAGECONFIG[consolekit] =
"--with-session-tracking=consolekit,,consolekit,consolekit"
PACKAGECONFIG[concheck] = "--enable-concheck,--disable-concheck,libsoup-2.4"
+PACKAGECONFIG[polkit] = "--enable-polkit, --disable-polkit, , polkit"
# Work around dbus permission problems since we lack a proper at_console
do_install_prepend() {
--
2.3.5
--
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
