Re: [oe] [meta-networking][PATCH] vpnc: Runtime dependency to perl was missing

2013-05-14 Thread Jukka Rissanen 

Hi Koen,

On 13.05.2013 23:42, Koen Kooi wrote:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Op 13-05-13 14:34, Jukka Rissanen schreef:

Generated package contains perl script but dependecy to perl was
missing.

Signed-off-by: Jukka Rissanen jukka.rissa...@linux.intel.com ---
meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb | 2 +- 1 file
changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb
b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb index
2ce9530..df90234 100644 ---
a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb +++
b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb @@ -6,7 +6,7 @@
PRIORITY = optional LICENSE = GPL-2.0+ LIC_FILES_CHKSUM =
file://COPYING;md5=173b74cb8ac640a9992c03f3bce22a33 DEPENDS =
libgcrypt -RDEPENDS_${PN} = kernel-module-tun +RDEPENDS_${PN} =
kernel-module-tun perl


I've seen a number of patches doing this and I hate it for 2 reasons:

1) the perl stuff should be looked at and split out in a subpackage whenever
possible
2) it doesn't actually fix the problem, since you need to specify the
perl-modules it needs as well.

So patches like this drag in perl while at the same time not actually fixing
the problem of failing runtimes, only papering over RPM bitching out
dependencies.


Thanks, I missed that one. I will send a new version with proper dependency.


Cheers,
Jukka


___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

[oe] [meta-networking][PATCH] vpnc: Runtime dependency to perl was missing

2013-05-13 Thread Jukka Rissanen 
Generated package contains perl script but dependecy to perl was missing.

Signed-off-by: Jukka Rissanen jukka.rissa...@linux.intel.com
---
 meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb 
b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb
index 2ce9530..df90234 100644
--- a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb
+++ b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb
@@ -6,7 +6,7 @@ PRIORITY = optional
 LICENSE = GPL-2.0+
 LIC_FILES_CHKSUM = file://COPYING;md5=173b74cb8ac640a9992c03f3bce22a33
 DEPENDS = libgcrypt
-RDEPENDS_${PN} = kernel-module-tun
+RDEPENDS_${PN} = kernel-module-tun perl
 
 CFLAGS_append = ' -DVERSION=\\${PV}\\'
 LDFLAGS_append =  -lgcrypt -lgpg-error
-- 
1.7.11.7


___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Re: [oe] [meta-networking][PATCH] vpnc: Runtime dependency to perl was missing

2013-05-13 Thread Joe MacDonald 
[[oe] [meta-networking][PATCH] vpnc: Runtime dependency to perl was missing] On 
13.05.13 (Mon 15:34) Jukka Rissanen wrote:

 Generated package contains perl script but dependecy to perl was missing.
 
 Signed-off-by: Jukka Rissanen jukka.rissa...@linux.intel.com
 ---
  meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb 
 b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb
 index 2ce9530..df90234 100644
 --- a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb
 +++ b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb
 @@ -6,7 +6,7 @@ PRIORITY = optional
  LICENSE = GPL-2.0+
  LIC_FILES_CHKSUM = file://COPYING;md5=173b74cb8ac640a9992c03f3bce22a33
  DEPENDS = libgcrypt
 -RDEPENDS_${PN} = kernel-module-tun
 +RDEPENDS_${PN} = kernel-module-tun perl
  
  CFLAGS_append = ' -DVERSION=\\${PV}\\'
  LDFLAGS_append =  -lgcrypt -lgpg-error

Merged, thanks.

-- 
-Joe MacDonald.
:wq


signature.asc
Description: Digital signature
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Re: [oe] [meta-networking][PATCH] vpnc: Runtime dependency to perl was missing

2013-05-13 Thread Koen Kooi 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Op 13-05-13 14:34, Jukka Rissanen schreef:
 Generated package contains perl script but dependecy to perl was
 missing.
 
 Signed-off-by: Jukka Rissanen jukka.rissa...@linux.intel.com --- 
 meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb | 2 +- 1 file
 changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb
 b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb index
 2ce9530..df90234 100644 ---
 a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb +++
 b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb @@ -6,7 +6,7 @@
 PRIORITY = optional LICENSE = GPL-2.0+ LIC_FILES_CHKSUM =
 file://COPYING;md5=173b74cb8ac640a9992c03f3bce22a33 DEPENDS =
 libgcrypt -RDEPENDS_${PN} = kernel-module-tun +RDEPENDS_${PN} =
 kernel-module-tun perl

I've seen a number of patches doing this and I hate it for 2 reasons:

1) the perl stuff should be looked at and split out in a subpackage whenever
possible
2) it doesn't actually fix the problem, since you need to specify the
perl-modules it needs as well.

So patches like this drag in perl while at the same time not actually fixing
the problem of failing runtimes, only papering over RPM bitching out
dependencies.



-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFRkVBMMkyGM64RGpERAnLvAJ0VTXP1DyYpLPkLp71UMs5f+xYE3ACgnNUE
MXjCjTRD/3hGYZ9bHbwdpMs=
=/124
-END PGP SIGNATURE-


___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Re: [oe] [meta-networking][PATCH] vpnc: Runtime dependency to perl was missing

2013-05-13 Thread Philip Balister 
On 05/13/2013 04:42 PM, Koen Kooi wrote:
 Op 13-05-13 14:34, Jukka Rissanen schreef:
 Generated package contains perl script but dependecy to perl was
 missing.
 
 Signed-off-by: Jukka Rissanen jukka.rissa...@linux.intel.com --- 
 meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb | 2 +- 1 file
 changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb
 b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb index
 2ce9530..df90234 100644 ---
 a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb +++
 b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb @@ -6,7 +6,7 @@
 PRIORITY = optional LICENSE = GPL-2.0+ LIC_FILES_CHKSUM =
 file://COPYING;md5=173b74cb8ac640a9992c03f3bce22a33 DEPENDS =
 libgcrypt -RDEPENDS_${PN} = kernel-module-tun +RDEPENDS_${PN} =
 kernel-module-tun perl
 
 I've seen a number of patches doing this and I hate it for 2 reasons:
 
 1) the perl stuff should be looked at and split out in a subpackage whenever
 possible
 2) it doesn't actually fix the problem, since you need to specify the
 perl-modules it needs as well.

Another way to annoy Koen :), is to suck in all the perl-modules rather
than work out which ones are really need.

Philip

 
 So patches like this drag in perl while at the same time not actually fixing
 the problem of failing runtimes, only papering over RPM bitching out
 dependencies.
 
 
 
 
 
 ___
 Openembedded-devel mailing list
 Openembedded-devel@lists.openembedded.org
 http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
 
 



signature.asc
Description: OpenPGP digital signature
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel