Re: [oe] [meta-networking][PATCH v2] chrony: Versatile implementation of NTP

2016-06-15 Thread Koen Kooi

> Op 15 jun. 2016, om 04:12 heeft Henry Hallam  het 
> volgende geschreven:
> 
> From: Henry Hallam 

[..]

> +DEPENDS = "pps-tools"
> +# It's probably a bad idea to run chrony and ntpd on the same system.
> +RCONFLICTS_${PN} = “ntp"

The rule of thumb is to put variables where there are used, so R* go below 
do_install since they affect packaging.

> +
> +SRC_URI = "https://download.tuxfamily.org/chrony/chrony-${PV}.tar.gz \
> +file://chrony.conf \
> +file://chronyd"
> +
> +SRC_URI[md5sum] = "d0598aa8a9be8faccef9386f6fc0d5f2"
> +SRC_URI[sha256sum] = 
> "8d04e7cda2333289c2104b731d39c3c1db94816e43bae35d7ee4e7ae8af6391f"
> +
> +# Note: Despite being built via './configure; make; make install',
> +#   chrony does not use GNU Autotools.
> +inherit update-rc.d systemd
> +
> +CONFFILES_${PN} = "${sysconfdir}/chrony.conf"
> +
> +INITSCRIPT_NAME = "chronyd"
> +INITSCRIPT_PARAMS = "defaults"
> +
> +SYSTEMD_PACKAGES = "${PN}"
> +SYSTEMD_SERVICE_${PN} = “chronyd.service"

The same CONFFILES/INITSCRIPT*/SYSTEMD_*, below do_install

> +
> +# Configuration options:
> +# - For command line editing support in chronyc, you may specify either
> +#   'editline' or 'readline' but not both.  editline is smaller, but
> +#   many systems already have readline for other purposes so you might want
> +#   to choose that instead.  However, beware license incompatibility
> +#   since chrony is GPLv2 and readline versions after 6.0 are GPLv3+.
> +#   You can of course choose neither, but if you're that tight on space
> +#   consider dropping chronyc entirely (you can use it remotely with
> +#   appropriate chrony.conf options).
> +# - Security-related:
> +#   - 'sechash' is omitted by default because it pulls in nss which is huge.
> +#   - 'privdrop' allows chronyd to run as non-root; would need changes to
> +# chrony.conf and init script.
> +#   - 'scfilter' enables support for system call filtering, but requires the
> +# kernel to have CONFIG_SECCOMP enabled.
> +PACKAGECONFIG ??= "editline scfilter"
> +PACKAGECONFIG[readline] = "--without-editline,--without-readline,readline"
> +PACKAGECONFIG[editline] = ",--without-editline,libedit"
> +PACKAGECONFIG[sechash] = "--without-tomcrypt,--disable-sechash,nss"
> +PACKAGECONFIG[privdrop] = ",--disable-privdrop,libcap"
> +PACKAGECONFIG[scfilter] = "--enable-scfilter,--without-seccomp"
> +
> +# --disable-static isn't supported by chrony's configure script.
> +DISABLE_STATIC = ""
> +
> +PACKAGES += "chronyc"
> +FILES_${PN} = "${sbindir}/chronyd ${sysconfdir} ${localstatedir}"
> +FILES_chronyc = "${bindir}/chronyc”

Change that to:

PACKAGES =+ “chronyc"
FILES_chronyc = "${bindir}/chronyc”

And move those below do_install

The recipe looks good to me beside the points mentioned.

regards,

Koen

> +
> +do_configure() {
> +./configure --sysconfdir=${sysconfdir} --bindir=${bindir} 
> --sbindir=${sbindir} \
> +--localstatedir=${localstatedir} --datarootdir=${datadir} \
> +${EXTRA_OECONF}
> +}
> +
> +do_install() {
> +# Binaries
> +install -d ${D}${bindir}
> +install -m 0755 ${S}/chronyc ${D}${bindir}
> +install -d ${D}${sbindir}
> +install -m 0755 ${S}/chronyd ${D}${sbindir}
> +
> +# Config file
> +install -d ${D}${sysconfdir}
> +install -m 644 ${WORKDIR}/chrony.conf ${D}${sysconfdir}
> +
> +# System V init script
> +install -d ${D}${sysconfdir}/init.d
> +install -m 755 ${WORKDIR}/chronyd ${D}${sysconfdir}/init.d
> +
> +# Systemd unit
> +install -d ${D}${systemd_unitdir}/system
> +install -m 0644 ${S}/examples/chronyd.service 
> ${D}${systemd_unitdir}/system/
> +
> +# Variable data (for drift file)
> +install -d ${D}${localstatedir}/lib/chrony
> +
> +# Log files
> +install -d ${D}${localstatedir}/log/chrony
> +
> +# Fix hard-coded paths in config files and init scripts
> +sed -i -e 's!/var/!${localstatedir}/!g' -e 's!/etc/!${sysconfdir}/!g' \
> +   -e 's!/usr/sbin/!${sbindir}/!g' -e 's!/usr/bin/!${bindir}/!g' \
> +   ${D}${sysconfdir}/chrony.conf \
> +   ${D}${sysconfdir}/init.d/chronyd \
> +   ${D}${systemd_unitdir}/system/chronyd.service
> +sed -i 
> 's!^PATH=.*!PATH=${base_sbindir}:${base_bindir}:${sbindir}:${bindir}!' 
> ${D}${sysconfdir}/init.d/chronyd
> +sed -i 
> 's!^EnvironmentFile=.*!EnvironmentFile=-${sysconfdir}/default/chronyd!' 
> ${D}${systemd_unitdir}/system/chronyd.service
> +}
> -- 
> 2.8.1
> 

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


[oe] [meta-networking][PATCH v2] chrony: Versatile implementation of NTP

2016-06-14 Thread Henry Hallam
From: Henry Hallam 

chrony is an alternative to ntpd.  In particular it may be useful
for quasi-realtime embedded systems that have a pulse-per-second
time reference available and need to rapidly synchronize to it after
boot, which appears to be unachievable with ntpd.

Signed-off-by: Henry Hallam 
---
 .../recipes-support/chrony/chrony/chrony.conf  |  44 
 .../recipes-support/chrony/chrony/chronyd  |  58 ++
 .../recipes-support/chrony/chrony_2.4.bb   | 120 +
 3 files changed, 222 insertions(+)
 create mode 100644 meta-networking/recipes-support/chrony/chrony/chrony.conf
 create mode 100644 meta-networking/recipes-support/chrony/chrony/chronyd
 create mode 100644 meta-networking/recipes-support/chrony/chrony_2.4.bb

diff --git a/meta-networking/recipes-support/chrony/chrony/chrony.conf 
b/meta-networking/recipes-support/chrony/chrony/chrony.conf
new file mode 100644
index 000..95f5f81
--- /dev/null
+++ b/meta-networking/recipes-support/chrony/chrony/chrony.conf
@@ -0,0 +1,44 @@
+# Use public NTP servers from the pool.ntp.org project.
+# Please consider joining the pool project if possible by running your own
+# server(s).
+# If you are a vendor distributing a product using chrony, you *MUST*
+# read and comply with http://www.pool.ntp.org/vendors.html
+pool 0.openembedded.pool.ntp.org iburst
+
+# Use a local timeserver in preference to the pool, if it's reachable.
+#server 192.168.22.22 iburst minpoll 2 prefer
+
+# Sync to pulse-per-second from an onboard GPS.
+#refclock PPS /dev/pps0 poll 0 prefer
+# You'll want to enable CONFIG_PPS and CONFIG_PPS_CLIENT_GPIO in your kernel,
+# and an entry something like this in your device tree:
+#  pps {
+#  compatible = "pps-gpio";
+#  gpios = <&ps7_gpio_0 56 0>;
+#  };
+
+# Record the rate at which the system clock gains/loses time,
+# improving accuracy after reboot
+driftfile /var/lib/chrony.drift
+
+# In first three updates step the system clock instead of slew
+# if the adjustment is larger than 1 second.
+makestep 1.0 3
+
+# Enable kernel synchronization of the real-time clock (RTC).
+rtcsync
+
+# Allow NTP client access from local network.
+#allow 192.168/16
+
+# Serve time even if not synchronized to any NTP server.
+#local stratum 10
+
+# Specify file containing keys for NTP authentication.
+#keyfile /etc/chrony.keys
+
+# Specify directory for log files.
+logdir /var/log/chrony
+
+# Select which information is logged.
+#log measurements statistics tracking
diff --git a/meta-networking/recipes-support/chrony/chrony/chronyd 
b/meta-networking/recipes-support/chrony/chrony/chronyd
new file mode 100644
index 000..04f1b68
--- /dev/null
+++ b/meta-networking/recipes-support/chrony/chrony/chronyd
@@ -0,0 +1,58 @@
+#! /bin/sh
+
+# System V init script for chrony
+# Adapted from the script already in meta-networking for ntpd
+
+### BEGIN INIT INFO
+# Provides:chrony
+# Required-Start:  $network $remote_fs $syslog
+# Required-Stop:   $network $remote_fs $syslog
+# Default-Start:   2 3 4 5
+# Default-Stop:
+# Short-Description: Start chrony time daemon
+### END INIT INFO
+
+PATH=/sbin:/bin:/usr/bin:/usr/sbin
+
+DAEMON=/usr/sbin/chronyd
+PIDFILE=/var/run/chronyd.pid
+
+test -x $DAEMON -a -r /etc/chrony.conf || exit 0
+
+# Source function library.
+. /etc/init.d/functions
+
+# Functions to do individual actions
+startdaemon(){
+   echo -n "Starting chronyd: "
+   start-stop-daemon --start --quiet --oknodo --pidfile $PIDFILE --startas 
$DAEMON -- "$@"
+   echo "done"
+}
+stopdaemon(){
+   echo -n "Stopping chronyd: "
+   start-stop-daemon --stop --quiet --oknodo -p $PIDFILE
+   echo "done"
+}
+
+case "$1" in
+  start)
+   startdaemon
+   ;;
+  stop)
+   stopdaemon
+   ;;
+  force-reload | restart | reload)
+   stopdaemon
+   startdaemon
+   ;;
+  status)
+   status /usr/sbin/chronyd;
+   exit $?
+   ;;
+  *)
+   echo "Usage: chronyd { start | stop | status | restart | reload }" >&2
+   exit 1
+   ;;
+esac
+
+exit 0
diff --git a/meta-networking/recipes-support/chrony/chrony_2.4.bb 
b/meta-networking/recipes-support/chrony/chrony_2.4.bb
new file mode 100644
index 000..07d312e
--- /dev/null
+++ b/meta-networking/recipes-support/chrony/chrony_2.4.bb
@@ -0,0 +1,120 @@
+SUMMARY = "Versatile implementation of the Network Time Protocol"
+DESCRIPTION = "Chrony can synchronize the system clock with NTP \
+servers, reference clocks (e.g. GPS receiver), and manual input using \
+wristwatch and keyboard. It can also operate as an NTPv4 (RFC 5905) \
+server and peer to provide a time service to other computers in the \
+network. \
+\
+It is designed to perform well in a wide range of conditions, \
+including intermittent network connections, heavily congested \
+networks, changing temperatures (ordinary computer clocks are \
+sensitive to temperature), and systems that do not run continuosly, or \
+run on

[oe] [meta-networking][PATCH v2] chrony: Versatile implementation of NTP

2016-06-14 Thread Henry Hallam

Patch version 2:
- No longer hard-coding paths  
- Fix missing build dependencies, depending on PACKAGECONFIG features 
- Split off chronyc into separate output package
- Default config points to openembedded.pool.ntp.org rather than
  pool.ntp.org (which should never be shipped as a default)

I have applied for the above NTP pool vendor zone per
http://www.pool.ntp.org/en/vendors.html#vendor-zone

Thanks, Henry
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel