Re: [oe] [meta-oe][PATCH 1/1] lcov: fix env command argument pass issue

2017-01-09 Thread Khem Raj
On Thu, Jan 5, 2017 at 1:44 AM,   wrote:
> From: chunguang yang 
>
> when exec lcov in bash, the following error will appear:
>
> /usr/bin/env: 'perl -w': No such file or directory
>
> perl uses the -w option to enable many warnings. But the
> env command can't pass the argument to perl, instead it
> treate perl -w as a file. To fix this issue, just keep
> the origin perl path and not use env command.
>

I would suggest that we get rid of -w as well, since the fix to use perl
via /usr/bin/env is to get rid of absolute paths.

> Signed-off-by: chunguang yang 
> ---
>  meta-oe/recipes-support/lcov/lcov_1.11.bb | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/meta-oe/recipes-support/lcov/lcov_1.11.bb 
> b/meta-oe/recipes-support/lcov/lcov_1.11.bb
> index 114bd84cd..2f9ac336e 100644
> --- a/meta-oe/recipes-support/lcov/lcov_1.11.bb
> +++ b/meta-oe/recipes-support/lcov/lcov_1.11.bb
> @@ -23,6 +23,5 @@ SRC_URI[sha256sum] = 
> "c282de8d678ecbfda32ce4b5c85fc02f77c2a39a062f068bd8e774d29d
>
>  do_install() {
>  oe_runmake install PREFIX=${D}
> -sed -i -e '1s,#!.*perl,#! ${USRBINPATH}/env perl,' ${D}${bindir}/*
>  }
>
> --
> 2.11.0
>
> --
> ___
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


[oe] [meta-oe][PATCH 1/1] lcov: fix env command argument pass issue

2017-01-05 Thread chunguang.yang
From: chunguang yang 

when exec lcov in bash, the following error will appear:

/usr/bin/env: 'perl -w': No such file or directory

perl uses the -w option to enable many warnings. But the
env command can't pass the argument to perl, instead it
treate perl -w as a file. To fix this issue, just keep
the origin perl path and not use env command.

Signed-off-by: chunguang yang 
---
 meta-oe/recipes-support/lcov/lcov_1.11.bb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta-oe/recipes-support/lcov/lcov_1.11.bb 
b/meta-oe/recipes-support/lcov/lcov_1.11.bb
index 114bd84cd..2f9ac336e 100644
--- a/meta-oe/recipes-support/lcov/lcov_1.11.bb
+++ b/meta-oe/recipes-support/lcov/lcov_1.11.bb
@@ -23,6 +23,5 @@ SRC_URI[sha256sum] = 
"c282de8d678ecbfda32ce4b5c85fc02f77c2a39a062f068bd8e774d29d
 
 do_install() {
 oe_runmake install PREFIX=${D}
-sed -i -e '1s,#!.*perl,#! ${USRBINPATH}/env perl,' ${D}${bindir}/*
 }
 
-- 
2.11.0

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel