Re: [oe] [meta-oe][master-next][PATCH v3 17/17] libeigen: rely on cmake.bbclass to put cmake package files in dev package

2018-05-29 Thread Khem Raj 
it was in queue so ran through it

ERROR: libeigen-3.3.4-r0 do_package: QA Issue: libeigen:
Files/directories were installed but not shipped in any package:
  /usr/share/eigen3
  /usr/share/eigen3/cmake
  /usr/share/eigen3/cmake/Eigen3Config.cmake
  /usr/share/eigen3/cmake/UseEigen3.cmake
  /usr/share/eigen3/cmake/Eigen3Targets.cmake
  /usr/share/eigen3/cmake/Eigen3ConfigVersion.cmake


It seems you need to keep

${datadir}/eigen3 added to FILES_${PN}-dev


On Fri, May 25, 2018 at 7:49 PM, Trevor Woerner  wrote:
> On Fri, May 25, 2018 at 10:45 PM, Trevor Woerner  wrote:
>
>> Sounds good; I'll take a look. Thanks!
>>
>
> Oops, spoke too soon; looks like someone beat me to it :-)
> --
> ___
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-oe][master-next][PATCH v3 17/17] libeigen: rely on cmake.bbclass to put cmake package files in dev package

2018-05-25 Thread Trevor Woerner 
On Fri, May 25, 2018 at 10:45 PM, Trevor Woerner  wrote:

> Sounds good; I'll take a look. Thanks!
>

Oops, spoke too soon; looks like someone beat me to it :-)
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-oe][master-next][PATCH v3 17/17] libeigen: rely on cmake.bbclass to put cmake package files in dev package

2018-05-25 Thread Trevor Woerner 
On Fri, May 25, 2018 at 3:58 PM, Andre McCurdy  wrote:

> On Fri, May 25, 2018 at 8:22 AM, Trevor Woerner 
> wrote:
> > As Anuj pointed out with patch 16/17 of this series (opencv: rely on
> > cmake.bbclass...), so too is this patch wrong and shouldn't be applied.
> > Sorry!
> >
> > Looking closer at this recipe (on an unrelated issue) do we really want
> the
> > include files being part of FILES_${PN}?
>
> No, we don't. It looks like it's been done that way as a workaround
> for the libeigen build not creating anything which would normally go
> in the main package. Setting:
>
>   ALLOW_EMPTY_${PN} = "1"
>
> together with careful review of the packaging rules and probably
> removing the RDEPENDS and RRECOMMENDS over-rides may be a better
> solution.
>
> You should also carefully check that things work as expected when
> libeigen is added to an SDK. That's a corner case which tests
> dependencies between runtime and -dev packages which isn't tested
> during a normal build (for what it's worth, creating an empty runtime
> package by using ALLOW_EMPTY_${PN} = "1" has always been the easiest
> solution whenever I've looked into this kind of issue in the past and
> it "just works" for the SDK case).
>

Sounds good; I'll take a look. Thanks!
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-oe][master-next][PATCH v3 17/17] libeigen: rely on cmake.bbclass to put cmake package files in dev package

2018-05-25 Thread Andre McCurdy 
On Fri, May 25, 2018 at 8:22 AM, Trevor Woerner  wrote:
> As Anuj pointed out with patch 16/17 of this series (opencv: rely on
> cmake.bbclass...), so too is this patch wrong and shouldn't be applied.
> Sorry!
>
> Looking closer at this recipe (on an unrelated issue) do we really want the
> include files being part of FILES_${PN}?

No, we don't. It looks like it's been done that way as a workaround
for the libeigen build not creating anything which would normally go
in the main package. Setting:

  ALLOW_EMPTY_${PN} = "1"

together with careful review of the packaging rules and probably
removing the RDEPENDS and RRECOMMENDS over-rides may be a better
solution.

You should also carefully check that things work as expected when
libeigen is added to an SDK. That's a corner case which tests
dependencies between runtime and -dev packages which isn't tested
during a normal build (for what it's worth, creating an empty runtime
package by using ALLOW_EMPTY_${PN} = "1" has always been the easiest
solution whenever I've looked into this kind of issue in the past and
it "just works" for the SDK case).
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-oe][master-next][PATCH v3 17/17] libeigen: rely on cmake.bbclass to put cmake package files in dev package

2018-05-25 Thread Trevor Woerner 
As Anuj pointed out with patch 16/17 of this series (opencv: rely on
cmake.bbclass...), so too is this patch wrong and shouldn't be applied.
Sorry!

Looking closer at this recipe (on an unrelated issue) do we really want the
include files being part of FILES_${PN}?
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

[oe] [meta-oe][master-next][PATCH v3 17/17] libeigen: rely on cmake.bbclass to put cmake package files in dev package

2018-05-24 Thread Trevor Woerner 
The cmake.bbclass in oe-core now ensures that ${libdir}/cmake and
${datadir}/cmake end up in the dev package, so recipes no longer need to
provide custom packaging rules to handles these files.


http://git.openembedded.org/openembedded-core/commit/?id=d91dc483a96e9d03cbbd21b8a546f9069c93

Originally-conceived-by: Andre McCurdy 
Signed-off-by: Trevor Woerner 
---
 meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb 
b/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
index bc3b32e384..2ffaea63ad 100644
--- a/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
+++ b/meta-oe/recipes-support/libeigen/libeigen_3.3.4.bb
@@ -13,7 +13,7 @@ S = "${WORKDIR}/eigen-eigen-5a0156e40feb"
 inherit cmake
 
 FILES_${PN} = "${includedir} ${libdir}"
-FILES_${PN}-dev = "${datadir}/eigen3/cmake ${datadir}/cmake/Modules 
${datadir}/pkgconfig"
+FILES_${PN}-dev = "${datadir}/pkgconfig"
 
 # ${PN} is empty so we need to tweak -dev and -dbg package dependencies
 RDEPENDS_${PN}-dev = ""
-- 
2.17.0.582.gccdcbd54c

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel