Re: [oe] [warrior][PATCH 0/4] vlc adjustments
On Fri, Sep 20, 2019 at 8:36 AM Adrian Bunk wrote: > > On Fri, Sep 20, 2019 at 03:14:04AM +0200, Andreas Müller wrote: > > On Fri, Aug 30, 2019 at 10:51 AM Andreas Müller > > wrote: > > > > > > On Thu, Aug 29, 2019 at 4:16 PM akuster808 wrote: > > > > > Ping > > > > > > > > in stable/warrior-nmut for testing. > > > > > > > Thanks > > > > > Patch 3 was applied / 1,2,4 not. Shall I resend or is there a reason > > not to apply them in warrior? > > 2 and 4 (written by me) were not applied since I recommended against. > > Patch 1 I don't have an opinion about here, but Armin might have > misunderstood my comment as disapproval also for this one. > * OK let's forget 2 & 4 * Patch 1 is important (for me): 1. Qt4 support is gone in vlc 2. Without Qt5 backend vlc is more or less useless Cheers Andreas -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [warrior][PATCH 0/4] vlc adjustments
On Fri, Sep 20, 2019 at 03:14:04AM +0200, Andreas Müller wrote: > On Fri, Aug 30, 2019 at 10:51 AM Andreas Müller > wrote: > > > > On Thu, Aug 29, 2019 at 4:16 PM akuster808 wrote: > > > > Ping > > > > > > in stable/warrior-nmut for testing. > > > > > Thanks > > > Patch 3 was applied / 1,2,4 not. Shall I resend or is there a reason > not to apply them in warrior? 2 and 4 (written by me) were not applied since I recommended against. Patch 1 I don't have an opinion about here, but Armin might have misunderstood my comment as disapproval also for this one. > Andreas cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [warrior][PATCH 0/4] vlc adjustments
On Fri, Aug 30, 2019 at 10:51 AM Andreas Müller wrote: > > On Thu, Aug 29, 2019 at 4:16 PM akuster808 wrote: > > > Ping > > > > in stable/warrior-nmut for testing. > > > Thanks > Patch 3 was applied / 1,2,4 not. Shall I resend or is there a reason not to apply them in warrior? Andreas -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [warrior][PATCH 0/4] vlc adjustments
On Thu, Aug 29, 2019 at 4:16 PM akuster808 wrote: > > Ping > > in stable/warrior-nmut for testing. > Thanks Andreas -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [warrior][PATCH 0/4] vlc adjustments
On 8/28/19 3:56 PM, Andreas Müller wrote: > On Sat, Aug 17, 2019 at 1:18 PM Adrian Bunk wrote: >> On Sat, Aug 17, 2019 at 10:13:35AM +0200, Andreas Müller wrote: >>> Some cherry-picks for vlc >>> ... >>> 2.- 4. Are good enhancements. It is upon warrior maintainers if they are >>>important enough to make it into stable branch. >>> >>> Adrian Bunk (3): >>> vlc: Remove workaround and patches for problems fixed upstream >>> vlc: notify switched to GTK+3 some time ago >>> vlc: Remove the obsolete dependency on dbus-glib >>> ... >> The notify change is an actual bugfix that should be added to warrior. >> >> The other two changes are cleanup patches with no (intentional) changes >> in the build result, I would recommend against backporting them since >> there are no benfits compared to the small regression risk. >> >> cu >> Adrian >> > Ping in stable/warrior-nmut for testing. -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [warrior][PATCH 0/4] vlc adjustments
On Sat, Aug 17, 2019 at 1:18 PM Adrian Bunk wrote: > > On Sat, Aug 17, 2019 at 10:13:35AM +0200, Andreas Müller wrote: > > Some cherry-picks for vlc > >... > > 2.- 4. Are good enhancements. It is upon warrior maintainers if they are > >important enough to make it into stable branch. > > > > Adrian Bunk (3): > > vlc: Remove workaround and patches for problems fixed upstream > > vlc: notify switched to GTK+3 some time ago > > vlc: Remove the obsolete dependency on dbus-glib > >... > > The notify change is an actual bugfix that should be added to warrior. > > The other two changes are cleanup patches with no (intentional) changes > in the build result, I would recommend against backporting them since > there are no benfits compared to the small regression risk. > > cu > Adrian > Ping -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Re: [oe] [warrior][PATCH 0/4] vlc adjustments
On Sat, Aug 17, 2019 at 10:13:35AM +0200, Andreas Müller wrote: > Some cherry-picks for vlc >... > 2.- 4. Are good enhancements. It is upon warrior maintainers if they are >important enough to make it into stable branch. > > Adrian Bunk (3): > vlc: Remove workaround and patches for problems fixed upstream > vlc: notify switched to GTK+3 some time ago > vlc: Remove the obsolete dependency on dbus-glib >... The notify change is an actual bugfix that should be added to warrior. The other two changes are cleanup patches with no (intentional) changes in the build result, I would recommend against backporting them since there are no benfits compared to the small regression risk. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
[oe] [warrior][PATCH 0/4] vlc adjustments
Some cherry-picks for vlc 1. Is mandatory because qt4 support is gone and without qt5 vlc is not useful exactly 2.- 4. Are good enhancements. It is upon warrior maintainers if they are important enough to make it into stable branch. Adrian Bunk (3): vlc: Remove workaround and patches for problems fixed upstream vlc: notify switched to GTK+3 some time ago vlc: Remove the obsolete dependency on dbus-glib Andreas Müller (1): vlc: rework qt PACKAGECONFIG .../recipes-multimedia/vlc/vlc.inc| 28 +++ .../0002-glibc-does-not-provide-strlcpy.patch | 15 -- .../vlc/0005-libpostproc-header-check.patch | 15 -- .../recipes-multimedia/vlc/vlc_3.0.6.bb | 5 4 files changed, 17 insertions(+), 46 deletions(-) delete mode 100644 meta-multimedia/recipes-multimedia/vlc/vlc/0002-glibc-does-not-provide-strlcpy.patch delete mode 100644 meta-multimedia/recipes-multimedia/vlc/vlc/0005-libpostproc-header-check.patch -- 2.20.1 -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
