Re: [oe] [meta-gnome][PATCH 1/6] network-manager-applet: Package gir-1.0 files into devel package

[Andreas Müller]

On Mon, May 21, 2018 at 12:47 AM, Khem Raj  wrote:
> On Sun, May 20, 2018 at 3:46 PM, Andreas Müller  
> wrote:
>> On Mon, May 21, 2018 at 12:35 AM, Khem Raj  wrote:
>>> Fixes QA errors e.g.
>>>
>>> ERROR: network-manager-applet-1.8.10-r0 do_package: QA Issue: 
>>> network-manager-applet: Files/directories were installed but not shipped in 
>>> any package:
>>>   /usr/share/gir-1.0
>>>
>>> Signed-off-by: Khem Raj 
>>> ---
>>>  .../network-manager-applet/network-manager-applet_1.8.10.bb   | 4 
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git 
>>> a/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
>>>  
>>> b/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
>>> index dc2b964be5..ccfe38d010 100644
>>> --- 
>>> a/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
>>> +++ 
>>> b/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
>>> @@ -43,3 +43,7 @@ FILES_${PN} += " \
>>>  ${datadir}/libnm-gtk/wifi.ui \
>>>  ${datadir}/libnma/wifi.ui \
>>>  "
>>> +
>>> +FILES_${PN}-dev += " \
>>> +${datadir}/gir-1.0 \
>>> +"
>>> --
>>> 2.17.0
>>>
>> On sumo I do not see this QA error and gir-files are packed properly
>> to network-manager-applet-dev.
>>
>> Sure that this is a correct fix? What changed in oe-core?
>>
>
> This is seen with musl builds. In anycase gir files if any should go
> into -dev pkgs.
>
Ahh musl / gir...

So how about dropping a note near FILES_${PN}-dev - otherwise chances
are high it gets removed sooner or later. For non musl this is not
necessary and at least I will not remember during next release
panic...

Andreas
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-gnome][PATCH 1/6] network-manager-applet: Package gir-1.0 files into devel package

[Khem Raj]

On Sun, May 20, 2018 at 3:46 PM, Andreas Müller  wrote:
> On Mon, May 21, 2018 at 12:35 AM, Khem Raj  wrote:
>> Fixes QA errors e.g.
>>
>> ERROR: network-manager-applet-1.8.10-r0 do_package: QA Issue: 
>> network-manager-applet: Files/directories were installed but not shipped in 
>> any package:
>>   /usr/share/gir-1.0
>>
>> Signed-off-by: Khem Raj 
>> ---
>>  .../network-manager-applet/network-manager-applet_1.8.10.bb   | 4 
>>  1 file changed, 4 insertions(+)
>>
>> diff --git 
>> a/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
>>  
>> b/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
>> index dc2b964be5..ccfe38d010 100644
>> --- 
>> a/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
>> +++ 
>> b/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
>> @@ -43,3 +43,7 @@ FILES_${PN} += " \
>>  ${datadir}/libnm-gtk/wifi.ui \
>>  ${datadir}/libnma/wifi.ui \
>>  "
>> +
>> +FILES_${PN}-dev += " \
>> +${datadir}/gir-1.0 \
>> +"
>> --
>> 2.17.0
>>
> On sumo I do not see this QA error and gir-files are packed properly
> to network-manager-applet-dev.
>
> Sure that this is a correct fix? What changed in oe-core?
>

This is seen with musl builds. In anycase gir files if any should go
into -dev pkgs.

> Andreas
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-gnome][PATCH 1/6] network-manager-applet: Package gir-1.0 files into devel package

[Andreas Müller]

On Mon, May 21, 2018 at 12:35 AM, Khem Raj  wrote:
> Fixes QA errors e.g.
>
> ERROR: network-manager-applet-1.8.10-r0 do_package: QA Issue: 
> network-manager-applet: Files/directories were installed but not shipped in 
> any package:
>   /usr/share/gir-1.0
>
> Signed-off-by: Khem Raj 
> ---
>  .../network-manager-applet/network-manager-applet_1.8.10.bb   | 4 
>  1 file changed, 4 insertions(+)
>
> diff --git 
> a/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
>  
> b/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
> index dc2b964be5..ccfe38d010 100644
> --- 
> a/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
> +++ 
> b/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.10.bb
> @@ -43,3 +43,7 @@ FILES_${PN} += " \
>  ${datadir}/libnm-gtk/wifi.ui \
>  ${datadir}/libnma/wifi.ui \
>  "
> +
> +FILES_${PN}-dev += " \
> +${datadir}/gir-1.0 \
> +"
> --
> 2.17.0
>
On sumo I do not see this QA error and gir-files are packed properly
to network-manager-applet-dev.

Sure that this is a correct fix? What changed in oe-core?

Andreas
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel