Re: [oe] [meta-networking][PATCH] tgt: Migrate recipe from meta-openstack layer

2018-07-16 Thread Bruce Ashfield 
On Sun, Jul 15, 2018 at 11:44 PM, Yu, Mingli  wrote:
>
>
> On 2018年07月14日 02:47, Khem Raj wrote:
>>
>> On 7/13/18 12:35 PM, Jagadeesh Krishnanjanappa wrote:
>>>
>>> Yes, we need to copy libconfig-general-perl recipe (from meta-openstack)
>>> to
>>> meta-networking as well.
>>>
>>> Bruce comment:
>>> We have specific version requirements with openstack, so we'll keep the
>>> original
>>> recipe in place in meta-openstack, so you might want to change the short
>>> log of
>>> your patch to "copy recipe from meta-openstack".
>>>
>>> Since tgt recipe will continue to exists under meta-openstack layer as
>>> per above comment,
>>> copying it under meta-networking would create duplication. Is it OK?
>>>
>>
>> this is SCSI target framework, in my mind this is neither openstack
>> specific nor networking specific. same is true for
>> libconfig-general-perl, however if there are no users of this outside
>> openstack layer users then its better it stays there, otherwise it
>> should move to meta-oe
>
>
> If we won't support the iscsitarget in the future as it needs too much
> change to work with kernel >= 4.14, it should be convenient to move tgt to
> meta-oe.

That statement actually makes little sense. If the meta-openstack
layer doesn't break anything, keeping the recipe there is one line in
a bblayers file. Not exactly a grand challenge.

In meta-openstack there are very specific version requirements and
system level testing that happens, so the uprev cadence is different.
If more frequent updates, and unit testing via meta-oe are going to be
done, then that is definitely a reason for a copy to be made (since
depending on meta-openstack could be a problem) .. that's an actual
reason, versus stating some fact that has nothing to do with recipe
placement.

But again, I'm not arguing one way or the other, and I'm certainly not
objecting to anything here .. I'll need to keep the recipe in
meta-openstack either way.

It is just Monday and I thought I'd point out that using valid
technical points makes decision making easier.

Cheers,

Bruce

>
> Thanks,
>
>
>>
>>> Regards,
>>> Jagadeesh
>>>
>>> On Thu, Jul 12, 2018 at 7:44 PM, Khem Raj >> > wrote:
>>>
>>>  I guess more recipes needs to be migrated. This fails with
>>>
>>>  ERROR: Nothing RPROVIDES 'libconfig-general-perl' (but
>>>
>>> /mnt/a/oe/sources/meta-openembedded/meta-networking/recipes-support/tgt/tgt_git.bb
>>>  
>>>  RDEPENDS on or otherwise requires it)
>>>  NOTE: Runtime target 'libconfig-general-perl' is unbuildable,
>>>  removing...
>>>  Missing or unbuildable dependency chain was:
>>> ['libconfig-general-perl']
>>>  NOTE: Runtime target 'tgt' is unbuildable, removing...
>>>  Missing or unbuildable dependency chain was: ['tgt',
>>>  'libconfig-general-perl']
>>>  ERROR: Nothing RPROVIDES 'tgt-dev' (but
>>>
>>> /mnt/a/oe/sources/meta-openembedded/meta-networking/recipes-support/tgt/tgt_git.bb
>>>  
>>>  RDEPENDS on or otherwise requires it)
>>>  No eligible RPROVIDERs exist for 'tgt-dev'
>>>  NOTE: Runtime target 'tgt-dev' is unbuildable, removing...
>>>  Missing or unbuildable dependency chain was: ['tgt-dev']
>>>
>>>
>>>  On Sat, Jul 7, 2018 at 11:26 AM Jagadeesh Krishnanjanappa
>>>  mailto:jkrishnanjana...@mvista.com>>
>>>  wrote:
>>>  >
>>>  > As iscsitarget cannot be built with Linux kernel >= 4.14, so
>>>  > migrate Linux SCSI target framework (tgt) recipe from
>>> meta-openstack
>>>  > layer; to allow users to test iSCSI target feature with tgt in
>>>  > meta-networking layer.
>>>  >
>>>  > Signed-off-by: Jagadeesh Krishnanjanappa
>>>  mailto:jkrishnanjana...@mvista.com>>
>>>  > ---
>>>  >  ...-path-of-header-files-check-in-Yocto-buil.patch |  47
>>> +
>>>  >  .../tgt/files/0001-usr-Makefile-WARNING-fix.patch  |  29 ++
>>>  >  .../recipes-support/tgt/files/tgtd.init| 116
>>>  +
>>>  >  ...Makefile-apply-LDFLAGS-to-all-executables.patch |  35 +++
>>>  >  meta-networking/recipes-support/tgt/tgt_git.bb
>>>   |  73 +
>>>  >  5 files changed, 300 insertions(+)
>>>  >  create mode 100644
>>>
>>> meta-networking/recipes-support/tgt/files/0001-Correct-the-path-of-header-files-check-in-Yocto-buil.patch
>>>  >  create mode 100644
>>>
>>> meta-networking/recipes-support/tgt/files/0001-usr-Makefile-WARNING-fix.patch
>>>  >  create mode 100644
>>>  meta-networking/recipes-support/tgt/files/tgtd.init
>>>  >  create mode 100644
>>>
>>> meta-networking/recipes-support/tgt/files/usr-Makefile-apply-LDFLAGS-to-all-executables.patch
>>>  >  create mode 100644 meta-networking/recipes-support/tgt/tgt_git.bb
>>>  
>>>  >
>>>  > diff --git
>>>
>>>

Re: [oe] [meta-networking][PATCH] tgt: Migrate recipe from meta-openstack layer

2018-07-15 Thread Yu, Mingli 



On 2018年07月14日 02:47, Khem Raj wrote:

On 7/13/18 12:35 PM, Jagadeesh Krishnanjanappa wrote:

Yes, we need to copy libconfig-general-perl recipe (from meta-openstack) to
meta-networking as well.

Bruce comment:
We have specific version requirements with openstack, so we'll keep the
original
recipe in place in meta-openstack, so you might want to change the short
log of
your patch to "copy recipe from meta-openstack".

Since tgt recipe will continue to exists under meta-openstack layer as
per above comment,
copying it under meta-networking would create duplication. Is it OK?



this is SCSI target framework, in my mind this is neither openstack
specific nor networking specific. same is true for
libconfig-general-perl, however if there are no users of this outside
openstack layer users then its better it stays there, otherwise it
should move to meta-oe


If we won't support the iscsitarget in the future as it needs too much 
change to work with kernel >= 4.14, it should be convenient to move tgt 
to meta-oe.


Thanks,




Regards,
Jagadeesh

On Thu, Jul 12, 2018 at 7:44 PM, Khem Raj mailto:raj.k...@gmail.com>> wrote:

 I guess more recipes needs to be migrated. This fails with

 ERROR: Nothing RPROVIDES 'libconfig-general-perl' (but
 
/mnt/a/oe/sources/meta-openembedded/meta-networking/recipes-support/tgt/tgt_git.bb
 
 RDEPENDS on or otherwise requires it)
 NOTE: Runtime target 'libconfig-general-perl' is unbuildable,
 removing...
 Missing or unbuildable dependency chain was: ['libconfig-general-perl']
 NOTE: Runtime target 'tgt' is unbuildable, removing...
 Missing or unbuildable dependency chain was: ['tgt',
 'libconfig-general-perl']
 ERROR: Nothing RPROVIDES 'tgt-dev' (but
 
/mnt/a/oe/sources/meta-openembedded/meta-networking/recipes-support/tgt/tgt_git.bb
 
 RDEPENDS on or otherwise requires it)
 No eligible RPROVIDERs exist for 'tgt-dev'
 NOTE: Runtime target 'tgt-dev' is unbuildable, removing...
 Missing or unbuildable dependency chain was: ['tgt-dev']


 On Sat, Jul 7, 2018 at 11:26 AM Jagadeesh Krishnanjanappa
 mailto:jkrishnanjana...@mvista.com>>
 wrote:
 >
 > As iscsitarget cannot be built with Linux kernel >= 4.14, so
 > migrate Linux SCSI target framework (tgt) recipe from meta-openstack
 > layer; to allow users to test iSCSI target feature with tgt in
 > meta-networking layer.
 >
 > Signed-off-by: Jagadeesh Krishnanjanappa
 mailto:jkrishnanjana...@mvista.com>>
 > ---
 >  ...-path-of-header-files-check-in-Yocto-buil.patch |  47 +
 >  .../tgt/files/0001-usr-Makefile-WARNING-fix.patch  |  29 ++
 >  .../recipes-support/tgt/files/tgtd.init| 116
 +
 >  ...Makefile-apply-LDFLAGS-to-all-executables.patch |  35 +++
 >  meta-networking/recipes-support/tgt/tgt_git.bb
  |  73 +
 >  5 files changed, 300 insertions(+)
 >  create mode 100644
 
meta-networking/recipes-support/tgt/files/0001-Correct-the-path-of-header-files-check-in-Yocto-buil.patch
 >  create mode 100644
 
meta-networking/recipes-support/tgt/files/0001-usr-Makefile-WARNING-fix.patch
 >  create mode 100644
 meta-networking/recipes-support/tgt/files/tgtd.init
 >  create mode 100644
 
meta-networking/recipes-support/tgt/files/usr-Makefile-apply-LDFLAGS-to-all-executables.patch
 >  create mode 100644 meta-networking/recipes-support/tgt/tgt_git.bb
 
 >
 > diff --git
 
a/meta-networking/recipes-support/tgt/files/0001-Correct-the-path-of-header-files-check-in-Yocto-buil.patch
 
b/meta-networking/recipes-support/tgt/files/0001-Correct-the-path-of-header-files-check-in-Yocto-buil.patch
 > new file mode 100644
 > index 000..173ecb6
 > --- /dev/null
 > +++
 
b/meta-networking/recipes-support/tgt/files/0001-Correct-the-path-of-header-files-check-in-Yocto-buil.patch
 > @@ -0,0 +1,47 @@
 > +From 93fea40915d01be6d02587a0b8be85a642e6a8d5 Mon Sep 17 00:00:00
 2001
 > +From: Zhenhua Luo mailto:zhenhua@freescale.com>>
 > +Date: Thu, 10 Apr 2014 11:26:39 +0800
 > +Subject: [PATCH] Correct the path of header files check in Yocto
 build env
 > +
 > +Upstream-Status: Inappropriate [the fix is specific to Yocto
 build env]
 > +
 > +Current Makefile will check headers on host instead of Yocto
 sysroot, following
 > +error appears. Change the path of header check.
 > +| bs_aio.c:34:20: fatal error: libaio.h: No such file or directory
 > +| #include 
 > +| ^
 > +| compilation terminated.
 > +
 > +Signed-off-by: Zhenhua Luo mailto:zhenhua@freescale.com>>
 > +
 > +---
 > + usr/Makefile | 6 +++---
 > + 1 file changed, 3 insertions(+), 3 deletions(-)
 > +
 > +diff --git

Re: [oe] [meta-networking][PATCH] tgt: Migrate recipe from meta-openstack layer

2018-07-13 Thread Khem Raj 
On 7/13/18 12:35 PM, Jagadeesh Krishnanjanappa wrote:
> Yes, we need to copy libconfig-general-perl recipe (from meta-openstack) to
> meta-networking as well.
> 
> Bruce comment:
> We have specific version requirements with openstack, so we'll keep the
> original
> recipe in place in meta-openstack, so you might want to change the short
> log of
> your patch to "copy recipe from meta-openstack".
> 
> Since tgt recipe will continue to exists under meta-openstack layer as
> per above comment,
> copying it under meta-networking would create duplication. Is it OK?
> 

this is SCSI target framework, in my mind this is neither openstack
specific nor networking specific. same is true for
libconfig-general-perl, however if there are no users of this outside
openstack layer users then its better it stays there, otherwise it
should move to meta-oe

> Regards,
> Jagadeesh
> 
> On Thu, Jul 12, 2018 at 7:44 PM, Khem Raj  > wrote:
> 
> I guess more recipes needs to be migrated. This fails with
> 
> ERROR: Nothing RPROVIDES 'libconfig-general-perl' (but
> 
> /mnt/a/oe/sources/meta-openembedded/meta-networking/recipes-support/tgt/tgt_git.bb
> 
> RDEPENDS on or otherwise requires it)
> NOTE: Runtime target 'libconfig-general-perl' is unbuildable,
> removing...
> Missing or unbuildable dependency chain was: ['libconfig-general-perl']
> NOTE: Runtime target 'tgt' is unbuildable, removing...
> Missing or unbuildable dependency chain was: ['tgt',
> 'libconfig-general-perl']
> ERROR: Nothing RPROVIDES 'tgt-dev' (but
> 
> /mnt/a/oe/sources/meta-openembedded/meta-networking/recipes-support/tgt/tgt_git.bb
> 
> RDEPENDS on or otherwise requires it)
> No eligible RPROVIDERs exist for 'tgt-dev'
> NOTE: Runtime target 'tgt-dev' is unbuildable, removing...
> Missing or unbuildable dependency chain was: ['tgt-dev']
> 
> 
> On Sat, Jul 7, 2018 at 11:26 AM Jagadeesh Krishnanjanappa
> mailto:jkrishnanjana...@mvista.com>>
> wrote:
> >
> > As iscsitarget cannot be built with Linux kernel >= 4.14, so
> > migrate Linux SCSI target framework (tgt) recipe from meta-openstack
> > layer; to allow users to test iSCSI target feature with tgt in
> > meta-networking layer.
> >
> > Signed-off-by: Jagadeesh Krishnanjanappa
> mailto:jkrishnanjana...@mvista.com>>
> > ---
> >  ...-path-of-header-files-check-in-Yocto-buil.patch |  47 +
> >  .../tgt/files/0001-usr-Makefile-WARNING-fix.patch  |  29 ++
> >  .../recipes-support/tgt/files/tgtd.init            | 116
> +
> >  ...Makefile-apply-LDFLAGS-to-all-executables.patch |  35 +++
> >  meta-networking/recipes-support/tgt/tgt_git.bb
>      |  73 +
> >  5 files changed, 300 insertions(+)
> >  create mode 100644
> 
> meta-networking/recipes-support/tgt/files/0001-Correct-the-path-of-header-files-check-in-Yocto-buil.patch
> >  create mode 100644
> 
> meta-networking/recipes-support/tgt/files/0001-usr-Makefile-WARNING-fix.patch
> >  create mode 100644
> meta-networking/recipes-support/tgt/files/tgtd.init
> >  create mode 100644
> 
> meta-networking/recipes-support/tgt/files/usr-Makefile-apply-LDFLAGS-to-all-executables.patch
> >  create mode 100644 meta-networking/recipes-support/tgt/tgt_git.bb
> 
> >
> > diff --git
> 
> a/meta-networking/recipes-support/tgt/files/0001-Correct-the-path-of-header-files-check-in-Yocto-buil.patch
> 
> b/meta-networking/recipes-support/tgt/files/0001-Correct-the-path-of-header-files-check-in-Yocto-buil.patch
> > new file mode 100644
> > index 000..173ecb6
> > --- /dev/null
> > +++
> 
> b/meta-networking/recipes-support/tgt/files/0001-Correct-the-path-of-header-files-check-in-Yocto-buil.patch
> > @@ -0,0 +1,47 @@
> > +From 93fea40915d01be6d02587a0b8be85a642e6a8d5 Mon Sep 17 00:00:00
> 2001
> > +From: Zhenhua Luo  >
> > +Date: Thu, 10 Apr 2014 11:26:39 +0800
> > +Subject: [PATCH] Correct the path of header files check in Yocto
> build env
> > +
> > +Upstream-Status: Inappropriate [the fix is specific to Yocto
> build env]
> > +
> > +Current Makefile will check headers on host instead of Yocto
> sysroot, following
> > +error appears. Change the path of header check.
> > +| bs_aio.c:34:20: fatal error: libaio.h: No such file or directory
> > +| #include 
> > +|                     ^
> > +| compilation terminated.
> > +
> > +Signed-off-by: Zhenhua Luo  >
> > +
> > +---
> > + usr/Makefile | 6 +++---
> > + 1 file changed, 3 insertions(+), 3 deletions(-)
> > +
> > +diff --git a/usr/Makefile b/usr/Makefile
> > +index decf13c..9ff8f15

Re: [oe] [meta-networking][PATCH] tgt: Migrate recipe from meta-openstack layer

2018-07-12 Thread Khem Raj 
I guess more recipes needs to be migrated. This fails with

ERROR: Nothing RPROVIDES 'libconfig-general-perl' (but
/mnt/a/oe/sources/meta-openembedded/meta-networking/recipes-support/tgt/tgt_git.bb
RDEPENDS on or otherwise requires it)
NOTE: Runtime target 'libconfig-general-perl' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['libconfig-general-perl']
NOTE: Runtime target 'tgt' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['tgt', 'libconfig-general-perl']
ERROR: Nothing RPROVIDES 'tgt-dev' (but
/mnt/a/oe/sources/meta-openembedded/meta-networking/recipes-support/tgt/tgt_git.bb
RDEPENDS on or otherwise requires it)
No eligible RPROVIDERs exist for 'tgt-dev'
NOTE: Runtime target 'tgt-dev' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['tgt-dev']


On Sat, Jul 7, 2018 at 11:26 AM Jagadeesh Krishnanjanappa
 wrote:
>
> As iscsitarget cannot be built with Linux kernel >= 4.14, so
> migrate Linux SCSI target framework (tgt) recipe from meta-openstack
> layer; to allow users to test iSCSI target feature with tgt in
> meta-networking layer.
>
> Signed-off-by: Jagadeesh Krishnanjanappa 
> ---
>  ...-path-of-header-files-check-in-Yocto-buil.patch |  47 +
>  .../tgt/files/0001-usr-Makefile-WARNING-fix.patch  |  29 ++
>  .../recipes-support/tgt/files/tgtd.init| 116 
> +
>  ...Makefile-apply-LDFLAGS-to-all-executables.patch |  35 +++
>  meta-networking/recipes-support/tgt/tgt_git.bb |  73 +
>  5 files changed, 300 insertions(+)
>  create mode 100644 
> meta-networking/recipes-support/tgt/files/0001-Correct-the-path-of-header-files-check-in-Yocto-buil.patch
>  create mode 100644 
> meta-networking/recipes-support/tgt/files/0001-usr-Makefile-WARNING-fix.patch
>  create mode 100644 meta-networking/recipes-support/tgt/files/tgtd.init
>  create mode 100644 
> meta-networking/recipes-support/tgt/files/usr-Makefile-apply-LDFLAGS-to-all-executables.patch
>  create mode 100644 meta-networking/recipes-support/tgt/tgt_git.bb
>
> diff --git 
> a/meta-networking/recipes-support/tgt/files/0001-Correct-the-path-of-header-files-check-in-Yocto-buil.patch
>  
> b/meta-networking/recipes-support/tgt/files/0001-Correct-the-path-of-header-files-check-in-Yocto-buil.patch
> new file mode 100644
> index 000..173ecb6
> --- /dev/null
> +++ 
> b/meta-networking/recipes-support/tgt/files/0001-Correct-the-path-of-header-files-check-in-Yocto-buil.patch
> @@ -0,0 +1,47 @@
> +From 93fea40915d01be6d02587a0b8be85a642e6a8d5 Mon Sep 17 00:00:00 2001
> +From: Zhenhua Luo 
> +Date: Thu, 10 Apr 2014 11:26:39 +0800
> +Subject: [PATCH] Correct the path of header files check in Yocto build env
> +
> +Upstream-Status: Inappropriate [the fix is specific to Yocto build env]
> +
> +Current Makefile will check headers on host instead of Yocto sysroot, 
> following
> +error appears. Change the path of header check.
> +| bs_aio.c:34:20: fatal error: libaio.h: No such file or directory
> +| #include 
> +| ^
> +| compilation terminated.
> +
> +Signed-off-by: Zhenhua Luo 
> +
> +---
> + usr/Makefile | 6 +++---
> + 1 file changed, 3 insertions(+), 3 deletions(-)
> +
> +diff --git a/usr/Makefile b/usr/Makefile
> +index decf13c..9ff8f15 100644
> +--- a/usr/Makefile
>  b/usr/Makefile
> +@@ -1,11 +1,11 @@
> + sbindir ?= $(PREFIX)/sbin
> + libdir ?= $(PREFIX)/lib/tgt
> +
> +-ifneq ($(shell test -e /usr/include/linux/signalfd.h && echo 1),)
> ++ifneq ($(shell test -e $(SYSROOT)/usr/include/linux/signalfd.h && echo 1),)
> + CFLAGS += -DUSE_SIGNALFD
> + endif
> +
> +-ifneq ($(shell test -n $(shell find /usr/include -name "timerfd.h" | head 
> -n1) && echo 1),)
> ++ifneq ($(shell test -n $(shell find $(SYSROOT)/usr/include -name 
> "timerfd.h" | head -n1) && echo 1),)
> + CFLAGS += -DUSE_TIMERFD
> + endif
> +
> +@@ -25,7 +25,7 @@ ifneq ($(SD_NOTIFY),)
> + CFLAGS += -DUSE_SYSTEMD
> + endif
> +
> +-ifneq ($(shell test -e /usr/include/sys/eventfd.h && test -e 
> /usr/include/libaio.h && echo 1),)
> ++ifneq ($(shell test -e $(SYSROOT)/usr/include/sys/eventfd.h && test -e 
> $(SYSROOT)/usr/include/libaio.h && echo 1),)
> + CFLAGS += -DUSE_EVENTFD
> + TGTD_OBJS += bs_aio.o
> + LIBS += -laio
> diff --git 
> a/meta-networking/recipes-support/tgt/files/0001-usr-Makefile-WARNING-fix.patch
>  
> b/meta-networking/recipes-support/tgt/files/0001-usr-Makefile-WARNING-fix.patch
> new file mode 100644
> index 000..078ba9e
> --- /dev/null
> +++ 
> b/meta-networking/recipes-support/tgt/files/0001-usr-Makefile-WARNING-fix.patch
> @@ -0,0 +1,29 @@
> +From 6f4e3b11c7dccf83e2d18635c84837b212dfcc1c Mon Sep 17 00:00:00 2001
> +From: Li xin 
> +Date: Sun, 26 Jul 2015 04:23:51 +0900
> +Subject: [PATCH] usr/Makefile: WARNING fix WARNING: QA Issue: tgt:
> + /work/i586-oe-linux/tgt/1.0.60+gitAUTOINC+ab51727a36-r0/
> + packages-split/tgt/usr/sbin/tgtd contains probably-redundant RPATH /usr/lib
> + [useless-rpaths]
> +
>

Re: [oe] [meta-networking][PATCH] tgt: Migrate recipe from meta-openstack layer

2018-07-07 Thread Jagadeesh Krishnanjanappa 
Hi Bruce,

Nothing breaks if tgt recipe exists in meta-openstack or in meta-networking
layer.
It requires sg3-utils (which is part of meta-oe), so meta-openstack layer
needs
layer dependency on meta-oe.

We thought having tgt in meta-networking layer would help users verify
iscsi target/multipath feature, just as they were doing with iscsitarget
recipe. If
tgt under meta-openstack receives updates regularly, we are fine to keep it
there.

Regards,
Jagadeesh


On Sun, Jul 8, 2018 at 2:31 AM, Bruce Ashfield 
wrote:

> On Sat, Jul 7, 2018 at 4:54 PM, Bruce Ashfield 
> wrote:
> > On Sat, Jul 7, 2018 at 1:25 PM, Jagadeesh Krishnanjanappa
> >  wrote:
> >> As iscsitarget cannot be built with Linux kernel >= 4.14, so
> >> migrate Linux SCSI target framework (tgt) recipe from meta-openstack
> >> layer; to allow users to test iSCSI target feature with tgt in
> >> meta-networking layer.
> >
> > What error is including the meta-openstack layer causing ? i.e. is
> > there an issue of
> > non-compliance that should be fixed ?
>
> never mind. I see it wasn't that the openstack layer was causing a problem,
> just that you were asked about doing the copy.
>
> I'll have to run meta-openstack through compliance anyway, I was just
> hoping there were existing hints on breakage.
>
> Cheers,
>
> Bruce
>
> >
> > We have specific version requirements with openstack, so we'll keep the
> original
> > recipe in place in meta-openstack, so you might want to change the short
> log of
> > your patch to "copy recipe from meta-openstack".
> >
> > Cheers,
> >
> > Bruce
> >
> >>
> >> Signed-off-by: Jagadeesh Krishnanjanappa 
> >> ---
> >>  ...-path-of-header-files-check-in-Yocto-buil.patch |  47 +
> >>  .../tgt/files/0001-usr-Makefile-WARNING-fix.patch  |  29 ++
> >>  .../recipes-support/tgt/files/tgtd.init| 116
> +
> >>  ...Makefile-apply-LDFLAGS-to-all-executables.patch |  35 +++
> >>  meta-networking/recipes-support/tgt/tgt_git.bb |  73 +
> >>  5 files changed, 300 insertions(+)
> >>  create mode 100644 meta-networking/recipes-support/tgt/files/0001-
> Correct-the-path-of-header-files-check-in-Yocto-buil.patch
> >>  create mode 100644 meta-networking/recipes-support/tgt/files/0001-usr-
> Makefile-WARNING-fix.patch
> >>  create mode 100644 meta-networking/recipes-support/tgt/files/tgtd.init
> >>  create mode 100644 meta-networking/recipes-support/tgt/files/usr-
> Makefile-apply-LDFLAGS-to-all-executables.patch
> >>  create mode 100644 meta-networking/recipes-support/tgt/tgt_git.bb
> >>
> >> diff --git a/meta-networking/recipes-support/tgt/files/0001-
> Correct-the-path-of-header-files-check-in-Yocto-buil.patch
> b/meta-networking/recipes-support/tgt/files/0001-
> Correct-the-path-of-header-files-check-in-Yocto-buil.patch
> >> new file mode 100644
> >> index 000..173ecb6
> >> --- /dev/null
> >> +++ b/meta-networking/recipes-support/tgt/files/0001-
> Correct-the-path-of-header-files-check-in-Yocto-buil.patch
> >> @@ -0,0 +1,47 @@
> >> +From 93fea40915d01be6d02587a0b8be85a642e6a8d5 Mon Sep 17 00:00:00 2001
> >> +From: Zhenhua Luo 
> >> +Date: Thu, 10 Apr 2014 11:26:39 +0800
> >> +Subject: [PATCH] Correct the path of header files check in Yocto build
> env
> >> +
> >> +Upstream-Status: Inappropriate [the fix is specific to Yocto build env]
> >> +
> >> +Current Makefile will check headers on host instead of Yocto sysroot,
> following
> >> +error appears. Change the path of header check.
> >> +| bs_aio.c:34:20: fatal error: libaio.h: No such file or directory
> >> +| #include 
> >> +| ^
> >> +| compilation terminated.
> >> +
> >> +Signed-off-by: Zhenhua Luo 
> >> +
> >> +---
> >> + usr/Makefile | 6 +++---
> >> + 1 file changed, 3 insertions(+), 3 deletions(-)
> >> +
> >> +diff --git a/usr/Makefile b/usr/Makefile
> >> +index decf13c..9ff8f15 100644
> >> +--- a/usr/Makefile
> >>  b/usr/Makefile
> >> +@@ -1,11 +1,11 @@
> >> + sbindir ?= $(PREFIX)/sbin
> >> + libdir ?= $(PREFIX)/lib/tgt
> >> +
> >> +-ifneq ($(shell test -e /usr/include/linux/signalfd.h && echo 1),)
> >> ++ifneq ($(shell test -e $(SYSROOT)/usr/include/linux/signalfd.h &&
> echo 1),)
> >> + CFLAGS += -DUSE_SIGNALFD
> >> + endif
> >> +
> >> +-ifneq ($(shell test -n $(shell find /usr/include -name "timerfd.h" |
> head -n1) && echo 1),)
> >> ++ifneq ($(shell test -n $(shell find $(SYSROOT)/usr/include -name
> "timerfd.h" | head -n1) && echo 1),)
> >> + CFLAGS += -DUSE_TIMERFD
> >> + endif
> >> +
> >> +@@ -25,7 +25,7 @@ ifneq ($(SD_NOTIFY),)
> >> + CFLAGS += -DUSE_SYSTEMD
> >> + endif
> >> +
> >> +-ifneq ($(shell test -e /usr/include/sys/eventfd.h && test -e
> /usr/include/libaio.h && echo 1),)
> >> ++ifneq ($(shell test -e $(SYSROOT)/usr/include/sys/eventfd.h && test
> -e $(SYSROOT)/usr/include/libaio.h && echo 1),)
> >> + CFLAGS += -DUSE_EVENTFD
> >> + TGTD_OBJS += bs_aio.o
> >> + LIBS += -laio
> >> diff --git 
> >>

Re: [oe] [meta-networking][PATCH] tgt: Migrate recipe from meta-openstack layer

2018-07-07 Thread Bruce Ashfield 
On Sat, Jul 7, 2018 at 4:54 PM, Bruce Ashfield  wrote:
> On Sat, Jul 7, 2018 at 1:25 PM, Jagadeesh Krishnanjanappa
>  wrote:
>> As iscsitarget cannot be built with Linux kernel >= 4.14, so
>> migrate Linux SCSI target framework (tgt) recipe from meta-openstack
>> layer; to allow users to test iSCSI target feature with tgt in
>> meta-networking layer.
>
> What error is including the meta-openstack layer causing ? i.e. is
> there an issue of
> non-compliance that should be fixed ?

never mind. I see it wasn't that the openstack layer was causing a problem,
just that you were asked about doing the copy.

I'll have to run meta-openstack through compliance anyway, I was just
hoping there were existing hints on breakage.

Cheers,

Bruce

>
> We have specific version requirements with openstack, so we'll keep the 
> original
> recipe in place in meta-openstack, so you might want to change the short log 
> of
> your patch to "copy recipe from meta-openstack".
>
> Cheers,
>
> Bruce
>
>>
>> Signed-off-by: Jagadeesh Krishnanjanappa 
>> ---
>>  ...-path-of-header-files-check-in-Yocto-buil.patch |  47 +
>>  .../tgt/files/0001-usr-Makefile-WARNING-fix.patch  |  29 ++
>>  .../recipes-support/tgt/files/tgtd.init| 116 
>> +
>>  ...Makefile-apply-LDFLAGS-to-all-executables.patch |  35 +++
>>  meta-networking/recipes-support/tgt/tgt_git.bb |  73 +
>>  5 files changed, 300 insertions(+)
>>  create mode 100644 
>> meta-networking/recipes-support/tgt/files/0001-Correct-the-path-of-header-files-check-in-Yocto-buil.patch
>>  create mode 100644 
>> meta-networking/recipes-support/tgt/files/0001-usr-Makefile-WARNING-fix.patch
>>  create mode 100644 meta-networking/recipes-support/tgt/files/tgtd.init
>>  create mode 100644 
>> meta-networking/recipes-support/tgt/files/usr-Makefile-apply-LDFLAGS-to-all-executables.patch
>>  create mode 100644 meta-networking/recipes-support/tgt/tgt_git.bb
>>
>> diff --git 
>> a/meta-networking/recipes-support/tgt/files/0001-Correct-the-path-of-header-files-check-in-Yocto-buil.patch
>>  
>> b/meta-networking/recipes-support/tgt/files/0001-Correct-the-path-of-header-files-check-in-Yocto-buil.patch
>> new file mode 100644
>> index 000..173ecb6
>> --- /dev/null
>> +++ 
>> b/meta-networking/recipes-support/tgt/files/0001-Correct-the-path-of-header-files-check-in-Yocto-buil.patch
>> @@ -0,0 +1,47 @@
>> +From 93fea40915d01be6d02587a0b8be85a642e6a8d5 Mon Sep 17 00:00:00 2001
>> +From: Zhenhua Luo 
>> +Date: Thu, 10 Apr 2014 11:26:39 +0800
>> +Subject: [PATCH] Correct the path of header files check in Yocto build env
>> +
>> +Upstream-Status: Inappropriate [the fix is specific to Yocto build env]
>> +
>> +Current Makefile will check headers on host instead of Yocto sysroot, 
>> following
>> +error appears. Change the path of header check.
>> +| bs_aio.c:34:20: fatal error: libaio.h: No such file or directory
>> +| #include 
>> +| ^
>> +| compilation terminated.
>> +
>> +Signed-off-by: Zhenhua Luo 
>> +
>> +---
>> + usr/Makefile | 6 +++---
>> + 1 file changed, 3 insertions(+), 3 deletions(-)
>> +
>> +diff --git a/usr/Makefile b/usr/Makefile
>> +index decf13c..9ff8f15 100644
>> +--- a/usr/Makefile
>>  b/usr/Makefile
>> +@@ -1,11 +1,11 @@
>> + sbindir ?= $(PREFIX)/sbin
>> + libdir ?= $(PREFIX)/lib/tgt
>> +
>> +-ifneq ($(shell test -e /usr/include/linux/signalfd.h && echo 1),)
>> ++ifneq ($(shell test -e $(SYSROOT)/usr/include/linux/signalfd.h && echo 1),)
>> + CFLAGS += -DUSE_SIGNALFD
>> + endif
>> +
>> +-ifneq ($(shell test -n $(shell find /usr/include -name "timerfd.h" | head 
>> -n1) && echo 1),)
>> ++ifneq ($(shell test -n $(shell find $(SYSROOT)/usr/include -name 
>> "timerfd.h" | head -n1) && echo 1),)
>> + CFLAGS += -DUSE_TIMERFD
>> + endif
>> +
>> +@@ -25,7 +25,7 @@ ifneq ($(SD_NOTIFY),)
>> + CFLAGS += -DUSE_SYSTEMD
>> + endif
>> +
>> +-ifneq ($(shell test -e /usr/include/sys/eventfd.h && test -e 
>> /usr/include/libaio.h && echo 1),)
>> ++ifneq ($(shell test -e $(SYSROOT)/usr/include/sys/eventfd.h && test -e 
>> $(SYSROOT)/usr/include/libaio.h && echo 1),)
>> + CFLAGS += -DUSE_EVENTFD
>> + TGTD_OBJS += bs_aio.o
>> + LIBS += -laio
>> diff --git 
>> a/meta-networking/recipes-support/tgt/files/0001-usr-Makefile-WARNING-fix.patch
>>  
>> b/meta-networking/recipes-support/tgt/files/0001-usr-Makefile-WARNING-fix.patch
>> new file mode 100644
>> index 000..078ba9e
>> --- /dev/null
>> +++ 
>> b/meta-networking/recipes-support/tgt/files/0001-usr-Makefile-WARNING-fix.patch
>> @@ -0,0 +1,29 @@
>> +From 6f4e3b11c7dccf83e2d18635c84837b212dfcc1c Mon Sep 17 00:00:00 2001
>> +From: Li xin 
>> +Date: Sun, 26 Jul 2015 04:23:51 +0900
>> +Subject: [PATCH] usr/Makefile: WARNING fix WARNING: QA Issue: tgt:
>> + /work/i586-oe-linux/tgt/1.0.60+gitAUTOINC+ab51727a36-r0/
>> + packages-split/tgt/usr/sbin/tgtd contains probably-redundant RPATH /usr/lib
>> + [useless-rpaths]
>> +
>> +Upstream-Status: pending
>> +
>> +Signed-off-by: Li

Re: [oe] [meta-networking][PATCH] tgt: Migrate recipe from meta-openstack layer

2018-07-07 Thread Bruce Ashfield 
On Sat, Jul 7, 2018 at 1:25 PM, Jagadeesh Krishnanjanappa
 wrote:
> As iscsitarget cannot be built with Linux kernel >= 4.14, so
> migrate Linux SCSI target framework (tgt) recipe from meta-openstack
> layer; to allow users to test iSCSI target feature with tgt in
> meta-networking layer.

What error is including the meta-openstack layer causing ? i.e. is
there an issue of
non-compliance that should be fixed ?

We have specific version requirements with openstack, so we'll keep the original
recipe in place in meta-openstack, so you might want to change the short log of
your patch to "copy recipe from meta-openstack".

Cheers,

Bruce

>
> Signed-off-by: Jagadeesh Krishnanjanappa 
> ---
>  ...-path-of-header-files-check-in-Yocto-buil.patch |  47 +
>  .../tgt/files/0001-usr-Makefile-WARNING-fix.patch  |  29 ++
>  .../recipes-support/tgt/files/tgtd.init| 116 
> +
>  ...Makefile-apply-LDFLAGS-to-all-executables.patch |  35 +++
>  meta-networking/recipes-support/tgt/tgt_git.bb |  73 +
>  5 files changed, 300 insertions(+)
>  create mode 100644 
> meta-networking/recipes-support/tgt/files/0001-Correct-the-path-of-header-files-check-in-Yocto-buil.patch
>  create mode 100644 
> meta-networking/recipes-support/tgt/files/0001-usr-Makefile-WARNING-fix.patch
>  create mode 100644 meta-networking/recipes-support/tgt/files/tgtd.init
>  create mode 100644 
> meta-networking/recipes-support/tgt/files/usr-Makefile-apply-LDFLAGS-to-all-executables.patch
>  create mode 100644 meta-networking/recipes-support/tgt/tgt_git.bb
>
> diff --git 
> a/meta-networking/recipes-support/tgt/files/0001-Correct-the-path-of-header-files-check-in-Yocto-buil.patch
>  
> b/meta-networking/recipes-support/tgt/files/0001-Correct-the-path-of-header-files-check-in-Yocto-buil.patch
> new file mode 100644
> index 000..173ecb6
> --- /dev/null
> +++ 
> b/meta-networking/recipes-support/tgt/files/0001-Correct-the-path-of-header-files-check-in-Yocto-buil.patch
> @@ -0,0 +1,47 @@
> +From 93fea40915d01be6d02587a0b8be85a642e6a8d5 Mon Sep 17 00:00:00 2001
> +From: Zhenhua Luo 
> +Date: Thu, 10 Apr 2014 11:26:39 +0800
> +Subject: [PATCH] Correct the path of header files check in Yocto build env
> +
> +Upstream-Status: Inappropriate [the fix is specific to Yocto build env]
> +
> +Current Makefile will check headers on host instead of Yocto sysroot, 
> following
> +error appears. Change the path of header check.
> +| bs_aio.c:34:20: fatal error: libaio.h: No such file or directory
> +| #include 
> +| ^
> +| compilation terminated.
> +
> +Signed-off-by: Zhenhua Luo 
> +
> +---
> + usr/Makefile | 6 +++---
> + 1 file changed, 3 insertions(+), 3 deletions(-)
> +
> +diff --git a/usr/Makefile b/usr/Makefile
> +index decf13c..9ff8f15 100644
> +--- a/usr/Makefile
>  b/usr/Makefile
> +@@ -1,11 +1,11 @@
> + sbindir ?= $(PREFIX)/sbin
> + libdir ?= $(PREFIX)/lib/tgt
> +
> +-ifneq ($(shell test -e /usr/include/linux/signalfd.h && echo 1),)
> ++ifneq ($(shell test -e $(SYSROOT)/usr/include/linux/signalfd.h && echo 1),)
> + CFLAGS += -DUSE_SIGNALFD
> + endif
> +
> +-ifneq ($(shell test -n $(shell find /usr/include -name "timerfd.h" | head 
> -n1) && echo 1),)
> ++ifneq ($(shell test -n $(shell find $(SYSROOT)/usr/include -name 
> "timerfd.h" | head -n1) && echo 1),)
> + CFLAGS += -DUSE_TIMERFD
> + endif
> +
> +@@ -25,7 +25,7 @@ ifneq ($(SD_NOTIFY),)
> + CFLAGS += -DUSE_SYSTEMD
> + endif
> +
> +-ifneq ($(shell test -e /usr/include/sys/eventfd.h && test -e 
> /usr/include/libaio.h && echo 1),)
> ++ifneq ($(shell test -e $(SYSROOT)/usr/include/sys/eventfd.h && test -e 
> $(SYSROOT)/usr/include/libaio.h && echo 1),)
> + CFLAGS += -DUSE_EVENTFD
> + TGTD_OBJS += bs_aio.o
> + LIBS += -laio
> diff --git 
> a/meta-networking/recipes-support/tgt/files/0001-usr-Makefile-WARNING-fix.patch
>  
> b/meta-networking/recipes-support/tgt/files/0001-usr-Makefile-WARNING-fix.patch
> new file mode 100644
> index 000..078ba9e
> --- /dev/null
> +++ 
> b/meta-networking/recipes-support/tgt/files/0001-usr-Makefile-WARNING-fix.patch
> @@ -0,0 +1,29 @@
> +From 6f4e3b11c7dccf83e2d18635c84837b212dfcc1c Mon Sep 17 00:00:00 2001
> +From: Li xin 
> +Date: Sun, 26 Jul 2015 04:23:51 +0900
> +Subject: [PATCH] usr/Makefile: WARNING fix WARNING: QA Issue: tgt:
> + /work/i586-oe-linux/tgt/1.0.60+gitAUTOINC+ab51727a36-r0/
> + packages-split/tgt/usr/sbin/tgtd contains probably-redundant RPATH /usr/lib
> + [useless-rpaths]
> +
> +Upstream-Status: pending
> +
> +Signed-off-by: Li Xin 
> +
> +---
> + usr/Makefile | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/usr/Makefile b/usr/Makefile
> +index 9ff8f15..cc8df11 100644
> +--- a/usr/Makefile
>  b/usr/Makefile
> +@@ -63,7 +63,7 @@ TGTD_OBJS += tgtd.o mgmt.o target.o scsi.o log.o driver.o 
> util.o work.o \
> +
> + TGTD_DEP = $(TGTD_OBJS:.o=.d)
> +
> +-LDFLAGS = -Wl,-E,-rpath=$(libdir)
> ++LDFLAGS += -Wl,-E
> +
> + .PHONY:all
> + all: