Re: [oe] [meta-oe][PATCH] enscript: set the correct path for perl

2017-08-28 Thread Huang, Jie (Jackie) 


> -Original Message-
> From: Khem Raj [mailto:raj.k...@gmail.com]
> Sent: Tuesday, August 29, 2017 09:11
> To: Huang, Jie (Jackie)
> Cc: openembeded-devel
> Subject: Re: [oe] [meta-oe][PATCH] enscript: set the correct path for perl
> 
> On Mon, Aug 28, 2017 at 6:07 PM, Huang, Jie (Jackie)
> <jackie.hu...@windriver.com> wrote:
> >
> >
> >> -Original Message-
> >> From: Khem Raj [mailto:raj.k...@gmail.com]
> >> Sent: Monday, August 28, 2017 23:26
> >> To: Huang, Jie (Jackie)
> >> Cc: openembeded-devel
> >> Subject: Re: [oe] [meta-oe][PATCH] enscript: set the correct path for perl
> >>
> >> On Sun, Aug 27, 2017 at 11:05 PM,  <jackie.hu...@windriver.com> wrote:
> >> > From: Jackie Huang <jackie.hu...@windriver.com>
> >> >
> >> > Set the correct path for perl and avoid
> >> > searching the one in hosttools that cause
> >> > QA issue:
> >> >
> >> > | ERROR: enscript-1.6.6-r0 do_package_qa: QA Issue: /usr/bin/diffpp
> >> >   contained in package enscript requires
> >> >   /builddir/tmp/hosttools/perl, but no providers found in
> RDEPENDS_enscript?
> >> [file-rdeps]
> >> >
> >>
> >> already fixed with https://patchwork.openembedded.org/patch/143281/
> >
> 
> I prefer the patch that I sent since that does not hardcode variables that
> configure should define.

I agree.

Thanks,
Jackie

> 
> > Got it, thanks!
> >
> > Thanks,
> > Jackie
> >
> >>
> >> > Signed-off-by: Jackie Huang <jackie.hu...@windriver.com>
> >> > ---
> >> >  meta-oe/recipes-extended/enscript/enscript_1.6.6.bb | 2 ++
> >> >  1 file changed, 2 insertions(+)
> >> >
> >> > diff --git a/meta-oe/recipes-extended/enscript/enscript_1.6.6.bb b/meta-
> >> oe/recipes-extended/enscript/enscript_1.6.6.bb
> >> > index 96129880a..65f1ccfa0 100644
> >> > --- a/meta-oe/recipes-extended/enscript/enscript_1.6.6.bb
> >> > +++ b/meta-oe/recipes-extended/enscript/enscript_1.6.6.bb
> >> > @@ -19,4 +19,6 @@ inherit autotools gettext
> >> >  SRC_URI[md5sum] = "3acc242b829adacabcaf28533f049afd"
> >> >  SRC_URI[sha256sum] =
> >>
> "6d56bada6934d055b34b6c90399aa85975e66457ac5bf513427ae7fc77f5c0bb"
> >> >
> >> > +CACHED_CONFIGUREVARS += "ac_cv_path_PERL=${bindir}/perl"
> >> > +
> >> >  RDEPENDS_${PN} = "perl"
> >> > --
> >> > 2.11.0
> >> >
> >> > --
> >> > ___
> >> > Openembedded-devel mailing list
> >> > Openembedded-devel@lists.openembedded.org
> >> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-oe][PATCH] enscript: set the correct path for perl

2017-08-28 Thread Huang, Jie (Jackie) 
Ok, please ignore mine if one of them is accepted.

Thanks,
Jackie

From: Martin Jansa [mailto:martin.ja...@gmail.com]
Sent: Tuesday, August 29, 2017 07:17
To: Khem Raj
Cc: Huang, Jie (Jackie); openembeded-devel
Subject: Re: [oe] [meta-oe][PATCH] enscript: set the correct path for perl

And also by:
https://patchwork.openembedded.org/patch/143340/

On Mon, Aug 28, 2017 at 5:26 PM, Khem Raj 
<raj.k...@gmail.com<mailto:raj.k...@gmail.com>> wrote:
On Sun, Aug 27, 2017 at 11:05 PM,  
<jackie.hu...@windriver.com<mailto:jackie.hu...@windriver.com>> wrote:
> From: Jackie Huang 
> <jackie.hu...@windriver.com<mailto:jackie.hu...@windriver.com>>
>
> Set the correct path for perl and avoid
> searching the one in hosttools that cause
> QA issue:
>
> | ERROR: enscript-1.6.6-r0 do_package_qa: QA Issue: /usr/bin/diffpp
>   contained in package enscript requires
>   /builddir/tmp/hosttools/perl, but no providers found in RDEPENDS_enscript? 
> [file-rdeps]
>

already fixed with https://patchwork.openembedded.org/patch/143281/

> Signed-off-by: Jackie Huang 
> <jackie.hu...@windriver.com<mailto:jackie.hu...@windriver.com>>
> ---
>  
> meta-oe/recipes-extended/enscript/enscript_1.6.6.bb<http://enscript_1.6.6.bb> 
> | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git 
> a/meta-oe/recipes-extended/enscript/enscript_1.6.6.bb<http://enscript_1.6.6.bb>
>  
> b/meta-oe/recipes-extended/enscript/enscript_1.6.6.bb<http://enscript_1.6.6.bb>
> index 96129880a..65f1ccfa0 100644
> --- 
> a/meta-oe/recipes-extended/enscript/enscript_1.6.6.bb<http://enscript_1.6.6.bb>
> +++ 
> b/meta-oe/recipes-extended/enscript/enscript_1.6.6.bb<http://enscript_1.6.6.bb>
> @@ -19,4 +19,6 @@ inherit autotools gettext
>  SRC_URI[md5sum] = "3acc242b829adacabcaf28533f049afd"
>  SRC_URI[sha256sum] = 
> "6d56bada6934d055b34b6c90399aa85975e66457ac5bf513427ae7fc77f5c0bb"
>
> +CACHED_CONFIGUREVARS += "ac_cv_path_PERL=${bindir}/perl"
> +
>  RDEPENDS_${PN} = "perl"
> --
> 2.11.0
>
> --
> ___
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org<mailto:Openembedded-devel@lists.openembedded.org>
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org<mailto:Openembedded-devel@lists.openembedded.org>
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-oe][PATCH] enscript: set the correct path for perl

2017-08-28 Thread Khem Raj 
On Mon, Aug 28, 2017 at 6:07 PM, Huang, Jie (Jackie)
<jackie.hu...@windriver.com> wrote:
>
>
>> -Original Message-
>> From: Khem Raj [mailto:raj.k...@gmail.com]
>> Sent: Monday, August 28, 2017 23:26
>> To: Huang, Jie (Jackie)
>> Cc: openembeded-devel
>> Subject: Re: [oe] [meta-oe][PATCH] enscript: set the correct path for perl
>>
>> On Sun, Aug 27, 2017 at 11:05 PM,  <jackie.hu...@windriver.com> wrote:
>> > From: Jackie Huang <jackie.hu...@windriver.com>
>> >
>> > Set the correct path for perl and avoid
>> > searching the one in hosttools that cause
>> > QA issue:
>> >
>> > | ERROR: enscript-1.6.6-r0 do_package_qa: QA Issue: /usr/bin/diffpp
>> >   contained in package enscript requires
>> >   /builddir/tmp/hosttools/perl, but no providers found in 
>> > RDEPENDS_enscript?
>> [file-rdeps]
>> >
>>
>> already fixed with https://patchwork.openembedded.org/patch/143281/
>

I prefer the patch that I sent since that does not hardcode variables that
configure should define.

> Got it, thanks!
>
> Thanks,
> Jackie
>
>>
>> > Signed-off-by: Jackie Huang <jackie.hu...@windriver.com>
>> > ---
>> >  meta-oe/recipes-extended/enscript/enscript_1.6.6.bb | 2 ++
>> >  1 file changed, 2 insertions(+)
>> >
>> > diff --git a/meta-oe/recipes-extended/enscript/enscript_1.6.6.bb b/meta-
>> oe/recipes-extended/enscript/enscript_1.6.6.bb
>> > index 96129880a..65f1ccfa0 100644
>> > --- a/meta-oe/recipes-extended/enscript/enscript_1.6.6.bb
>> > +++ b/meta-oe/recipes-extended/enscript/enscript_1.6.6.bb
>> > @@ -19,4 +19,6 @@ inherit autotools gettext
>> >  SRC_URI[md5sum] = "3acc242b829adacabcaf28533f049afd"
>> >  SRC_URI[sha256sum] =
>> "6d56bada6934d055b34b6c90399aa85975e66457ac5bf513427ae7fc77f5c0bb"
>> >
>> > +CACHED_CONFIGUREVARS += "ac_cv_path_PERL=${bindir}/perl"
>> > +
>> >  RDEPENDS_${PN} = "perl"
>> > --
>> > 2.11.0
>> >
>> > --
>> > ___
>> > Openembedded-devel mailing list
>> > Openembedded-devel@lists.openembedded.org
>> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-oe][PATCH] enscript: set the correct path for perl

2017-08-28 Thread Huang, Jie (Jackie) 


> -Original Message-
> From: Khem Raj [mailto:raj.k...@gmail.com]
> Sent: Monday, August 28, 2017 23:26
> To: Huang, Jie (Jackie)
> Cc: openembeded-devel
> Subject: Re: [oe] [meta-oe][PATCH] enscript: set the correct path for perl
> 
> On Sun, Aug 27, 2017 at 11:05 PM,  <jackie.hu...@windriver.com> wrote:
> > From: Jackie Huang <jackie.hu...@windriver.com>
> >
> > Set the correct path for perl and avoid
> > searching the one in hosttools that cause
> > QA issue:
> >
> > | ERROR: enscript-1.6.6-r0 do_package_qa: QA Issue: /usr/bin/diffpp
> >   contained in package enscript requires
> >   /builddir/tmp/hosttools/perl, but no providers found in RDEPENDS_enscript?
> [file-rdeps]
> >
> 
> already fixed with https://patchwork.openembedded.org/patch/143281/

Got it, thanks!

Thanks,
Jackie

> 
> > Signed-off-by: Jackie Huang <jackie.hu...@windriver.com>
> > ---
> >  meta-oe/recipes-extended/enscript/enscript_1.6.6.bb | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/meta-oe/recipes-extended/enscript/enscript_1.6.6.bb b/meta-
> oe/recipes-extended/enscript/enscript_1.6.6.bb
> > index 96129880a..65f1ccfa0 100644
> > --- a/meta-oe/recipes-extended/enscript/enscript_1.6.6.bb
> > +++ b/meta-oe/recipes-extended/enscript/enscript_1.6.6.bb
> > @@ -19,4 +19,6 @@ inherit autotools gettext
> >  SRC_URI[md5sum] = "3acc242b829adacabcaf28533f049afd"
> >  SRC_URI[sha256sum] =
> "6d56bada6934d055b34b6c90399aa85975e66457ac5bf513427ae7fc77f5c0bb"
> >
> > +CACHED_CONFIGUREVARS += "ac_cv_path_PERL=${bindir}/perl"
> > +
> >  RDEPENDS_${PN} = "perl"
> > --
> > 2.11.0
> >
> > --
> > ___
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-oe][PATCH] enscript: set the correct path for perl

2017-08-28 Thread Martin Jansa 
And also by:
https://patchwork.openembedded.org/patch/143340/

On Mon, Aug 28, 2017 at 5:26 PM, Khem Raj  wrote:

> On Sun, Aug 27, 2017 at 11:05 PM,   wrote:
> > From: Jackie Huang 
> >
> > Set the correct path for perl and avoid
> > searching the one in hosttools that cause
> > QA issue:
> >
> > | ERROR: enscript-1.6.6-r0 do_package_qa: QA Issue: /usr/bin/diffpp
> >   contained in package enscript requires
> >   /builddir/tmp/hosttools/perl, but no providers found in
> RDEPENDS_enscript? [file-rdeps]
> >
>
> already fixed with https://patchwork.openembedded.org/patch/143281/
>
> > Signed-off-by: Jackie Huang 
> > ---
> >  meta-oe/recipes-extended/enscript/enscript_1.6.6.bb | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/meta-oe/recipes-extended/enscript/enscript_1.6.6.bb
> b/meta-oe/recipes-extended/enscript/enscript_1.6.6.bb
> > index 96129880a..65f1ccfa0 100644
> > --- a/meta-oe/recipes-extended/enscript/enscript_1.6.6.bb
> > +++ b/meta-oe/recipes-extended/enscript/enscript_1.6.6.bb
> > @@ -19,4 +19,6 @@ inherit autotools gettext
> >  SRC_URI[md5sum] = "3acc242b829adacabcaf28533f049afd"
> >  SRC_URI[sha256sum] = "6d56bada6934d055b34b6c90399aa8
> 5975e66457ac5bf513427ae7fc77f5c0bb"
> >
> > +CACHED_CONFIGUREVARS += "ac_cv_path_PERL=${bindir}/perl"
> > +
> >  RDEPENDS_${PN} = "perl"
> > --
> > 2.11.0
> >
> > --
> > ___
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> --
> ___
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-oe][PATCH] enscript: set the correct path for perl

2017-08-28 Thread Khem Raj 
On Sun, Aug 27, 2017 at 11:05 PM,   wrote:
> From: Jackie Huang 
>
> Set the correct path for perl and avoid
> searching the one in hosttools that cause
> QA issue:
>
> | ERROR: enscript-1.6.6-r0 do_package_qa: QA Issue: /usr/bin/diffpp
>   contained in package enscript requires
>   /builddir/tmp/hosttools/perl, but no providers found in RDEPENDS_enscript? 
> [file-rdeps]
>

already fixed with https://patchwork.openembedded.org/patch/143281/

> Signed-off-by: Jackie Huang 
> ---
>  meta-oe/recipes-extended/enscript/enscript_1.6.6.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta-oe/recipes-extended/enscript/enscript_1.6.6.bb 
> b/meta-oe/recipes-extended/enscript/enscript_1.6.6.bb
> index 96129880a..65f1ccfa0 100644
> --- a/meta-oe/recipes-extended/enscript/enscript_1.6.6.bb
> +++ b/meta-oe/recipes-extended/enscript/enscript_1.6.6.bb
> @@ -19,4 +19,6 @@ inherit autotools gettext
>  SRC_URI[md5sum] = "3acc242b829adacabcaf28533f049afd"
>  SRC_URI[sha256sum] = 
> "6d56bada6934d055b34b6c90399aa85975e66457ac5bf513427ae7fc77f5c0bb"
>
> +CACHED_CONFIGUREVARS += "ac_cv_path_PERL=${bindir}/perl"
> +
>  RDEPENDS_${PN} = "perl"
> --
> 2.11.0
>
> --
> ___
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel