Re: [oe] [zeus 00/17] Patch review

2020-01-03 Thread akuster808



On 1/2/20 7:38 PM, Khem Raj wrote:
> On Thu, Jan 2, 2020 at 6:49 PM Armin Kuster  wrote:
>> Please have comments back by Saturday.
>>
>> The following changes since commit fbe4cf8d56eea586c096621e7c913b24bd99c9c6:
>>
>>   gtkwave: add the libtirpc dependence and config (2019-12-17 21:57:51 -0800)
>>
>> are available in the Git repository at:
>>
>>   https://git.openembedded.org/meta-openembedded-contrib stable/zeus-nut
>>   
>> http://cgit.openembedded.org/meta-openembedded-contrib/log/?h=stable/zeus-nut
>>
>> Adrian Bunk (3):
>>   networkmanager: Upgrade 1.18.2 -> 1.18.4
>>   gpsd: Backport a memory leak fix
>>   libqmi: Upgrade 1.24.0 -> 1.24.2
>>
>> Changqing Li (1):
>>   xfce-dusk-gtk3: correct invalid SRC_URI
>>
>> Hongxu Jia (1):
>>   python-more-itertools: downgrade 7.2.0 -> 5.0.0
>>
>> Kai Kang (1):
>>   fltk: fix build error when enable package config examples
>>
>> Khem Raj (9):
>>   grpc: Define libdir and cmakedir in terms of multilib
>>   tinyalsa: fix installation libdir path to match multilibs
>>   libqb: Add --enable-nosection-fallback with mips64/clang
>>   x11vnc: Fix build for 32bit arches with 64bit time_t
>>   evtest: Fix build for 32bit arches with 64bit time_t
>>   lirc: Fix build for 32bit arches with 64bit time_t
>>   utouch-evemu,utouch-frame: Fix build for 32bit arches with 64bit
>> time_t
>>   directfb: Fix build for 32bit arches with 64bit time_t
>>   ruli: Fix install step and build samples too
>>
> 64bit time_t fixes are not necessary but are not hurtful either, since the
> C libraries in zeus do not have the needed bits to enable 64bit time_t
> so unless someone else has issues with it, I am fine to bring them to zeus
will drop the 64bit time_t changes.

- armin
>
>> Stefan Agner (1):
>>   networkmanager: do not deploy unnecessary udev rule file
>>
>> zhangxiao (1):
>>   syslog-ng: Fix multilib header conflict - syslog-ng-config.h
>>
>>  .../recipes-multimedia/tinyalsa/tinyalsa.bb   |   4 +-
>>  ...L_-path-instead-of-hardcoding-bin-li.patch |  46 +
>>  ...ger_1.18.2.bb => networkmanager_1.18.4.bb} |   9 +-
>>  .../recipes-devtools/grpc/grpc_1.24.1.bb  |   4 +-
>>  ...-Fix-build-with-format-string-checks.patch |  29 ++-
>>  ...ake-space-for-flags-from-environment.patch |  95 +
>>  ...v-Mark-prev_addr_list_size-as-unused.patch |  35 
>>  .../recipes-support/ruli/files/Makefile.patch | 122 
>>  .../recipes-support/ruli/ruli_0.36.bb |  23 ++-
>>  .../{libqmi_1.24.0.bb => libqmi_1.24.2.bb}|   4 +-
>>  ...ld-on-32bit-arches-with-64bit-time_t.patch |  40 
>>  .../recipes-connectivity/lirc/lirc_0.9.4d.bb  |   1 +
>>  meta-oe/recipes-extended/libqb/libqb_1.0.5.bb |   6 +-
>>  .../recipes-graphics/directfb/directfb.inc|   3 +-
>>  ...ld-on-32bit-arches-with-64bit-time_t.patch | 139 +
>>  ...ld-on-32bit-arches-with-64bit-time_t.patch | 111 +++
>>  .../recipes-graphics/x11vnc/x11vnc_0.9.16.bb  |   5 +-
>>  .../0001-gps_shm_close-Free-privdata.patch|  37 
>>  meta-oe/recipes-navigation/gpsd/gpsd_3.19.bb  |   1 +
>>  meta-oe/recipes-support/fltk/fltk.bb  |   7 +-
>>  ...-when-enable-package-config-examples.patch | 182 ++
>>  .../recipes-support/syslog-ng/syslog-ng.inc   |   4 +-
>>  ...ld-on-32bit-arches-with-64bit-time_t.patch |  76 
>>  .../utouch/utouch-evemu_git.bb|   4 +-
>>  ...ld-on-32bit-arches-with-64bit-time_t.patch |  41 
>>  ...tat.h-for-fixing-build-issue-on-musl.patch |   0
>>  .../remove-man-page-creation.patch|   0
>>  .../utouch/utouch-frame_git.bb|   1 +
>>  ...ld-on-32bit-arches-with-64bit-time_t.patch |  41 
>>  meta-oe/recipes-test/evtest/evtest_1.34.bb|   6 +-
>>  .../python/python-more-itertools.inc  |   3 -
>>  .../python/python-more-itertools_5.0.0.bb |   7 +
>>  .../python/python-more-itertools_7.2.0.bb |   2 -
>>  .../python/python3-more-itertools_7.2.0.bb|   3 +
>>  .../xfce-dusk-gtk3/xfce-dusk-gtk3_1.3.bb  |   2 +-
>>  35 files changed, 935 insertions(+), 158 deletions(-)
>>  create mode 100644 
>> meta-multimedia/recipes-multimedia/tinyalsa/tinyalsa/0001-Use-CMAKE_INSTALL_-path-instead-of-hardcoding-bin-li.patch
>>  rename 
>> meta-networking/recipes-connectivity/networkmanager/{networkmanager_1.18.2.bb
>>  => networkmanager_1.18.4.bb} (94%)
>>  create mode 100644 
>> meta-networking/recipes-support/ruli/files/0001-Make-space-for-flags-from-environment.patch
>>  create mode 100644 
>> meta-networking/recipes-support/ruli/files/0001-ruli_srv-Mark-prev_addr_list_size-as-unused.patch
>>  delete mode 100644 meta-networking/recipes-support/ruli/files/Makefile.patch
>>  rename meta-oe/recipes-connectivity/libqmi/{libqmi_1.24.0.bb => 
>> libqmi_1.24.2.bb} (85%)
>>  create mode 100644 
>> meta-oe/recipes-connectivity/lirc/lirc/0001-Fix-build-on-32bit-arches-with-64bit-time_t.patch
>>  create mode 100644 
>> 

Re: [oe] [zeus 00/17] Patch review

2020-01-03 Thread Adrian Bunk
On Thu, Jan 02, 2020 at 07:38:38PM -0800, Khem Raj wrote:
> On Thu, Jan 2, 2020 at 6:49 PM Armin Kuster  wrote:
>...
> > Khem Raj (9):
> >   grpc: Define libdir and cmakedir in terms of multilib
> >   tinyalsa: fix installation libdir path to match multilibs
> >   libqb: Add --enable-nosection-fallback with mips64/clang
> >   x11vnc: Fix build for 32bit arches with 64bit time_t
> >   evtest: Fix build for 32bit arches with 64bit time_t
> >   lirc: Fix build for 32bit arches with 64bit time_t
> >   utouch-evemu,utouch-frame: Fix build for 32bit arches with 64bit
> > time_t
> >   directfb: Fix build for 32bit arches with 64bit time_t
> >   ruli: Fix install step and build samples too
> >
> 
> 64bit time_t fixes are not necessary but are not hurtful either, since the
> C libraries in zeus do not have the needed bits to enable 64bit time_t
> so unless someone else has issues with it, I am fine to bring them to zeus
>...

There are zero benefits and a non-zero regression risk if backporting them,
I would recommend against adding them to zeus.

cu
Adrian
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel


Re: [oe] [zeus 00/17] Patch review

2020-01-02 Thread Khem Raj
On Thu, Jan 2, 2020 at 6:49 PM Armin Kuster  wrote:
>
> Please have comments back by Saturday.
>
> The following changes since commit fbe4cf8d56eea586c096621e7c913b24bd99c9c6:
>
>   gtkwave: add the libtirpc dependence and config (2019-12-17 21:57:51 -0800)
>
> are available in the Git repository at:
>
>   https://git.openembedded.org/meta-openembedded-contrib stable/zeus-nut
>   
> http://cgit.openembedded.org/meta-openembedded-contrib/log/?h=stable/zeus-nut
>
> Adrian Bunk (3):
>   networkmanager: Upgrade 1.18.2 -> 1.18.4
>   gpsd: Backport a memory leak fix
>   libqmi: Upgrade 1.24.0 -> 1.24.2
>
> Changqing Li (1):
>   xfce-dusk-gtk3: correct invalid SRC_URI
>
> Hongxu Jia (1):
>   python-more-itertools: downgrade 7.2.0 -> 5.0.0
>
> Kai Kang (1):
>   fltk: fix build error when enable package config examples
>
> Khem Raj (9):
>   grpc: Define libdir and cmakedir in terms of multilib
>   tinyalsa: fix installation libdir path to match multilibs
>   libqb: Add --enable-nosection-fallback with mips64/clang
>   x11vnc: Fix build for 32bit arches with 64bit time_t
>   evtest: Fix build for 32bit arches with 64bit time_t
>   lirc: Fix build for 32bit arches with 64bit time_t
>   utouch-evemu,utouch-frame: Fix build for 32bit arches with 64bit
> time_t
>   directfb: Fix build for 32bit arches with 64bit time_t
>   ruli: Fix install step and build samples too
>

64bit time_t fixes are not necessary but are not hurtful either, since the
C libraries in zeus do not have the needed bits to enable 64bit time_t
so unless someone else has issues with it, I am fine to bring them to zeus

> Stefan Agner (1):
>   networkmanager: do not deploy unnecessary udev rule file
>
> zhangxiao (1):
>   syslog-ng: Fix multilib header conflict - syslog-ng-config.h
>
>  .../recipes-multimedia/tinyalsa/tinyalsa.bb   |   4 +-
>  ...L_-path-instead-of-hardcoding-bin-li.patch |  46 +
>  ...ger_1.18.2.bb => networkmanager_1.18.4.bb} |   9 +-
>  .../recipes-devtools/grpc/grpc_1.24.1.bb  |   4 +-
>  ...-Fix-build-with-format-string-checks.patch |  29 ++-
>  ...ake-space-for-flags-from-environment.patch |  95 +
>  ...v-Mark-prev_addr_list_size-as-unused.patch |  35 
>  .../recipes-support/ruli/files/Makefile.patch | 122 
>  .../recipes-support/ruli/ruli_0.36.bb |  23 ++-
>  .../{libqmi_1.24.0.bb => libqmi_1.24.2.bb}|   4 +-
>  ...ld-on-32bit-arches-with-64bit-time_t.patch |  40 
>  .../recipes-connectivity/lirc/lirc_0.9.4d.bb  |   1 +
>  meta-oe/recipes-extended/libqb/libqb_1.0.5.bb |   6 +-
>  .../recipes-graphics/directfb/directfb.inc|   3 +-
>  ...ld-on-32bit-arches-with-64bit-time_t.patch | 139 +
>  ...ld-on-32bit-arches-with-64bit-time_t.patch | 111 +++
>  .../recipes-graphics/x11vnc/x11vnc_0.9.16.bb  |   5 +-
>  .../0001-gps_shm_close-Free-privdata.patch|  37 
>  meta-oe/recipes-navigation/gpsd/gpsd_3.19.bb  |   1 +
>  meta-oe/recipes-support/fltk/fltk.bb  |   7 +-
>  ...-when-enable-package-config-examples.patch | 182 ++
>  .../recipes-support/syslog-ng/syslog-ng.inc   |   4 +-
>  ...ld-on-32bit-arches-with-64bit-time_t.patch |  76 
>  .../utouch/utouch-evemu_git.bb|   4 +-
>  ...ld-on-32bit-arches-with-64bit-time_t.patch |  41 
>  ...tat.h-for-fixing-build-issue-on-musl.patch |   0
>  .../remove-man-page-creation.patch|   0
>  .../utouch/utouch-frame_git.bb|   1 +
>  ...ld-on-32bit-arches-with-64bit-time_t.patch |  41 
>  meta-oe/recipes-test/evtest/evtest_1.34.bb|   6 +-
>  .../python/python-more-itertools.inc  |   3 -
>  .../python/python-more-itertools_5.0.0.bb |   7 +
>  .../python/python-more-itertools_7.2.0.bb |   2 -
>  .../python/python3-more-itertools_7.2.0.bb|   3 +
>  .../xfce-dusk-gtk3/xfce-dusk-gtk3_1.3.bb  |   2 +-
>  35 files changed, 935 insertions(+), 158 deletions(-)
>  create mode 100644 
> meta-multimedia/recipes-multimedia/tinyalsa/tinyalsa/0001-Use-CMAKE_INSTALL_-path-instead-of-hardcoding-bin-li.patch
>  rename 
> meta-networking/recipes-connectivity/networkmanager/{networkmanager_1.18.2.bb 
> => networkmanager_1.18.4.bb} (94%)
>  create mode 100644 
> meta-networking/recipes-support/ruli/files/0001-Make-space-for-flags-from-environment.patch
>  create mode 100644 
> meta-networking/recipes-support/ruli/files/0001-ruli_srv-Mark-prev_addr_list_size-as-unused.patch
>  delete mode 100644 meta-networking/recipes-support/ruli/files/Makefile.patch
>  rename meta-oe/recipes-connectivity/libqmi/{libqmi_1.24.0.bb => 
> libqmi_1.24.2.bb} (85%)
>  create mode 100644 
> meta-oe/recipes-connectivity/lirc/lirc/0001-Fix-build-on-32bit-arches-with-64bit-time_t.patch
>  create mode 100644 
> meta-oe/recipes-graphics/directfb/directfb/0001-Fix-build-on-32bit-arches-with-64bit-time_t.patch
>  create mode 100644 
> meta-oe/recipes-graphics/x11vnc/files/0001-Fix-build-on-32bit-arches-with-64bit-time_t.patch
>  create mode 100644 
>