[Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report
The proposal to merge lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753 -- https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report
Tests should be ready -- https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report
Review: Approve code review just remove "name = ''" at line 110 Thanks! -- https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report
Review: Needs Fixing Nico, line 74,76: I think you should use 'lot_icecream_0' and 'lot_icecream_1' line 91: you are writing 'prodlot_id' field with another lot, but I think it's unnecessary, as lots are already assigned by 'stock.move.split' wizard. line 115: the test is checking if the invoice lines are 2, but the bug said "Now the 2 different serial number will be repeat for each invoice line, while each line must have only its serial" So, the test should check if every invoice line has got only one lot line 112: 'ac' is unnecessary Thanks -- https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report
> LGTM. > > Is there any chance I could convince you to write an automated test for this? Hi Alexandre, Sorry For the late, i have write the automated test for checking the bug. Regards. -N. -- https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report
> LGTM. > > Is there any chance I could convince you to write an automated test for this? Sorry i forgot it, i'll made soon -- https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report
Review: Approve code review, no test LGTM. Is there any chance I could convince you to write an automated test for this? -- https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report
Nicola Malcontenti - Agile BG has proposed merging
lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into
lp:account-invoice-report.
Requested reviews:
Account Core Editors (account-core-editors)
Related bugs:
Bug #1284049 in Account - Invoicing Reports: "serial numbers on invoice"
https://bugs.launchpad.net/account-invoice-report/+bug/1284049
For more details, see:
https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753
https://bugs.launchpad.net/account-invoice-report/+bug/1284049
--
https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-invoice-report.
=== modified file 'account_invoice_production_lot/__openerp__.py'
--- account_invoice_production_lot/__openerp__.py 2014-01-02 10:03:31 +
+++ account_invoice_production_lot/__openerp__.py 2014-02-28 09:49:59 +
@@ -29,6 +29,7 @@
"depends": [
"sale_stock",
"invoice_webkit",
+"stock_picking_invoice_link",
],
"author": "Agile Business Group",
"summary": "Display delivered serial numbers in invoice",
=== modified file 'account_invoice_production_lot/invoice.py'
--- account_invoice_production_lot/invoice.py 2014-01-02 10:03:31 +
+++ account_invoice_production_lot/invoice.py 2014-02-28 09:49:59 +
@@ -30,10 +30,15 @@
result = {}
for line in self.browse(cr, uid, ids, context=context):
result[line.id] = []
-for order_line in line.order_lines:
-for move in order_line.move_ids:
+if line.move_line_ids:
+for move in line.move_line_ids:
if move.prodlot_id:
result[line.id].append(move.prodlot_id.id)
+else:
+for order_line in line.order_lines:
+for move in order_line.move_ids:
+if move.prodlot_id:
+result[line.id].append(move.prodlot_id.id)
return result
_inherit = "account.invoice.line"
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
